[clang-tools-extra] [clangd] Introduce reusable modules builder (PR #73483)

2023-11-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/73483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [llvm] [libcxx] [libc] [clang] [compiler-rt] [Clang] Use correct base expression for counted_by field (#73168) (PR #73465)

2023-11-26 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/73465 >From 3aa35a39184ff8d4ff11b9f41b4551bec78bdca5 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 22 Nov 2023 15:16:19 -0800 Subject: [PATCH 1/2] [Clang] Use correct base expression for counted_by field T

[clang] [clang][dataflow] Strengthen widening of boolean values. (PR #73484)

2023-11-26 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/73484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

2023-11-26 Thread مهدي شينون via cfe-commits
@@ -204,6 +204,29 @@ void Flang::AddAArch64TargetArgs(const ArgList &Args, } } +static void addVSDefines(const ToolChain &TC, const ArgList &Args, + ArgStringList &CmdArgs) { + + unsigned ver = 0; + const VersionTuple vt = TC.computeMSVCVersion(null

[llvm] [clang] [InstCombine] Set disjoint flag when turning Add into Or. (PR #72702)

2023-11-26 Thread Nicolai Hähnle via cfe-commits
nhaehnle wrote: Time to rebase this on main, I think... https://github.com/llvm/llvm-project/pull/72702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 659e401 - [clang-format][NFC] Improve an `if` conditional in the annotator

2023-11-26 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-11-26T22:54:44-08:00 New Revision: 659e4017b7371efa8ce97da2d87270c60a93d03d URL: https://github.com/llvm/llvm-project/commit/659e4017b7371efa8ce97da2d87270c60a93d03d DIFF: https://github.com/llvm/llvm-project/commit/659e4017b7371efa8ce97da2d87270c60a93d03d.diff LOG:

[clang] [clang][dataflow] Strengthen widening of boolean values. (PR #73484)

2023-11-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes Before we widen to top, we now check if both values can be proved either true or false in their respective environments; if so, widening returns a true or false literal. The idea is that we avoid losing informati

[clang] [clang][dataflow] Strengthen widening of boolean values. (PR #73484)

2023-11-26 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/73484 Before we widen to top, we now check if both values can be proved either true or false in their respective environments; if so, widening returns a true or false literal. The idea is that we avoid losing infor

[clang] [Driver][MachineOutliner] Support -moutline option for aarch64_be (PR #73223)

2023-11-26 Thread dong jianqiang via cfe-commits
https://github.com/dongjianqiang2 updated https://github.com/llvm/llvm-project/pull/73223 >From b58489a05f97dcb6cf31ce9527ff0e7a16a9f56e Mon Sep 17 00:00:00 2001 From: dong jianqiang Date: Thu, 23 Nov 2023 16:58:11 +0800 Subject: [PATCH] [Driver][MachineOutliner] Support outlining option with L

[clang-tools-extra] [clangd] Introduce reusable modules builder (PR #73483)

2023-11-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e89324219acf3d799a86fed5651e492bbab4867c 052e2da0ede8cc72e22ad9ba75ddf2868e5fffe1 --

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2023-11-26 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @sam-mccall I created https://github.com/llvm/llvm-project/pull/73483 as the following patches to reuse built module files. I think that patch should be necessary since the current patch may waste too many time and space since it won't reuse the module files across source fil

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2023-11-26 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @frederick-vs-ja Just to be clear, are you waiting for anyone to merge this? https://github.com/llvm/llvm-project/pull/68846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang-tools-extra] [clangd] Introduce reusable modules builder (PR #73483)

2023-11-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clangd Author: Chuanqi Xu (ChuanqiXu9) Changes This is a draft based on https://github.com/llvm/llvm-project/pull/66462. The main goal of the patch is to implement the TODO step 1: "reuse module files" across source

[clang-tools-extra] [clangd] Introduce reusable modules builder (PR #73483)

2023-11-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 converted_to_draft https://github.com/llvm/llvm-project/pull/73483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2023-11-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/66462 >From 32010ae7e0a47cd4a70a9401980b32ed1d3e10f6 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Fri, 15 Sep 2023 11:33:53 +0800 Subject: [PATCH] [clangd] [C++20] [Modules] Introduce initial support for C++20 M

[clang] [Driver][MachineOutliner] Support -moutline option for aarch64_be (PR #73223)

2023-11-26 Thread dong jianqiang via cfe-commits
https://github.com/dongjianqiang2 updated https://github.com/llvm/llvm-project/pull/73223 >From 2a90faa84bd4a47a291f0631f26b87e7ee60ce63 Mon Sep 17 00:00:00 2001 From: dong jianqiang Date: Thu, 23 Nov 2023 16:58:11 +0800 Subject: [PATCH] [Driver][MachineOutliner] Support outlining option with L

[clang] [Driver] Allow -e entry but reject -eentry (PR #72804)

2023-11-26 Thread dong jianqiang via cfe-commits
https://github.com/dongjianqiang2 closed https://github.com/llvm/llvm-project/pull/72804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 282201d - [Driver] Allow -e entry but reject -eentry (#72804)

2023-11-26 Thread via cfe-commits
Author: Fangrui Song Date: 2023-11-27T11:04:29+08:00 New Revision: 282201dc633e164042df0ae726a804c0aad46e50 URL: https://github.com/llvm/llvm-project/commit/282201dc633e164042df0ae726a804c0aad46e50 DIFF: https://github.com/llvm/llvm-project/commit/282201dc633e164042df0ae726a804c0aad46e50.diff

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

2023-11-26 Thread Nathan Ridge via cfe-commits
@@ -585,6 +585,17 @@ TEST_F(TokenCollectorTest, DelayedParsing) { EXPECT_THAT(collectAndDump(Code), StartsWith(ExpectedTokens)); } +TEST_F(TokenCollectorTest, UnclosedToken) { HighCommander4 wrote: I started looking at this to try and make some progress tow

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2023-11-26 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja updated https://github.com/llvm/llvm-project/pull/68846 >From 9ef23f11f52735976a05080227bb880af3b9cbb6 Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Tue, 17 Oct 2023 10:41:18 +0800 Subject: [PATCH] [Docs][Clang] DR status in cxx_status.html --- clang/www/c

[clang-tools-extra] [clangd] Improve BlockEnd inlay hints presentation (PR #72345)

2023-11-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. (see previous comment) https://github.com/llvm/llvm-project/pull/72345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang-tools-extra] [clangd] Improve BlockEnd inlay hints presentation (PR #72345)

2023-11-26 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Thanks, the behaviour changes look reasonable to me. > I haven't update the test because the hard-coded limit 10 makes it hard to > write the tests. Any opinion of how to structure this? I would suggest running most tests with `HintMinLineLimit = 2` (and then have one te

[clang] [clang-format] Fix a bug in formating `#define A x:` (PR #73220)

2023-11-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/73220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a369a59 - [clang-format] Fix a bug in formating `#define A x:` (#73220)

2023-11-26 Thread via cfe-commits
Author: Owen Pan Date: 2023-11-26T16:20:19-08:00 New Revision: a369a5946f99254d56455f3deb0031199562c1dd URL: https://github.com/llvm/llvm-project/commit/a369a5946f99254d56455f3deb0031199562c1dd DIFF: https://github.com/llvm/llvm-project/commit/a369a5946f99254d56455f3deb0031199562c1dd.diff LOG:

[libc] [libcxx] [clang] [llvm] [compiler-rt] [flang] [Clang] Use correct base expression for counted_by field (#73168) (PR #73465)

2023-11-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Bill Wendling (bwendling) Changes I'll add some testcases later today. --- Patch is 31.10 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/73465.diff 4 Files Affected: - (modified) cla

[libc] [libcxx] [clang] [llvm] [compiler-rt] [flang] [Clang] Use correct base expression for counted_by field (#73168) (PR #73465)

2023-11-26 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/73465 I'll add some testcases later today. >From 3aa35a39184ff8d4ff11b9f41b4551bec78bdca5 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 22 Nov 2023 15:16:19 -0800 Subject: [PATCH] [Clang] Use correct base

[clang] [Clang] Eagerly instantiate used constexpr function upon definition. (PR #73463)

2023-11-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Despite CWG2497 not being resolved, it is reasonable to expect the following code to compile (and which is supported by other compilers) ```cpp template constexpr T f(); constexpr int g() { retu

[clang] [Clang] Eagerly instantiate used constexpr function upon definition. (PR #73463)

2023-11-26 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/73463 Despite CWG2497 not being resolved, it is reasonable to expect the following code to compile (and which is supported by other compilers) ```cpp template constexpr T f(); constexpr int g() { return f(); } //

[clang] [compiler-rt] [llvm] [flang] [clang-tools-extra] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

2023-11-26 Thread via cfe-commits
jathu wrote: @chapuni can you help my understand what you mean by those two suggestions by providing some examples? > construct the symlink-ed tree for one's convenience Isn't that what we are doing in this diff? We are producing the symlinked tree for the tool. https://github.com/llvm/llvm-

[libc] [compiler-rt] [llvm] [lldb] [lld] [clang-tools-extra] [mlir] [clang] [openmp] [libcxx] [flang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-11-26 Thread Lei Zhang via cfe-commits
antiagainst wrote: Thanks for breaking down this pull request into various smaller pieces to make it easier for review. I looked at various pieces; LGTM. Looking forward to see this being supported! :) from @joker-eph: > Vulkan and Spirv still have dedicated runners on the model of the origina

[clang] d033f51 - [OpenMP] atomic compare fail : Parser & AST support

2023-11-26 Thread Sandeep Kosuri via cfe-commits
Author: Sunil Kuravinakop Date: 2023-11-26T13:34:34-06:00 New Revision: d033f51a0aafd8149f5059bc0f89ffd300093356 URL: https://github.com/llvm/llvm-project/commit/d033f51a0aafd8149f5059bc0f89ffd300093356 DIFF: https://github.com/llvm/llvm-project/commit/d033f51a0aafd8149f5059bc0f89ffd300093356.d

[mlir] [flang] [clang-tools-extra] [lldb] [llvm] [libc] [lld] [compiler-rt] [libcxx] [clang] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-26 Thread Lei Zhang via cfe-commits
https://github.com/antiagainst approved this pull request. LGTM regarding SPIR-V. But please address comments from others. :) https://github.com/llvm/llvm-project/pull/71430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [clang-format] Add BreakConcatenatedStrings option (PR #73432)

2023-11-26 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/73432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakConcatenatedStrings option (PR #73432)

2023-11-26 Thread Björn Schäpers via cfe-commits
@@ -2088,6 +2088,19 @@ struct FormatStyle { /// \version 3.7 bool BreakBeforeTernaryOperators; + /// Break between concatenated string literals in C, C++, and Objective-C. HazardyKnusperkeks wrote: Why limited to that languages? https://github.com/llvm/

[clang] [clang-format] Add BreakConcatenatedStrings option (PR #73432)

2023-11-26 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/73432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in formating `#define A x:` (PR #73220)

2023-11-26 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/73220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Allow -e entry but reject -eentry (PR #72804)

2023-11-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 approved this pull request. https://github.com/llvm/llvm-project/pull/72804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

2023-11-26 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: > > LGTM, thank you for taking care of this 🙏🏻 > > Dare I ask - what's "dupes"? I only found > > [dupe](https://dictionary.cambridge.org/dictionary/english/dupe). Also, > > please wait for @kiranchandramohan to approve before merging this :) > > I used "dupes" in the sense

[clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

2023-11-26 Thread Andrzej Warzyński via cfe-commits
@@ -0,0 +1,15 @@ +! UNSUPPORTED: system-windows + +! RUN: %flang -x ir -o %t.c-object -c %S/Inputs/main_dupes.ll +! RUN: %flang -o %t -c %s +! RUN: not %flang -o %t.exe %t %t.c-object 2>&1 banach-space wrote: That was just a nit - I am happy if you keep things as

[clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

2023-11-26 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/73124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Non-object types are non-trivially relocatable (PR #69734)

2023-11-26 Thread Amirreza Ashouri via cfe-commits
AMP999 wrote: > LGTM, thanks! You're welcome! https://github.com/llvm/llvm-project/pull/69734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakConcatenatedStrings option (PR #73432)

2023-11-26 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/73432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix: C++ empty record with align lead to va_list out of sync (PR #72197)

2023-11-26 Thread via cfe-commits
hstk30-hw wrote: OK, just delete the `return ABIArgInfo::getDirect(llvm::Type::getInt8Ty(getVMContext()));` from the empty struct codepath, let it fall through to the main path. Check it again, plz. https://github.com/llvm/llvm-project/pull/72197 ___

[clang] [Driver] Add the --gcc-triple option (PR #73214)

2023-11-26 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/73214 >From 72f6f3a611f237f71ce02cfb79620257a9e2d827 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 16 Nov 2023 05:11:04 + Subject: [PATCH 1/2] [Driver] Add the --gcc-triple option When --gcc-triple is us

[clang] [clang] Non-object types are non-trivially relocatable (PR #69734)

2023-11-26 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/69734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] Fix #41439: Update the documentation with the correct information. (PR #69377)

2023-11-26 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69377 >From 0e0a3e7ad1a0a7098e05a5164413369eaa58c55b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Tue, 17 Oct 2023 20:49:47 +0100 Subject: [PATCH 1/4] Fix #41439: Update the documentation with the correct informa

[clang] [clang] Non-object types are non-trivially relocatable (PR #69734)

2023-11-26 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/69734 >From befa9931fb8c9e52bb05a9075dfbea7116ff14ea Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Sun, 26 Nov 2023 15:06:32 +0330 Subject: [PATCH] [clang] Non-object types are non-trivially relocatable Both ac

[flang] [clang-tools-extra] [llvm] [clang] [compiler-rt] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

2023-11-26 Thread NAKAMURA Takumi via cfe-commits
chapuni wrote: I still think this is not a right way to control Bazel's build directory tree. IMO, we should publish the tree with the archive (with filegroup), or produce the utility shell script to construct the symlink-ed tree for one's convenience. https://github.com/llvm/llvm-project/pull

[clang-tools-extra] [clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-11-26 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > I also discovered some complications related to nested templates, and I have > some thoughts on how to resolve them, but I'm going to suggest that we start > with getting a simple case (e.g. just one level of templates, no nested > templates) to work, and then tackle nested te

[clang-tools-extra] [clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-11-26 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Thank you again for bothering with this, and sorry for not responding for over a week. Just now, I replicated the experimentation > I've done some local experimentation, and what I'm seeing is that > `TemplateTypeParmDecl::getDeclContext()` does return the FunctionDecl or > CX

[clang] [clang-format] Add BreakConcatenatedStrings option (PR #73432)

2023-11-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Closes #70451. --- Full diff: https://github.com/llvm/llvm-project/pull/73432.diff 7 Files Affected: - (modified) clang/docs/ClangFormatStyleOptions.rst (+15) - (modified) clang/docs/ReleaseNotes.rst (+

[clang] [clang-format] Add BreakConcatenatedStrings option (PR #73432)

2023-11-26 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/73432 Closes #70451. >From def7bbb22cdd9269aa927d8dcf4247c88877503b Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 25 Nov 2023 23:55:11 -0800 Subject: [PATCH] [clang-format] Add BreakConcatenatedStrings option Clo