HighCommander4 wrote:

Thanks, the behaviour changes look reasonable to me.

> I haven't update the test because the hard-coded limit 10 makes it hard to 
> write the tests. Any opinion of how to structure this?

I would suggest running most tests with `HintMinLineLimit = 2` (and then have 
one test for the behaviour with `HintMinLineLimit = 10`).

To allow the tests to change `HintMinLineLimit`, we could give the 
`inlayHints()` function an optional parameter to specify it (could wrap it in 
an `InlayHintOptions` class for adding other options in the future).

https://github.com/llvm/llvm-project/pull/72345
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to