[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1432 TEST(TypeHints, SubstTemplateParameterAliases) { + llvm::StringRef Header = R"cpp(

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

zixuan-wu added inline comments. Comment at: llvm/test/CodeGen/CSKY/intrinsic.ll:21 +entry: + %ntz = call i32 @llvm.cttz.i32(i32 %x, i1 1) + ret i32 %ntz I think we can also test the condition that the second argument is zero. CHANGES SINCE LAST ACTION http

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 545929. tbaeder added a comment. merge `visitConditional()` into its only caller, `VisitAbstractConditionalOperator()`. This works now sine the initializer and non-initializer code paths are the same. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

cfe-commits@lists.llvm.org

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 545928. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Context.cpp clang/test/AST/Interp/l

cfe-commits@lists.llvm.org

yubing updated this revision to Diff 545927. yubing added a comment. update testcase due to w=>x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptions.def clang/

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 545926. tbaeder added a comment. Add `::delegate(const Expr *E)` and squash previous commits into this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG422bcd10c48b: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON (authored by evelez7). Changed prior to commit: htt

[clang] 422bcd1 - [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

Author: Erick Velez Date: 2023-07-31T23:29:04-07:00 New Revision: 422bcd10c48bac9042ed9f33f3d17eb81ebfd21a URL: https://github.com/llvm/llvm-project/commit/422bcd10c48bac9042ed9f33f3d17eb81ebfd21a DIFF: https://github.com/llvm/llvm-project/commit/422bcd10c48bac9042ed9f33f3d17eb81ebfd21a.diff L

cfe-commits@lists.llvm.org

yubing updated this revision to Diff 545924. yubing added a comment. address c++ windows's mangling prefix w=>x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptio

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Sorry, looks like I messed up with the commits before. Fixed it now. Comment at: clang-tools-extra/clangd/InlayHints.cpp:207 + + // This is a bit tricky: we traverse the type structure and find whether or + // not a type in the desugaring process is o

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 545922. zyounan added a comment. Fix the chaos in the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp

[PATCH] D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC.

Jim updated this revision to Diff 545921. Jim added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156686/new/ https://reviews.llvm.org/D156686 Files: clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 545920. zyounan marked 2 inline comments as done. zyounan added a comment. Herald added a project: clang. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files

[PATCH] D150929: [RISCV][BF16] Enable __bf16 for riscv targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5791bfef4e4: [RISCV][BF16] Enable __bf16 for riscv targets (authored by joshua-arch1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.ll

[clang] a5791bf - [RISCV][BF16] Enable __bf16 for riscv targets

Author: Jun Sha (Joshua) Date: 2023-08-01T13:59:27+08:00 New Revision: a5791bfef4e4bcc159ef9bf40d88262e5f409766 URL: https://github.com/llvm/llvm-project/commit/a5791bfef4e4bcc159ef9bf40d88262e5f409766 DIFF: https://github.com/llvm/llvm-project/commit/a5791bfef4e4bcc159ef9bf40d88262e5f409766.di

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

vsapsai added a comment. Thanks for the quick review! In D156749#4549226 , @ChuanqiXu wrote: > Although there is a FIXME in the definition of `getNameAsRequested()`, it > looks not sense to require you to fix that. It might not be an over burden > for

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

danix800 updated this revision to Diff 545913. danix800 added a comment. Update ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155661/new/ https://reviews.llvm.org/D155661 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ASTImp

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

danix800 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2862-2866 + bool ShouldAddRedecl = !(IsFriendTemplate && IsDependentContext); + // We may already have a record of the same name; try to find and match it. RecordDecl *PrevDecl = nullptr; if (!DC-

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

danix800 updated this revision to Diff 545912. danix800 added a comment. Cleanup as @balazske suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155661/new/ https://reviews.llvm.org/D155661 Files: clang/lib/AST/ASTImporter.cpp clang/unit

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

cpsughrue updated this revision to Diff 545910. cpsughrue retitled this revision from "[clang][deps] provide support for cc1 command line scanning" to "[clang][deps] add support for dependency scanning with cc1 command line". cpsughrue edited the summary of this revision. cpsughrue added a commen

[PATCH] D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC.

craig.topper added inline comments. Comment at: clang/lib/AST/Type.cpp:2356 bool Type::isSizelessBuiltinType() const { + if (isSVESizelessBuiltinType()) +return true; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

bcain created this revision. bcain added reviewers: kparzysz, sidneym, MaskRay. Herald added a project: All. bcain requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The removal of the early return in 96832a6bf7e0e7f1e8d634d38c44a1b32d512923

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Although there is a FIXME in the definition of `getNameAsRequested()`, it looks not sense to require you to fix that. It might not be an over burden for someone who will be intended to

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

ahatanak added a comment. I think we still need to do something like what this patch is doing (i.e., drop the nullability qualifiers) when deducing types for `auto` or `__auto_type`, assuming that's the rule we want and we want to restore the previous behavior. I agree with you that we should m

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

AlexVlx marked an inline comment as done. AlexVlx added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3542 +LangAS AAS = getASTAllocaAddressSpace(); +LangAS EAS = E->getType().getAddressSpace(); +if (AAS != EAS) { rjmccall wrote: > `E->

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

AlexVlx updated this revision to Diff 545882. AlexVlx added a comment. Use pointee's address space for the check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156539/new/ https://reviews.llvm.org/D156539 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/dynamic-alloca-with

[PATCH] D155668: [RISCV] Upgrade Zvfh version to 1.0 and move out of experimental state.

craig.topper added a comment. In D155668#4548454 , @jrtc27 wrote: > Uh, why are there clang/test/Sema/aarch64* tests full of RISC-V extension > names? That's not right at all. One of them is coming from > https://reviews.llvm.org/D135011, I haven't trac

[clang] 690edea - [AArch64] Remove copy/pasted RISC-V extension names from some tests. NFC

Author: Craig Topper Date: 2023-07-31T17:34:38-07:00 New Revision: 690edeab78ba6996a44f6fd9e8fce79cb78e7737 URL: https://github.com/llvm/llvm-project/commit/690edeab78ba6996a44f6fd9e8fce79cb78e7737 DIFF: https://github.com/llvm/llvm-project/commit/690edeab78ba6996a44f6fd9e8fce79cb78e7737.diff

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-multi-parm-span.cpp:37-39 +// CHECK: fix-it:{{.*}}:{[[@LINE+3]]:24-[[@LINE+3]]:30}:"std::span p" +// CHECK: fix-it:{{.*}}:{[[@LINE+2]]:32-[[@LINE+2]]:39}:"std::span q" +// CHECK: f

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 updated this revision to Diff 545872. ziqingluo-90 marked 4 inline comments as done. ziqingluo-90 added a comment. Carved out NFC changes from the original diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153059/new/ https://reviews.llvm.org/D153059 Files: clang/inclu

[clang] 42c9354 - Revert "Reland "[LoongArch] Support -march=native and -mtune=""

Author: Steven Wu Date: 2023-07-31T16:57:06-07:00 New Revision: 42c9354a928d4d9459504527085fccc91b46aed3 URL: https://github.com/llvm/llvm-project/commit/42c9354a928d4d9459504527085fccc91b46aed3 DIFF: https://github.com/llvm/llvm-project/commit/42c9354a928d4d9459504527085fccc91b46aed3.diff LOG

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

AntonRydahl updated this revision to Diff 545867. AntonRydahl added a comment. Running tests again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156641/new/ https://reviews.llvm.org/D156641 Files: clang/include/clang/Driver/Options.td flang/t

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

steven_wu added a comment. In D155824#4548921 , @SixWeining wrote: > In D155824#4548677 , @steven_wu > wrote: > >> After another look, I will need to request to revert this because this >> implementation doesn'

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining added a comment. In D155824#4548677 , @steven_wu wrote: > After another look, I will need to request to revert this because this > implementation doesn't work with `-fno-integrated-cc1` at all. You can't > setCPU/Tune in the driver into a glo

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3542 +LangAS AAS = getASTAllocaAddressSpace(); +LangAS EAS = E->getType().getAddressSpace(); +if (AAS != EAS) { `E->getType().getAddressSpace()` is actually the top-level qual

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

AlexVlx updated this revision to Diff 545860. AlexVlx added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156539/new/ https://reviews.llvm.org/D156539 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/dynamic-alloca-with-address-space.c

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor the `getFixIts` function for better

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:44-45 +static_assert(false, L"\x1ff"// expected-warning {{encoding prefix 'L' on an unevaluated string literal has no effect and is incompatible with c++2c}} \ +

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

steven_wu added a comment. After another look, I will need to request to revert this because this implementation doesn't work with `-fno-integrated-cc1` at all. You can't setCPU/Tune in the driver into a global variable and expect that will work during compilation. You can reproduce with `-fno

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:5930-5931 break; +case DeclaratorContext::Member: + // Expand for packed data members. case DeclaratorContext::TemplateParam: cjdb wrote: > dblaikie wrote: > > Perhaps a

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

vsapsai created this revision. vsapsai added reviewers: ChuanqiXu, jansvoboda11. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix errors like > module 'MultiPath'

[PATCH] D155668: [RISCV] Upgrade Zvfh version to 1.0 and move out of experimental state.

jrtc27 added a comment. Uh, why are there clang/test/Sema/aarch64* tests full of RISC-V extension names? That's not right at all. One of them is coming from https://reviews.llvm.org/D135011, I haven't traced the rest back, but that's clearly wrong. The test looks to be a copy of the RISC-V one

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

rjmccall added a comment. I would like to avoid the overhead of this when we're not emitting for a REPL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156537/new/ https://reviews.llvm.org/D156537 ___ cfe

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2548 +case Builtin::BI__builtin_sqrtf128: +case Builtin::BI__builtin_elementwise_sqrt: { llvm::Value *Call = emitUnaryMaybeConstrainedFPBuiltin( bob80905 wrote: > Nit: I thin

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

gruuprasad updated this revision to Diff 545807. gruuprasad added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156724/new/ https://reviews.llvm.org/D156724 Files: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp clang/tes

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao marked an inline comment as done. SlaterLatiao added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3292-3295 + // FIXME: Eventually, a NULL return will mean that one of the + // instantiations was a semantic disaster, and w

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

bob80905 added a comment. I think you need to mention this new builtin in clang/docs/ReleaseNotes.rst. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2548 +case Builtin::BI__builtin_sqrtf128: +case Builtin::BI__builtin_elementwise_sqrt: { llvm::Value *Call = emitUna

[PATCH] D156743: [wip] clang/OpenCL: Add inline implementations of sqrt in builtin header

arsenm created this revision. arsenm added reviewers: yaxunl, svenvh, Anastasia. Herald added a subscriber: Naghasan. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. We want the !fpmath metadata to be attached to the sqrt intrinsic to make it

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 545804. SlaterLatiao added a comment. Fix code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp clang/lib/S

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

efriedma added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->getType().isConstQualified()) { - if (HasConstInit) rnk wrote: > I think this is not compatible with MSVC. MSVC uses sim

[PATCH] D156705: [clang-format] Fix braced initializer formatting with templated base class initializer

galenelias added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13461 " A() : a{} {}\n" + " A() : Base{} {}\n" " A(int b) : b(b) {}\n" HazardyKnusperkeks wrote: > Please also add nested templates. Ok, added `A() : Base>{}

[PATCH] D156705: [clang-format] Fix braced initializer formatting with templated base class initializer

galenelias updated this revision to Diff 545798. galenelias marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156705/new/ https://reviews.llvm.org/D156705 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clan

[PATCH] D156286: [docs] Bump minimum GCC version to 7.4

MaskRay added inline comments. Comment at: llvm/docs/GettingStarted.rst:284-298 `python `_ >=3.6 Automated test suite\ :sup:`2` `zlib `_ >=1.2.3.4 Compression library

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

arsenm created this revision. arsenm added reviewers: yaxunl, fhahn, bob80905. Herald added subscribers: StephenFan, Anastasia. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. This will be used in the opencl builtin headers to provide direct

[PATCH] D156733: Stop using legacy helpers indicating typed pointer types. NFC

bjope updated this revision to Diff 545783. bjope added a comment. Herald added a subscriber: ormris. Replaced a couple of more occurances in this update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156733/new/ https://reviews.llvm.org/D156733 F

[PATCH] D156286: [docs] Bump minimum GCC version to 7.4

aaron.ballman added inline comments. Comment at: llvm/docs/GettingStarted.rst:284-298 `python `_ >=3.6 Automated test suite\ :sup:`2` `zlib `_ >=1.2.3.4 Compression l

[PATCH] D156286: [docs] Bump minimum GCC version to 7.4

MaskRay added inline comments. Comment at: llvm/docs/GettingStarted.rst:345 * Apple Clang 10.0 -* GCC 7.1 +* GCC 7.4 * Visual Studio 2019 16.7 PiotrZSL wrote: > What about Glibc version ? > I were using GCC 9.1 + glibc 2.13 + some old kernel to compile Clang 15

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 545781. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 Files: clang/test/CodeGenObjC/arc.m clang/test/CodeGenObjC/convert-messages-to-runtime-calls.m llvm/include/llvm/IR/Intrinsics.td llvm/lib/Cod

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs added a comment. oops, uploaded the wrong patch to this review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 ___ cfe-commits mailing list cfe-commit

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 545779. jroelofs added a comment. Move the `stripPointerCasts()` change into its own review: https://reviews.llvm.org/D156735 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs added a comment. In D105671#4547848 , @nikic wrote: > Please separate the change to stripPointerCasts() into a separate review. https://reviews.llvm.org/D156735 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D156588: feat: Add support for Rocky Linux to LLVM Distro

MaskRay added a comment. In D156588#4544152 , @tbaeder wrote: > @MaskRay Isn't this something we should be doing with config files now? I agree. This should use https://clang.llvm.org/docs/UsersManual.html#configuration-files . We should try to remove e

[PATCH] D156286: [docs] Bump minimum GCC version to 7.4

PiotrZSL added inline comments. Comment at: llvm/docs/GettingStarted.rst:345 * Apple Clang 10.0 -* GCC 7.1 +* GCC 7.4 * Visual Studio 2019 16.7 What about Glibc version ? I were using GCC 9.1 + glibc 2.13 + some old kernel to compile Clang 15, after upgrading

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

AlexVlx added a comment. In D156539#4547814 , @rjmccall wrote: > In D156539#4546834 , @AlexVlx wrote: > >> In D156539#4542836 , @rjmccall >> wrote: >> >>> We should proba

[PATCH] D156286: [docs] Bump minimum GCC version to 7.4

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e06b82bded6: [docs] Bump minimum GCC version to 7.4 (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D156286: [docs] Bump minimum GCC version to 7.4

MaskRay updated this revision to Diff 545769. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a subscriber: bd1976llvm. reword description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156286/new/ https://reviews.

[PATCH] D156286: [docs] Bump minimum GCC version to 7.4

MaskRay updated this revision to Diff 545768. MaskRay retitled this revision from "[docs] Bump minimum GCC version to 7.5" to "[docs] Bump minimum GCC version to 7.4". MaskRay edited the summary of this revision. MaskRay added a comment. 7.5 => 7.4 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D156733: Stop using legacy helpers indicating typed pointer types. NFC

bjope created this revision. Herald added subscribers: nlopes, Enna1, pmatos, asb, jeroen.dobbelaere, pengfei, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. bjope requested review of this revision. Herald added subscribers: cfe-commits, wangpc, aheejin. Herald added pr

[PATCH] D156705: [clang-format] Fix braced initializer formatting with templated base class initializer

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13461 " A() : a{} {}\n" + " A() : Base{} {}\n" " A(int b) : b(b) {}\n" Please also add nested templates. CHANGES SINCE LAST ACTION https://review

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

gribozavr2 added a comment. I understand that this is an expedient fix that silences the warning. However, the fundamental problem is the simplistic implementation of the warning (that it is not flow-sensitive), not the inference of nullability. That is, when we are removing nullability qualifi

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:657-666 + bool DisallowLineBreaksOnThisLine = [&Style = this->Style, &Current] { +// Deal with lambda arguments in C++. The aim here is to ensure that we +// don't over-indent

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

rnk added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->getType().isConstQualified()) { - if (HasConstInit) I think this is not compatible with MSVC. MSVC uses simple logic, it does

[PATCH] D156674: [clang][dataflow] Remove `Strict` suffix from accessors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb244b6ae0b21: [clang][dataflow] Remove `Strict` suffix from accessors. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156674/new/ http

[PATCH] D156672: [clang][dataflow] Use `Strict` accessors where we weren't using them yet.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rGf76f6674d822: [clang][dataflow] Use `Strict` accessors where we weren't using them yet. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D156673: [clang][dataflow] Remove deprecated accessors as well as `SkipPast`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG17ba278f7611: [clang][dataflow] Remove deprecated accessors as well as `SkipPast`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15667

[clang] b244b6a - [clang][dataflow] Remove `Strict` suffix from accessors.

Author: Martin Braenne Date: 2023-07-31T19:40:09Z New Revision: b244b6ae0b2153521c5e55ff4705a88618f503aa URL: https://github.com/llvm/llvm-project/commit/b244b6ae0b2153521c5e55ff4705a88618f503aa DIFF: https://github.com/llvm/llvm-project/commit/b244b6ae0b2153521c5e55ff4705a88618f503aa.diff LOG

[clang] 17ba278 - [clang][dataflow] Remove deprecated accessors as well as `SkipPast`.

Author: Martin Braenne Date: 2023-07-31T19:40:06Z New Revision: 17ba278f76116b12eb7a954c8963ee5a5a19c32b URL: https://github.com/llvm/llvm-project/commit/17ba278f76116b12eb7a954c8963ee5a5a19c32b DIFF: https://github.com/llvm/llvm-project/commit/17ba278f76116b12eb7a954c8963ee5a5a19c32b.diff LOG

[clang] f76f667 - [clang][dataflow] Use `Strict` accessors where we weren't using them yet.

Author: Martin Braenne Date: 2023-07-31T19:40:04Z New Revision: f76f6674d8221f59f9e515e3cc03ad07fa72fe46 URL: https://github.com/llvm/llvm-project/commit/f76f6674d8221f59f9e515e3cc03ad07fa72fe46 DIFF: https://github.com/llvm/llvm-project/commit/f76f6674d8221f59f9e515e3cc03ad07fa72fe46.diff LOG

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

ahatanak added a comment. Also, `_Atomic` has the same problem, but it's not clear whether we want to strip the qualifiers. See https://github.com/llvm/llvm-project/issues/63659 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156728/new/ https://rev

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3885 ParamType = ParamType.getUnqualifiedType(); +(void)AttributedType::stripOuterNullability(ParamType); + } This isn't needed to fix the test cases I added, but I thi

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

ahatanak created this revision. ahatanak added reviewers: doug.gregor, rjmccall. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Prior to https://reviews.llvm.org/D110216, the deduced types didn't inherit the nullability qualifiers of the

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:291 + /// the frontend. + OpenMPDirectiveKind PrevMappedDirective = llvm::omp::OMPD_unknown; + I don't see where this field is stored/loaded for PCH support. You need add a support

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman added a comment. In D156565#4543503 , @aaron.ballman wrote: > In D156565#4543414 , @jrtc27 wrote: > >> Given GCC defines GNU C++ and regards this as a feature (unless you use >> things like -pedant

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

steakhal added a comment. In D156724#4547891 , @gruuprasad wrote: > Sure, Initially I didn't find the folder `StaticAnalysis` in the `clang/test` > folder, found that relevant tests are in `test/Analysis`. Correct, thanks! Repository: rG LLVM Githu

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

gruuprasad added a comment. Sure, Initially I didn't find the folder `StaticAnalysis` in the `clang/test` folder, found that relevant tests are in `test/Analysis`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156724/new/ https://reviews.llvm.org/

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

aaron.ballman added subscribers: cor3ntin, hubert.reinterpretcast, rsmith. aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +

[clang] 3a100ea - Fix test to not write temporary files, use -fsyntax-only instead

Author: David Blaikie Date: 2023-07-31T19:01:44Z New Revision: 3a100ea901ed79d6a06a5f018be2b4d3bbca51e8 URL: https://github.com/llvm/llvm-project/commit/3a100ea901ed79d6a06a5f018be2b4d3bbca51e8 DIFF: https://github.com/llvm/llvm-project/commit/3a100ea901ed79d6a06a5f018be2b4d3bbca51e8.diff LOG:

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. Please separate the change to stripPointerCasts() into a separate review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

steakhal added a comment. Could you please add a test for the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156724/new/ https://reviews.llvm.org/D156724 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 545752. Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 Files: clang/test/CodeGenObjC/arc.m clang/test/CodeGenObjC/convert-messages-to

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie created this revision. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Turned out we were making overly simple assumptions about which sections (& s

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

rjmccall added a comment. In D156539#4546834 , @AlexVlx wrote: > In D156539#4542836 , @rjmccall > wrote: > >> We should probably write this code to work properly in case we add a target >> that makes `__builtin_

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

jdoerfert added a comment. In D156641#4547718 , @AntonRydahl wrote: > The tests that failed pass locally on my machine. If the tests are clearly not related to your change, assume they are broken before or flaky. Repository: rG LLVM Github Monorepo

[PATCH] D156322: Outputs parameter comments using clang-doc and markdown generator

This revision was automatically updated to reflect the committed changes. Closed by commit rG29b1af7396b0: Outputs parameter comments using clang-doc and markdown generator (authored by BotellaA, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang-tools-extra] 29b1af7 - Outputs parameter comments using clang-doc and markdown generator

Author: Arnaud Botella Date: 2023-07-31T14:27:15-04:00 New Revision: 29b1af7396b0839f076ca0a8ae3a5ac47ed55ee7 URL: https://github.com/llvm/llvm-project/commit/29b1af7396b0839f076ca0a8ae3a5ac47ed55ee7 DIFF: https://github.com/llvm/llvm-project/commit/29b1af7396b0839f076ca0a8ae3a5ac47ed55ee7.diff

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

gruuprasad created this revision. gruuprasad added reviewers: NoQ, xazax.hun. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. gruuprasad requested review of this revision. Herald a

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

aaron.ballman added a comment. In D154328#4542457 , @Hahnfeld wrote: > Let me see if I can come up a fix for that in `clang-repl` that would then > need this API. But for now, it's also fine for us if the patch stays pending > in review, still better th

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475

  1   2   3   >