[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. Thanks, @nickdesaulniers for reviewing and @nathanchance for testing the change. @aaron.ballman, I also agree with @xbolva00 seems warning in kernel code is valid but I also agree with your comment about macro, may be better to track the macro-related issue with another

[PATCH] D155573: [Clang] Fix the location of default init expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG64cfcde31a48: [Clang] Fix the location of default init expressions (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D155573?vs=541473&id=541853#toc Repository: rG LLVM Github

[clang] 64cfcde - [Clang] Fix the location of default init expressions

Author: Corentin Jabot Date: 2023-07-19T08:54:01+02:00 New Revision: 64cfcde31a48962c3bbc703753a4ea41200da7a8 URL: https://github.com/llvm/llvm-project/commit/64cfcde31a48962c3bbc703753a4ea41200da7a8 DIFF: https://github.com/llvm/llvm-project/commit/64cfcde31a48962c3bbc703753a4ea41200da7a8.diff

[PATCH] D155619: [clangd] Always run preamble indexing on a separate thread

This revision was automatically updated to reflect the committed changes. Closed by commit rG036a1b2202cb: [clangd] Always run preamble indexing on a separate thread (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155619/new/ h

[clang-tools-extra] 036a1b2 - [clangd] Always run preamble indexing on a separate thread

Author: Kadir Cetinkaya Date: 2023-07-19T08:48:14+02:00 New Revision: 036a1b2202cb71aacfa72ef15145a88dc50a02cf URL: https://github.com/llvm/llvm-project/commit/036a1b2202cb71aacfa72ef15145a88dc50a02cf DIFF: https://github.com/llvm/llvm-project/commit/036a1b2202cb71aacfa72ef15145a88dc50a02cf.dif

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdfdfd306cfaf: [Clang] Fix -Wconstant-logical-operand when LHS is a constant (authored by shivam-amd). Changed prior to co

[clang] dfdfd30 - [Clang] Fix -Wconstant-logical-operand when LHS is a constant

Author: Shivam Gupta Date: 2023-07-19T12:12:11+05:30 New Revision: dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976 URL: https://github.com/llvm/llvm-project/commit/dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976 DIFF: https://github.com/llvm/llvm-project/commit/dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976.diff

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidConstOrRefDataMembersCheck.cpp:91-102 + Finder->addMatcher( + fieldDecl(unless(isMemberOfLambda()), +hasDeclContext(cxxRecordDecl(isCopyableOrMovable())), +

[clang] f5768ec - [NFC] [C++20] [Modules] Add C++20 modules related changes to Release Note

Author: Chuanqi Xu Date: 2023-07-19T14:33:09+08:00 New Revision: f5768ec9b1dcc3f72aae9ab90b92670c2828770b URL: https://github.com/llvm/llvm-project/commit/f5768ec9b1dcc3f72aae9ab90b92670c2828770b DIFF: https://github.com/llvm/llvm-project/commit/f5768ec9b1dcc3f72aae9ab90b92670c2828770b.diff LO

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

cor3ntin added a comment. I agree with Aaron that in the current state, the common case diagnostics are made worse. But there is room for improvement! I think what we want to do here is modify `ConvertAPValueToString` so that it applies the same escape logic to `char` as we do in `pushEscapedSt

[clang] bc3f29c - Revert "[NFC] [C++20] [Modules] Add C++20 modules related changes to Release Note"

Author: Chuanqi Xu Date: 2023-07-19T14:28:47+08:00 New Revision: bc3f29c5401f866380e5c4cedf5a1a8a8e503348 URL: https://github.com/llvm/llvm-project/commit/bc3f29c5401f866380e5c4cedf5a1a8a8e503348 DIFF: https://github.com/llvm/llvm-project/commit/bc3f29c5401f866380e5c4cedf5a1a8a8e503348.diff LO

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

carlosgalvezp added a comment. In D155625#4512123 , @PiotrZSL wrote: > LGTM, but I'm not sure if isCopyableOrMovable will always work correctly, for > a user defined special members it looks ok, but for some implicit ones I > worry it may not always wor

[clang] 95bdd6e - [NFC] [C++20] [Modules] Add C++20 modules related changes to Release Note

Author: Chuanqi Xu Date: 2023-07-19T14:16:01+08:00 New Revision: 95bdd6eed6f3f4b8a95523516120068ac18eccff URL: https://github.com/llvm/llvm-project/commit/95bdd6eed6f3f4b8a95523516120068ac18eccff DIFF: https://github.com/llvm/llvm-project/commit/95bdd6eed6f3f4b8a95523516120068ac18eccff.diff LO

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:153 + static_assert(__builtin_LINE() == 152, ""); +} what is missing to enable the existing source location tests with the new intterpreter? Repository: rG LLVM Github M

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. Note that you are probably need something like `SourceLocExprScopeGuard` to make source_location actually work, , it might be worth doing in this patch. The idea is to remember the location of a call when evaluating default arguments / default member initializers Repo

[PATCH] D155674: [RISCV] Update zihintntl to 1p0

BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, nio

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

arichardson added inline comments. Comment at: clang/test/Driver/riscv-features.c:41 +// DEFAULT: "-target-feature" "-unaligned-scalar-mem" +// DEFAULT-NOT: "-target-feature" "+unaligned-scalar-mem" + This looks a bit fragile, can we just check all -target-featur

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This looks good can you wait for one of the others to accept too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/ https

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl updated this revision to Diff 541836. yaxunl added a comment. update release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155539/new/ https://reviews.llvm.org/D155539 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/LangStandards.def clang/lib/Basic/LangS

[PATCH] D155670: [c-index-test] Suppress -Wcast-qual after D153911

MaskRay abandoned this revision. MaskRay added a comment. commit 0f0c3d45d7d75ba82a955246da654146a7d57a0d did this first Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155670/new

[PATCH] D155545: [clang][Interp] Pass CallExpr to builtin functions

tbaeder updated this revision to Diff 541834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155545/new/ https://reviews.llvm.org/D155545 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/InterpBuiltin.cpp clang/lib/AST/Interp/Opcod

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder added a comment. One thing I'm wondering though is: constexpr char A[] = {'1', '2', '3'}; constexpr double d = __builtin_nans(A); what's expected here? The given char array is not null-terminated. Should the interpreter ignore the null byte at the end if it's there? `StringRef::get

[clang] 12f35b3 - [tools] Use "#pragma GCC" instead of "#pragma clang" to ignore -Wcast-qual in c-index-test.c (NFC)

Author: Jie Fu Date: 2023-07-19T12:05:05+08:00 New Revision: 12f35b39ee63e932d4bdf6b28cce2e3d07713c4d URL: https://github.com/llvm/llvm-project/commit/12f35b39ee63e932d4bdf6b28cce2e3d07713c4d DIFF: https://github.com/llvm/llvm-project/commit/12f35b39ee63e932d4bdf6b28cce2e3d07713c4d.diff LOG: [

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder updated this revision to Diff 541833. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155356/new/ https://reviews.llvm.org/D155356 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/t

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:106 +// 2008 revisions, MIPS interpreted sNaN-2008 as qNan and qNaN-2008 as +// sNaN. This is now known as "legacy NaN" encoding. +if (Signaling

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder updated this revision to Diff 541832. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155356/new/ https://reviews.llvm.org/D155356 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/t

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

wangpc added a comment. Can we run mem2reg pass in RUNs just like RVV tests (maybe another cleanup patch)? I think there are a lot of noises in CHECKS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 ___

[clang] 16d5078 - [tools] Fix buildbot build failure

Author: Jie Fu Date: 2023-07-19T11:39:00+08:00 New Revision: 16d50781e16374f5bf930ba0b9aa8cbbb034ee6c URL: https://github.com/llvm/llvm-project/commit/16d50781e16374f5bf930ba0b9aa8cbbb034ee6c DIFF: https://github.com/llvm/llvm-project/commit/16d50781e16374f5bf930ba0b9aa8cbbb034ee6c.diff LOG: [

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541824. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Re

[clang] 0f0c3d4 - [tools] Ignore -Wcast-qual in c-index-test.c after D153911 (NFC)

Author: Jie Fu Date: 2023-07-19T10:55:12+08:00 New Revision: 0f0c3d45d7d75ba82a955246da654146a7d57a0d URL: https://github.com/llvm/llvm-project/commit/0f0c3d45d7d75ba82a955246da654146a7d57a0d DIFF: https://github.com/llvm/llvm-project/commit/0f0c3d45d7d75ba82a955246da654146a7d57a0d.diff LOG: [

[PATCH] D155671: [include-cleaner] allow spelling strategies to customize verbatim/system headers

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Our use case is wanting to apply a spelling strategy to rewrite the sp

[PATCH] D155147: [X86] Add SM3 instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:162 +/// \param imm8 +///A 128-bit vector of [4 x int]. +/// \returns This is `int` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/

[PATCH] D155670: [c-index-test] Suppress -Wcast-qual after D153911

MaskRay created this revision. MaskRay added reviewers: AlexM, dblaikie. Herald added a subscriber: arphaman. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. free_remapped_files needs to discard the cast

[PATCH] D155416: [Clang][RISCV] Improve diagnostic message for full multiply intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28c3a74a5c6c: [Clang][RISCV] Improve diagnostic message for full multiply intrinsics (authored by eopXD). Repository: rG LLVM Github Monorepo CHA

[clang] 28c3a74 - [Clang][RISCV] Improve diagnostic message for full multiply intrinsics

Author: eopXD Date: 2023-07-18T19:39:46-07:00 New Revision: 28c3a74a5c6c7ed1ac97a010ca080eaacfd7f324 URL: https://github.com/llvm/llvm-project/commit/28c3a74a5c6c7ed1ac97a010ca080eaacfd7f324 DIFF: https://github.com/llvm/llvm-project/commit/28c3a74a5c6c7ed1ac97a010ca080eaacfd7f324.diff LOG: [C

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541815. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Rel

[PATCH] D155147: [X86] Add SM3 instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:161-164 +/// \param imm8 +///A 128-bit vector of [4 x int]. +/// \returns +///A 32-bit int. The description should invert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155147: [X86] Add SM3 instructions.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

gedare added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25486 "comment\n" - " return;\n" "}", MyDeveloperDay wrote: > Why remove? oops. that's a spurious change. I have reverted it. Reposito

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

gedare updated this revision to Diff 541813. gedare marked an inline comment as done. gedare added a comment. Revert deleted line in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154755/new/ https://reviews.llvm.org/D154755 Files: clang/li

[PATCH] D155148: [X86] Add SM4 instructions.

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

shafik added a comment. I think this looks fine, I just wonder if we should be adding more tests to make sure we cover the a fuller set of types and non-type template parameters. I feel like this is always what bites us when bugs come up, if we had just test more carefully we would have caught

[PATCH] D155414: [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4a5b5849767: [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64 (authored by eopXD). Repository: rG LLVM Github Monor

[clang] c4a5b58 - [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64

Author: eopXD Date: 2023-07-18T18:57:33-07:00 New Revision: c4a5b58497677f6be2618765f89b08462e820337 URL: https://github.com/llvm/llvm-project/commit/c4a5b58497677f6be2618765f89b08462e820337 DIFF: https://github.com/llvm/llvm-project/commit/c4a5b58497677f6be2618765f89b08462e820337.diff LOG: [C

[PATCH] D155668: [RISCV] Upgrade Zvfh version to 1.0 and move out of experimental state.

craig.topper created this revision. craig.topper added reviewers: asb, reames, kito-cheng. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfe

[PATCH] D155667: [-Wunsafe-buffer-usage] Check source location validity before using `TypeLoc`s

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The safe-buffer analysis analyzes `TypeLoc`s

[clang] 8f54b83 - [clang-format][doc] Replace single back quotes with double ones

Author: Owen Pan Date: 2023-07-18T18:27:15-07:00 New Revision: 8f54b8331f9f083220eab06fe903b47115441dbe URL: https://github.com/llvm/llvm-project/commit/8f54b8331f9f083220eab06fe903b47115441dbe DIFF: https://github.com/llvm/llvm-project/commit/8f54b8331f9f083220eab06fe903b47115441dbe.diff LOG:

[PATCH] D155012: Fix types of arm64 MSVC __readx18/__writex18 intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ae87b3f8adc: Fix types of arm64 MSVC __readx18/__writex18 intrinsics (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 4ae87b3 - Fix types of arm64 MSVC __readx18/__writex18 intrinsics

Author: Akira Hatanaka Date: 2023-07-18T18:16:20-07:00 New Revision: 4ae87b3f8adc35faa3769f2929e51940dd397803 URL: https://github.com/llvm/llvm-project/commit/4ae87b3f8adc35faa3769f2929e51940dd397803 DIFF: https://github.com/llvm/llvm-project/commit/4ae87b3f8adc35faa3769f2929e51940dd397803.diff

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8360 + // Do not constant fold an R-value. + if (Info.EvalMode == EvalInfo::EM_ConstantFold && !E->isLValue()) +return false; nickdesaulniers wrote: > efriedma wrote: > > Checking is

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe marked 3 inline comments as done. FreddyYe added a comment. I think we can discuss this issue first in https://reviews.llvm.org/D155662 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 ___

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); craig.topper wro

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541793. FreddyYe added a comment. Add missing doxygen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basi

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

t-rasmud added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-multi-parm-span.cpp:306 + b[5] = 5; // expected-note{{used in buffer access here}} +} Can we have a test case with qualifiers on parameters and maybe another with a

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:230 +/// \endcode +#define _mm_sm3rnds2_epi32(A, B, C, D) \ + (__m128i) __builtin_ia32_vsm3rnds2((__v4su)A, (__v4su)B, (__v4su)C, (int)D) pengfei w

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541792. FreddyYe marked 5 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Re

[PATCH] D155661: [ASTImporter] Fix recursive friend class template with non-type parm

danix800 created this revision. Herald added subscribers: martong, kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 541787. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/Rel

[clang] b43df5b - PseudoObjectExpr: Prefer ArrayRef over iterator_range when iterating with pointers

Author: David Blaikie Date: 2023-07-18T23:43:41Z New Revision: b43df5bfe7e7ef358e135b515b0651ec51f635d8 URL: https://github.com/llvm/llvm-project/commit/b43df5bfe7e7ef358e135b515b0651ec51f635d8 DIFF: https://github.com/llvm/llvm-project/commit/b43df5bfe7e7ef358e135b515b0651ec51f635d8.diff LOG:

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

dblaikie added a comment. In D153536#4490918 , @cor3ntin wrote: > @dblaikie Would you be willing to look at the debugger side of things in a > subsequent patch? I'm not familiar with debug symbol code gen so I'm not sure > I'd be able to improve thing t

[PATCH] D155012: Fix types of arm64 MSVC __readx18/__writex18 intrinsics

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. Thanks Akira. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155012/new/ https://reviews.llvm.org/D155012 __

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 ___ cfe-commits mailing l

[PATCH] D152632: [Clang] Add warnings for CWG2521

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ce5e983f82c: [Clang] Add warnings for CWG2521 (authored by rZhBoYao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D1

[clang] 5ce5e98 - [Clang] Add warnings for CWG2521

Author: Po-yao Chang Date: 2023-07-19T07:23:34+08:00 New Revision: 5ce5e983f82c802e44faa8ed42d605d70c045ba9 URL: https://github.com/llvm/llvm-project/commit/5ce5e983f82c802e44faa8ed42d605d70c045ba9 DIFF: https://github.com/llvm/llvm-project/commit/5ce5e983f82c802e44faa8ed42d605d70c045ba9.diff

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1095-1102 // Gadgets "claim" variables they're responsible for. Once this loop finishes, // the tracker will only track DREs that weren't claimed by any gadgets, // i.e. not underst

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2248-2249 +#ifndef NDEBUG +// FIXME: F->getBaseStmt() should never be null! +// (Or we should build a better interface for this.) +Handler.addDebugNoteForVar(

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

NoQ added a comment. Awesome!! Did you try running it on some real code? Does this actually cover most cases? (I suspect that (1.) is going to be the most popular case, but that's also the easiest case to diagnose visually. We might still want a note if we wanted to prioritize among non-variab

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8360 + // Do not constant fold an R-value. + if (Info.EvalMode == EvalInfo::EM_ConstantFold && !E->isLValue()) +return false; efriedma wrote: > Checking isLValue() doesn't mak

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare planned changes to this revision. gedare added a comment. I need to fix this to reflect the changes in the parent rev. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

gedare added a comment. In D155239#4509921 , @HazardyKnusperkeks wrote: > If you limit it to `Never` I don't see any value in the differentiation. You > could just always use `Custom` (by dropping the custom and only having the > nested options). > > B

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

gedare updated this revision to Diff 541770. gedare added a comment. Parse deprecated options and map to new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/ https://reviews.llvm.org/D155239 Files: clang/docs/ClangFormatStyleOptio

[PATCH] D155134: [clang][docs] Defensively turn off exception behavior in dump_ast_matchers.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e62587a48a3: [clang][docs] Defensively turn off exception behavior in dump_ast_matchers.py (authored by t-rasmud). Herald added a project: clang. He

[clang] 1e62587 - [clang][docs] Defensively turn off exception behavior in dump_ast_matchers.py

Author: Rashmi Mudduluru Date: 2023-07-18T15:36:09-07:00 New Revision: 1e62587a48a33b3bf5939e1eef2fd4e41b7e75f6 URL: https://github.com/llvm/llvm-project/commit/1e62587a48a33b3bf5939e1eef2fd4e41b7e75f6 DIFF: https://github.com/llvm/llvm-project/commit/1e62587a48a33b3bf5939e1eef2fd4e41b7e75f6.di

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper updated this revision to Diff 541759. craig.topper added a comment. Fix name of zip/unzip builtin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 Files: clang/lib/Headers/CMakeLists.txt c

[PATCH] D155304: [clang][docs] Update LibASTMatchersReference.html

NoQ added a subscriber: ccotter. NoQ added a comment. @ccotter: now your matcher is properly documented in https://clang.llvm.org/docs/LibASTMatchersReference.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155304/new/ https://reviews.llvm.org/

[PATCH] D155273: [clang-format] Add TypeNames option to disambiguate types/objects

MyDeveloperDay added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155273/new/ https://reviews.llvm.org/D155273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D155304: [clang][docs] Update LibASTMatchersReference.html

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ea673a97b05: [clang][docs] Update LibASTMatchersReference.html (authored by t-rasmud). Herald added a project: clang. Herald added a subscriber: cfe

[clang] 3ea673a - [clang][docs] Update LibASTMatchersReference.html

Author: Rashmi Mudduluru Date: 2023-07-18T15:27:59-07:00 New Revision: 3ea673a97b0583affc22345b9d62e863ba36b3d8 URL: https://github.com/llvm/llvm-project/commit/3ea673a97b0583affc22345b9d62e863ba36b3d8 DIFF: https://github.com/llvm/llvm-project/commit/3ea673a97b0583affc22345b9d62e863ba36b3d8.di

[PATCH] D155651: [SystemZ][z/OS] Add OpenFlags to CreateMissingDirectories path when creating temp files

tltao created this revision. Herald added a project: All. tltao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Additional patch to https://reviews.llvm.org/D103806 to add the same flags in the path where the CreateMissingDirectories boole

[PATCH] D155641: [-Wunsafe-buffer-usage] Do not assert that function parameters have names.

NoQ added a comment. I nitpicked to comments, but other than that LGTM, thanks! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1890-1891 + // A parameter of a function definition has no name. + // FIXME: We should create a name for the parameter as part of the

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1095-1102 // Gadgets "claim" variables they're responsible for. Once this loop finishes, // the tracker will only track DREs that weren't claimed by any gadgets, // i.e. not understood by th

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 541753. capfredf added a comment. Remove unnecessary braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Interpreter/CodeCompletion.h

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper updated this revision to Diff 541752. craig.topper added a comment. Fix file description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 Files: clang/lib/Headers/CMakeLists.txt clang/lib/

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper updated this revision to Diff 541751. craig.topper added a comment. git add the header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 Files: clang/lib/Headers/CMakeLists.txt clang/lib/He

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, wangpc, kito-cheng. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edwar

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

t-rasmud updated this revision to Diff 541745. t-rasmud added a comment. This patch addresses cases 2, 3, and 4 described in the summary (i.e) adds debug notes for unclaimed uses of variables and for failed fixit generation of variable declarations. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D155636: [clang][dataflow] Add function to `WatchedLiteralsSolver` that reports whether the iteration limit has been reached.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1defa781243f: [clang][dataflow] Add function to `WatchedLiteralsSolver` that reports whether… (authored by ymandel). Repository: rG LLVM Github Mo

[clang] 1defa78 - [clang][dataflow] Add function to `WatchedLiteralsSolver` that reports whether the iteration limit has been reached.

Author: Yitzhak Mandelbaum Date: 2023-07-18T21:43:55Z New Revision: 1defa781243f9d0bc66719465e4de33e9fb7a243 URL: https://github.com/llvm/llvm-project/commit/1defa781243f9d0bc66719465e4de33e9fb7a243 DIFF: https://github.com/llvm/llvm-project/commit/1defa781243f9d0bc66719465e4de33e9fb7a243.diff

[PATCH] D155414: [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155414/new/ https://reviews.llvm.org/D155414 ___

[PATCH] D134475: [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9591-9594 + bool IsMSConstexpr = Info.CurrentCall->CanEvalMSConstexpr && + OperatorNew->hasAttr(); if (OperatorNew->isReservedGlobalPlacementOperator() && + (Info.CurrentCall->

[PATCH] D134475: [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5615-5627 +if (canEvalMSConstexpr || isMSConstexpr) { + // Diagnose invalid usage of [[msvc::constexpr]] function + bool isConstructor = isa(Definition); + if (canEvalMSConstexpr) { // !is

[PATCH] D155642: Unconditionally include intrinsic headers in MSVC mode

Neumann-A created this revision. Herald added a project: All. Neumann-A requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Even though there is a significant compile time overhead for all users being a true drop in replacement for cl requires

[PATCH] D155273: [clang-format] Add TypeNames option to disambiguate types/objects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c106f7b947e: [clang-format] Add TypeNames option to disambiguate types/objects (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGE

[clang] 5c106f7 - [clang-format] Add TypeNames option to disambiguate types/objects

Author: Owen Pan Date: 2023-07-18T14:18:40-07:00 New Revision: 5c106f7b947e514852402ad5678c0ebf70ce91b1 URL: https://github.com/llvm/llvm-project/commit/5c106f7b947e514852402ad5678c0ebf70ce91b1 DIFF: https://github.com/llvm/llvm-project/commit/5c106f7b947e514852402ad5678c0ebf70ce91b1.diff LOG:

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134588/new/ https://reviews.llvm.org/D134588 ___ cfe-commits mailing list cfe-comm

[PATCH] D155641: [-Wunsafe-buffer-usage] Do not assert that function parameters have names.

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is possible that a function parameter does

[PATCH] D153423: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGff40c3488177: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special… (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D153423?vs=534059&id=541727#toc Re

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0570cc568f5c: [clang-format] Fix indent for selective formatting (authored by Sedeniono, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] ff40c34 - [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

Author: Piotr Zegar Date: 2023-07-18T21:11:08Z New Revision: ff40c34881772e0641027327cd1791f4acacf6ff URL: https://github.com/llvm/llvm-project/commit/ff40c34881772e0641027327cd1791f4acacf6ff DIFF: https://github.com/llvm/llvm-project/commit/ff40c34881772e0641027327cd1791f4acacf6ff.diff LOG: [

  1   2   3   4   >