[PATCH] D154664: [NFC] Add some missing header includes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9f95146a7f: [NFC] Add optional include to Format.h (authored by etcwilde). Changed prior to commit: https://reviews.llvm.org/D154664?vs=537916&i

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

hubert.reinterpretcast added a comment. In D153536#4483182 , @hubert.reinterpretcast wrote: > If `llvm-dwarfdump` is to be believed, it looks like a compiler bug (two > members reported at the same offset). Similarly, only one local variable out of two

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/cxx2c-placeholder-vars.cpp:46 +int arr[2] = {0, 1}; +static auto [_, _] = arr; // expected-error {{redefinition of '_'}} \ +// expected-note {{previous definition is

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

hubert.reinterpretcast added a comment. In D153536#4479275 , @hubert.reinterpretcast wrote: > It seems the class member case trips up debuggers. If `llvm-dwarfdump` is to be believed, it looks like a compiler bug (two members reported at the same offse

[clang] cfbe86c - Remove getInternalLinkageFor

Author: Fangrui Song Date: 2023-07-08T17:26:36-07:00 New Revision: cfbe86cc28310be0c95a645cde7443cf6625ce1a URL: https://github.com/llvm/llvm-project/commit/cfbe86cc28310be0c95a645cde7443cf6625ce1a DIFF: https://github.com/llvm/llvm-project/commit/cfbe86cc28310be0c95a645cde7443cf6625ce1a.diff

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added a comment. In D154290#4483055 , @cor3ntin wrote: > In D154290#4482975 , @barannikov88 > wrote: > >> According to the current wording, the static_assert-message is either >> unevaluated string

[PATCH] D154778: [clang] Fix __is_trivially_equality_comparable for classes which contain arrays of non-trivially equality comparable types

philnik created this revision. philnik added reviewers: aaron.ballman, cor3ntin, erichkeane. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #63656 Repository: rG LLVM Github Monorepo https://

[PATCH] D154471: [clang] Add serialization support for the DynamicAllocLValue variant of APValue::LValueBase::Ptr

nridge created this revision. Herald added a project: All. nridge updated this revision to Diff 537970. nridge added a comment. nridge edited the summary of this revision. Herald added a subscriber: kadircet. nridge published this revision for review. Herald added subscribers: cfe-commits, ilya-bir

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge added a comment. Review ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149236/new/ https://reviews.llvm.org/D149236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin added a comment. In D154290#4482975 , @barannikov88 wrote: > According to the current wording, the static_assert-message is either > unevaluated string or an expression evaluated at compile time. > Unevaluated strings don't allow certain escape

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks for the patience, I'm really looking forward to use this. But please wait for other opinions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/

[PATCH] D153835: [Sema] Clone VisibilityAttr for functions in template instantiations

MaskRay added a comment. In D153835#4481816 , @rjmccall wrote: > I agree that the change to test51 is the right result, yes. The explicit > visibility attribute on the template declaration should take precedence over > the visibility of the types in th

[PATCH] D154774: [Sema] Respect instantiated-from template's VisibilityAttr for two implicit/explicit instantiation cases

MaskRay created this revision. MaskRay added reviewers: clang, aaron.ballman, efriedma, rjmccall, smeenai. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In CodeGenCXX/visibility.cpp, Match GCC for par

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

barannikov88 created this revision. barannikov88 added a reviewer: cor3ntin. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The width of the APSInt values should be the width of an element. getChar

[clang] 3f370a2 - [test] Add more instantiation cases to visibility.cpp

Author: Fangrui Song Date: 2023-07-08T12:30:49-07:00 New Revision: 3f370a2af59f83134cf1de405358506be9280251 URL: https://github.com/llvm/llvm-project/commit/3f370a2af59f83134cf1de405358506be9280251 DIFF: https://github.com/llvm/llvm-project/commit/3f370a2af59f83134cf1de405358506be9280251.diff

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added a comment. According to the current wording, the static_assert-message is either unevaluated string or an expression evaluated at compile time. Unevaluated strings don't allow certain escape sequences, but if I wrap the string in a string_view-like class, I'm allowed to use an

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik added inline comments. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:182 +namespace GH63605 { +struct { + unsigned : 2; cor3ntin wrote: > Should we add bases? Good catch b/c of course bases would cause problems 🤣 CHANGES SINCE LAST ACT

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik added a comment. I can't really see any details on the libcxx failure :-( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154675/new/ https://reviews.llvm.org/D154675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/include/clang/Driver/Options.td:3220 Values<"simple,mangled">, Flags<[CC1Option, NoDriverOption]>; +def gsrc_hash_EQ : Joined<["-"], "gsrc-hash=">, + Group, Flags<[CC1Option, NoDriverOption]>, dblaikie wrote

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3883 + ///< message. +CCEK_StaticAssertMessageData, ///< Call to data() in a static assert + ///< message. Appear

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a comment. In D134813#4482852 , @Hahnfeld wrote: > In D134813#4482822 , @aaron.ballman > wrote: > >> In D134813#4482819 , @Hahnfeld >> wrote: >> >>>

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

aaron.ballman added subscribers: ChuanqiXu, tahonermann, Bigcheese. aaron.ballman added a comment. In D154130#4481763 , @MrTrillian wrote: > In D154130#4481673 , @aaron.ballman > wrote: > >> Adding a few more fo

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Hahnfeld added a comment. In D134813#4482822 , @aaron.ballman wrote: > In D134813#4482819 , @Hahnfeld > wrote: > >> Thanks! Note that the same probably holds true (but I didn't test) for all >> other classes th

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a comment. In D134813#4482819 , @Hahnfeld wrote: > In D134813#4482808 , @aaron.ballman > wrote: > >> In D134813#4482674 , @Hahnfeld >> wrote: >> >>>

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Hahnfeld added a comment. In D134813#4482808 , @aaron.ballman wrote: > In D134813#4482674 , @Hahnfeld > wrote: > >> Out of curiosity, not sure if it's worth fixing because it's easy enough to >> work around: I

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

HaohaiWen added a comment. In D154295#4477203 , @hans wrote: > In D154295#4477165 , @HaohaiWen > wrote: > >>> It would be nice to have some documentation for this feature though. >> >> This feature is same as Lin

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a comment. In D134813#4482674 , @Hahnfeld wrote: > Out of curiosity, not sure if it's worth fixing because it's easy enough to > work around: I think after this change, it's not possible anymore to call > `printName(raw_ostream &OS)`

cfe-commits@lists.llvm.org

Author: Aaron Ballman Date: 2023-07-08T08:30:58-04:00 New Revision: 0566791ab28b5b842c3befea63d7d47fe9ba1a59 URL: https://github.com/llvm/llvm-project/commit/0566791ab28b5b842c3befea63d7d47fe9ba1a59 DIFF: https://github.com/llvm/llvm-project/commit/0566791ab28b5b842c3befea63d7d47fe9ba1a59.diff

[PATCH] D153738: Add LibClang guide

aaron.ballman added a comment. LGTM, thank you! Do you need me to commit this on your behalf? If so, what name and email address would you like me to use for patch attribution? (I'll build the docs locally and correct any remaining formatting mistakes before landing.) Repository: rG LLVM Git

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:1 +// RUN: %clang_cc1 -triple csky -emit-llvm -o - %s | FileCheck %s + This file is pure test, has nothing to do with `llvm.cttz`, just to avoid another patch. Repository: r

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 538356. benshi001 set the repository for this revision to rG LLVM Github Monorepo. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/

[PATCH] D154764: [clang] ASTImport: force recomputing ASTRecordLayout when importing

danix800 created this revision. danix800 added a project: clang. Herald added a subscriber: martong. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. RecordLayout is cached for RecordDecl. Force recomputing in case staled one is retu

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16898 + } + + QualType T = Message->getType().getNonReferenceType(); tbaeder wrote: > What if the message is ` StringLiteral` but `getCharByteWidth()` doesn't > return `1`? We would get

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin updated this revision to Diff 538350. cor3ntin marked 4 inline comments as done. cor3ntin added a comment. Address Timm's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154290/new/ https://reviews.llvm.org/D154290 Files: clang/d

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Hahnfeld added a comment. Out of curiosity, not sure if it's worth fixing because it's easy enough to work around: I think after this change, it's not possible anymore to call `printName(raw_ostream &OS)` on a (statically typed) `TagDecl` / `EnumDecl` because it's hidden by `TagDecl::printName(

[PATCH] D154543: [Support] Move StringExtras.h include from Error.h to Error.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39d8e6e22cd1: Add missing StringExtras.h includes (authored by IncludeGuardian). Changed prior to commit: https://reviews.llvm.org/D154543?vs=5382

[clang] 39d8e6e - Add missing StringExtras.h includes

Author: Elliot Goodrich Date: 2023-07-08T10:19:07+01:00 New Revision: 39d8e6e22cd192db6ace37a4c842265058dcddb8 URL: https://github.com/llvm/llvm-project/commit/39d8e6e22cd192db6ace37a4c842265058dcddb8 DIFF: https://github.com/llvm/llvm-project/commit/39d8e6e22cd192db6ace37a4c842265058dcddb8.dif

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono added a comment. If everyone is ok with the changes, could someone commit it for me since I do not have commit rights? Thanks! `Sedenion <39583823+sedeni...@users.noreply.github.com>` Note: I cannot really make sense of the error reported by the pre merge checks

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added a comment. In D105759#4482543 , @barannikov88 wrote: > @cor3ntin > I've been working on pretty much the same functionality in our downstream > fork. I was not aware of the paper, nor of the ongoing work in this > direction, and so I unf

[PATCH] D154761: [clang][Interp] Diagnose callsite for implicit functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't have any code to point at here, so the diag

[PATCH] D153738: Add LibClang guide

manuel5975p updated this revision to Diff 538333. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153738/new/ https://reviews.llvm.org/D153738 Files: clang/docs/LibClang.rst Index: clang/docs/LibClang.rst ===

[PATCH] D154758: [clang][Interp] Emit correct diagnostic for uninitialized reads

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM but please make sure to run clang-format before commiting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154758/new/ https://reviews.llvm.org/D154758 ___

[PATCH] D154396: [clang] Add support for SerenityOS

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:85 + auto linkerIs = [Exec](const char *name) { +return llvm::sys::path::filename(Exec).equals_insensitive(name) || + llvm::sys::path::stem(Exec).equals_insensitive(name); -