[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

hokein accepted this revision. hokein added a comment. Thanks, this looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 ___ cfe-commits mailing list cfe

[PATCH] D154634: [6/8][RISCV] Add rounding mode control variant for vfsqrt, vfrec7

eopXD updated this revision to Diff 538008. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154634/new/ https://reviews.llvm.org/D154634 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking

[PATCH] D154633: [5/8][RISCV] Add rounding mode control variant for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac

eopXD updated this revision to Diff 538007. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154633/new/ https://reviews.llvm.org/D154633 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking

[PATCH] D154632: [4/8][RISCV] Add rounding mode control variant for vfmacc, vfnmacc, vfmsac, vfnmsac, vfmadd, vfnmadd, vfmsub, vfnmsub

eopXD updated this revision to Diff 538006. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154632/new/ https://reviews.llvm.org/D154632 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking

[PATCH] D154631: [3/8][RISCV] Add rounding mode control variant for vfmul, vfdiv, vfrdiv, vfwmul

eopXD updated this revision to Diff 538004. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154631/new/ https://reviews.llvm.org/D154631 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking

[PATCH] D154629: [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub

eopXD updated this revision to Diff 538003. eopXD added a comment. Update test case for vfwsub under clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154629/new/ https://reviews.llvm.org/D154629

[PATCH] D154629: [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub

eopXD updated this revision to Diff 538001. eopXD marked 2 inline comments as done. eopXD added a comment. Address comment from Craig: - Remove unnecessary added header - Reduce code duplication Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154629/

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

tbaeder added a comment. @cjdb LGTY? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153359/new/ https://reviews.llvm.org/D153359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

cor3ntin updated this revision to Diff 537996. cor3ntin added a comment. Address Tom's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153621/new/ https://reviews.llvm.org/D153621 Files: clang/docs/ReleaseNotes.rst clang/include/clang/B

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:182 +namespace GH63605 { +struct { + unsigned : 2; Should we add bases? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154675/new/ https://reviews.llvm.org/

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

cor3ntin added a comment. Thanks Shafik. I have some concern about the diagnostics being wonky because, if the init and field don't match, it's hard to be sure we won't run into simar issues (although i agree this fixes the crash.) Also, I'm not saying you should do this but... maybe this th

[PATCH] D154628: [1/8][RISCV] Add rounding mode control variant for vfsub, vfrsub

eopXD updated this revision to Diff 537993. eopXD marked an inline comment as done. eopXD edited the summary of this revision. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154628/new/ https://revi

[PATCH] D154628: [1/8][RISCV] Add rounding mode control variant for vfsub, vfrsub

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4811 return SemaBuiltinConstantArgRange(TheCall, 4, 0, 3); case RISCVVector::BI__builtin_rvv_vfadd_vv_rm_ta: case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_t

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa10dccf2712f: [X86] Support some Intel CPUs for cpu_specific/dispatch feature (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES

[clang] a10dccf - [X86] Support some Intel CPUs for cpu_specific/dispatch feature

Author: Freddy Ye Date: 2023-07-07T13:47:33+08:00 New Revision: a10dccf2712fe4c9d90684626f510913bc6d1307 URL: https://github.com/llvm/llvm-project/commit/a10dccf2712fe4c9d90684626f510913bc6d1307 DIFF: https://github.com/llvm/llvm-project/commit/a10dccf2712fe4c9d90684626f510913bc6d1307.diff LOG

[PATCH] D154683: [RISCV] Split __builtin_riscv_brev8 into _32 and _64 builtin.

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, kito-cheng. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D153418: Adding iconv support to CharSetConverter class

cor3ntin added a comment. In D153418#4478766 , @tahonermann wrote: >> Please correct me if I'm wrong, I'm not too familiar with icu4c, but I think >> adding support for ICU would be the better long-term solution since it seems >> to allow the same beha

[PATCH] D154681: [RISCV] Split __builtin_riscv_xperm4/8 into separate _32 and _64 builtins.

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, kito-cheng. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

cor3ntin marked 6 inline comments as done. cor3ntin added inline comments. Comment at: clang/test/Preprocessor/ucn-allowed-chars.c:16 - // Identifier initial characters tahonermann wrote: > I assume this line was deleted to minimize the disruption to line numb

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

FreddyYe updated this revision to Diff 537980. FreddyYe added a comment. Tune test as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154493/new/ https://reviews.llvm.org/D154493 Files: clang/test/CodeGen/attr-cpuspecific-cpus.c llvm/lib/T

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

owenpan marked an inline comment as done. owenpan added a comment. In D154484#4475377 , @MyDeveloperDay wrote: > I reckon you could detect the `=` condition between the matching paren don't > you? Absolutely. Comment at: clang/docs/

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 537975. sstwcw marked an inline comment as done. sstwcw added a comment. - Drop the line in the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added a comment. If it is expected that the method does not modify the field, and the expectation is not fulfilled, I prefer to make it clear rather than to pretend that the method works as expected. Can you help me come up with an alternative? Braces need to be added around the string

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1532 + +} + This is in large parts copied from existing code. Can we extract those parts into helper functions instead of duplicating them? Repository: rG LLVM Github Mono

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

jdoerfert added a comment. Do you have tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154568/new/ https://reviews.llvm.org/D154568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

jdoerfert added a comment. FWIW, I assume we want this also for OpenMP offload. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154672/new/ https://reviews.llvm.org/D154672 ___

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

owenpan updated this revision to Diff 537971. owenpan added a comment. This revision is now accepted and ready to land. Don't remove the outermost double parentheses after `if`/`while` if there is an `=` inside. Also rename the options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1544

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

FreddyYe added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:419 // Sapphire Rapids microarchitecture based processors. - { {"sapphirerapids"}, CK_SapphireRapids, FEATURE_AVX512BF16, FeaturesSapphireRapids, '\0', false }, + { {"sapphirerapids"}, CK_

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

FreddyYe updated this revision to Diff 537957. FreddyYe marked an inline comment as done. FreddyYe added a comment. Tuned some manglings. SPR should create a new mangling for its feature list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154493/new

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

owenpan accepted this revision. owenpan added a comment. The clang-format part LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D153835: [Sema] Clone VisibilityAttr for functions in template instantiations

MaskRay added a comment. In D153835#4478700 , @efriedma wrote: > Can you write the complete rule we're trying to follow here? Like, if you > have a free function template, prioritize attributes in the following order > ..., if you have a member functio

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik added inline comments. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:195 +.c = 1, // reorder-error {{field 'd' will be initialized after field 'c'}} // reorder-note {{previous initialization for field 'c' is here}} +.b = 1, // reorder-error {{fie

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik created this revision. shafik added reviewers: aaron.ballman, cor3ntin. Herald added a project: All. shafik requested review of this revision. In C++ we are not allowed to use designated initializers to initialize fields out of order. In some cases when diagnosing this we are crashing beca

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

hubert.reinterpretcast added a comment. In D153536#4474066 , @cor3ntin wrote: > Seems to work well enough @hubert.reinterpretcast It seems the class member case trips up debuggers. union U { struct A { int _, _; } a; struct B { int x, y; } b;

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald a

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rsmith added a comment. In D154658#4479170 , @rjmccall wrote: > I don't think it's an intended guarantee of the Itanium ABI that the v-table > will be unique, and v-tables are frequently not unique in the presence of > shared libraries. https://itanium

[clang] 4ac7fd8 - Make test more flexible for platforms that may emit extra arguments.

Author: Douglas Yung Date: 2023-07-06T17:53:48-07:00 New Revision: 4ac7fd866bf83913cbf0311fa6bd8ebb86a278f8 URL: https://github.com/llvm/llvm-project/commit/4ac7fd866bf83913cbf0311fa6bd8ebb86a278f8 DIFF: https://github.com/llvm/llvm-project/commit/4ac7fd866bf83913cbf0311fa6bd8ebb86a278f8.diff

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rjmccall added a comment. I don't think it's an intended guarantee of the Itanium ABI that the v-table will be unique, and v-tables are frequently not unique in the presence of shared libraries. They should be unique for classes with internal linkage, but of course that's a vastly reduced doma

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154493/new/ https://reviews.llvm.org/D154493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] d1e8df8 - [clang] Fix a typo "mdoule" in comments. NFC.

Author: Volodymyr Sapsai Date: 2023-07-06T17:19:26-07:00 New Revision: d1e8df85e6d1f9f823f2de5e0eb88d9a08d1763f URL: https://github.com/llvm/llvm-project/commit/d1e8df85e6d1f9f823f2de5e0eb88d9a08d1763f DIFF: https://github.com/llvm/llvm-project/commit/d1e8df85e6d1f9f823f2de5e0eb88d9a08d1763f.di

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 537933. capfredf marked an inline comment as not done. capfredf added a comment. get rid of the wrapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: cla

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin marked 2 inline comments as done. yronglin added a comment. Thanks for your review! Comment at: clang/lib/AST/ExprConstant.cpp:4914 static bool EvaluateDependentExpr(const Expr *E, EvalInfo &Info) { assert(E->isValueDependent()); aaron.ballman wr

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin updated this revision to Diff 537929. yronglin added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp clan

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin updated this revision to Diff 537928. yronglin marked an inline comment as done. yronglin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 Files: clang/docs/Rel

[clang] 6ca6cdb - Revert "[libc] Add support for creating wrapper headers for offloading in clang"

Author: Joseph Huber Date: 2023-07-06T18:26:41-05:00 New Revision: 6ca6cdb23ece54fcbdead75cda3dd36e08db9665 URL: https://github.com/llvm/llvm-project/commit/6ca6cdb23ece54fcbdead75cda3dd36e08db9665 DIFF: https://github.com/llvm/llvm-project/commit/6ca6cdb23ece54fcbdead75cda3dd36e08db9665.diff

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a26374aa11: [libc] Add support for creating wrapper headers for offloading in clang (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] a4a2637 - [libc] Add support for creating wrapper headers for offloading in clang

Author: Joseph Huber Date: 2023-07-06T18:10:49-05:00 New Revision: a4a26374aa11d48ac6bf65c78c2aaf8f16414287 URL: https://github.com/llvm/llvm-project/commit/a4a26374aa11d48ac6bf65c78c2aaf8f16414287 DIFF: https://github.com/llvm/llvm-project/commit/a4a26374aa11d48ac6bf65c78c2aaf8f16414287.diff

[PATCH] D154664: [NFC] Add some missing header includes

mib accepted this revision. mib added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154664/new/ https://reviews.llvm.org/D154664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf marked an inline comment as not done. capfredf added inline comments. Comment at: clang/lib/Interpreter/CodeCompletion.cpp:84 + std::string AllCodeText = + MainInterp.getAllInput() + "\nvoid dummy(){\n" + Buffer.str() + "}"; + auto Lines = std::count(AllCodeText.b

[PATCH] D154664: [NFC] Add some missing header includes

etcwilde updated this revision to Diff 537916. etcwilde added a comment. Grabbed the right patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154664/new/ https://reviews.llvm.org/D154664 Files: llvm/include/llvm/Support/Format.h llvm/include/

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 537915. capfredf added a comment. remove an unused decl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Interpreter/CodeCompletion.h c

[PATCH] D154664: [NFC] Add some missing header includes

etcwilde created this revision. etcwilde added reviewers: compnerd, mib. etcwilde added projects: clang, LLVM. Herald added a project: All. etcwilde requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. Fixing local build failures due to missing header includes.

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 537912. capfredf added a comment. move the comment up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Interpreter/CodeCompletion.h cla

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 537910. capfredf added a comment. move the comment up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/lib/Interpreter/CodeCompletion.cpp Index: clan

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

nlopes added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1541 +CGF.Builder.CreateBr(CastFail); +return llvm::UndefValue::get(CGF.VoidPtrTy); + } Please use PoisonValue as a placeholder whenever possible. We are trying to get rid of

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1274 if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) -if (StringRef(A->getValue()) == "single") +if (StringRef(A->getValue()) == "single" && Output.isFilename()) ret

[PATCH] D153418: Adding iconv support to CharSetConverter class

tahonermann added a subscriber: hubert.reinterpretcast. tahonermann added a comment. > Please correct me if I'm wrong, I'm not too familiar with icu4c, but I think > adding support for ICU would be the better long-term solution since it seems > to allow the same behaviour across different platfo

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added subscribers: nlopes, mgrang. Herald added a project: All. rsmith requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. - When the destination is a final class ty

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay added a comment. I've used something like `for i in llvm clang clang-tools flang lld lldb bolt mlir; do LIT_OPTS='--filter=xxx --allow-empty-runs' ninja -C /tmp/Rel check-$i` to ensure I have built everything, beside a few projects I run `check-$i`. It's always good to make the last-minu

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay added a comment. Glad that you landed the first change separately:) The Error.cpp change was reverted by b3c8554f28a95063e406924c25336e0da7efb4fd which was more focused. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. Changes look good; I added a number of suggested edits for minor issues. Comment at: clang/docs/ReleaseNotes.rst:203-204 +- Implemented `WG14 N3124

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 537886. IncludeGuardian added a comment. Fix `CompressionTest.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154543/new/ https://reviews.llvm.org/D154543 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/BareMetal.cp

[PATCH] D153835: [Sema] Clone VisibilityAttr for functions in template instantiations

efriedma added a comment. Can you write the complete rule we're trying to follow here? Like, if you have a free function template, prioritize attributes in the following order ..., if you have a member function, use the following order ..., etc. I know that's a significant amount of writing,

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4914 static bool EvaluateDependentExpr(const Expr *E, EvalInfo &Info) { assert(E->isValueDependent()); rsmith wrote: > I don't think the changes to this function are appropriate

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 537883. capfredf edited the summary of this revision. capfredf added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/I

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

jrbyrnes added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:187 +Value *AMDGPULateCodeGenPrepare::buildLegalLaneIntrinsic( +IRBuilder<> &B, Intrinsic::ID IID, Value *Data0, Value *Data1, Value *Lane0, arsenm wrote: > You

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

shafik added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4003-4004 + // that are not referenced or used later. e.g.: if (int var = init()); + ConditionVar->setReferenced(false); + ConditionVar->setIsUsed(false); + tbaeder wrote: > shafik wrote:

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added a comment. @nikic could you try running this over the rust tests again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 ___ cfe-commits mailing l

[PATCH] D154552: [clang-format] Add note directive generation for docs

gedare updated this revision to Diff 537872. gedare added a comment. Update from D153205 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154552/new/ https://reviews.llvm.org/D154552 Files: clang/docs/ClangFormatS

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 537871. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files: clang/test/Headers/mm_malloc.c llvm/lib/Passes/PassBuilderPipelin

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG413a7cb6e0db: [clang-format] Support block indenting array/struct list initializers (authored by gedare, committed by owenpan). Repository: rG LLV

[clang] 413a7cb - [clang-format] Support block indenting array/struct list initializers

Author: Gedare Bloom Date: 2023-07-06T13:42:11-07:00 New Revision: 413a7cb6e0db96b29bda0dab8541e225193ad139 URL: https://github.com/llvm/llvm-project/commit/413a7cb6e0db96b29bda0dab8541e225193ad139 DIFF: https://github.com/llvm/llvm-project/commit/413a7cb6e0db96b29bda0dab8541e225193ad139.diff

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

shafik added inline comments. Herald added subscribers: jplehr, mattd, carlosgalvezp, MaskRay. Herald added a project: All. Comment at: clang/lib/Sema/SemaDecl.cpp:14543 // deletion in some later function. -if (getDiagnostics().hasUncompilableErrorOccurred() || +if (

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

gedare updated this revision to Diff 537859. gedare added a comment. Regenerate complete diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154550/new/ https://reviews.llvm.org/D154550 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/R

[PATCH] D154635: [7/8][RISCV] Add rounding mode control variant for conversion intrinsics between floating-point and integer

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:6769 +let hasSideEffects = 0 in { +defm PseudoVFWCVT_F_XU : VPseudoVWCVTF_V_RM; +defm PseudoVFWCVT_F_X : VPseudoVWCVTF_V_RM; craig.topper wrote: > These don't

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

gedare updated this revision to Diff 537857. gedare added a comment. Reorder traits and add comment about backward compatibility. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensu

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9f5119a78aa: [DebugInfo] Enable debug info emission for extern variables in C++ (authored by chiyuze, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] a9f5119 - [DebugInfo] Enable debug info emission for extern variables in C++

Author: Yuze Chi Date: 2023-07-06T12:59:05-07:00 New Revision: a9f5119a78aaa1fc63347a89aee50922bbb8c99c URL: https://github.com/llvm/llvm-project/commit/a9f5119a78aaa1fc63347a89aee50922bbb8c99c DIFF: https://github.com/llvm/llvm-project/commit/a9f5119a78aaa1fc63347a89aee50922bbb8c99c.diff LOG:

[PATCH] D154647: [RISCV] Re-define sha256, Zksed, and Zksh intrinsics to use i32 types.

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, kito-cheng, reames. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edwar

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate

SuperSodaSea updated this revision to Diff 537842. SuperSodaSea added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Add more context in patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154646/new/ https://reviews.llvm.org/D154646 Files:

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate

SuperSodaSea created this revision. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, mravishankar, awarzynski, sdasgup3, wenzhicui, wrengr, jsetoain, hanchung, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, a

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin abandoned this revision. cor3ntin added a comment. The right way to do that is outline here https://reviews.llvm.org/D153701#4478240 There is no point in trying to keep this attempt around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:595-599 +IO.enumCase(Value, "Never", FormatStyle::SWFLS_Never); +IO.enumCase(Value, "false", FormatStyle::SWFLS_Never); +IO.enumCase(Value, "NonEmpty", FormatStyle::SWFLS_NonEmpty); +

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. In D151761#4474136 , @galenelias wrote: > I re-wrote the alignment to stop using AlignTokens so that I can now handle > all the edge cases that came up. Specifically: > > - Allowing empty case labels (implicit fall t

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25808 +TEST_F(FormatTest, RemoveParentheses) { + FormatStyle Style = getLLVMStyle(); Should check for `__attribute((what ever))__`. Repository: rG LLVM Github Monor

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

arsenm requested changes to this revision. arsenm added inline comments. This revision now requires changes to proceed. Herald added a subscriber: wangpc. Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:187 +Value *AMDGPULateCodeGenPrepare::buildLegalLaneIntrins

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added a comment. In D154093#4466597 , @sstwcw wrote: > In D154093#4466246 , > @HazardyKnusperkeks wrote: > >> I'd really prefer you put what you need to modify `mutable` instead of >> removing

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8901-8914 + // [P2718R0] Lifetime extension in range-based for loops. + // + // 6.7.7 [class.temporary] p5: + // There are four contexts in which temporaries are destroyed at a different + // point than

[PATCH] D154635: [7/8][RISCV] Add rounding mode control variant for conversion intrinsics between floating-point and integer

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:6769 +let hasSideEffects = 0 in { +defm PseudoVFWCVT_F_XU : VPseudoVWCVTF_V_RM; +defm PseudoVFWCVT_F_X : VPseudoVWCVTF_V_RM; These don't need rounding mode. A

[PATCH] D154629: [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:14 #include "RISCVInstrInfo.h" +#include "MCTargetDesc/RISCVBaseInfo.h" #include "MCTargetDesc/RISCVMatInt.h" RISCV.h already includes this. Comment at:

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

rsmith added a comment. Making the `return ESR_Failed;` unconditional looks to be the correct change here. We can't continue evaluation past that point because we don't know what would be executed next. Unconditionally returning `ESR_Failed` in that situation is what the other similar paths thr

[PATCH] D154628: [1/8][RISCV] Add rounding mode control variant for vfsub, vfrsub

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4811 return SemaBuiltinConstantArgRange(TheCall, 4, 0, 3); case RISCVVector::BI__builtin_rvv_vfadd_vv_rm_ta: case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_ta: Not related t

[PATCH] D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf70967fdc473: [OPENMP52] Support Support omp_cur_iteration modifier for doacross (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES

[clang] f70967f - [OPENMP52] Support Support omp_cur_iteration modifier for doacross

Author: Jennifer Yu Date: 2023-07-06T11:40:02-07:00 New Revision: f70967fdc4736a5c5150db294be55fa9e7792bb8 URL: https://github.com/llvm/llvm-project/commit/f70967fdc4736a5c5150db294be55fa9e7792bb8 DIFF: https://github.com/llvm/llvm-project/commit/f70967fdc4736a5c5150db294be55fa9e7792bb8.diff L

[PATCH] D153600: Implement -frecord-command-line for XCOFF

scott.linder accepted this revision. scott.linder added a comment. This revision is now accepted and ready to land. Thank you for the patch and the changes! This LGTM, and AFAICT all of the comments have been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D154636: [RISCV] Add rounding mode control variant for vfredosum, vfredusum, vfwredosum, vfwredusum

eopXD created this revision. eopXD added reviewers: craig.topper, reames, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jon

[PATCH] D154635: [RISCV] Add rounding mode control variant for conversion intrinsics between floating-point and integer

eopXD created this revision. eopXD added reviewers: craig.topper, reames, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jon

[PATCH] D154634: [RISCV] Add rounding mode control variant for vfsqrt, vfrec7

eopXD created this revision. eopXD added reviewers: craig.topper, reames, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jon

[PATCH] D154633: [RISCV] Add rounding mode control variant for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac

eopXD created this revision. eopXD added reviewers: craig.topper, reames, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jon

  1   2   3   >