craig.topper added inline comments.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:4811 return SemaBuiltinConstantArgRange(TheCall, 4, 0, 3); case RISCVVector::BI__builtin_rvv_vfadd_vv_rm_ta: case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_ta: ---------------- Not related to this patch, but why do the builtins end in _ta when the C intrinsics don't? ================ Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:5916 //===----------------------------------------------------------------------===// -let mayRaiseFPException = true in { +let mayRaiseFPException = true, hasSideEffects = 0 in { defm PseudoVFADD : VPseudoVALU_VV_VF_RM; ---------------- Why do we need `hasSideEffects = 0` now? We didn't have it before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154628/new/ https://reviews.llvm.org/D154628 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits