[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type

eopXD updated this revision to Diff 534167. eopXD marked an inline comment as done. eopXD added a comment. Add a blank line to separate from SVE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153510/new/ https://reviews.llvm.org/D153510 Files: c

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a so far broken Lambda test case. Repositor

[PATCH] D125272: [clang] Add -fcheck-new support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52c8f0bb20eb: [clang] Add -fcheck-new support (authored by heatd, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D125272

[clang] 52c8f0b - [clang] Add -fcheck-new support

Author: Pedro Falcato Date: 2023-06-23T22:45:17-07:00 New Revision: 52c8f0bb20eb9e7b1b54ffdddf6da77b53caeb3a URL: https://github.com/llvm/llvm-project/commit/52c8f0bb20eb9e7b1b54ffdddf6da77b53caeb3a DIFF: https://github.com/llvm/llvm-project/commit/52c8f0bb20eb9e7b1b54ffdddf6da77b53caeb3a.diff

[PATCH] D105759: Implement P2361 Unevaluated string literals

shafik added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:3268 + + return ParseStringLiteralExpression(false, true); +} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llv

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

shafik added a comment. In D153296#612 , @erichkeane wrote: > So I think I'm pretty confident that the only time we would call > `EvaluateDependentExpr` is when we are in an error condition, so I'm > convinced the fix 'as is' is incorrect. The che

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

shafik added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18217 + NewFD->setIsPlaceholderVar(LangOpts.CPlusPlus && II && II->isPlaceholder()); if (PrevDecl && !isa(PrevDecl)) { Why can't we fold this into `FieldDecl::Create`? This comment applie

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

shafik added inline comments. Comment at: clang/lib/AST/Decl.cpp:1831 + // Objective-C as an extension. + if (isa(this) && getLangOpts().ObjC) return true; It is not obvious to me if this is a drive by fix or this has a larger effect in the context of thi

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. Sorry for the long delay reviewing again. I noted some mostly minor issues. I'm on vacation next week, but I'll try to watch for updates. I'm still concerned that the chang

[PATCH] D117929: [XRay] Add support for RISCV

MaskRay added inline comments. Comment at: compiler-rt/lib/xray/xray_trampoline_riscv32.S:16 + .text + .file "xray_trampoline_riscv32.S" + .globl __xray_FunctionEntry Omit `.file` Consider using `#include "../sanitizer_common/sanitizer_asm.h"`

[PATCH] D153681: [X86] Move back _mulx_u32 to 32-bit only

pengfei created this revision. pengfei added reviewers: probinson, craig.topper, RKSimon. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We cannot lower it to mulx at the present due to backend reason.

[PATCH] D117929: [XRay] Add support for RISCV

MaskRay added a comment. Herald added subscribers: wangpc, luke, Enna1, shiva0217, arichardson. Herald added a project: All. I am still interested in a RISC-V XRay port :) Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:280 + // Emit NOP instructions + for (int8_t I = 0

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 534141. evelez7 added a comment. Add conversion function and overloaded operator support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files: clang/include/clang/

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

wenlei added a comment. > For concrete data are you talking about between the different solutions e.g. > --lto-whole-program-visibility, -funknown-vtable-visibility-filepaths, RTTI > based, FatLTO based etc or something else? Right, between the different solutions. RTTI based solution doesn't e

[PATCH] D153491: [dataflow] Avoid copying environment

gribozavr2 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153491/new/ https://reviews.llvm.org/D153491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Herald added a subscriber: wangpc. Comment at: clang/lib/Basic/Targets/RISCV.cpp:369 +Feature = Feature.trim(); +StringRef Attrstring = Feature.split("=").second.trim(); + Attrstring -> AttrString Com

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:211 PostVisitCFG(Element, DataflowAnalysisState{ -*Lattice, State.Env}); +*Lattice, State.Env.fork()})

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

sammccall created this revision. sammccall added reviewers: xazax.hun, ymandel. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Environ

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

modimo updated this revision to Diff 534134. modimo added a comment. Feedback, add documentation for flag and unknown visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152741/new/ https://reviews.llvm.org/D152741 Files: clang/docs/LTOVis

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

modimo marked 4 inline comments as done. modimo added a comment. In D152741#4445112 , @wenlei wrote: >> The big advantage of doing this in the FE is that we know which types are >> actually coming from the native headers. Blocking all types in the TU is

[PATCH] D144911: adding bf16 support to NVPTX

tra planned changes to this revision. tra added a comment. We're still missing clang-side tests for the new builtins. Now that the intrinsics use `bfloat` we also need to change builtin signatures. Or change codegen to bitcast to/from bfloat to match the types. To be continued next week. Reposi

[PATCH] D144911: adding bf16 support to NVPTX

tra updated this revision to Diff 534130. tra added a comment. Fixed few missed places in bf16 lowering. Changed intrinsic types to use bfloat type. Auto-upgrade the old intrinsic variants. Updated broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D153510: [Clang] Check type support for local variable declaration

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8780 } + if (T->isRVVType()) +checkRVVTypeSupport(T, NewVD->getLocation(), cast(CurContext)); Add a blank line before this to separate it from SVE Repository: rG LLVM Github M

[PATCH] D153670: [clang/HeaderSearch] Make sure `loadSubdirectoryModuleMaps` doesn't cause loading of regular files

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/unittests/Tooling/DependencyScannerTest.cpp:274 +llvm::ErrorOr> +openFileForRead(const Twine &Path) override { + ReadFiles.push_back(Path.str()); benlangmuir w

[PATCH] D153670: [clang/HeaderSearch] Make sure `loadSubdirectoryModuleMaps` doesn't cause loading of regular files

akyrtzi updated this revision to Diff 534123. akyrtzi added a comment. For the test also check for unnecessary `stat` call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153670/new/ https://reviews.llvm.org/D153670 Files: clang/lib/Lex/HeaderSea

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm closed this revision. arsenm added a comment. 9d84f8dc948b3188fdec9a1a080eb6d845c2082d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 __

[clang] e248955 - clang: Add missing cases to elementwise builtin SemaCXX test

Author: Matt Arsenault Date: 2023-06-23T19:52:06-04:00 New Revision: e248955aeda50bd7e0910eabdabdf7bd617e649f URL: https://github.com/llvm/llvm-project/commit/e248955aeda50bd7e0910eabdabdf7bd617e649f DIFF: https://github.com/llvm/llvm-project/commit/e248955aeda50bd7e0910eabdabdf7bd617e649f.diff

[clang] 9d84f8d - clang: Add __builtin_elementwise_rint and nearbyint

Author: Matt Arsenault Date: 2023-06-23T19:52:06-04:00 New Revision: 9d84f8dc948b3188fdec9a1a080eb6d845c2082d URL: https://github.com/llvm/llvm-project/commit/9d84f8dc948b3188fdec9a1a080eb6d845c2082d DIFF: https://github.com/llvm/llvm-project/commit/9d84f8dc948b3188fdec9a1a080eb6d845c2082d.diff

[clang] 7ba9506 - clang: Fix elementwise value naming to match instruction

Author: Matt Arsenault Date: 2023-06-23T19:39:04-04:00 New Revision: 7ba95064856cd1be9a3b48b70caa0ec4a2cda0e4 URL: https://github.com/llvm/llvm-project/commit/7ba95064856cd1be9a3b48b70caa0ec4a2cda0e4 DIFF: https://github.com/llvm/llvm-project/commit/7ba95064856cd1be9a3b48b70caa0ec4a2cda0e4.diff

[PATCH] D153476: [dataflow] document & test determinism of formula structure

sammccall updated this revision to Diff 534120. sammccall marked an inline comment as done. sammccall added a comment. typo fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153476/new/ https://reviews.llvm.org/D153476 Files: clang/lib/Analysis/

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added a comment. BTW, since this is a substantial API/concept change, I'll wait on approval from all of @mboehme, @xazax.hun, @gribozavr2 - if you don't plan to review just LMK. (Not in a hurry, just wanted to mention so we don't deadlock :-) Comment at: clang/includ

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 534117. sammccall marked 10 inline comments as done. sammccall added a comment. address Martin's review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Fil

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8360 + // Do not constant fold an R-value. + if (Info.EvalMode == EvalInfo::EM_ConstantFold && !E->isLValue()) +return false; Checking isLValue() doesn't make sense; consider: ``` s

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 accepted this revision. bob80905 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 ___ cfe-commits mailing list cfe-commi

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

yaxunl added inline comments. Comment at: clang/test/Driver/hip-phases.hip:259 +// RELOC-DAG: [[P4:[0-9]+]]: assembler, {[[P3]]}, object, (device-[[T]], [[ARCH]]) +// RELOC-NOT: [[P5:[0-9]+]]: linker, {[[P4]]}, image, (device-[[T]], [[ARCH]]) +// RELOC-DAG: [[P5:[0-9]+]]: offloa

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 534111. arsenm added a comment. Add fixme to test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Builtin

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added a comment. In D153233#4443000 , @bob80905 wrote: > Should there be tests added for usage of scalable vector types for RISC-V / > AArch64? > I typically have added such tests in the past, as shown here: > https://reviews.llvm.org/D135011 Te

[clang] 83835e2 - [RISCV] Implement KCFI operand bundle lowering

Author: Sami Tolvanen Date: 2023-06-23T22:57:56Z New Revision: 83835e22c7cd50c0e9b836cc359b6c59985b921f URL: https://github.com/llvm/llvm-project/commit/83835e22c7cd50c0e9b836cc359b6c59985b921f DIFF: https://github.com/llvm/llvm-project/commit/83835e22c7cd50c0e9b836cc359b6c59985b921f.diff LOG:

[PATCH] D153476: [dataflow] document & test determinism of formula structure

sammccall added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ArenaTest.cpp:169 + auto &BOr = A.makeOr(BY, BX); + auto &BEqual = A.makeEquals(BOr, BAnd); + EXPECT_EQ(Expected, llvm::to_string(B.getFormula(BEqual))); gribozavr2 wrote: > gr

[PATCH] D153476: [dataflow] document & test determinism of formula structure

sammccall updated this revision to Diff 534107. sammccall marked 3 inline comments as done. sammccall added a comment. fix busted test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153476/new/ https://reviews.llvm.org/D153476 Files: clang/lib/An

[PATCH] D153670: [clang/HeaderSearch] Make sure `loadSubdirectoryModuleMaps` doesn't cause loading of regular files

benlangmuir added inline comments. Comment at: clang/unittests/Tooling/DependencyScannerTest.cpp:274 +llvm::ErrorOr> +openFileForRead(const Twine &Path) override { + ReadFiles.push_back(Path.str()); Should we add `status` override as well? I think we

[PATCH] D153491: [dataflow] Avoid copying environment

sammccall added a comment. In D153491#4445051 , @ymandel wrote: > In D153491#4443704 , @xazax.hun > wrote: > >> This sounds extremely error-prone to me. In case copying the analysis state >> has side effects lik

[PATCH] D153670: [clang/HeaderSearch] Make sure `loadSubdirectoryModuleMaps` doesn't cause loading of regular files

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `HeaderSearch::loadSubdirectoryModuleMaps` `stat`s all the files in a directory which causes the dependency scanning servic

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2293 +// search of connected components. +if (!ParmsNeedFix.empty()) { + auto First = ParmsNeedFix.begin(), Last = First; NoQ wrote: > ziqingluo-90 wrote: >

[PATCH] D149716: clang: Use new frexp intrinsic for builtins and add f16 version

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149716/new/ https://reviews.llvm.org/D149716 ___ cfe-commits mailing list cfe-

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 534090. nickdesaulniers added a comment. - test for RValue and EvalMode in LValueExprEvaluator::VisitMaterializeTemporaryExpr rather than Visit MTE's in VisitImplicitValueInitExpr. - reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes updated this revision to Diff 534086. jrbyrnes added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes created this revision. jrbyrnes added a reviewer: yaxunl. Herald added a project: All. jrbyrnes requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Change-Id: Ia19a28867d15022d1400d3e18c61f14259057ff4 Repository: rG LLVM Gi

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

cjdb accepted this revision. cjdb added a comment. Thanks! This LGTM now. Do you need assistance with merging? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153267/new/ https://reviews.llvm.org/D153267 ___ cfe-commits mailing list cfe-commits

[PATCH] D149716: clang: Use new frexp intrinsic for builtins and add f16 version

arsenm added a comment. In D149716#4445411 , @yaxunl wrote: > should we have tests for llvm.frexp.* for LLVM codegen? Those are added in the parent that adds the intrinsic, this is just the clang side CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D153584: [dataflow] Make SAT solver deterministic

sammccall added a comment. In D153584#4443796 , @xazax.hun wrote: > Is there a measurable perf cost for this determinism? I'm going to say no... All the extra cost is paid in addTransitiveFlowConditionConstraints. (We were building a set, now we're buil

[PATCH] D149716: clang: Use new frexp intrinsic for builtins and add f16 version

yaxunl added a comment. should we have tests for llvm.frexp.* for LLVM codegen? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149716/new/ https://reviews.llvm.org/D149716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] e809ebe - Revert "[RISCV] Implement KCFI operand bundle lowering"

Author: Sami Tolvanen Date: 2023-06-23T21:42:57Z New Revision: e809ebeb6c8b4986cc82542cffd07a453bfac66c URL: https://github.com/llvm/llvm-project/commit/e809ebeb6c8b4986cc82542cffd07a453bfac66c DIFF: https://github.com/llvm/llvm-project/commit/e809ebeb6c8b4986cc82542cffd07a453bfac66c.diff LOG:

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1279 + if (isa(E)) +return nullptr; + efriedma wrote: > nickdesaulniers wrote: > > efriedma wrote: > > > nickdesaulniers wrote: > > > > efriedma wrote: > > > > >

[PATCH] D153652: [llvm][Support] Don'tt set "all_exe" mode by default for file written by llvm::writeToOutput.

avl added a reviewer: jhenderson. avl added a comment. Agree that it is safe to remove all_exec from the default permissions. There are currently three usages of writeToOutput API: clang include cleaner, llvm-objcopy, llvm-dwarfutil. Both llvm-objcopy and llvm-dwarfutil use FilePermissionsAppli

[PATCH] D144911: adding bf16 support to NVPTX

tra commandeered this revision. tra edited reviewers, added: kushanam; removed: tra. tra added a comment. This revision now requires review to proceed. Herald added a subscriber: bixia. I've got a few more fixes for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1279 + if (isa(E)) +return nullptr; + nickdesaulniers wrote: > efriedma wrote: > > nickdesaulniers wrote: > > > efriedma wrote: > > > > efriedma wrote: > > > > > This ne

[PATCH] D153423: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

PiotrZSL updated this revision to Diff 534059. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Herald added a project: clang. Review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153423/new/ https://reviews.llvm.org/D1534

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 534060. evelez7 added a comment. Fix duplicate visitation of CXXRecordDecls by overloading WalkUpFromCXXRecordDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Fi

[PATCH] D153423: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

PiotrZSL marked 4 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/exception-escape.rst:14 * ``swap()`` functions -* Functions marked with ``throw()`` or ``noexcept`` +* Functions marked with ``throw()``, ``n

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1279 + if (isa(E)) +return nullptr; + efriedma wrote: > nickdesaulniers wrote: > > efriedma wrote: > > > efriedma wrote: > > > > This needs a comment explaining w

[PATCH] D153568: [ClangPackager] Add an option to extract inputs to an archive

This revision was automatically updated to reflect the committed changes. Closed by commit rG869baa912573: [ClangPackager] Add an option to extract inputs to an archive (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153568/new/

[clang] 869baa9 - [ClangPackager] Add an option to extract inputs to an archive

Author: Joseph Huber Date: 2023-06-23T15:03:43-05:00 New Revision: 869baa9125736f6140ef770e4a3a852c5f9be505 URL: https://github.com/llvm/llvm-project/commit/869baa9125736f6140ef770e4a3a852c5f9be505 DIFF: https://github.com/llvm/llvm-project/commit/869baa9125736f6140ef770e4a3a852c5f9be505.diff

[PATCH] D153568: [ClangPackager] Add an option to extract inputs to an archive

jhuber6 added a comment. In D153568#4445133 , @JonChesterfield wrote: > LGTM. As a meta level comment, we have far too many of these binary munging > sorts of tools. Definitely agree. This is supposed to be a direct repalcement for `clang-offload-bund

[PATCH] D153568: [ClangPackager] Add an option to extract inputs to an archive

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM. As a meta level comment, we have far too many of these binary munging sorts of tools. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

wenlei added a comment. > The big advantage of doing this in the FE is that we know which types are > actually coming from the native headers. Blocking all types in the TU is > overly conservative and also less stable as header changes can effectively > turn on/off unrelated large chunks of WPD

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Seems that the main change is in `llvm/include/llvm/Support/Error.h`. I think there is a small but not negligible chance that this patch may cause a breakage for some build configurations. I

[PATCH] D153659: [RISCV] Fix name mangling for LMUL!=1 vector types with attribute(rvv_vector_bits)

craig.topper created this revision. craig.topper added reviewers: aaron.ballman, reames, eopXD, kito-cheng, frasercrmck, rogfer01. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Ma

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 534050. kushanam added a comment. fixing the f16x2-instructions test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/include/clang/Basic/BuiltinsNVPTX

[PATCH] D153458: [clang-tidy] Model noexcept more properly in bugprone-exception-escape

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:319 +static bool cannotThrow(const FunctionDecl *Func) { + const auto *FunProto = Func->getType()->getAs(); isuckatcs wrote: > Put this in the anonymous namesp

[clang] 63b0b82 - When float_t and double_t types are used inside a scope with

Author: Zahira Ammarguellat Date: 2023-06-23T15:12:51-04:00 New Revision: 63b0b82fd6bee672fa20078aa2fbe3c4ee2b8970 URL: https://github.com/llvm/llvm-project/commit/63b0b82fd6bee672fa20078aa2fbe3c4ee2b8970 DIFF: https://github.com/llvm/llvm-project/commit/63b0b82fd6bee672fa20078aa2fbe3c4ee2b8970

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

This revision was automatically updated to reflect the committed changes. Closed by commit rG63b0b82fd6be: When float_t and double_t types are used inside a scope with (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153590/new/

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152741/new/ https://reviews.llvm.org/D152741 _

[PATCH] D153491: [dataflow] Avoid copying environment

ymandel added a comment. In D153491#4443704 , @xazax.hun wrote: > This sounds extremely error-prone to me. In case copying the analysis state > has side effects like this, I would argue we want such operations to be > really explicit. What do you think?

[PATCH] D153458: [clang-tidy] Model noexcept more properly in bugprone-exception-escape

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:319 +static bool cannotThrow(const FunctionDecl *Func) { + const auto *FunProto = Func->getType()->getAs(); Put this in the anonymous namespace above please t

[PATCH] D153423: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

isuckatcs added a comment. Apart from some nits I think this patch looks good. Comment at: clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp:26 + +AST_MATCHER(FunctionDecl, isExplicitThrow) { + switch (Node.getExceptionSpecType()) { How about crea

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rG62fa708ceb02: [RISCV] Implement KCFI operand bundle lowering (authored by samitolvanen). Herald added a subscriber: wangpc. Changed prior to commit: https://reviews.llvm.org/D148385?vs=531476&id=534032#

[clang] 62fa708 - [RISCV] Implement KCFI operand bundle lowering

Author: Sami Tolvanen Date: 2023-06-23T18:25:24Z New Revision: 62fa708ceb027713b386c7e0efda994f8bdc27e2 URL: https://github.com/llvm/llvm-project/commit/62fa708ceb027713b386c7e0efda994f8bdc27e2 DIFF: https://github.com/llvm/llvm-project/commit/62fa708ceb027713b386c7e0efda994f8bdc27e2.diff LOG:

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:390 for (const Type *T : TypesToDelete) -ThrownExceptions.erase(T); +ThrownExceptions.erase({T, SourceLocation()}); isuckatcs wrote: > PiotrZSL wrote

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:390 for (const Type *T : TypesToDelete) -ThrownExceptions.erase(T); +ThrownExceptions.erase({T, SourceLocation()}); PiotrZSL wrote: > isuckatcs wrot

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. The latest patch revision still fails on a few LLVM tests: Failed Tests (3): LLVM :: CodeGen/NVPTX/bf16-instructions.ll LLVM :: CodeGen/NVPTX/f16x2-instructions.ll LLVM :: CodeGen/NVPTX/math-intrins-sm80-ptx70.ll Comment at: llvm/lib/Target/N

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

craig.topper accepted this revision. craig.topper added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/ReleaseNotes.rst:209 disassembler/assembler. +* Added support for the vendor-defined Xsfcie (SiFive SCIE) extension + disassembler/a

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. visitLocalInitializer() pops the pointer from the

[PATCH] D153510: [Clang] Check type support for local variable declaration

eopXD updated this revision to Diff 534025. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153510/new/ https://reviews.llvm.org/D153510 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono marked an inline comment as done. Sedeniono added a comment. @owenpan , @MyDeveloperDay Any opinion on the latest changes? Otherwise, since I do not have commit rights, someone needs to commit the changes to main (my name and mail: `Sedenion <39583823+sedeni...@users.noreply.github.co

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

alexhenrie added a comment. Herald added a project: All. Any update on this? The Wine project would like to omit the refptr symbols, see https://gitlab.winehq.org/wine/wine/-/merge_requests/3109 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61670/new/ https://re

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked 6 inline comments as done. Sedeniono added inline comments. Comment at: clang/lib/Format/Format.cpp:3476-3477 + + // Regarding the 16: Note that multiple passes are added in + // addQualifierAlignmentFixerPasses(). + SmallVector Passes; Hazard

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono updated this revision to Diff 534024. Sedeniono added a comment. As suggested by the reviewers, the noop fixes are now filtered only if the qualifier alignment passes are active. Also implemented the other minor refactorings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153652: [llvm][Support] Don'tt set "all_exe" mode by default for file written by llvm::writeToOutput.

hokein created this revision. hokein added a reviewer: avl. Herald added a subscriber: hiraditya. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D153649: [clang][Interp] Fix return statements with expresssion in void functions

tbaeder updated this revision to Diff 534021. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153649/new/ https://reviews.llvm.org/D153649 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/Interp/functions.cpp Index: clang/test/AST/Interp/functions.cpp ==

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 updated this revision to Diff 534018. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153370/new/ https://reviews.llvm.org/D153370 Files: clang/test/Driver/riscv-cpus.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst llvm/lib

[PATCH] D153649: [clang][Interp] Fix return statements with expresssion in void functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the return type of a function is void, ReturnT

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

jrbyrnes added a comment. In D147732#4434557 , @arsenm wrote: > I think this may not hard break mesa. I believe mesa bypasses the intrinsic > creation API, and just declares the string name of the intrinsic. The type > name mangling suffix is technicall

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

ilya-biryukov added a comment. In D153294#065 , @Fznamznon wrote: >> While we wait for Richard's response... @Fznamznon what are your thoughts on >> wrapping all ConstantExpr that span immediate invocations with redundant >> ExprWithCleanups per Ric

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

erichkeane added a comment. So I think I'm pretty confident that the only time we would call `EvaluateDependentExpr` is when we are in an error condition, so I'm convinced the fix 'as is' is incorrect. The check for noteSideEffect records that we HAVE a side effect, then returns if we are OK i

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:787 + // names like class and protocol names. + if (const auto *CD = dyn_cast(&RenameDecl)) +if (CD->getName() != IdentifierToken->text(SM)) kadircet wrote: > this spec

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533993. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-ex

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

Endill added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151697/new/ https://reviews.llvm.org/D151697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533989. IncludeGuardian added a comment. Fix missing includes for Windows-only files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: clang-tools-extr

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153590/new/ https://reviews.llvm.org/D153590 ___ cfe-commits mailing list cfe-comm

  1   2   >