MaskRay added inline comments.
================ Comment at: compiler-rt/lib/xray/xray_trampoline_riscv32.S:16 + .text + .file "xray_trampoline_riscv32.S" + .globl __xray_FunctionEntry ---------------- Omit `.file` Consider using `#include "../sanitizer_common/sanitizer_asm.h"` like aarch64 and x86-64. This is in case we have RISC-V for other object file formats (say Mach-O) in the future. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117929/new/ https://reviews.llvm.org/D117929 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
