[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:135 {"xventanacondops", RISCVExtensionVersion{1, 0}}, +{"xsfcie", RISCVExtensionVersion{1, 0}}, }; Put this with xsfvcp Comment at: llvm/lib/Target/RISC

[PATCH] D153379: Remove -flang-experimental-exec flag

antmo added a comment. Hello, I think this broke some bots due to remaining references to -flang-experimental-exec in llvm-zorg buildbot config - clang-aarch64-sve-vla-2stage https://lab.llvm.org/buildbot/#/builders/198/builds/2907 - clang-aarch64-sve-vls-2stage https://lab.llvm.org/buildbot/#

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGcea0eea28e71: [llvm] Split out DenseMapInfo specialization (authored by IncludeGuardian). Herald added a project: Flang. Changed prior to commit: https://reviews.llvm.org/D150997?vs=532038&id=5

[clang-tools-extra] cea0eea - [llvm] Split out DenseMapInfo specialization

Author: Elliot Goodrich Date: 2023-06-22T06:50:54+01:00 New Revision: cea0eea28e71204bf8543ca94dbf185cbf597ca5 URL: https://github.com/llvm/llvm-project/commit/cea0eea28e71204bf8543ca94dbf185cbf597ca5 DIFF: https://github.com/llvm/llvm-project/commit/cea0eea28e71204bf8543ca94dbf185cbf597ca5.dif

[PATCH] D143241: [Clang] Reset FP options before function instantiations

sepavloff added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:1736 + // point of the template definition. + Actions.resetFPOptions(LPT.FPO); + rjmccall wrote: > Ah, is this bug specific to the MSVC-compatible template logic? Exactly. This is MS

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thank you for the detailed analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153228/new/ https://reviews.llvm.org/D153228 ___ c

[PATCH] D152671: [doc][LoongArch] Add missed release note about `ual` feature addition

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/ReleaseNotes.rst:164 +* An target feature ``ual`` is introduced to allow unaligned memory accesses and + this feature is enabled by default on g

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

sammccall added reviewers: mboehme, xazax.hun, gribozavr2. sammccall added a comment. Here we start to see benefits: Value becomes less reliant on inheritance, flow conditions are no longer Values that can uselessly bear properties, atomic variables are numbered in order of creation, we'll soon

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

shafik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:835 + + // C++20 [module.interface]p3: if (auto *ND = dyn_cast(D)) { Can you please add the quoted text for clarity. This is especially helpful if the text changes in the future and we

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added reviewers: gribozavr2, xazax.hun, mboehme. sammccall added a comment. Splitting out Formula from BoolValue is a pretty big change... I've tried to keep this patch a manageable size by really just using Formula for interacting with the SAT solver and some printing, but this means

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:983 EnableNewConstInterp(C.getLangOpts().EnableNewConstInterp), - BottomFrame(*this, SourceLocation(), nullptr, nullptr, CallRef()), + BottomFrame(*this, SourceLocation(), nullpt

[PATCH] D152671: [doc][LoongArch] Add missed release note about `ual` feature addition

xen0n added a comment. Thanks for the catch! Comment at: llvm/docs/ReleaseNotes.rst:163 * The ``lp64s`` ABI is supported now and has been tested on Rust bare-matal target. +* An target feature ``ual`` is introduced to allow unaligned memory accesses and + this feature is en

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall added reviewers: ymandel, xazax.hun. sammccall added a comment. The idea with the change to Environment::join() is that the current signature forces the base environment to be mutable, but this sometimes forces the caller to make a copy, and the implementation actually copies everythin

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall updated this revision to Diff 533463. sammccall added a comment. refactor, restore comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153493/new/ https://reviews.llvm.org/D153493 Files: clang/include/clang/Analysis/FlowSensitive/Dat

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is clunky but greatly improves debuggin

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

shafik added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.cpp:273 +return Lexer::findLocationAfterToken(NoexceptLoc, tok::r_paren, SM, + LangOpts, true); + To conform with [burprone-argume

[PATCH] D152796: [clang][Sema] Fix diagnostic message for unused constant varialbe templates

shafik added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1385 + Diag(DiagD->getLocation(), diag::warn_unused_template) + << /*variable*/ 1 << DiagD; } else if (DiagD->getType().isConstQualified()) { Sorry for late review bu

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

shafik added a comment. Thank you for this improvement! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152788/new/ https://reviews.llvm.org/D152788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

shafik added a reviewer: clang-language-wg. shafik added a comment. Adding clang-language-wg for more visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 __

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

shafik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11226 +def err_module_private_use : Error< + "%select{declaration|definition|default argument|" + "explicit specialization|partial specialization}0 of %1 is private to module " -

[PATCH] D153491: [dataflow] Avoid copying environment

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This appears to be just an accidental copy r

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm closed this revision. arsenm added a comment. 1717c18664d5880f78db85eb0075a2c1379df2d9 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823 __

[PATCH] D138397: HIP: Directly call ldexp builtins

arsenm closed this revision. arsenm added a comment. c448e1dabeeb066c41d893fc8e7a3d8bde2056c8 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138397/new/ https://reviews.llvm.org/D138397 __

[clang] c448e1d - HIP: Directly call ldexp builtins

Author: Matt Arsenault Date: 2023-06-21T21:34:42-04:00 New Revision: c448e1dabeeb066c41d893fc8e7a3d8bde2056c8 URL: https://github.com/llvm/llvm-project/commit/c448e1dabeeb066c41d893fc8e7a3d8bde2056c8 DIFF: https://github.com/llvm/llvm-project/commit/c448e1dabeeb066c41d893fc8e7a3d8bde2056c8.diff

[PATCH] D153488: [dataflow] HTMLLogger: meaningful names for flow condition variables

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of meaningless "V7", use the name "B

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3476-3477 + + // Regarding the 16: Note that multiple passes are added in + // addQualifierAlignmentFixerPasses(). + SmallVector Passes; This comment is unnecessary and too verbose IMO. I s

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. And simplify formulas containing true/false

[PATCH] D153379: Remove -flang-experimental-exec flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG0867d4157328: [flang] don't require -flang-experimental-exec flag anymore (authored by everythingfunctional, committed by ktras). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 0867d41 - [flang] don't require -flang-experimental-exec flag anymore

Author: Brad Richardson Date: 2023-06-21T16:47:52-07:00 New Revision: 0867d4157328169c570f4d1e9c01806624035873 URL: https://github.com/llvm/llvm-project/commit/0867d4157328169c570f4d1e9c01806624035873 DIFF: https://github.com/llvm/llvm-project/commit/0867d4157328169c570f4d1e9c01806624035873.dif

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/include/clang/Driver/Options.td:2311 MarshallingInfoString>; +defm fat_lto_objects : BoolFOption<"fat-lto-objects", + CodeGenOpts<"FatLTO">, DefaultFalse, MaskRay wrote: > We just need the pos flag for CC1Opt

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 533433. paulkirth marked 12 inline comments as done. paulkirth added a comment. Rebase and address comments - Update & rename tests - Fix typos - Handle options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D153481: [clang] NFCI: Use `DirectoryEntryRef` in framework lookup

frs513 created this revision. Herald added a project: All. frs513 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This removes one use of the deprecated `DirectoryEntry::getName()`. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

schittir added a comment. @tahonermann @shafik - is it ok to land this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D153462: [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153462/new/ https://reviews.llvm.org/D153462 ___ cfe-commits mailing list c

[PATCH] D150489: [-Wunsafe-buffer-usage] Handle pointer initializations for grouping related variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb3dcedb9ced: [-Wunsafe-buffer-usage] Handle pointer initializations for grouping related… (authored by t-rasmud). Herald added a project: clang. Her

[clang] db3dced - [-Wunsafe-buffer-usage] Handle pointer initializations for grouping related variables

Author: Rashmi Mudduluru Date: 2023-06-21T15:54:09-07:00 New Revision: db3dcedb9cedcec4a9570fda7406490c642df8ae URL: https://github.com/llvm/llvm-project/commit/db3dcedb9cedcec4a9570fda7406490c642df8ae DIFF: https://github.com/llvm/llvm-project/commit/db3dcedb9cedcec4a9570fda7406490c642df8ae.di

[PATCH] D153176: [Frontend] Remove ShowIncludesPretendHeader

This revision was automatically updated to reflect the committed changes. Closed by commit rG1df10f15807f: [Frontend] Remove ShowIncludesPretendHeader (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153176/new/ https://reviews.l

[PATCH] D153175: [Frontend] Don't output skipped includes from predefines

This revision was automatically updated to reflect the committed changes. Closed by commit rG67a11290df64: [Frontend] Don't output skipped includes from predefines (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153175/new/ http

[clang] 1df10f1 - [Frontend] Remove ShowIncludesPretendHeader

Author: Shoaib Meenai Date: 2023-06-21T15:48:28-07:00 New Revision: 1df10f15807f9b7deba3f714d27e21578a8b4748 URL: https://github.com/llvm/llvm-project/commit/1df10f15807f9b7deba3f714d27e21578a8b4748 DIFF: https://github.com/llvm/llvm-project/commit/1df10f15807f9b7deba3f714d27e21578a8b4748.diff

[clang] 67a1129 - [Frontend] Don't output skipped includes from predefines

Author: Shoaib Meenai Date: 2023-06-21T15:48:27-07:00 New Revision: 67a11290df64fec44e671a1bdc3a225ed8a02962 URL: https://github.com/llvm/llvm-project/commit/67a11290df64fec44e671a1bdc3a225ed8a02962 DIFF: https://github.com/llvm/llvm-project/commit/67a11290df64fec44e671a1bdc3a225ed8a02962.diff

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will be

[PATCH] D153476: [dataflow] document & test determinism of formula structure

sammccall created this revision. Herald added subscribers: martong, mgrang, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This doesn't depend on object addres

[PATCH] D153175: [Frontend] Don't output skipped includes from predefines

smeenai added a comment. In D153175#4431923 , @hans wrote: >> -H is supposed to skip outputting headers from -include command line >> arguments, but -fshow-skipped-includes was outputting any skipped >> includes encountered via -include. > > I was thrown

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan marked 2 inline comments as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6371-6380 + verifyFormat("#if FOO\n" + "int a = 1;\n" + "#else\n" + "int ab = 2;\n" + "#endif\n" +

[PATCH] D153243: [clang-format] Don't finalize #if, #else, #endif, etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e85739a5f24: [clang-format] Don't finalize #if, #else, #endif, etc. (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153243/new/ https:

[clang] 8e85739 - [clang-format] Don't finalize #if, #else, #endif, etc.

Author: Owen Pan Date: 2023-06-21T15:15:57-07:00 New Revision: 8e85739a5f24e34cb22768fe6ef33b593ed054df URL: https://github.com/llvm/llvm-project/commit/8e85739a5f24e34cb22768fe6ef33b593ed054df DIFF: https://github.com/llvm/llvm-project/commit/8e85739a5f24e34cb22768fe6ef33b593ed054df.diff LOG:

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This properly frees the Value hierarchy from

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

aeubanks created this revision. aeubanks added a reviewer: tejohnson. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:886-887 TopLevelCase = Case; - else + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt, C

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir updated this revision to Diff 533386. schittir marked 3 inline comments as done. schittir added a comment. Changes to address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://reviews.llvm.org/D153236 Files: clang/lib/Sema/SemaExprObjC.cpp clang/l

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

mstorsjo added a comment. In D152785#4438544 , @MaskRay wrote: > CodeView is the default debug info format for COFF. Perhaps `-gsplit-dwarf` > should be rejected when the default `-gcodeview` is used, with a test. IIRC some users do generate both CodeVi

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D152986#4426256 , @eddyz87 wrote: > In D152986#4425736 , @rnk wrote: > >> The purpose of the attribute is really

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

NoQ added a comment. > In this case function `fileno` returns -1 because of failure, but this is not > indicated in a `NoteTag`. This is a correct result, only the note is missing. > This problem can be solved if a note is displayed on every branch ("case") of > the standard C functions. But th

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

h-vetinari added a comment. Does https://clang.llvm.org/docs/OpenMPSupport.html need an update? It still says "Clang fully supports OpenMP 4.5" (with many 5.0/5.1 features marked as "worked on" / "unclaimed"), which would make it unusual to put the default on a version that's (according to that

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 533375. dicej added a comment. remove config.py changes per review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

NoQ added a comment. Uh-oh, looks like I'm not paying nearly enough attention to this discussion (sorry about that!!) I'm somewhat skeptical of the decision made in D151225 because the entire reason I originally implemented `StdCLibraryFunctions` was to deal

[PATCH] D153462: [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D153462 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

iains added a comment. In D152946#4431974 , @h-vetinari wrote: > Mark P2615 as implemented in > https://github.com/llvm/llvm-project/blame/main/clang/www/cxx_status.html? In D152946#4431974

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2077 + for (const auto &[VD, Fixables] : FixablesForUnsafeVars.byVar) { FixItsForVariable[VD] = NoQ wrote: > There's a bug in variable naming: `FixablesForUnsafeVars`

[PATCH] D153458: [clang-tidy] Model noexcept more properly in bugprone-exception-escape

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, isuckatcs, JonasToth, baloghadamsoftware. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subs

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

dblaikie added a comment. I haven't looked closely at this, but from a vague/quick reading, it sounds like this is creating annotations on certain type DINodes, but then moving them around to different types? It'd be nice if we could avoid that/create them in the right place in the first place.

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:347 +return triple + m = re.match(r"(\w+)-(\w+)-(\w+)", triple) dicej wrote: > sbc100 wrote: > > Are the the changes to this file meant to be part of this CL? > The `

[PATCH] D153205: [clang-format] Add new block type ListInit

HazardyKnusperkeks added a comment. In D153205#4437966 , @MyDeveloperDay wrote: > My only concern is that this changes behaviour without someone making the > conscious decision to make that change, now as much as I can't understand why > someone would

[PATCH] D153418: Adding iconv support to CharSetConverter class

efriedma added a comment. This doesn't really address the concerns from https://discourse.llvm.org/t/rfc-adding-a-charset-converter-to-the-llvm-support-library/69795/17 about consistency. It's bad if different hosts support a different set of charsets/charset names, and it's really bad if a gi

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

efriedma added a comment. As I mentioned at https://discourse.llvm.org/t/rfc-enabling-fexec-charset-support-to-llvm-and-clang-reposting/71512 , I think SimplifyLibCalls needs to be aware of encodings. To make that work, this probably needs to be somewhere in llvm/ , not clang/ . Repository:

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4437877 , @sbc100 wrote: > In D153293#4437644 , @dicej wrote: > >> In D153293#4436629 , @sbc100 wrote: >> >>> I'm happy to merge it, but

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam updated this revision to Diff 533360. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/IdentifierTable.h clang/include/clang/Basic/TokenKinds.def clang/inc

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

rjmccall added a comment. Yes, this is very close, thank you. Comment at: clang/include/clang/Basic/TokenKinds.def:805 +INTERESTING_IDENTIFIER(float_t) +INTERESTING_IDENTIFIER(double_t) +INTERESTING_IDENTIFIER(FILE) I think it would be cleaner if you added thes

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:62 +if(Iconv_FOUND AND NOT Iconv_IS_BUILT_IN) + set(system_libs ${system_libs} ${Iconv_LIBRARIES}) +endif() michae

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan updated this revision to Diff 533352. abhina.sreeskantharajan added a reviewer: michaelplatings. abhina.sreeskantharajan added a comment. Use target_link_libraries instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153418/

[PATCH] D143241: [Clang] Reset FP options before function instantiations

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:1736 + // point of the template definition. + Actions.resetFPOptions(LPT.FPO); + Ah, is this bug specific to the MSVC-compatible template logic? Repository: rG LLVM Github Monorep

[PATCH] D153419: Enable fexec-charset option

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6864 + CmdArgs.push_back("-fexec-charset"); + CmdArgs.push_back(Args.MakeArgString(Triple.getSystemCharset())); if (Arg *execCharset = Args.getLastArg(options::OPT_fexec_charset_EQ)) {

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

cjdb added a comment. I think this will be a good addition because it underscores the salient part of why the function isn't viable. Would it be possible for patches like this to have both examples of before and after this patch in their commit message please? That'll help expose why patches l

[PATCH] D143241: [Clang] Reset FP options before function instantiations

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143241/new/ https://reviews.llvm.org/D143241 ___

[PATCH] D143241: [Clang] Reset FP options before function instantiations

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143241/new/ https://reviews.llvm.org/D143241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

cjdb added a comment. I like this patch, thanks for working on it 😄 In D153359#4436873 , @hazohelet wrote: > Consider the following code. (I added another parameter to the original code > so that the covered range becomes clearer) > > void func(int aa

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added a comment. CodeView is the default debug info format for COFF. Perhaps `-gsplit-dwarf` should be rejected when the default `-gcodeview` is used, with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.l

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:1167 // GCC style -dumpdir. We intentionally don't implement the less useful -dumpbase{,-ext}. -def dumpdi

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); } rjmcca

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 54. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/IdentifierTable.h clang/include/clang/Basic/TokenKinds.def clang/include/clang/Basic/TokenKinds.h clang/lib/B

[PATCH] D153379: Remove -flang-experimental-exec flag

everythingfunctional added a comment. In D153379#4438419 , @PeteSteinfeld wrote: > All builds and tests correctly and looks good. > > @everythingfunctional, can you please post on Discourse about this change > when you merge? Since we've discussed this

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo updated this revision to Diff 533326. modimo added a comment. Address feedback. Allow empty string to unset the flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152741/new/ https://reviews.llvm.org/D152741 Files: clang/include/clang/Bas

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo added a comment. In D152741#4438007 , @tejohnson wrote: > Ok what I missed is that you don't want to apply this to entire TUs, but > rather just some paths that are header files, which may be included in many > source files. So in your above exam

[PATCH] D153379: Remove -flang-experimental-exec flag

PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. All builds and tests correctly and looks good. @everythingfunctional, can you please post on Discourse about this change when you merge? Since we've discussed this with the community, I think we should let them know that this

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hoy added a comment. In D144006#4437804 , @dzhidzhoev wrote: > In D144006#4435677 , @hoy wrote: > >> Hello, I'm seeing a build failure that seems related to this patch. I'm >> seeing the patch has been relanded

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

donat.nagy added a comment. In D152436#4437822 , @steakhal wrote: > In D152436#4437692 , @donat.nagy > wrote: > >> Personally I think it's completely acceptable if the analyzer sometimes >> emits bug reports tha

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

tigermoth added a comment. Now that AES, SHA2, SHA3 and SM4 features have been removed from armv8.6-a, these Apple CPUs can be changed again from 8.5-a to more correctly specified as armv8.6-a https://reviews.llvm.org/D141606?id=488968 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134

[PATCH] D153338: [clang-format] vim integration: Mention python3 variant of bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rG9741ac5b3b3e: [clang-format] vim integration: Mention python3 variant of bindings (authored by jsilvanus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1533

[clang] 9741ac5 - [clang-format] vim integration: Mention python3 variant of bindings

Author: Jannik Silvanus Date: 2023-06-21T17:18:36+02:00 New Revision: 9741ac5b3b3e7942e3332e37af829e58e5e2bb82 URL: https://github.com/llvm/llvm-project/commit/9741ac5b3b3e7942e3332e37af829e58e5e2bb82 DIFF: https://github.com/llvm/llvm-project/commit/9741ac5b3b3e7942e3332e37af829e58e5e2bb82.dif

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

tejohnson added a comment. In D152741#4422462 , @modimo wrote: > In D152741#4421067 , @tejohnson > wrote: > >> In D152741#4419366 , @modimo wrote: >> >>> In D152741#44193

[PATCH] D152975: [clang-format] Allow break after return keyword

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1484 LLVMStyle.PenaltyBreakFirstLessLess = 120; + LLVMStyle.PenaltyBreakReturn = 100; LLVMStyle.PenaltyBreakString = 1000; is 100 the current penalty? Comment

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added a comment. My only concern is that this changes behaviour without someone making the conscious decision to make that change, now as much as I can't understand why someone would want to put the `}` onto the same line, it will only take on person to say "hey I liked it like t

[PATCH] D153430: Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings created this revision. michaelplatings added reviewers: peter.smith, DavidSpickett. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald ad

[PATCH] D153418: Adding iconv support to CharSetConverter class

michaelplatings added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:62 +if(Iconv_FOUND AND NOT Iconv_IS_BUILT_IN) + set(system_libs ${system_libs} ${Iconv_LIBRARIES}) +endif() This doesn't look like an idomatic way to link a library. Could you use

[PATCH] D153338: [clang-format] vim integration: Mention python3 variant of bindings

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153338/new/ https://reviews.llvm.org/D153338 ___

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added a comment. In D153293#4437644 , @dicej wrote: > In D153293#4436629 , @sbc100 wrote: > >> I'm happy to merge it, but perhaps we should get @sunfish to lg too. >> >> Also, should we remove the `-experim

[PATCH] D153423: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/exception-escape.rst:29 +and destructors, it is a clear indication of the developer's intention and +should be respected.. + Double period. Repository: rG LLV

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

steakhal resigned from this revision. steakhal added a comment. I resign as a reviewer as I'm not deeply connected to this checker, thus I won't block it or accept it. However, my opinion is that a checker should be "released" if they have clear diagnostics (which includes that it doesn't flood

[PATCH] D153424: [clang][ASTImporter] Add import of CXXRewrittenBinaryOperator.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

  1   2   >