MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/docs/ReleaseNotes.rst:164
+* An target feature ``ual`` is introduced to allow unaligned memory accesses 
and
+  this feature is enabled by default on generic 64bit processors.
 
----------------
xen0n wrote:
> nit: "for generic 64-bit"
> 
> Here "for" (compared to "on") is to signify it's controlled by target instead 
> of host spec.
Target feature is internal and mentioning it in release notes may be excessive 
(if we do, there are too many to enumerate ...). I think we can omit mentioning 
the target feature. Focusing on the behavior about the user-facing 
`-m[no-]unaligned-access` is more useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152671/new/

https://reviews.llvm.org/D152671

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to