[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

grosser added a comment. That is perfectly fine. I just wanted to let you know that we are still interested in this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.org/D138278 __

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

nridge updated this revision to Diff 532798. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153251/new/ https://reviews.llvm.org/D153251 Files: clang/lib/Index/IndexDecl.cpp clang/unittests/Index/I

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532797. eopXD added a comment. Remove unnecessary include-s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td clang/

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532796. eopXD marked an inline comment as done. eopXD added a comment. Save and restore FRM in RISCVInsertReadWriteCSR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996

[PATCH] D153235: [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUi/iULi

Jim updated this revision to Diff 532790. Jim added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153235/new/ https://reviews.llvm.org/D153235 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/test/CodeGen/RI

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL added a comment. Question would be, does this can stay +- like this and we could wait with extension this until some users for example complain, that they would like it to be extended, or this need to be done now. Main reason for this change is, that often I run into situation when ther

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL updated this revision to Diff 532783. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Review fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153298/new/ https://reviews.llvm.org/D153298 Files: clang-tools-extra

[clang] dafaa84 - [XRay] Make llvm.xray.customevent parameter type match __xray_customevent

Author: Fangrui Song Date: 2023-06-19T20:38:16-07:00 New Revision: dafaa8463ef6991055c2fcee799757fa46965625 URL: https://github.com/llvm/llvm-project/commit/dafaa8463ef6991055c2fcee799757fa46965625 DIFF: https://github.com/llvm/llvm-project/commit/dafaa8463ef6991055c2fcee799757fa46965625.diff

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews.llvm.org/D152391 __

[PATCH] D138397: HIP: Directly call ldexp builtins

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138397/new/ https://reviews.llvm.org/D138397 ___ cfe-commits mailing list cfe-

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

owenpan added a comment. In D153208#4433511 , @HazardyKnusperkeks wrote: > In D153208#4431697 , @owenpan wrote: > >> In D153208#4431239 , >> @HazardyKnusperkeks wrote: >

[PATCH] D153243: [clang-format] Don't finalize #if, #else, #endif, etc.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1416-1421 + if (Tok->is(tok::hash) && !Tok->Previous && Tok->Next && + Tok->Next->isOneOf(tok::pp_if, tok::pp_ifdef, tok::pp_ifndef, + tok::pp_elif, to

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 created this revision. JOE1994 added reviewers: barannikov88, nikic. Herald added subscribers: StephenFan, kbarton, nemanjai. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partial progress towa

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 __

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 532772. FreddyYe added a comment. Adjust atom_sse4_2_movbe test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.cpp clang/lib

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen marked an inline comment as done. HaohaiWen added a comment. Any other comments? If not , I'll land this patch tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 _

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:110 FeatureBitset Features; + char Mangling; + bool OnlyForCPUDispatchSpecific; RKSimon wrote: > Do we have a documented list of the mangling values anywhere? The values >

[clang] cb9ac70 - Reland "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)" (2)

Author: Vladislav Dzhidzhoev Date: 2023-06-20T03:01:46+02:00 New Revision: cb9ac7051589ea0d05507f9370d0716bef86b4ae URL: https://github.com/llvm/llvm-project/commit/cb9ac7051589ea0d05507f9370d0716bef86b4ae DIFF: https://github.com/llvm/llvm-project/commit/cb9ac7051589ea0d05507f9370d0716bef86b4a

[clang] fec7c64 - Revert "Reland "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)""

Author: Vladislav Dzhidzhoev Date: 2023-06-20T01:54:48+02:00 New Revision: fec7c6457ced7e87d4e0837402b0b8a644cf6242 URL: https://github.com/llvm/llvm-project/commit/fec7c6457ced7e87d4e0837402b0b8a644cf6242 DIFF: https://github.com/llvm/llvm-project/commit/fec7c6457ced7e87d4e0837402b0b8a644cf624

[PATCH] D153310: Add builtin_elementwise_pow

bob80905 created this revision. Herald added subscribers: luke, Anastasia, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added a comment. @jrtc27: The tests: - are under llvm/test/MC/RISCV - use llvm-mc as assembler (rather than C!) - are as simple as they can be - cover every line touched by this patch. Would you unblock this now? Thanks for your feedback so far. @MaskRay: Let me know if you miss

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532758. abel-bernabeu added a comment. On the zdinx test, changed a FileCheck comment that was written starting with "//" rather than "#". Changed for "#" just for consistency with the rest of tests. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu accepted this revision. abel-bernabeu added a comment. Am happy with the current patch version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 ___

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532754. abel-bernabeu added a comment. Removed a gratuitous blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 Files: llvm/lib/Target/RISCV/AsmParser/

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532753. abel-bernabeu added a comment. Added --match-fulllines to FileCheck for making the check stricter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 Files

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp:84-86 + if (AnalyzeResult.containsUnknownElements()) +diag(MatchedDecl->getLocation(), "may throw unknown exceptions", + DiagnosticIDs::Note);

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

jhuber6 updated this revision to Diff 532748. jhuber6 added a comment. I'm not sure why this keeps failing on Windows and have no clue how to tell what's going wrong. The builder simply says c:\ws\w4\llvm-project\premerge-checks\build\bin\clang-linker-wrapper.exe: error: invalid argument But

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:18177 getASTContext()), /*IsImmediateInvocation*/ true); if (Cached.hasValue()) Drive by nit clean-up while we are here. Comment

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Please wait for at least @MyDeveloperDay to say something, as he is the original author of the work. Comment at: clang/lib/Format/Format.cpp:3475

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

HazardyKnusperkeks added a comment. In D153208#4431697 , @owenpan wrote: > In D153208#4431239 , > @HazardyKnusperkeks wrote: > >> We also could add a clang-format style, the you wouldn't have to to touch >> all

[PATCH] D153235: [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUi/iULi

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:22 +TARGET_BUILTIN(__builtin_riscv_clz_32, "iUi", "nc", "zbb|xtheadbb") +TARGET_BUILTIN(__builtin_riscv_clz_64, "iULi", "nc", "zbb|xtheadbb,64bit") +TARGET_BUILTIN(__builtin_riscv_ctz_32,

[clang] 407dcaf - [Driver] Correct -fnoxray-link-deps to -fno-xray-link-deps

Author: Fangrui Song Date: 2023-06-19T12:48:33-07:00 New Revision: 407dcaf002f71abf940f3e903fa17791b150995d URL: https://github.com/llvm/llvm-project/commit/407dcaf002f71abf940f3e903fa17791b150995d DIFF: https://github.com/llvm/llvm-project/commit/407dcaf002f71abf940f3e903fa17791b150995d.diff

[PATCH] D153243: [clang-format] Don't finalize #if, #else, #endif, etc.

Sedeniono requested changes to this revision. Sedeniono added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1416-1421 + if (Tok->is(tok::hash) && !Tok->Previous && Tok->Next && + Tok->Next->is

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added inline comments. Comment at: llvm/test/MC/RISCV/comments.ll:25 +# CHECK: .Lpcrel_hi0:#c0 #c1 #c2 #c3 #c4 #c5 #c6 +# CHECK: auipc s0, %pcrel_hi(symbol+10) +# CHECK: addis0, s0, %pcrel_lo(.Lpcrel_hi0) This shoul

[PATCH] D153248: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

nridge added a comment. In D153248#4432108 , @hokein wrote: > The other question might worth thinking, are these cases critical to fix now? > I'm not sure `this->find()` is a common case (`find();` already works today). I may have simplified the test ca

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 532734. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clan

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked 2 inline comments as done. Sedeniono added inline comments. Comment at: clang/lib/Format/Format.cpp:3475 AnalyzerPass; SmallVector Passes; HazardyKnusperkeks wrote: > Just increase here, and add a comment that there are multiple passe

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

nridge planned changes to this revision. nridge added inline comments. Comment at: clang/lib/Index/IndexDecl.cpp:708 } else if (const auto *NTTP = dyn_cast(TP)) { +IndexCtx.indexTypeSourceInfo(NTTP->getTypeSourceInfo(), Parent); if (NTTP->hasDefaultArgumen

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono updated this revision to Diff 532721. Sedeniono added a comment. As suggested by HazardyKnusperkeks, increased the number of stack elements and removed the reserve(). That causes all Passes to be stored on the stack. (I counted 17 distinct possible passes, but not all of them can be ac

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn marked an inline comment as done. hnrklssn added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': nikic wrote: > nikic wrote: > > nikic wrote: >

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 532719. hnrklssn added a comment. Keep supporting --check-globals without explicit level as meaning '--check-globals all' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D14

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding accord

[clang] 2da4517 - Reland "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)"

Author: Vladislav Dzhidzhoev Date: 2023-06-19T19:50:46+02:00 New Revision: 2da45172c4bcd42f704c57c656926f56f32fc5ce URL: https://github.com/llvm/llvm-project/commit/2da45172c4bcd42f704c57c656926f56f32fc5ce DIFF: https://github.com/llvm/llvm-project/commit/2da45172c4bcd42f704c57c656926f56f32fc5c

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 532705. dicej added a comment. generalize Wasm tests and release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst clang/test

[PATCH] D149596: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

This revision was automatically updated to reflect the committed changes. Closed by commit rG706b5472d897: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149

[clang] 706b547 - [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

Author: Amy Kwan Date: 2023-06-19T12:17:30-05:00 New Revision: 706b5472d897ca75ebd210e4109637793288bcf2 URL: https://github.com/llvm/llvm-project/commit/706b5472d897ca75ebd210e4109637793288bcf2 DIFF: https://github.com/llvm/llvm-project/commit/706b5472d897ca75ebd210e4109637793288bcf2.diff LOG:

[clang] aeb99dc - Revert "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)"

Author: Vladislav Dzhidzhoev Date: 2023-06-19T19:16:13+02:00 New Revision: aeb99dc48a58f872465e818d0eda7d9c3f221e06 URL: https://github.com/llvm/llvm-project/commit/aeb99dc48a58f872465e818d0eda7d9c3f221e06 DIFF: https://github.com/llvm/llvm-project/commit/aeb99dc48a58f872465e818d0eda7d9c3f221e0

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. Thanks for the review. I'll post an update shortly. Comment at: clang/docs/ReleaseNotes.rst:705 +- The `wasm32-wasi` target now supports `Emscripten-style shared libraries + `

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, isuckatcs, JonasToth, baloghadamsoftware. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subs

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. Oops, compiler explorer website seems crashed, Once it's recovery, I'll append a link. :2:13: error: use of undeclared identifier 'f' 2 | switch (f) { | ^ clang++: /root/llvm-project/llvm/lib/Support/APInt.cpp:282: int llvm::APInt::com

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin created this revision. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: yronglin Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153296 Files: clang/lib/AST

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added a comment. Herald added a subscriber: ormris. Nice! lgtm with a couple of nits Comment at: clang/docs/ReleaseNotes.rst:705 +- The `wasm32-wasi` target now supports `Emscripten-style shared libraries +

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10399 +DeviceID = CGF.Builder.getInt64(OMP_DEVICEID_UNDEF); + } jdoerfert wrote: > Move this behind the if generation and guard the emit scalar with a > conditional, all is o

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

OikawaKirie added a comment. BTW, what does the `Done` checkbox mean in the code comments? Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:286-287 + SVal V, + std::function); steakhal wrote: > I'd hig

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

nhaehnle added a comment. Herald added a subscriber: wangpc. I haven't looked at this in a while, sorry. I do plan to cycle back to it eventually, but right now my work scheduling is more stack-based than FIFO and this is fairly low down... Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Immediate invocations do not need to run cleanups themselves and the destructors need to run after each full-expression

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej created this revision. Herald added subscribers: pmatos, asb, delcypher, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. dicej requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, aheejin. Herald added projects:

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Since a boolean flag is effectively free in DWARF as it can be stored in the abbreviations, this looks like a good change to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij marked an inline comment as done. stuij added a comment. Comment at: clang/test/Driver/arm-execute-only.c:1 -// RUN: not %clang -c -target thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: %clang -c -### --target=thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: FileCh

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532686. abel-bernabeu added a comment. Rebased on top of the latest changes in RISCVAsmParser.cpp Moved the testing to llc-mc test cases under lvm/test/MC/RISCV/ Covered with tests for every single case where the parser consumes a token and a potential

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': nikic wrote: > nikic wrote: > > hnrklssn wrote: > > > nikic wrote: > > > > We should also not

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij updated this revision to Diff 532685. stuij marked 3 inline comments as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 Files: clang/lib/Driv

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 532684. stuij added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/test/Dr

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': nikic wrote: > hnrklssn wrote: > > nikic wrote: > > > We should also not print the `all` argu

[PATCH] D144802: clang: Add __builtin_elementwise_round

arsenm closed this revision. arsenm added a comment. 2a488b4443a9c0aa0f368aed901676508ced202f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144802/new/ https://reviews.llvm.org/D144802 __

[clang] 2a488b4 - clang: Add __builtin_elementwise_round

Author: Matt Arsenault Date: 2023-06-19T11:32:56-04:00 New Revision: 2a488b4443a9c0aa0f368aed901676508ced202f URL: https://github.com/llvm/llvm-project/commit/2a488b4443a9c0aa0f368aed901676508ced202f DIFF: https://github.com/llvm/llvm-project/commit/2a488b4443a9c0aa0f368aed901676508ced202f.diff

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

michaelplatings created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously if no matching multilib was found then the user

[PATCH] D144802: clang: Add __builtin_elementwise_round

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144802/new/ https://reviews.llvm.org/D144802 ___ cfe-commits mailing list cfe-co

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': hnrklssn wrote: > nikic wrote: > > We should also not print the `all` argument for `--check-g

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153281/new/ https://reviews.llvm.org/D153281

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

Michael137 updated this revision to Diff 532664. Michael137 added a comment. - fix test comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153282/new/ https://reviews.llvm.org/D153282 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Code

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently we emit `DW_AT_deleted` for `deleted` speci

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:110 FeatureBitset Features; + char Mangling; + bool OnlyForCPUDispatchSpecific; Do we have a documented list of the mangling values anywhere? The values below look too much

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

DavidTruby created this revision. DavidTruby added reviewers: tblah, vzakhari, awarzynski. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. DavidTruby requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, Mas

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

tbaeder added a comment. LGTM but let's wait for a second opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153267/new/ https://reviews.llvm.org/D153267 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D152548: [Clang][Interp] Diagnose uninitialized ctor of global record arrays

tbaeder accepted this revision. tbaeder added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152548/new/ https://reviews.llvm.org/D152548 ___ cfe-commits mailing list cfe-commits

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. In D148216#4431456 , @jdoerfert wrote: > could you put a little more information in the commit message please. "It > won't do X when we do Y", could mean a lot of things. We don't do Y anymore, > or we do X' now, with various c

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66511b401042: [DebugMetadata][DwarfDebug] Support function-local types in lexical block… (authored by dzhidzhoev). Repository: rG LLVM Github Mono

[clang] 66511b4 - [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

Author: Vladislav Dzhidzhoev Date: 2023-06-19T16:42:43+02:00 New Revision: 66511b401042f28c74d2ded3aac76d19a53bd7c4 URL: https://github.com/llvm/llvm-project/commit/66511b401042f28c74d2ded3aac76d19a53bd7c4 DIFF: https://github.com/llvm/llvm-project/commit/66511b401042f28c74d2ded3aac76d19a53bd7c

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa45f81ff7ea: [clang][Serialization][RISCV] Increase the number of reserved predefined type… (authored by rogfer01). Repository: rG LLVM Github Mo

[clang] fa45f81 - [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

Author: Roger Ferrer Ibanez Date: 2023-06-19T14:37:46Z New Revision: fa45f81ff7ea9fc2a2a40fea8dd7626ecc3a8dbb URL: https://github.com/llvm/llvm-project/commit/fa45f81ff7ea9fc2a2a40fea8dd7626ecc3a8dbb DIFF: https://github.com/llvm/llvm-project/commit/fa45f81ff7ea9fc2a2a40fea8dd7626ecc3a8dbb.diff

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. It is possible to add note tags to show decisions at standard functions. For example at `fileno` show if it has failed or not failed. The most simple way is to add it to all places, this means a note will show up on any bug path at all standard function usages. This is

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 532649. hnrklssn added a comment. Rebase after reformatting with Black, update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 Files: clang/test/uti

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new `InvalidCast` op for this purpose and emi

[PATCH] D153128: [AArch64][RCPC3] Add Neon intrinsics for LDAP1 and STL2

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM. ACLE PR here: https://github.com/ARM-software/acle/pull/265 Comment at: clang/lib/CodeGen/CGBuiltin.cpp:6769 + // and vstl1(q)_lane, but codegen is equivalent fo

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 532643. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 532642. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeGen/debug-info-codeview-unnamed.c clang/test

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a subscriber: ronlieb. jhuber6 added a comment. ping @ronlieb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews.llvm.org/D152391 ___ cfe-commits mailing list cfe-com

[PATCH] D153273: CPP-4465 Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource created this revision. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch reworks generation for the `CFGScopeBegin`,

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

tuliom added inline comments. Comment at: clang/test/CodeGenCXX/macro-prefix-map-lambda.cpp:11 + auto *s = lambdatest([](){}); +// CHECK: @"__PRETTY_FUNCTION__._Z10lambdatestIZ4mainE3$_0EDaOT_" = private unnamed_addr constant [{{[0-9]+}} x i8] c"auto lambdatest(f &&) [f = (lamb

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

uabelho added inline comments. Comment at: clang/tools/libclang/CXFile.h:18 +inline CXFile makeCXFile(OptionalFileEntryRef FE) { + return CXFile(FE ? &FE->getMapEntry() : nullptr); +} Gcc warns here: ``` ../../clang/tools/libclang/CXFile.h:18:50: warning: cast f

[PATCH] D144802: clang: Add __builtin_elementwise_round

arsenm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:647 + T __builtin_elementwise_round(T x) round x to the nearest integer value in floating point format, floating point types + rounding halfway cases to

[PATCH] D153271: [include-cleaner] Bailout on invalid code for the command-line tool

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. The binary tool only works on working source code, if the source code is not compilable, don't perform any analysis and

[PATCH] D138504: clang/HIP: Remove __llvm_amdgcn_* wrapper hacks

arsenm closed this revision. arsenm added a comment. f407a7399575a6821940973c54754d42e72dd9ce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138504/new/ https://reviews.llvm.org/D138504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] f407a73 - clang/HIP: Remove __llvm_amdgcn_* wrapper hacks

Author: Matt Arsenault Date: 2023-06-19T08:55:10-04:00 New Revision: f407a7399575a6821940973c54754d42e72dd9ce URL: https://github.com/llvm/llvm-project/commit/f407a7399575a6821940973c54754d42e72dd9ce DIFF: https://github.com/llvm/llvm-project/commit/f407a7399575a6821940973c54754d42e72dd9ce.diff

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM. The diff looks weird for some reason, but the downloadable `.diff` file looks fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 __

[clang] 85232b0 - HIP: Directly call isfinite builtins

Author: Matt Arsenault Date: 2023-06-19T08:48:48-04:00 New Revision: 85232b0ecbf817bc1d70ae602cf44cf6ea03c0e6 URL: https://github.com/llvm/llvm-project/commit/85232b0ecbf817bc1d70ae602cf44cf6ea03c0e6 DIFF: https://github.com/llvm/llvm-project/commit/85232b0ecbf817bc1d70ae602cf44cf6ea03c0e6.diff

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb, erichkeane. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. On mismatch of arity of functions like void func( int aa, int bb) {} void callsite() {

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa032dc139dda: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ h

  1   2   >