[clang] f2a352e - [Clang] Add the list of core papers approved in Varna to the status page

Author: Corentin Jabot Date: 2023-06-17T09:52:36+03:00 New Revision: f2a352e0584093c65f07cdd7cc62c5cc66beacbd URL: https://github.com/llvm/llvm-project/commit/f2a352e0584093c65f07cdd7cc62c5cc66beacbd DIFF: https://github.com/llvm/llvm-project/commit/f2a352e0584093c65f07cdd7cc62c5cc66beacbd.diff

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. > That said, there are two large issues that I think should be addressed in the > design (though not necessarily *implemented* now). Yeah, totally agreed. Design is pretty important especially in open source softwares. I'm pretty open to the suggestions. --- > suppo

[PATCH] D153184: [NFC][clang] Refactor FileCheck metadata references in pragma-followup_inner.cpp

MaskRay added a comment. > `[NFC]` You can use `[test]` for test-only patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153184/new/ https://reviews.llvm.org/D153184 ___ cfe-commits mailing list cf

[PATCH] D147962: [RFC][clang] Pull experimental targets' info out of TargetInfo.cpp (NFC)

barannikov88 abandoned this revision. barannikov88 added a comment. Abandoning as D148094 landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147962/new/ https://reviews.llvm.org/D147962 ___

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG992cb98462ab: [clang][CodeGen] Break up TargetInfo.cpp [8/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63534779b4ef: [clang][CodeGen] Break up TargetInfo.cpp [7/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 6353477 - [clang][CodeGen] Break up TargetInfo.cpp [7/8]

Author: Sergei Barannikov Date: 2023-06-17T07:14:43+03:00 New Revision: 63534779b4ef1816e2961246011e2ec3be110d27 URL: https://github.com/llvm/llvm-project/commit/63534779b4ef1816e2961246011e2ec3be110d27 DIFF: https://github.com/llvm/llvm-project/commit/63534779b4ef1816e2961246011e2ec3be110d27.d

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2888cddd5d9: [NFC] Fix potential dereferencing of null return value. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152977/new/ http

[clang] c2888cd - [NFC] Fix potential dereferencing of null return value.

Author: Sindhu Chittireddy Date: 2023-06-16T20:31:08-07:00 New Revision: c2888cddd5d98081fc82c51cb92be241144c6ffa URL: https://github.com/llvm/llvm-project/commit/c2888cddd5d98081fc82c51cb92be241144c6ffa DIFF: https://github.com/llvm/llvm-project/commit/c2888cddd5d98081fc82c51cb92be241144c6ffa.

[PATCH] D153184: [NFC][clang] Refactor FileCheck metadata references in pragma-followup_inner.cpp

jmciver created this revision. Herald added a project: All. jmciver added reviewers: MaskRay, Meinersbur. jmciver added a subscriber: nlopes. jmciver published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. - FileCheck variables for metadata are de

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 532358. barannikov88 added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.r

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 532357. barannikov88 added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files: clang/lib/CodeGen/Target

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. In D153003#4427731 , @Hahnfeld wrote: >> We can't say this abstractly. It should be fine to work in ODRHash for C++20 >> modules issues as long as we don't lose informations. > > I honestly don't understand this: For the approa

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

arsenm closed this revision. arsenm added a comment. b84721df636747a9955408a934e713192a9cfe21 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137524/new/ https://reviews.llvm.org/D137524 __

[clang] b84721d - clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

Author: Matt Arsenault Date: 2023-06-16T20:18:50-04:00 New Revision: b84721df636747a9955408a934e713192a9cfe21 URL: https://github.com/llvm/llvm-project/commit/b84721df636747a9955408a934e713192a9cfe21 DIFF: https://github.com/llvm/llvm-project/commit/b84721df636747a9955408a934e713192a9cfe21.diff

[PATCH] D153132: [clang analysis][NFCI] Preparatory work for D153131.

aaronpuchert added a comment. Is this actually required for the subsequent change? I don't see the connection. That being said, I haven't spent a lot of thought on what belongs in `ThreadSafetyAnalyzer` and what in `BuildLockset`. Comment at: clang/lib/Analysis/ThreadSafety.c

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2165 + + VisitorBase::VisitReturnStmt(S); +} Also wondering why we're doing this—no other visitor function seems to bother the `VisitorBase = ConstStmtVisitor`. Are these not ju

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

owenpan added a comment. Rebased and changed a unit test to use `verifyNoChange` before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151954/new/ https://reviews.llvm.org/D151954 ___ cfe-commits

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG441108ccba94: Reland [clang-format] Fix overlapping whitespace replacements before PPDirective (authored by owenpan). Changed prior to commit: htt

[clang] 441108c - Reland [clang-format] Fix overlapping whitespace replacements before PPDirective

Author: Owen Pan Date: 2023-06-16T17:00:12-07:00 New Revision: 441108ccba948d76e7002c61236e3bcbca0203ce URL: https://github.com/llvm/llvm-project/commit/441108ccba948d76e7002c61236e3bcbca0203ce DIFF: https://github.com/llvm/llvm-project/commit/441108ccba948d76e7002c61236e3bcbca0203ce.diff LOG:

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

efriedma updated this revision to Diff 532334. efriedma added a comment. Restrict to AArch64. Actually, it seems like something sort of similar happens with x86 vectorcall. But I haven't tried to test all the permutations of that, so don't modify the behavior for now. Repository: rG LLVM G

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

aaronpuchert added reviewers: aaron.ballman, aaronpuchert. aaronpuchert added a comment. Thanks for working on this! Someone recently pointed out to me that we have a gap there. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1046 def ThreadSafetyPrecise: DiagGr

[clang] 1b8c7ee - [Fuchsia] Forward libedit flags to stage2

Author: Daniel Thornburgh Date: 2023-06-16T16:55:00-07:00 New Revision: 1b8c7ee4240a42e8914d7ae11db5b19841a5c1dd URL: https://github.com/llvm/llvm-project/commit/1b8c7ee4240a42e8914d7ae11db5b19841a5c1dd DIFF: https://github.com/llvm/llvm-project/commit/1b8c7ee4240a42e8914d7ae11db5b19841a5c1dd.d

[clang] 926e1fa - [clang-format][NFC] Use verifyGoogleFormat in FormatTest.cpp

Author: Owen Pan Date: 2023-06-16T16:44:06-07:00 New Revision: 926e1faabc6f6fd4c2fc208fc416c80eff3c05a5 URL: https://github.com/llvm/llvm-project/commit/926e1faabc6f6fd4c2fc208fc416c80eff3c05a5 DIFF: https://github.com/llvm/llvm-project/commit/926e1faabc6f6fd4c2fc208fc416c80eff3c05a5.diff LOG:

[clang] 3ab9d4f - [RISCV] Reduce alignment for __attribute__((riscv_rvv_vector_bits)) for LMUL<1 types.

Author: Craig Topper Date: 2023-06-16T16:41:15-07:00 New Revision: 3ab9d4f479aa3deb63500b7dba55c9d6715208b6 URL: https://github.com/llvm/llvm-project/commit/3ab9d4f479aa3deb63500b7dba55c9d6715208b6 DIFF: https://github.com/llvm/llvm-project/commit/3ab9d4f479aa3deb63500b7dba55c9d6715208b6.diff

[clang] a1d73b7 - [Fuchsia] Forward terminfo flags to stage 2

Author: Daniel Thornburgh Date: 2023-06-16T16:34:42-07:00 New Revision: a1d73b773b933009633cedc45acc55063c118ddc URL: https://github.com/llvm/llvm-project/commit/a1d73b773b933009633cedc45acc55063c118ddc DIFF: https://github.com/llvm/llvm-project/commit/a1d73b773b933009633cedc45acc55063c118ddc.d

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 ___

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

efriedma created this revision. efriedma added reviewers: rnk, hans, dblaikie, sigatrev, samtebbs, rjmccall. Herald added subscribers: mstorsjo, kristof.beyls. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. MSVC normally has a bunch of restr

[PATCH] D153109: [clang-format][NFC] Clean up unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG20b4df1ed611: [clang-format][NFC] Clean up unit tests (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153109/new/ https://reviews.llvm.

[clang] 20b4df1 - [clang-format][NFC] Clean up unit tests

Author: Owen Pan Date: 2023-06-16T16:03:19-07:00 New Revision: 20b4df1ed611517d2c964dbade3e61aff4be2e87 URL: https://github.com/llvm/llvm-project/commit/20b4df1ed611517d2c964dbade3e61aff4be2e87 DIFF: https://github.com/llvm/llvm-project/commit/20b4df1ed611517d2c964dbade3e61aff4be2e87.diff LOG:

[PATCH] D153109: [clang-format][NFC] Clean up unit tests

owenpan added a comment. Because FormatTestCSharp.cpp, FormatTestJS.cpp, and FormatTestSelective.cpp don't `#include` FormatTestBase.h, they can't benefit from `verifyNoChange`. However, the rest of the unit tests are all free of the repeated arguments in `EXPECT_EQ` and `verifyFormat` (as far

[PATCH] D153176: [Frontend] Remove ShowIncludesPretendHeader

smeenai created this revision. smeenai added reviewers: hans, rnk, thakis. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It hasn't been written to since https://reviews.llvm.org/D46652, so it was alway

[PATCH] D153175: [Frontend] Don't output skipped includes from predefines

smeenai created this revision. smeenai added reviewers: hans, rnk, thakis. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `-H` is supposed to skip outputting headers from `-include` command line argumen

[PATCH] D153109: [clang-format][NFC] Clean up unit tests

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153109/new/ https://reviews.llvm.org/D153109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:341 + void setInterestingIdentifierID(unsigned ID) { +assert(ID != FirstBuiltinID); +ObjCOrBuiltinID = FirstInterestingIdentifierID + (ID - 1); Similarly, this assert

[PATCH] D153123: Fix diag for read-only target features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8c583071591: Fix diag for read-only target features (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHA

[clang] c8c5830 - Fix diag for read-only target features

Author: Yaxun (Sam) Liu Date: 2023-06-16T17:48:27-04:00 New Revision: c8c583071591dbc6927955e608dcd44c0bac8b9c URL: https://github.com/llvm/llvm-project/commit/c8c583071591dbc6927955e608dcd44c0bac8b9c DIFF: https://github.com/llvm/llvm-project/commit/c8c583071591dbc6927955e608dcd44c0bac8b9c.dif

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added inline comments. Comment at: clang/test/Driver/split-debug.c:19 // RUN: %clang -### -c -target amdgcn-amd-amdhsa -gsplit-dwarf -g %s 2>&1 | FileCheck %s --check-prefix=SPLIT +// RUN: %clang_cl -### -c -target x86_64-unknown-windows-msvc -gsplit-dwarf -g %s 2>&1 |

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:326 +ObjCOrBuiltinID = FirstBuiltinID + (ID - 1); +assert(getBuiltinID() == ID && "ID too large for field!"); + } Is this the assert you are looking for? CHANGES SI

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 532294. AlexVlx added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 Files: clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.cpp clan

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 532293. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

craig.topper created this revision. craig.topper added reviewers: jrtc27, asb, kito-cheng, wangpc, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

owenpan added a comment. @jrmolin is this option really for breaking before the first parameter? Or are you trying to have one parameter per line as shown by the examples in your GitHub issue? Also, how would it interact with `BAS_AlwaysBreak`, `BinPackParameters`, and `AllowAllParametersOfDecl

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1470 +->getLambdaStaticInvoker()) && + !Fn->getName().contains("__impl")) { +// If emitting a lambda with static invoker on X86 Windows, change ---

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 532291. akhuang added a comment. Use isDelegateCall to check whether function is actual call op fn or not Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: cla

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: clang/test/Driver/fatlto.c:1 + tejohnson wrote: > Is this empty file meant to contain something? No, this was just a mistake in my commit. I had the linker checks in another

[clang] 85f4ef3 - Revert "Revert "clang: Update tests after InstSimplify change""

Author: Arthur Eubanks Date: 2023-06-16T13:53:32-07:00 New Revision: 85f4ef3baa9eb76aec939beaa3d378f57df8f0ef URL: https://github.com/llvm/llvm-project/commit/85f4ef3baa9eb76aec939beaa3d378f57df8f0ef DIFF: https://github.com/llvm/llvm-project/commit/85f4ef3baa9eb76aec939beaa3d378f57df8f0ef.diff

[PATCH] D153123: Fix diag for read-only target features

yaxunl updated this revision to Diff 532284. yaxunl added a comment. use -verify in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153123/new/ https://reviews.llvm.org/D153123 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/Basic/Targets.cpp clang/test/OpenMP/openmp-read-only

[PATCH] D153064: [-Wunsafe-buffer-usage] Do not emit fixits for C++ interfaces with C linkage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1ae844dc2cc: [-Wunsafe-buffer-usage] Do not emit fixits for C++ interfaces with C linkage (authored by t-rasmud). Herald added a project: clang. Her

[clang] d1ae844 - [-Wunsafe-buffer-usage] Do not emit fixits for C++ interfaces with C linkage

Author: Rashmi Mudduluru Date: 2023-06-16T13:28:34-07:00 New Revision: d1ae844dc2cc58bc762135d9500464c61d50f4f9 URL: https://github.com/llvm/llvm-project/commit/d1ae844dc2cc58bc762135d9500464c61d50f4f9 DIFF: https://github.com/llvm/llvm-project/commit/d1ae844dc2cc58bc762135d9500464c61d50f4f9.di

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 532272. paulkirth added a comment. Rebase and fix run line in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added a comment. In D153008#4424821 , @jrtc27 wrote: > Clang tests should not compile to asm. You want an IR test. My bad. You suggested IR as input (rather than C) and makes total sense. The latest update captures that suggestion. Repos

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

nridge added a comment. > The major problem I see now is that we can't handle third party modules. > Third party modules refer to the modules whose source codes are not in > current project. The users are still able to see the hint from clangd if the > BMI of the third party modules are built a

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:325 void setBuiltinID(unsigned ID) { -ObjCOrBuiltinID = ID + tok::NUM_OBJC_KEYWORDS; -assert(ObjCOrBuiltinID - unsigned(tok::NUM_OBJC_KEYWORDS) == ID - && "ID too large fo

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532268. abel-bernabeu added a comment. The test has been moved to llvm/test/CodeGen/RISCV Also has been reworked for using LLVM IR as input, so clang is not needed in the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D146777: [clang] Preliminary fat-lto-object support

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/Driver/fatlto.c:1 + Is this empty file meant to contain something? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

sammccall added a comment. (Sorry, hit send too soon) I suspect the answer for header modules is that we can study this patch and understand what the equivalents of graph nodes/deps/names/scanning look like for explicit header modules, and understand that we'll be able to abstractify some name

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

sammccall added a comment. Thanks for putting this together, I'm going to study it carefully and try it out! That said, there are two large issues that I think should be addressed in the design (though not necessarily *implemented* now). I'll be upfront: these are things without which $EMPLOYER

[PATCH] D152645: [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a709689bc17: [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl… (authored by nridge). Repository: rG LLVM Github Mo

[clang-tools-extra] 7a70968 - [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()

Author: Nathan Ridge Date: 2023-06-16T15:19:50-04:00 New Revision: 7a709689bc1755a569864a97d93b96d22f988eb4 URL: https://github.com/llvm/llvm-project/commit/7a709689bc1755a569864a97d93b96d22f988eb4 DIFF: https://github.com/llvm/llvm-project/commit/7a709689bc1755a569864a97d93b96d22f988eb4.diff

[PATCH] D152645: [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()

nridge updated this revision to Diff 532263. nridge marked an inline comment as done. nridge added a comment. Address last comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152645/new/ https://reviews.llvm.org/D152645 Files: clang-tools-extr

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f4d48d73d39: [clang] Replace use of Type::getPointerTo() (NFC) (authored by JOE1994, committed by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 0f4d48d - [clang] Replace use of Type::getPointerTo() (NFC)

Author: Youngsuk Kim Date: 2023-06-16T22:07:32+03:00 New Revision: 0f4d48d73d3941ed554ecd9d4bb285176ec01954 URL: https://github.com/llvm/llvm-project/commit/0f4d48d73d3941ed554ecd9d4bb285176ec01954 DIFF: https://github.com/llvm/llvm-project/commit/0f4d48d73d3941ed554ecd9d4bb285176ec01954.diff

[clang] 3632e2f - Diagnose incorrect use of scoped enumerations in format strings

Author: Aaron Ballman Date: 2023-06-16T15:03:38-04:00 New Revision: 3632e2f5179a420ea8ab84e6ca33747ff6130fa2 URL: https://github.com/llvm/llvm-project/commit/3632e2f5179a420ea8ab84e6ca33747ff6130fa2 DIFF: https://github.com/llvm/llvm-project/commit/3632e2f5179a420ea8ab84e6ca33747ff6130fa2.diff

[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.

craig.topper created this revision. craig.topper added reviewers: reames, jrtc27, asb, VincentWu. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532256. qiongsiwu1 added a comment. Clean up code in `addLTOOptions`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Files: clang/lib/Driver/ToolChains/CommonAr

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:325 void setBuiltinID(unsigned ID) { -ObjCOrBuiltinID = ID + tok::NUM_OBJC_KEYWORDS; -assert(ObjCOrBuiltinID - unsigned(tok::NUM_OBJC_KEYWORDS) == ID - && "ID too large fo

[PATCH] D153123: Fix diag for read-only target features

jhuber6 added inline comments. Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8 +// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s +// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is read only jdoerfert w

[clang] dd1c79b - Revert "clang: Update tests after InstSimplify change"

Author: Arthur Eubanks Date: 2023-06-16T11:24:28-07:00 New Revision: dd1c79b03004ae88ebead51aa021ab229ab0175c URL: https://github.com/llvm/llvm-project/commit/dd1c79b03004ae88ebead51aa021ab229ab0175c DIFF: https://github.com/llvm/llvm-project/commit/dd1c79b03004ae88ebead51aa021ab229ab0175c.diff

[PATCH] D153123: Fix diag for read-only target features

jdoerfert added inline comments. Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8 +// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s +// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is read only yaxunl wr

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

jdoerfert added a comment. This looks pretty good. The device vs if clause thing should be fixed while we are here. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10399 +DeviceID = CGF.Builder.getInt64(OMP_DEVICEID_UNDEF); + } Move this behind the if

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532241. qiongsiwu1 edited the summary of this revision. qiongsiwu1 added a comment. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Files: c

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 ___

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao updated this revision to Diff 532223. rZhBoYao edited the summary of this revision. rZhBoYao added a comment. Depends on D153156 PS: I'm going on a vacation for 2 weeks. See you guys in July :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rZhBoYao created this revision. rZhBoYao added reviewers: Endill, aaron.ballman. Herald added a subscriber: jvesely. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [Clang] CWG1473: do not err on the la

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 532212. paulkirth marked an inline comment as done. paulkirth added a comment. Rebase, address comments, and add missing test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.l

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added a comment. In D153008#4428568 , @MaskRay wrote: > This new update still applies many unneeded `getParser().Lex();` and adds a > test at a wrong layer >

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

ilinpv added a comment. Thank you for the patch, it comes in the right time - we are also working on AArch64 __builtin_cpu_supports, and I was thinking how to make it more general. I uploaded our RFC version for review https://reviews.llvm.org/D153153 It would be great to have in __builtin_cpu_su

[PATCH] D153153: [AArch64][RFC][Draft] Implement __builtin_cpu_supports, compiler-rt tests.

ilinpv created this revision. ilinpv added reviewers: danielkiss, kristof.beyls, nemanjai, arsenm. Herald added subscribers: Enna1, dberris. Herald added a project: All. ilinpv requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, wdng. Herald added projects: clang,

[PATCH] D153109: [clang-format][NFC] Clean up unit tests

owenpan updated this revision to Diff 532192. owenpan added a comment. Cleaned up FormatTestJS.cpp as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153109/new/ https://reviews.llvm.org/D153109 Files: clang/unittests/Format/FormatTest.cpp clang/unittests/Format/FormatTestBase.

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu marked an inline comment as done. abel-bernabeu added a comment. In D153008#4428568 , @MaskRay wrote: > This new update still applies many unneeded `getParser().Lex();` and adds a > test at a wrong layer >

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

MaskRay added inline comments. Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:1244 +int64_t Value = CE->getValue(); +return Value >= 0 && Value < 256; + } `isUInt<8>(Value)`. Can the limit be tested? Comment at: llvm/test/

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

MaskRay added inline comments. Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6422 + // consume an optional trailing '#' (GNU compatibility) + if (getLexer().is(AsmToken::Hash)) +Parser.Lex(); Use `parseOptionalToken`. Repository: rG LLVM G

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot updated this revision to Diff 532199. robot added a comment. Remove left-over file of other patch from CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153152/new/ https://reviews.llvm.org/D153152 Files: clang-tools-extra/clang

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot added a comment. This change is not done, I need some advice: - I don't understand why there are two levels of data structures in an entry of the final overriders map, hence I can't properly name the variables nor do I fully understand what I'm doing there. - It's not clear if the tweak s

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot created this revision. robot added a reviewer: sammccall. Herald added subscribers: ChuanqiXu, kadircet, arphaman. Herald added a project: All. robot requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This tweak searches the

[PATCH] D152356: [clang][ExtractAPI] Add --emit-symbol-graph option

Arsenic created this revision. Arsenic added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. Arsenic updated this revision to Diff 529841. Arsenic added a comment. Arsenic marked 5 inline comments as done. Arsenic updated this revision to Diff 532145. Arsenic updat

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. In D152321#4428398 , @JOE1994 wrote: > With the updated revision, I don't see new test failures from `ninja > check-clang` & `ninja check-llvm` & `ninja check-clang-unit` & `ninja > check-llvm-unit` . Thank you, it was my

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added a comment. In D153008#4425244 , @jrtc27 wrote: > In D153008#4425238 , @abel-bernabeu > wrote: > >> In D153008#4424821 , @jrtc27 wrote: >> >>> Clang te

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

MaskRay added a comment. This new update still applies many unneeded `getParser().Lex();` and adds a test at a wrong layer (clang/test/CodeGen): Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532185. abel-bernabeu added a comment. Simplified the test. Also I check that the comments are a carried over to the assembly output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://rev

[PATCH] D153150: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532182. abel-bernabeu added a comment. Simplified the test and checking for comments to be carried over to the assembly output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153150/new/ https://reviews.ll

[PATCH] D153150: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosH

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30ffb3e4fbce: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments (authored by dankm, committed by MaskRay). Changed prior to c

[clang] 30ffb3e - [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

Author: Dan McGregor Date: 2023-06-16T08:47:00-07:00 New Revision: 30ffb3e4fbce3132fbf63c62a8ecbb1edbec4fc9 URL: https://github.com/llvm/llvm-project/commit/30ffb3e4fbce3132fbf63c62a8ecbb1edbec4fc9 DIFF: https://github.com/llvm/llvm-project/commit/30ffb3e4fbce3132fbf63c62a8ecbb1edbec4fc9.diff

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added a comment. > Previously when a packed struct, containing vector data types such as > uint16x8_t, is passed as a function argument, the alignment of the > struct used by the function caller and the alignment used by the callee > to load the argument from stack does not match. I would s

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

ManuelJBrito added inline comments. Comment at: llvm/lib/Target/X86/X86InstCombineIntrinsic.cpp:3102-3105 case Intrinsic::x86_sse4a_extrqi: case Intrinsic::x86_sse4a_insertq: case Intrinsic::x86_sse4a_insertqi: +PoisonElts.setHighBits(VWidth / 2); nl

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:515 +- Apply ``-fmacro-prefix-map`` to anonymous tags in template arguments + (`#63219 `_) I'll add a period to be consistent with other e

[clang] 501405f - [Clang] Fixes a diagnostic typo.

Author: Mark de Wever Date: 2023-06-16T17:40:53+02:00 New Revision: 501405f1d5f027717ab6866aa1dece2d384791cc URL: https://github.com/llvm/llvm-project/commit/501405f1d5f027717ab6866aa1dece2d384791cc DIFF: https://github.com/llvm/llvm-project/commit/501405f1d5f027717ab6866aa1dece2d384791cc.diff

  1   2   >