[clang] b59ca49 - [4/11][Clang][RISCV] Expand all variants for unit stride segment store

Author: eopXD Date: 2023-06-13T23:51:02-07:00 New Revision: b59ca492d98d96c989dcc4aa31fa15b8c38f URL: https://github.com/llvm/llvm-project/commit/b59ca492d98d96c989dcc4aa31fa15b8c38f DIFF: https://github.com/llvm/llvm-project/commit/b59ca492d98d96c989dcc4aa31fa15b8c38f.diff LOG: [4

[PATCH] D152072: [4/11][Clang][RISCV] Expand all variants for unit stride segment store

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb59ca492d98d: [4/11][Clang][RISCV] Expand all variants for unit stride segment store (authored by eopXD). Repository: rG LLVM Github Monorepo CHA

[PATCH] D152072: [4/11][Clang][RISCV] Expand all variants for unit stride segment store

eopXD updated this revision to Diff 531203. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152072/new/ https://reviews.llvm.org/D152072 Files: clang/include/clang/Basic/riscv_vector.td clang/test/C

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5847ec4deba2: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types (authored by eopXD). Repository: rG LLVM Github Monorepo CHAN

[clang] 5847ec4 - [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

Author: eopXD Date: 2023-06-13T23:45:31-07:00 New Revision: 5847ec4deba28b7ac57953e39e7555e741650c92 URL: https://github.com/llvm/llvm-project/commit/5847ec4deba28b7ac57953e39e7555e741650c92 DIFF: https://github.com/llvm/llvm-project/commit/5847ec4deba28b7ac57953e39e7555e741650c92.diff LOG: [2

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

eopXD updated this revision to Diff 531199. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152070/new/ https://reviews.llvm.org/D152070 Files: clang/include/clang/Basic/RISCVVTypes.def clang/include

[PATCH] D152889: [RISCV] Model vxrm control for vsadd, vsaddu, vssub, and vssubu

eopXD updated this revision to Diff 531193. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152889/new/ https://reviews.llvm.org/D152889 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152889: [RISCV] Model vxrm control for vsadd, vsaddu, vssub, and vssubu

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, arcbbb, rogfer01, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, ed

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd updated this revision to Diff 531189. animeshk-amd added a comment. Herald added subscribers: jplehr, sunshaoce, pcwang-thead. Rebase and fixing the merge conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129635/new/ https://revi

[PATCH] D143587: [Docs] Multilib design

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5aeba737694: [Docs] Multilib design (authored by michaelplatings). Changed prior to commit: https://reviews.llvm.org/D143587?vs=529588&id=531184#

[PATCH] D143075: BareMetal ToolChain multilib layering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab2c80bb1256: [Driver] BareMetal ToolChain multilib layering (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedc1130c0ac0: [Driver] Enable selecting multiple multilibs (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4eebc8674e1: [Driver] Enable multilib.yaml in the BareMetal ToolChain (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D142933: [Driver] Add -print-multi-flags-experimental option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa794ab92b41f: [Driver] Add -print-multi-flags-experimental option (authored by michaelplatings). Changed prior to commit: https://reviews.llvm.org

[clang] a5aeba7 - [Docs] Multilib design

Author: Michael Platings Date: 2023-06-14T06:46:42+01:00 New Revision: a5aeba737694f56daacfbe8f78601cbd14f5d359 URL: https://github.com/llvm/llvm-project/commit/a5aeba737694f56daacfbe8f78601cbd14f5d359 DIFF: https://github.com/llvm/llvm-project/commit/a5aeba737694f56daacfbe8f78601cbd14f5d359.di

[PATCH] D142932: Multilib YAML parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rG4794bdab7aed: [Driver] Multilib YAML parsing (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.o

[clang] ab2c80b - [Driver] BareMetal ToolChain multilib layering

Author: Michael Platings Date: 2023-06-14T06:46:41+01:00 New Revision: ab2c80bb125634816e39a1e4787a5a103cd03a74 URL: https://github.com/llvm/llvm-project/commit/ab2c80bb125634816e39a1e4787a5a103cd03a74 DIFF: https://github.com/llvm/llvm-project/commit/ab2c80bb125634816e39a1e4787a5a103cd03a74.di

[clang] edc1130 - [Driver] Enable selecting multiple multilibs

Author: Michael Platings Date: 2023-06-14T06:46:41+01:00 New Revision: edc1130c0ac0e52ac5e347127972313ba928fe9a URL: https://github.com/llvm/llvm-project/commit/edc1130c0ac0e52ac5e347127972313ba928fe9a DIFF: https://github.com/llvm/llvm-project/commit/edc1130c0ac0e52ac5e347127972313ba928fe9a.di

[clang] b4eebc8 - [Driver] Enable multilib.yaml in the BareMetal ToolChain

Author: Michael Platings Date: 2023-06-14T06:46:41+01:00 New Revision: b4eebc8674e1f1dc1ef08fa7648ca494a119449d URL: https://github.com/llvm/llvm-project/commit/b4eebc8674e1f1dc1ef08fa7648ca494a119449d DIFF: https://github.com/llvm/llvm-project/commit/b4eebc8674e1f1dc1ef08fa7648ca494a119449d.di

[clang] a794ab9 - [Driver] Add -print-multi-flags-experimental option

Author: Michael Platings Date: 2023-06-14T06:46:41+01:00 New Revision: a794ab92b41f00ba29b5852c34a510173638dcc0 URL: https://github.com/llvm/llvm-project/commit/a794ab92b41f00ba29b5852c34a510173638dcc0 DIFF: https://github.com/llvm/llvm-project/commit/a794ab92b41f00ba29b5852c34a510173638dcc0.di

[clang] 4794bda - [Driver] Multilib YAML parsing

Author: Michael Platings Date: 2023-06-14T06:46:40+01:00 New Revision: 4794bdab7aed92e699db29e031bfe71f4005326f URL: https://github.com/llvm/llvm-project/commit/4794bdab7aed92e699db29e031bfe71f4005326f DIFF: https://github.com/llvm/llvm-project/commit/4794bdab7aed92e699db29e031bfe71f4005326f.di

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 531178. eopXD added a comment. Resolve test case failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td clang/te

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf abandoned this revision. qiucf added a subscriber: tuliom. qiucf added a comment. There's a glibc patch in review to fix the motivation error in math.h (thanks to @tuliom ): https://patchwork.sourceware.org/project/glibc/patch/20230613215633.3179708-1-tul...@ascii.art.br/ I think this rev

[PATCH] D150023: [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8a36b00d198: [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other… (authored by ChuanqiXu). Herald added a project: clang.

[clang] d8a36b0 - [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit

Author: Chuanqi Xu Date: 2023-06-14T12:45:34+08:00 New Revision: d8a36b00d198fdc2ea866ea5da449628db07070f URL: https://github.com/llvm/llvm-project/commit/d8a36b00d198fdc2ea866ea5da449628db07070f DIFF: https://github.com/llvm/llvm-project/commit/d8a36b00d198fdc2ea866ea5da449628db07070f.diff LO

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 531157. eopXD added a comment. Resolve test case failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td clang/t

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl. Herald added a subscriber: tpr. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1, MaskRay. Herald added a reviewer: jdoe

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo updated this revision to Diff 531151. modimo added a comment. Remove unrelated change, fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152741/new/ https://reviews.llvm.org/D152741 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

zyounan created this revision. Herald added a project: All. zyounan added reviewers: aaron.ballman, lh123. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. `desugarForDiagnostic` only sets ShouldAKA to true if desugaring happens, ot

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo updated this revision to Diff 531149. modimo added a comment. Herald added subscribers: llvm-commits, ormris, steven_wu, hiraditya. Herald added a project: LLVM. Implement using VCallVisibilityUnknown Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, arcbbb, rogfer01, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, ed

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 531144. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 531141. eopXD added a comment. Fix `ManualCodeGen` part, the maskedoff parameter was not passed correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clan

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

FreddyYe added a comment. This patch is mainly for another WIP patch https://reviews.llvm.org/D151696, while I realize maybe it's too aggressive to support too many CPUs with -march, -mcpu, ... I'll reimplement the WIP patch to try to make the supports range same as before. Close this first.

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 added a comment. In D150803#4419370 , @sunfish wrote: > Would it make sense to call this "jspi" in practice, rather than "async"? > Even though this isn't clang's decision per se anymore, it seems like the > reasoning earlier in this review would

[PATCH] D121629: clang: also check alloc_alignment claims in return

jyknight added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3684 + const AllocAlignAttr *AA = CurCodeDecl->getAttr(); + if (SanOpts.has(SanitizerKind::Alignment) && AA) { It may be nice to also verify the alignment required by an AssumeAlignAttr

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

MaskRay added a comment. In D152570#4417752 , @dankm wrote: > @MaskRay if this meets your approval, are you able to commit it for me? LG, but give @aaron.ballman and @shafik some time if they have opinions. In D152570#4416201

[PATCH] D152867: OpenMP: Add a new test for constantexpr evaluation of math headers

arsenm created this revision. arsenm added reviewers: AMDGPU, doru1004, JonChesterfield, ddpagan, pdhaliwal, ronlieb. Herald added subscribers: sunshaoce, guansong, yaxunl, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: jplehr, sstefan1, w

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sunfish added a comment. Would it make sense to call this "jspi" in practice, rather than "async"? Even though this isn't clang's decision per se anymore, it seems like the reasoning earlier in this review would still apply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo added a comment. In D152741#4419324 , @tejohnson wrote: > In D152741#4419265 , @modimo wrote: > >> In D152741#4418831 , @tejohnson >> wrote: >> >>> I think I under

[PATCH] D151834: Include math-errno with fast-math

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2249 + // MSVC takes into account math-errno when compiling at -O2 level in + // the presence of a '#pragma float_control precise(on/off)'. Since we handle "#pragma float_contr

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

kstoimenov added a comment. In D151785#4418037 , @zyounan wrote: > In D151785#4417973 , @kstoimenov > wrote: > >> Looks like this might have broken a couple of sanitizer builds. Here is one >> of them: https://l

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

rnk added a comment. In D152604#4415403 , @MaskRay wrote: > I have thought about not applying `-fsanitize-address-globals-dead-stripping` > in `-fno-data-sections` mode, so that we won't have sections like `.bss.a`, > but the driver complexity/cognitive

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

tejohnson added a comment. In D152741#4419265 , @modimo wrote: > In D152741#4418831 , @tejohnson > wrote: > >> I think I understand the motivation, but not sure I agree this is the right >> approach - can you si

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

jyknight added inline comments. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1333 +CalleeDecl->getOverloadedOperator() == OO_Delete) { + CallOrInvoke->addParamAttr(0, llvm::Attribute::AllocatedPointer); +} Perhaps we should add this attribute to t

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Nice! Comment at: lld/test/wasm/merge-custom-attr-section.ll:47 +} + +attributes #0 = { "wasm-custom"="custom0" } Is there some reason we can't use assembly

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo added a comment. In D152741#4418831 , @tejohnson wrote: > I think I understand the motivation, but not sure I agree this is the right > approach - can you simply not pass -flto-unit and -fwhole-program-vtables for > these files? For our third-pa

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 531089. kushanam added a comment. renaming useBF16Math to hasBF16Math Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/include/clang/Basic/BuiltinsNVPT

[PATCH] D144911: adding bf16 support to NVPTX

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with few nits. Thank you for your patience with revising the patch. Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:629-631 + const bool IsBFP16FP16x2NegAvailable = S

[clang] bb209ce - [-Wtcb-enforcement] Disable on unevaluated code.

Author: Artem Dergachev Date: 2023-06-13T14:36:51-07:00 New Revision: bb209ce138e71f2fd646b7f0f865f957336c67e9 URL: https://github.com/llvm/llvm-project/commit/bb209ce138e71f2fd646b7f0f865f957336c67e9 DIFF: https://github.com/llvm/llvm-project/commit/bb209ce138e71f2fd646b7f0f865f957336c67e9.dif

[PATCH] D152858: OpenMP: Use generated checks and pragma declare target

arsenm created this revision. arsenm added reviewers: AMDGPU, JonChesterfield, doru1004, ronlieb, ddpagan, jdoerfert. Herald added subscribers: sunshaoce, guansong, yaxunl, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: jplehr, sstefan1, w

[PATCH] D152857: OpenMP: Don't use target regions in library function test

arsenm created this revision. arsenm added reviewers: AMDGPU, JonChesterfield, pdhaliwal, jdoerfert, doru1004. Herald added subscribers: sunshaoce, guansong, yaxunl, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. Us

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 531068. kushanam added a comment. add constantFP for bf16 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/include/clang/Basic/BuiltinsNVPTX.def llvm

[PATCH] D152856: [Driver] Allow warning for unclaimed TargetSpecific options

MaskRay created this revision. MaskRay added reviewers: jansvoboda11, mstorsjo, xen0n, SixWeining. Herald added a subscriber: hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

owenpan added a comment. In D151761#4418809 , @HazardyKnusperkeks wrote: > I think we need some input what should be able to be aligned - the statement > vs. the colon - and only //short// case statements vs all case statements. I think we should align

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

arsenm added a comment. In D152829#4419016 , @JonChesterfield wrote: > That seems like something we should fix. Visibility/dso really should be the > same default. I don't know what that fp thing is Whether you're allowed to turn x * y + z into an fma

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 531060. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

JonChesterfield added a comment. That seems like something we should fix. Visibility/dso really should be the same default. I don't know what that fp thing is CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152829/new/ https://reviews.llvm.org/D152829 ___

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added a comment. In D152226#4418978 , @goldstein.w.n wrote: > In D152226#4418498 , @jdoerfert > wrote: > >> FWIW, I wish the time that went into this would have been to improve and >> enable the (

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added a comment. In D152226#4418498 , @jdoerfert wrote: > FWIW, I wish the time that went into this would have been to improve and > enable the (lightweight) Attributor pass. > Anyway, I'm still doing that, and the latest numbers didn't loo

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

dschuff added a comment. oh also: please add the new relocation type to the document at https://github.com/WebAssembly/tool-conventions/blob/main/Linking.md Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

dschuff added a comment. backend code looks pretty good. I'll defer to the clang experts for the clang part. Comment at: lld/test/wasm/custom-undefine.s:17 +.type bar,@function +bar: +.functype bar () -> () I don't fully understand how

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

arsenm updated this revision to Diff 531048. arsenm added a comment. Use -verify CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152829/new/ https://reviews.llvm.org/D152829 Files: clang/test/Headers/__clang_hip_libdevice_declares.cpp Index: clang/test/Headers/__clang_hip_libdevice_de

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

shafik added a comment. Looks like this change is coming up in: https://github.com/llvm/llvm-project/issues/63284 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 _

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

jyknight added a comment. > As a result, clang/llvm should correctly > optimize custom allocators like this without needing specialized > knowledge going forward. Not exactly: we still need knowledge of this in //clang// (`isReplaceableGlobalAllocationFunction` was taught that the variant with a

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

jyknight added a comment. In D148700#4418767 , @rsandifo-arm wrote: > Hi @jyknight , @rsmith > > Do you have any more thoughts on the above? Quick version is: > > 1. Is it OK to have `[[…]]` attributes in the `arm` namespace that affect > semantics? I

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

AMS21 updated this revision to Diff 531042. AMS21 added a comment. Remove debug code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152852/new/ https://reviews.llvm.org/D152852 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93, carlosgalvezp. Herald added subscribers: ChuanqiXu, xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes llvm

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

tejohnson added a comment. I think I understand the motivation, but not sure I agree this is the right approach - can you simply not pass -flto-unit and -fwhole-program-vtables for these files? Also, isn't this hiding possibly necessary info from WPD that might be needed for correct class hier

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

MaskRay added a comment. @jansvoboda11 For ELF operating systems (that traditionally use GCC), I think unsupported `-m*` options as errors are very desired as that's the GCC behavior and some configure system will prefer it. I think x86 `-m*` options are the most possible options to be misused

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. In D151761#4416224 , @galenelias wrote: > Well, I guess I didn't put quite enough thought into the `AlignCaseColons` > option. While this solves the empty case label problem, it will also match > in non-short case l

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG651e5ae62d29: [MS] Fix passing aligned records by value in some cases (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 651e5ae - [MS] Fix passing aligned records by value in some cases

Author: Reid Kleckner Date: 2023-06-13T12:54:23-07:00 New Revision: 651e5ae62d29fdb07eb85f75ab7e686b98479f3a URL: https://github.com/llvm/llvm-project/commit/651e5ae62d29fdb07eb85f75ab7e686b98479f3a DIFF: https://github.com/llvm/llvm-project/commit/651e5ae62d29fdb07eb85f75ab7e686b98479f3a.diff

[PATCH] D152851: OpenMP: Fix nothrow new/delete for amdgpu

arsenm created this revision. arsenm added reviewers: AMDGPU, jdoerfert, JonChesterfield, ronlieb, saiislam. Herald added subscribers: sunshaoce, guansong, tpr, dstuttard, yaxunl, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: jplehr, sste

[PATCH] D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP

yaxunl added inline comments. Herald added subscribers: jplehr, sunshaoce. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8090 if (Triple.isAMDGPU()) -handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs, /*IsCC1As=*/true); +handleAMDGPUCodeObjectVersionOptions(D,

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152401/new/ https://reviews.llvm.org/D152401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm added a comment. Hi @jyknight , @rsmith Do you have any more thoughts on the above? Quick version is: 1. Is it OK to have `[[…]]` attributes in the `arm` namespace that affect semantics? 2. Is it OK to raise an error for unrecognised attributes in the `arm` namespace (for a measu

[PATCH] D152850: OpenMP: Add missing test coverage for nothrow new/delete

arsenm created this revision. arsenm added reviewers: jdoerfert, ABataev, JonChesterfield, saiislam. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. Missing test from fd3

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2001 -void CodeGenModule::getDefaultFunctionAttributes(StringRef Name, - bool HasOptnone, - bool AttrOnCallSit

[PATCH] D152729: Enable zbb for riscv android

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6bcf57f0b7ec: Enable zbb for riscv android (authored by AdityaK <1894981+hiradi...@users.noreply.github.com>). Herald adde

[clang] 6bcf57f - Enable zbb for riscv android

Author: AdityaK Date: 2023-06-13T12:30:04-07:00 New Revision: 6bcf57f0b7ec8b28e933387a4925dfc52779ce0f URL: https://github.com/llvm/llvm-project/commit/6bcf57f0b7ec8b28e933387a4925dfc52779ce0f DIFF: https://github.com/llvm/llvm-project/commit/6bcf57f0b7ec8b28e933387a4925dfc52779ce0f.diff LOG:

[PATCH] D152442: [LinkerWrapper] Support linking vendor bitcode late

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. This LG, the complicated stuff is in the previous patch. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152442/new/ http

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2001 -void CodeGenModule::getDefaultFunctionAttributes(StringRef Name, - bool HasOptnone, - bool AttrO

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG474a2b9367ad: [clang-tidy] Add more checks for functions which should be noexcept (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM

[clang-tools-extra] 474a2b9 - [clang-tidy] Add more checks for functions which should be noexcept

Author: AMS21 Date: 2023-06-13T18:56:57Z New Revision: 474a2b9367ad36213ad8575dc349350fdd8fc8f3 URL: https://github.com/llvm/llvm-project/commit/474a2b9367ad36213ad8575dc349350fdd8fc8f3 DIFF: https://github.com/llvm/llvm-project/commit/474a2b9367ad36213ad8575dc349350fdd8fc8f3.diff LOG: [clang-

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

PiotrZSL added a comment. In D152589#4418649 , @ErezAmihud wrote: > I want to make sure I understand. > The ideal situation would be to create `misc-no-relative-includes` check that > checks for `..` in paths (meaning - relative paths), and have a `Stri

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

ErezAmihud added a comment. In D152589#4410930 , @PiotrZSL wrote: > Even with that for me for example, I would consider `#include "xyz"` be fine, > but `#include "../xyz"` would be a red flag, so please consider adding > `StrictMode` option to check so

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. This patch seems like a win to me. Comment at: clang/docs/ReleaseNotes.rst:325 + invalid code. Furthermore, it also displays the object as written by the user. + (`#57081:

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added a comment. In D139730#4418630 , @arsenm wrote: > In D139730#3991628 , > @JonChesterfield wrote: > >> We currently require that library for libm, which I'm also not thrilled >> about, but at least y

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

arsenm added a comment. Herald added subscribers: jplehr, sunshaoce. In D139730#3991628 , @JonChesterfield wrote: > We currently require that library for libm, which I'm also not thrilled > about, but at least you can currently build and run openmp prog

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

This revision was automatically updated to reflect the committed changes. Closed by commit rG6eb6ee3cfe57: [clang-tidy] Move formatDereference to FixitHintUtils (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] 6eb6ee3 - [clang-tidy] Move formatDereference to FixitHintUtils

Author: Mike Crowe Date: 2023-06-13T18:54:49Z New Revision: 6eb6ee3cfe57b768d384486693a17c7abaa0f59a URL: https://github.com/llvm/llvm-project/commit/6eb6ee3cfe57b768d384486693a17c7abaa0f59a DIFF: https://github.com/llvm/llvm-project/commit/6eb6ee3cfe57b768d384486693a17c7abaa0f59a.diff LOG: [c

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

cjdb accepted this revision. cjdb added a comment. Thanks for fixing this, it'll hopefully cause less frustration for devs :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152525/new/ https://reviews.llvm.org/D152525 __

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/include/clang/Basic/Builtins.h:65 enum ID { +#define INTERESTING_IDENTIER(ID, TYPE, ATTRS) ID, NotBuiltin = 0, // This is not a builtin function. You shouldn't muddle this into `Builtin::ID`. =

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp:43-44 + + if (!MaybeHeaderToInclude && (ReplacementPrintFunction == "std::print" || +ReplacementPrintlnFunction == "std::println")) +MaybeH

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl updated this revision to Diff 531014. brendandahl added a comment. Fix few remaining issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim updated this revision to Diff 531013. dim added a comment. Squash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152788/new/ https://reviews.llvm.org/D152788 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.t

  1   2   3   >