[PATCH] D149158: [clang][analyzer] Cleanup tests of StdCLibraryFunctionsChecker (NFC)

steakhal added inline comments. Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2 +typedef typeof(sizeof(int)) size_t; +typedef signed long ssize_t; +typedef struct { balazske wrote: > steakhal wrote: > > `ssize_t`'s size should match the size

[PATCH] D148124: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda4fcb0c0b28: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple. (authored by kito-cheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] da4fcb0 - [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

Author: Kito Cheng Date: 2023-04-27T14:46:01+08:00 New Revision: da4fcb0c0b281746067f92d8804c18dbce4269bd URL: https://github.com/llvm/llvm-project/commit/da4fcb0c0b281746067f92d8804c18dbce4269bd DIFF: https://github.com/llvm/llvm-project/commit/da4fcb0c0b281746067f92d8804c18dbce4269bd.diff LO

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. Thanks @tbaeder, I really appreciate your time. Name is Unique_Usman and my email is usmanakinyemi...@gmail.com As you mentioned, if anyone later chime in, I will be glad to update the issue back. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D149160: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

balazske updated this revision to Diff 517457. balazske added a comment. added special argument condition function to remove code repetition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149160/new/ https://reviews.llvm.org/D149160 Files: clang/

[clang] 7c30d30 - [clang] Modernize DelayedDiagnostics (NFC)

Author: Kazu Hirata Date: 2023-04-26T23:29:03-07:00 New Revision: 7c30d3028b2cc0bea7858f995f9bb4024ad1d7d0 URL: https://github.com/llvm/llvm-project/commit/7c30d3028b2cc0bea7858f995f9bb4024ad1d7d0 DIFF: https://github.com/llvm/llvm-project/commit/7c30d3028b2cc0bea7858f995f9bb4024ad1d7d0.diff L

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

njames93 added a comment. It may be a good idea to create unittests for the formatconverter in `clang-tools-extra/unittests/clang-tidy/` Can this check be renamed to just `modernize-use-std-print`. This sticks with the convention of other modernize names and potentially in the future allows us

[clang] aba32ab - [C++20] [Modules] Avoid crash if the inconsistency the size of lang options exceeds 1

Author: Chuanqi Xu Date: 2023-04-27T14:20:59+08:00 New Revision: aba32abe2d93133a46f67764937a1c85d455dce8 URL: https://github.com/llvm/llvm-project/commit/aba32abe2d93133a46f67764937a1c85d455dce8 DIFF: https://github.com/llvm/llvm-project/commit/aba32abe2d93133a46f67764937a1c85d455dce8.diff LO

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt -S -

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder updated this revision to Diff 517450. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang-tools-extra/test/clang-tidy/checkers/cert/uppercas

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. /* will update the diff ~soon */ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___ cfe-commits mailing list cfe-commit

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

tbaeder accepted this revision. tbaeder added a comment. This revision is now accepted and ready to land. When I run with `-verify=foo,bar`I only get the output for `bar-no-diagnostics`. Adding `bar-no-diagnostics`, I get no output at all and the test succeeds. I didn't know how passing multipl

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added a comment. In D149272#4301103 , @raj.khem wrote: > This would fix https://github.com/llvm/llvm-project/issues/62192 Thanks. I didn't know that was created. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D149272: [clang] Call printName to get name of Decl

raj.khem added a comment. This would fix https://github.com/llvm/llvm-project/issues/62192 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 ___ cfe-commits maili

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517429. chaitanyav added a comment. Revert libcxx libcxxabi files unrelated to the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/Releas

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 517427. dankm added a comment. And restore original change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/lib/AST/Decl.cpp clang/lib/AST/DeclarationNa

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 517426. dankm added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/test/CodeGen/debug-prefix-map.cpp Index: clang/test/CodeGe

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt -S

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, let it go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149314/new/ https://reviews.llvm.org/D149314

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai added a comment. Ping. Want to remind everyone that it is OK to review only a subset of files. The change spans multiple sub-projects and it is understandable nobody is comfortable reviewing //all// of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 517413. ziqingluo-90 added a comment. Move the traversal framework to `AnalysisBasedWarnings` so that the `UnsafeBufferUsage` analyzer (as well as other possible analyzers) is still function based. It is in the same pattern as the original `IssueWarnin

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

rsmith added a comment. LGTM, I'll leave approval to @shafik :) Comment at: clang/lib/Sema/SemaInit.cpp:5379 +} else { ArrayLength = Args.size(); +} Can we assert that we have an `IncompleteArrayType` here? (That is, that we don't have a `Depend

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 517416. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenO

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

craig.topper updated this revision to Diff 517408. craig.topper added a comment. Add another test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149314/new/ https://reviews.llvm.org/D149314 Files: clang/include/clang/Basic/Attr.td clang/li

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay marked an inline comment as done. MaskRay added a comment. I think the patch as-is implements all the useful parts of GCC's complex rules and in the absence of `-dumpbase` (we deliberately don't implement), the rule almost exactly matches GCC unless we do `gcc -g -gsplit-dwarf d/a.c -o e

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

craig.topper created this revision. craig.topper added reviewers: jrtc27, kito-cheng. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, e

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7fa92126cc3: [clang] Apply -fcoverage-prefix-map reverse order (authored by gulfem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] d7fa921 - [clang] Apply -fcoverage-prefix-map reverse order

Author: Gulfem Savrun Yeniceri Date: 2023-04-27T00:24:18Z New Revision: d7fa92126cc398b993f301273816739b23ed8740 URL: https://github.com/llvm/llvm-project/commit/d7fa92126cc398b993f301273816739b23ed8740 DIFF: https://github.com/llvm/llvm-project/commit/d7fa92126cc398b993f301273816739b23ed8740.d

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 517400. gulfem added a comment. Extend the comment about the usage of CoveragePrefixMap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 Files: clang/include/clang/B

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:138-144 +bool SkipForSpecialization, +bool ForConstraintInstantiation) { if (!ClassTemplSpec->isClassScopeExplicitSpecialization()) { // We

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

rsmith added a comment. I think that the bugs that this was aiming to fix were fixed by rG1e43349e321694d7fee3d77cb691887ad67fb5d7 , which means that we should not ask whether the constraints of an inherited constructor are s

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:211 + + /// Prefix replacement map for coverage. + llvm::SmallVector, 0> CoveragePrefixMap; MaskRay wrote: > MaskRay wrote: > > While adding a comment, clarify what coverage it

[clang] 1e43349 - Pass the found declaration to DiagnoseUseOfDecl.

Author: Richard Smith Date: 2023-04-26T16:55:30-07:00 New Revision: 1e43349e321694d7fee3d77cb691887ad67fb5d7 URL: https://github.com/llvm/llvm-project/commit/1e43349e321694d7fee3d77cb691887ad67fb5d7 DIFF: https://github.com/llvm/llvm-project/commit/1e43349e321694d7fee3d77cb691887ad67fb5d7.diff

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:211 + + /// Prefix replacement map for coverage. + llvm::SmallVector, 0> CoveragePrefixMap; MaskRay wrote: > While adding a comment, clarify what coverage it is? There are mul

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added a comment. Hoorat for me. I just managed to produce a reduced test case. That'll be added to the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 __

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov planned changes to this revision. alexander-shaposhnikov added a comment. /* working on it */ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___

[PATCH] D138394: HIP: Directly call fma builtins

arsenm closed this revision. arsenm added a comment. 43fd46fda3c90b014e8a73c62f67af9543ea4d59 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138394/new/ https://reviews.llvm.org/D138394 __

[clang] 43fd46f - HIP: Directly call fma builtins

Author: Matt Arsenault Date: 2023-04-26T19:27:11-04:00 New Revision: 43fd46fda3c90b014e8a73c62f67af9543ea4d59 URL: https://github.com/llvm/llvm-project/commit/43fd46fda3c90b014e8a73c62f67af9543ea4d59 DIFF: https://github.com/llvm/llvm-project/commit/43fd46fda3c90b014e8a73c62f67af9543ea4d59.diff

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 517375. gulfem added a comment. Add text to document that coverage prefix map should be traversed in reverse order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 Fi

[PATCH] D147747: Add test to verify behavior of .cfi_sections .debug_frame intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe8eab468eee: Add tests to verify behavior of .cfi_sections .debug_frame intrinsic. (authored by rastogishubham). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LL

[clang] fe8eab4 - Add tests to verify behavior of .cfi_sections .debug_frame intrinsic.

Author: Shubham Sandeep Rastogi Date: 2023-04-26T16:16:33-07:00 New Revision: fe8eab468eee18329922901bcf74310534e08b59 URL: https://github.com/llvm/llvm-project/commit/fe8eab468eee18329922901bcf74310534e08b59 DIFF: https://github.com/llvm/llvm-project/commit/fe8eab468eee18329922901bcf74310534e0

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517372. chaitanyav added a comment. Add parentheses around integer expressions in libcxx tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay added a comment. In D149193#4300501 , @phosek wrote: > Do we have any way to check if there are projects out there that use > `-dumpbase`? It shouldn't be too difficult to support it, but we should find > out first if it's needed. I spot checke

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG921b45a855f0: [Sema]Select correct lexical context during template instantiate (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHA

[clang] 921b45a - [Sema]Select correct lexical context during template instantiate

Author: Congcong Cai Date: 2023-04-27T00:29:13+02:00 New Revision: 921b45a855f09afe99ea9c0c173794ee4ccd5872 URL: https://github.com/llvm/llvm-project/commit/921b45a855f09afe99ea9c0c173794ee4ccd5872 DIFF: https://github.com/llvm/llvm-project/commit/921b45a855f09afe99ea9c0c173794ee4ccd5872.diff

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x()) --

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers updated this revision to Diff 517358. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - rebase - use llvm::enumerate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141451/new/ https://reviews.llvm.o

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

phosek added a comment. Do we have any way to check if there are projects out there that use `-dumpbase`? It shouldn't be too difficult to support it, but we should find out first if it's needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14919

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

sberg added a comment. > But the fact that these two attributes already confuse users (AND we've got > unused as an attribute in the mix as well, which doesn't help) means we > should proceed with caution (and likely coordinate with GCC given that all > three of these attributes came from their

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When calling InitializeBase(...), TryOrBuidlParenListInit(...) needs to pass in the parent entity; otherwise, we erroneously t

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

scott.linder added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3884 + nullptr, getOpts().getOption(options::OPT_dumpdir), + Args.MakeArgString(Args.getLastArgValue(options::OPT_o, "a") + "-")); + Arg->claim(); MaskRay wrote: >

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3884 + nullptr, getOpts().getOption(options::OPT_dumpdir), + Args.MakeArgString(Args.getLastArgValue(options::OPT_o, "a") + "-")); + Arg->claim(); dblaikie wrote: > woul

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 517323. ivanmurashko added a comment. Windows constrains added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp clang/te

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3884 + nullptr, getOpts().getOption(options::OPT_dumpdir), + Args.MakeArgString(Args.getLastArgValue(options::OPT_o, "a") + "-")); + Arg->claim(); would be nice to have

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 517310. IncludeGuardian added a comment. Rebase on upstream to resolve conflicts in release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517300. chaitanyav added a comment. Revert to earliest patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added inline comments. Comment at: clang/lib/AST/DeclarationName.cpp:119-125 if (const RecordType *ClassRec = ClassType->getAs()) { -OS << *ClassRec->getDecl(); +ClassRec->getDecl()->printName(OS, Policy); return; } if (Policy.SuppressTemplateArgsInCXX

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane added a comment. In D149264#4299877 , @erichkeane wrote: > Creduced the new crash down to: > > template struct a; > template <> struct a { > template constexpr static c e(b, c) { > typename b ::f d; > } > }; > int h; >

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. In D147844#4299874 , @aaron.ballman wrote: > In D147844#4299856 , @chaitanyav > wrote: > >> Disable precedence conditional warning by default; Revert changes to test >> files > > I'm

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

ConchuOD added a comment. Perhaps redundant now that Palmer has commented, an opinion was solicited from me so here I am, pretty much copy-pasting from elsewhere: IMO, alignment with gcc is helpful, permissiveness is better. Given "canonical order" can, and has, change(d) in the past I think it'

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added a comment. @aaron.ballman If you could commit for me that would be great. Please use "Elliot Goodrich" for the name and "elliotgoodr...@gmail.com" for the email - thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D14792

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 517291. IncludeGuardian added a comment. Update Clang release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Lex/MultipleIncludeOpt

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

malavikasamak added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11786 + "%select{" +"unsafe operation on raw pointer in expression|" +"unsafe arithmetic on raw pointer|" NoQ wrote: > The first mode doesn't show up in any

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

palmer-dabbelt added a comment. IDK about the specifics here, but I think in general being more permissive on ISA string parsing is the way to go. The rules have changed so many times it's not really viable to follow them, so we're sort of just stuck with a bunch of historally-driven implement

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

myhsu added a comment. In D148094#4284316 , @barannikov88 wrote: > ping > Does the approach look right? This definitely improves the readability and potentially the compilation time. > Would it be better to put everything into cpp files and only expose

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane added a comment. Creduced the new crash down to: template struct a; template <> struct a { template constexpr static c e(b, c) { typename b ::f d; } }; int h; I'll end up having to look at it tomorrow, but it isn't clear how this patch broke that. CHANGES SI

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

aaron.ballman added a comment. In D147844#4299856 , @chaitanyav wrote: > Disable precedence conditional warning by default; Revert changes to test > files I'm sorry, I think there was a miscommunication. We were saying that we don't typically want off

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517268. chaitanyav added a comment. Disable precedence conditional warning by default; Revert changes to test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844

[clang] 7ec3f19 - Fix Clang sphinx bot

Author: Aaron Ballman Date: 2023-04-26T15:29:02-04:00 New Revision: 7ec3f19f851509ea3c46e651c9bfab8324b79133 URL: https://github.com/llvm/llvm-project/commit/7ec3f19f851509ea3c46e651c9bfab8324b79133 DIFF: https://github.com/llvm/llvm-project/commit/7ec3f19f851509ea3c46e651c9bfab8324b79133.diff

[PATCH] D149272: [clang] Call printName to get name of Decl

aaron.ballman added a comment. Thank you for working on this! Please be sure to add a release note and test coverage for the changes. Comment at: clang/lib/AST/DeclarationName.cpp:119-125 if (const RecordType *ClassRec = ClassType->getAs()) { -OS << *ClassRec->getDecl()

[PATCH] D147989: [clang] Fix Attribute Placement

This revision was automatically updated to reflect the committed changes. Closed by commit rGb893368fd4fd: Fix the diagnostic about attribute placement for scoped enumerations (authored by ipriyanshi1708, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D147989?vs

[clang] b893368 - Fix the diagnostic about attribute placement for scoped enumerations

Author: ipriyanshi1708 Date: 2023-04-26T15:18:40-04:00 New Revision: b893368fd4fdf40b7778df8d0b17312def1a8156 URL: https://github.com/llvm/llvm-project/commit/b893368fd4fdf40b7778df8d0b17312def1a8156 DIFF: https://github.com/llvm/llvm-project/commit/b893368fd4fdf40b7778df8d0b17312def1a8156.diff

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon updated this revision to Diff 517264. agozillon added a comment. - [Clang][OpenMP][IRBuilder] Run clang-format and tidy up files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.llvm.org/D149162 Files: clang/li

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added a comment. If this sort of check is deemed acceptable then I have plans for future improvements, including: 1. Automatically turning absl::StrFormat into fmt::format too (with an option to choose an alternative to `absl::StrFormat`.) 2. Detecting format strings that end in `"\n

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:360 (`#61336 `_) +- Fix parsing of `auto(x)`, when it is surrounded by parenthesese. Comment at: clang/include

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add FormatStringConve

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:43 +namespace { + gribozavr2 wrote: > mboehme wrote: > > There were a number of pre-existing declarations that w

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme updated this revision to Diff 517258. mboehme added a comment. Use anonymous namespace only for classes, `static` for functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149144/new/ https://reviews.llvm.org/D149144 Files: clang/incl

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4299722 , @aaron.ballman wrote: > LGTM! Do you need someone to land this on your behalf? If so, what name and > email address would you like used for patch attribution? Yes, I need someone who can commit it fo

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG951919e5112c: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHA

[clang] 951919e - [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

Author: Zarko Todorovski Date: 2023-04-26T14:55:14-04:00 New Revision: 951919e5112cabbd63c7a3bf424736efca81d964 URL: https://github.com/llvm/llvm-project/commit/951919e5112cabbd63c7a3bf424736efca81d964 DIFF: https://github.com/llvm/llvm-project/commit/951919e5112cabbd63c7a3bf424736efca81d964.di

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM assuming tests pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149210/new/ https://reviews.llvm.org/D149210

[PATCH] D147989: [clang] Fix Attribute Placement

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D149000: Update with warning message for comparison to NULL pointer

aaron.ballman added a comment. Precommit CI is still failing on test/SemaCXX/constant-expression-cxx2a.cpp with a false positive warning. You'll need to investigate why that's happening, but I suspect that the warning logic isn't aware that `dynamic_cast` can return null. Co

[PATCH] D149274: [NFC][Clang]Remove a reference on argument since 'Name' is not modified'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG739f5578c497: [NFC][Clang]Remove a reference on argument since 'Name' is not modified' (authored by mingmingl). Repository: rG LLVM Github Monorep

[clang] 739f557 - [NFC][Clang]Remove a reference on argument since 'Name' is not modified'

Author: Mingming Liu Date: 2023-04-26T11:21:34-07:00 New Revision: 739f5578c497a64f2127d2ec7c41f8efa514d0b9 URL: https://github.com/llvm/llvm-project/commit/739f5578c497a64f2127d2ec7c41f8efa514d0b9 DIFF: https://github.com/llvm/llvm-project/commit/739f5578c497a64f2127d2ec7c41f8efa514d0b9.diff

[PATCH] D149274: [NFC][Clang]Remove a reference on argument since 'Name' is not modified'

mingmingl added a comment. thanks for the quick reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149274/new/ https://reviews.llvm.org/D149274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 517250. ayzhao added a comment. add another test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/incl

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 517249. ayzhao added a comment. add another test and fix whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKi

[clang] 085a747 - Remove the empty analysis diagnostics file

Author: Aaron Ballman Date: 2023-04-26T14:18:22-04:00 New Revision: 085a747c364493198c0c8043372fd3b9f90cd07b URL: https://github.com/llvm/llvm-project/commit/085a747c364493198c0c8043372fd3b9f90cd07b DIFF: https://github.com/llvm/llvm-project/commit/085a747c364493198c0c8043372fd3b9f90cd07b.diff

[PATCH] D149274: [NFC][Clang]Remove a reference on argument since 'Name' is not modified'

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149274/new/ https://reviews.llvm.org/D149274

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517248. cor3ntin added a comment. Fix whitespace only changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst clang/include/cl

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. Allow auto(x) to appear in a parenthesis expression. The pattern (au

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5364-5368 if (const ConstantArrayType *CAT = S.getASTContext().getAsConstantArrayType(Entity.getType())) ArrayLength = CAT->getSize().getZExtValue(); else ArrayLength = Args

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 517246. ayzhao marked 5 inline comments as done. ayzhao added a comment. code review comments + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/i

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth added inline comments. Comment at: clang/test/Driver/clang_f_opts.c:144 +// RUN: %clang -### -S -fprofile-instr-use=%t.profdata -fdiagnostics-misexpect-tolerance=10 -Wmisexpect %s 2>&1 | FileCheck %s --check-prefix=CHECK-MISEXPECT-TOLLERANCE +// CHECK-MISEXPECT-TOLLER

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth updated this revision to Diff 517243. paulkirth marked an inline comment as done. paulkirth added a comment. Update test to check if the flag is in cc1, instead of just looking for a warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149123/new/ https://reviews.llvm.org/D149123 ___ cfe

[PATCH] D149274: [NFC][Clang]Remove a e reference on argument since 'Name' is not modified'

mingmingl created this revision. Herald added a project: All. mingmingl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D149274 Files: clang/lib/Basic/Targets/X86.cpp Inde

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

aaron.ballman added a comment. In D147844#4299418 , @chaitanyav wrote: > @aaron.ballman just for learning, can you point me to the code where a > warning is selectively enabled/disabled based on a flag. For e.g. > -Wunused-comparison Sure! This is han

  1   2   3   >