[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4257721 , @aaron.ballman wrote: > Thank you for working on this! > > The changes are missing test coverage; please be sure to add that, along with > a release note about the fix. I think there's likely more wor

[PATCH] D148410: [Parse] Remove TimeTraceScope for "ParseTemplate"

MaskRay created this revision. MaskRay added reviewers: clang, MaggieYi, aras-p, anton-afanasyev. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issues/56554

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

HerrCai0907 added a comment. > While this will fix the crash I am a little concerned that I don't a > diagnostic for each place we call ActOnParamDefaultArgumentError(...), there > is only once place where we diagnose this the rest don't. So I wonder if this > was purposeful or not. No, before

[PATCH] D148314: [clang-tidy][NFC] Improved hungarian notation regression test at post-commit review

dougpuob added a comment. In D148314#4268989 , @PiotrZSL wrote: > I will push into repository this in a moment @PiotrZSL, Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148314/new/ https://r

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

owenpan added a comment. In D146101#4268487 , @jp4a50 wrote: > Would appreciate someone committing for me. Can you rebase it? I got a conflict in ReleaseNotes.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

akyrtzi updated this revision to Diff 513828. akyrtzi added a comment. Remove `-optimize-args` from the test invocations since it's not relevant for the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148369/new/ https://reviews.llvm.org/D1483

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

philnik added a comment. In D141775#4256381 , @royjacobson wrote: > In D141775#4255923 , @philnik wrote: > >> Is this essentially "is_trivial_for_the_purposes_of_abi"? > > I'd say so. Are you asking for a potenti

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 513808. ayzhao added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao added inline comments. Comment at: clang/include/clang/Sema/Initialization.h:509 bool isImplicitMemberInitializer() const { -return getKind() == EK_Member && Variable.IsImplicitFieldInit; +return (getKind() == EK_Member || getKind() == EK_ParenAggInitMember) &&

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 513805. ayzhao marked 7 inline comments as done. ayzhao added a comment. Address code review comments and (try) to fix Windows bot failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://review

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

jsjodin added inline comments. Comment at: mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h:174 +if (offloadMod.getIsDevice()) { + hostIRFilePath = offloadMod.getHostIRFilePath(); +} agozillon wrote: > This will break the patch buildbo

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void added a comment. Note: This is a work-in-progress, so there's no need for a formal review, though any suggestions will definitely be appreciated. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

shafik added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134 "specifier in SFINAE context?"); -if (!hasReachableDefinition(PartialSpec)) +if (PartialSpec->hasDefinition() && +!h

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 513766. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

samitolvanen created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, ormris, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shi

[PATCH] D148260: [clang] Mark CWG2331 as N/A

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148260/new/ https://reviews.llvm.org/D148260 ___

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d0fab467efb: [Clang] Fix defaulted equality operator so that it does not attempt to compare… (authored by shafik). Herald added a project: clang. R

[clang] 6d0fab4 - [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

Author: Shafik Yaghmour Date: 2023-04-14T15:01:00-07:00 New Revision: 6d0fab467efbc7ce92bd890d9618259c4995ddcc URL: https://github.com/llvm/llvm-project/commit/6d0fab467efbc7ce92bd890d9618259c4995ddcc DIFF: https://github.com/llvm/llvm-project/commit/6d0fab467efbc7ce92bd890d9618259c4995ddcc.dif

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik updated this revision to Diff 513754. shafik added a comment. - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146329/new/ https://reviews.llvm.org/D146329 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/class/class.compare/

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 updated this revision to Diff 513753. zhuhan0 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148262/new/ https://reviews.llvm.org/D148262 Files: clang/lib/Basic/CMakeLists.txt llvm/cmake/modules/Genera

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 added inline comments. Comment at: llvm/cmake/modules/GenerateVersionFromVCS.cmake:50 +endif() +append_info(${name} "${${name}_SOURCE_DIR}" "" "") endif() drodriguez wrote: > I would recommend changing the flow a little bit: > > - Remove `path

[PATCH] D148383: [driver] Enable response file when using lld on baremetal targets

haowei created this revision. haowei added reviewers: mcgrathr, phosek. Herald added a subscriber: abidh. Herald added a project: All. haowei requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch enables response file support w

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 added inline comments. Comment at: llvm/cmake/modules/GenerateVersionFromVCS.cmake:23-25 +if(path) + get_source_info("${path}" revision repository) +endif() drodriguez wrote: > Nit: Looks like tabs were added? These are not tabs but spaces. T

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

shafik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5332 +if (Arg) + IS.Diagnose(S, SubEntity, SubKind, Arg); +else Do we have tests that trigger this diagnostic and the one right below? Comment at: cl

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

akyrtzi updated this revision to Diff 513751. akyrtzi added a comment. Make sure to check `FD` is valid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148369/new/ https://reviews.llvm.org/D148369 Files: clang/lib/Tooling/DependencyScanning/Modul

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

akyrtzi added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905 + if (BriefResult) { +llvm::outs() << "num modules: " << FD->getNumModules() << '\n'; +return HadErrors; jansvoboda11 wrote: > This assumes `FD` is not empty, i.

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void created this revision. void added reviewers: kees, nickdesaulniers. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a reviewer: aaron.ballman. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a su

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

shafik added inline comments. Comment at: clang/include/clang/Sema/Initialization.h:400 + static InitializedEntity InitializeMemberFromParenAggInit(FieldDecl *Member) { +return InitializedEntity(Member, nullptr, false, false, true); + }

[PATCH] D148377: [clang][dataflow] Drop optional model's dependency on libc++ internals.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Adjusts the matchers in the optional mode

[PATCH] D148200: [clang-format] Correctly indent comment above finalized PPDirective

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG293e4da32b1d: [clang-format] Correctly indent comment above finalized PPDirective (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[clang] 293e4da - [clang-format] Correctly indent comment above finalized PPDirective

Author: Owen Pan Date: 2023-04-14T13:58:38-07:00 New Revision: 293e4da32b1d823e63b2614e626bcd22649a8a15 URL: https://github.com/llvm/llvm-project/commit/293e4da32b1d823e63b2614e626bcd22649a8a15 DIFF: https://github.com/llvm/llvm-project/commit/293e4da32b1d823e63b2614e626bcd22649a8a15.diff LOG:

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

drodriguez requested changes to this revision. drodriguez added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/CMakeLists.txt:16 set(llvm_source_dir ${LLVM_MAIN_SRC_DIR}) endif() if(clang_vc AND LLVM_APPEND_VC_REV) ---

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

shafik added a comment. Thank you for the fix! While this will fix the crash I am a little concerned that I don't a diagnostic for each place we call `ActOnParamDefaultArgumentError(...)`, there is only once place where we diagnose this the rest don't. So I wonder if this was purposeful or not

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148344/new/ https://reviews.llvm.org/D148344 __

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added inline comments. Comment at: mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h:174 +if (offloadMod.getIsDevice()) { + hostIRFilePath = offloadMod.getHostIRFilePath(); +} This will break the patch buildbot unfortunately u

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

jansvoboda11 added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905 + if (BriefResult) { +llvm::outs() << "num modules: " << FD->getNumModules() << '\n'; +return HadErrors; This assumes `FD` is not empty, i.e. the `-format e

[PATCH] D119291: [Clang] Add support for STDC CX_LIMITED_RANGE pragma.

tahonermann resigned from this revision. tahonermann added a comment. Herald added a project: All. Resigning to remove this old review from my review queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119291/new/ https://reviews.llvm.org/D119291

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added a comment. In D145265#4225332 , @asbirlea wrote: > Nit: the diffs would be easier to analyze with "-fno-discard-value-names". done, see commit description the IR diffs look pretty good now, I'm not seeing any major regressions Repositor

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 513731. aeubanks edited the summary of this revision. aeubanks added a comment. fix clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files: clang/test/Co

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

ymandel updated this revision to Diff 513730. ymandel added a comment. tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148344/new/ https://reviews.llvm.org/D148344 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 513728. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files: llvm/lib/Passes/PassBuilderPipelines.cpp llvm/test/Feature/optnon

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:262 /// Returns true if and only if `Type` is an optional type. bool isOptionalType(QualType Type) { if (!Type->isRe

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

ymandel updated this revision to Diff 513727. ymandel added a comment. Improves the matcher and adds (missing) `std` qualifier to one of the names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148344/new/ https://reviews.llvm.org/D148344 Files:

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. A little unsure how to test this change on its own for Flang-new + OpenMP, as there currently isn't anything that utilises it upstream at the moment. It's part of the declare target work that I'm beginning to upstream, so eventually it'll be tested on the Flang side t

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

HerrCai0907 created this revision. HerrCai0907 added reviewers: aaron.ballman, cjdb. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed: https://github.com/llvm/llvm-project/issues/62122 This chan

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon created this revision. Herald added subscribers: bviyer, sunshaoce, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is particularly useful to avoid diverging the modules between a PCH and a translation-unit compilation. Repository:

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 513717. jrmolin marked 2 inline comments as done. jrmolin added a comment. there were a couple of bugs in the last patch that I missed. format tests all pass again with this one. I am using "Leave" as a transparent value, so no line breaks are added and none

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Just some minor issues in documentation. To be honest for me this check still looks too strict, for example it will warn when we capture `this` explicitly, and we don't use any class fields

[PATCH] D130665: [clang-tidy] Fix false negative in readability-convert-member-functions-to-static

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Looks good, release notes need to be corrected (order of checks) (even that it apply without conflicts) and could land. Test properly fail without fix. Repository: rG LLVM Github Monore

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:55 +AvoidByValueCaptureDefaultWhenCapturingThisCheck>( + "cppcoreguidelines-avoid-by-va

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp updated this revision to Diff 513705. carlosgalvezp added a comment. Shorten check name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148340/new/ https://reviews.llvm.org/D148340 Files: clang-tools-extra/clang-tidy/cppcoreguidelin

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 513694. PiotrZSL added a comment. Ping + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-too

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL updated this revision to Diff 513693. PiotrZSL added a comment. Ping + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt cl

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL updated this revision to Diff 513692. PiotrZSL added a comment. Ping + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146842/new/ https://reviews.llvm.org/D146842 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-ext

[PATCH] D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape

PiotrZSL updated this revision to Diff 513691. PiotrZSL added a comment. Ping + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145865/new/ https://reviews.llvm.org/D145865 Files: clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.c

[clang] 64ae766 - [Docs] Update ClangFormatStyleOptions.rst's versionbadge's to have min-width

Author: Shivam Gupta Date: 2023-04-14T23:57:26+05:30 New Revision: 64ae7669a7cefa12ea1117680cf9bfb5c3f6084c URL: https://github.com/llvm/llvm-project/commit/64ae7669a7cefa12ea1117680cf9bfb5c3f6084c DIFF: https://github.com/llvm/llvm-project/commit/64ae7669a7cefa12ea1117680cf9bfb5c3f6084c.diff

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. Any further comments @RKSimon ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.org/D143287 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

njames93 added a comment. For what its worth, there typically isn't any performance gain using `\n` over `std::endl` when writing to `std::cerr` or `std::clog` (or their wide string counterparts) as every write operation on those implicitly calls flush. However If the fix was changed to convert

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:413-414 + // Including the path to the just-built libc++.dylib if libc++ is bootstrapped + // and /bin/../lib/libc++.dylib is a valid path + I would reword this to: ``` // If

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Thanks for working on this! This generally LGTM, with a few comments. You should be able to add tests in a way similar to `clang/test/Driver/darwin-header-search-libcxx.cpp`. The i

[PATCH] D148354: [clang-tidy][NFC] Remove reference to Visual studio native plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2919f8f49ab: [clang-tidy][NFC] Remove reference to Visual studio native plugin (authored by sousajo, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D148314: [clang-tidy][NFC] Improved hungarian notation regression test at post-commit review

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f3995c051fc: [clang-tidy][NFC] Improved hungarian notation regression test at post-commit… (authored by dougpuob, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rG5abe338f2a7f: [clang-tidy] Fix false positve for defaulted move constructor in performance… (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang-tools-extra] e2919f8 - [clang-tidy][NFC] Remove reference to Visual studio native plugin

Author: Jorge Pinto Sousa Date: 2023-04-14T17:43:37Z New Revision: e2919f8f49abfd2fa493aeaf4f4a99be1c2bdaae URL: https://github.com/llvm/llvm-project/commit/e2919f8f49abfd2fa493aeaf4f4a99be1c2bdaae DIFF: https://github.com/llvm/llvm-project/commit/e2919f8f49abfd2fa493aeaf4f4a99be1c2bdaae.diff

[clang-tools-extra] 9f3995c - [clang-tidy][NFC] Improved hungarian notation regression test at post-commit review

Author: Douglas Chen Date: 2023-04-14T17:43:37Z New Revision: 9f3995c051fcbacea4efcea5016943917ff3c400 URL: https://github.com/llvm/llvm-project/commit/9f3995c051fcbacea4efcea5016943917ff3c400 DIFF: https://github.com/llvm/llvm-project/commit/9f3995c051fcbacea4efcea5016943917ff3c400.diff LOG:

[clang-tools-extra] 5abe338 - [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

Author: AMS21 Date: 2023-04-14T17:43:37Z New Revision: 5abe338f2a7f6f99708bd268419de6fb6e3da9e3 URL: https://github.com/llvm/llvm-project/commit/5abe338f2a7f6f99708bd268419de6fb6e3da9e3 DIFF: https://github.com/llvm/llvm-project/commit/5abe338f2a7f6f99708bd268419de6fb6e3da9e3.diff LOG: [clang-

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL added a reviewer: carlosgalvezp. PiotrZSL added a comment. I'm pushing this as it looks fine, and I don't see any reason to block this. @carlosgalvezp Fell free to look into this in some free time if you see any bugs/issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 513672. Leporacanthicus added a comment. Remove unnecessary braces in if-statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/cla

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

efriedma added a comment. Please don't upload reviews for followup patches on top of the original patch; it confuses the history of happened when. But sure, looks fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143813/new/ https://reviews.llvm.org/D143813

[PATCH] D148354: [clang-tidy][NFC] Remove reference to Visual studio native plugin

sousajo added a comment. In D148354#4269013 , @PiotrZSL wrote: > I see you uploaded this path without author attached, should I push this as > "Jorge Pinto Sousa " ? Yes please do thanks :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148354/

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

njames93 updated this revision to Diff 513669. njames93 added a comment. Updated to work on all special member functions as long as they aren't trivial Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147808/new/ https://reviews.llvm.org/D147808 File

[PATCH] D148354: [clang-tidy][NFC] Remove reference to Visual studio native plugin

PiotrZSL added a comment. I see you uploaded this path without author attached, should I push this as "Jorge Pinto Sousa " ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148354/new/ https://reviews.llvm.org/D148354 ___ cfe-commits mailing l

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:55 +AvoidByValueCaptureDefaultWhenCapturingThisCheck>( + "cppcoreguidelines-avoid-by-value-capture-default-when-capturing-this"); Check

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:262 /// Returns true if and only if `Type` is an optional type. bool isOptionalType(QualType Type) { if (!Type->isRecordType()) ymandel wrote

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:262 /// Returns true if and only if `Type` is an optional type. bool isOptionalType(QualType Type) { if (!Type->isRecordType()) xazax.hun wro

[PATCH] D148314: [clang-tidy][NFC] Improved hungarian notation regression test at post-commit review

PiotrZSL accepted this revision. PiotrZSL added a comment. I will push into repository this in a moment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148314/new/ https://reviews.llvm.org/D148314 ___

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy created this revision. donat.nagy added reviewers: steakhal, NoQ, gamesh411, Szelethus. donat.nagy added a project: clang-tools-extra. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a proje

[PATCH] D148354: [clang-tidy] Remove reference to Visual studio native plugin

PiotrZSL added a comment. LGTM, as I undestand you don't have commit access, i will push this... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148354/new/ https://reviews.llvm.org/D148354 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

njames93 added a comment. In D147808#4268523 , @kadircet wrote: > there's actually a slight difference between an inline defaulted special > member function and an out-of-line defaulted one. the latter makes the > special member "user-defined" which mig

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:262 /// Returns true if and only if `Type` is an optional type. bool isOptionalType(QualType Type) { if (!Type->isRecordType()) Why do we n

[PATCH] D148354: [clang-tidy] Remove reference to Visual studio native plugin

sousajo created this revision. sousajo added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. sousajo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe

[PATCH] D148314: [clang-tidy][NFC] Improved hungarian notation regression test at post-commit review

dougpuob marked an inline comment as done. dougpuob added a comment. In D148314#4268460 , @PiotrZSL wrote: > Change in tests is ok, change in release notes not needed (please remove). > Change title into [clang-tidy][NFC] Improved ... > > NFC - Non Functi

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

dougpuob updated this revision to Diff 513648. dougpuob added a comment. - Removed unnecessary information from ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148314/new/ https://reviews.llvm.org/D148314 Files: clang-tools-extra

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Just going to rip out llvm::StringView. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148181/new/ https://reviews.llvm.org/D148181 __

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rG2eb9cc76a6c0: [clangd] Handle destructors in DefineOutline tweak (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D147802?vs=511780&id=513644#toc Repository: rG LLVM Github M

[clang-tools-extra] 2eb9cc7 - [clangd] Handle destructors in DefineOutline tweak

Author: Nathan James Date: 2023-04-14T17:51:45+01:00 New Revision: 2eb9cc76a6c0b61fcf75b747258e27b7b7683ca1 URL: https://github.com/llvm/llvm-project/commit/2eb9cc76a6c0b61fcf75b747258e27b7b7683ca1 DIFF: https://github.com/llvm/llvm-project/commit/2eb9cc76a6c0b61fcf75b747258e27b7b7683ca1.diff

[PATCH] D78644: [LSan] Enable for SystemZ

MaskRay added a comment. In D78644#4268685 , @iii wrote: > I guess the intention is dropping the special case? The following patch > passes regtests: > > --- a/compiler-rt/lib/lsan/lsan_allocator.h > +++ b/compiler-rt/lib/lsan/lsan_allocator.h > @@

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

foad added a comment. In D147732#4268661 , @rampitec wrote: > In D147732#4267553 , @foad wrote: > >> Changing the existing intrinsics to use type mangling could break clients >> like LLPC and Mesa. I've put up a

[PATCH] D78644: [LSan] Enable for SystemZ

iii added a comment. I guess the intention is dropping the special case? The following patch passes regtests: --- a/compiler-rt/lib/lsan/lsan_allocator.h +++ b/compiler-rt/lib/lsan/lsan_allocator.h @@ -68,9 +68,6 @@ using PrimaryAllocator = PrimaryAllocatorASVT; # if SANITIZER_FUCHSIA

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

rampitec added a comment. In D147732#4267553 , @foad wrote: > Changing the existing intrinsics to use type mangling could break clients > like LLPC and Mesa. I've put up a patch for LLPC to protect it against this > change: https://github.com/GPUOpen-Dr

[PATCH] D78644: [LSan] Enable for SystemZ

iii added a comment. That's where the mappings normally end. Example: $ cat /proc/self/maps 2aa-2aa2000 r--p 5e:01 668061 /usr/bin/cat 2aa2000-2aa6000 r-xp 2000 5e:01 668061 /usr/bin/cat 2aa6000-2aa8000

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin marked 4 inline comments as done. jrmolin added inline comments. Comment at: clang/lib/Format/Format.cpp:1336 LLVMStyle.AlwaysBreakAfterDefinitionReturnType = FormatStyle::DRTBS_None; + LLVMStyle.AlwaysBreakBeforeFunctionParameters = false; LLVMStyle.AlwaysBreakBef

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 513610. jrmolin added a comment. changing the added option from a boolean to an enum that takes `Leave`, `Always`, and `Never`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.or

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path::Style::native hans wrote: > Won't the code above (line 5

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 513611. zequanwu added a comment. Added clang-cl option test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 Files: clang/include/clang/Basic/LangOptions.h clan

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

kadircet added a comment. there's actually a slight difference between an inline defaulted special member function and an out-of-line defaulted one. the latter makes the special member "user-defined" which might cause various headaches (e.g. type is no longer "trivial"). i don't think we should

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:186-194 + if (const auto *Destructor = llvm::dyn_cast(FD)) { +if (auto Err = Declarati

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added a comment. Commit details as follows as per other diffs: Name: Jon Phillips Email: jonap2...@gmail.com Would appreciate someone committing for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D14

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 513599. TIFitis added a comment. Updated to use opaque pointers, removed BitCast Insts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGO

  1   2   >