[PATCH] D147165: [Windows SEH] Fix catch+return crash for Windows -EHa

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cc66f3c779b: [Windows SEH] Fix catch+return crash for Windows -EHa (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147165/new/ https:/

[clang] 0cc66f3 - [Windows SEH] Fix catch+return crash for Windows -EHa

Author: Phoebe Wang Date: 2023-04-01T14:53:33+08:00 New Revision: 0cc66f3c779b80a199d692fa84f7ed8d29373d1c URL: https://github.com/llvm/llvm-project/commit/0cc66f3c779b80a199d692fa84f7ed8d29373d1c DIFF: https://github.com/llvm/llvm-project/commit/0cc66f3c779b80a199d692fa84f7ed8d29373d1c.diff L

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 510186. Krishna-13-cyber added a comment. - Updated diff with `git clang-format HEAD~1` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146376 Files: clang/lib/Se

[PATCH] D147369: [clang][Interp] Support empty initlist initializers for complex types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder updated this revision to Diff 510180. tbaeder added a comment. Screw it, just use a `llvm::function_ref`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCode

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added a comment. Does `git clang-format HEAD~1` not work on your system? It should only format the changed parts, not everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146376 _

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 510168. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Headers/CMa

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510167. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Inter

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:99 + unless(isExpansionInSystemHeader()), argumentCountIs(1U), + IgnoreDependentExpresions + ? expr(unless(isInstantiationDependent

[PATCH] D147365: [HIPSPV] Remove useIntegratedAs. NFC

jhuber6 added a comment. I don't know the toolchain, does `HIPSPV` perform as expected if you pass `-fno-integrated-as`? The difference is that `useIntegratedAs` forces it to always be enabled so the user can't change it AFAIK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147365: [HIPSPV] Remove useIntegratedAs. NFC

brad created this revision. brad added reviewers: jhuber6, ronlieb. brad added a project: clang. Herald added a subscriber: yaxunl. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. useIntegratedAs() is enabled if IsIntegratedAssem

[PATCH] D147328: [clang-format] Handle enum in Verilog

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1712 break; - // This only applies for C++. - if (!Style.isCpp()) { + // This only applies for C++ and Verilog. + if (!Style.isCpp() &&

[clang] 4d7e516 - [OHOS] Remove redundant IsIntegratedAssemblerDefault. NFC

Author: Brad Smith Date: 2023-03-31T20:27:29-04:00 New Revision: 4d7e5163d96758516c4838f05bfaa481d63179e1 URL: https://github.com/llvm/llvm-project/commit/4d7e5163d96758516c4838f05bfaa481d63179e1 DIFF: https://github.com/llvm/llvm-project/commit/4d7e5163d96758516c4838f05bfaa481d63179e1.diff LO

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:949 + /// If unset, ``ContinuationIndentWidth`` is used. + /// \code + /// AlignAfterOpenBracket: AlwaysBreak HazardyKnusperkeks wrote: > jp4a50 wrote: > > MyDeveloperDay wrote: >

[PATCH] D147111: [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG253985d58caf: [clang-format] Add MinDigits suboptions to IntegerLi

[clang] 253985d - [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

Author: Owen Pan Date: 2023-03-31T17:14:33-07:00 New Revision: 253985d58caf95db8a84632d5a761b96fb7cd7d6 URL: https://github.com/llvm/llvm-project/commit/253985d58caf95db8a84632d5a761b96fb7cd7d6 DIFF: https://github.com/llvm/llvm-project/commit/253985d58caf95db8a84632d5a761b96fb7cd7d6.diff LOG:

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @rsmith - thanks a lot for the review, is there anything you'd like me to do on this diff or we are good to go ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 __

[PATCH] D147121: [hwasan] remove requirment for PIE

vitalybuka removed a reviewer: alekseyshl. vitalybuka added 1 blocking reviewer(s): eugenis. vitalybuka accepted this revision. vitalybuka added a comment. This revision now requires review to proceed. I don't know why HWASAN may required pie, but @eugenis seems confident on D44745

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base, sizeof(base)) : 0; + } else { tkuchta wrote: > browneee wrote: > > `base, sizeof(base

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a42a7b4e873: [clang-format] Don't misannotate left squares as lambda introducers (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[clang] 2a42a7b - [clang-format] Don't misannotate left squares as lambda introducers

Author: Owen Pan Date: 2023-03-31T16:13:03-07:00 New Revision: 2a42a7b4e87395ae2a4321292f0fd9dce401b4e1 URL: https://github.com/llvm/llvm-project/commit/2a42a7b4e87395ae2a4321292f0fd9dce401b4e1 DIFF: https://github.com/llvm/llvm-project/commit/2a42a7b4e87395ae2a4321292f0fd9dce401b4e1.diff LOG:

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

owenpan added a comment. In D147295#4235648 , @rymiel wrote: > This is great! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147295/new/ https://reviews.llvm.org/D147295 __

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba6e747f9b05: [clang] Set ShowInSystemHeader for module-build and module-import remarks (authored by kastiglione). Repository: rG LLVM Github Mono

[clang] ba6e747 - [clang] Set ShowInSystemHeader for module-build and module-import remarks

Author: Dave Lee Date: 2023-03-31T15:56:09-07:00 New Revision: ba6e747f9b05e541e88822e1dbd6bd5424cfe2fb URL: https://github.com/llvm/llvm-project/commit/ba6e747f9b05e541e88822e1dbd6bd5424cfe2fb DIFF: https://github.com/llvm/llvm-project/commit/ba6e747f9b05e541e88822e1dbd6bd5424cfe2fb.diff LOG:

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione updated this revision to Diff 510141. kastiglione added a comment. minor cleanup of test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139653/new/ https://reviews.llvm.org/D139653 Files: clang/include/clang/Basic/DiagnosticFrontendKi

[PATCH] D147360: [AArch64] Add IR intrinsic for vbsl*

pranavk created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pranavk requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione updated this revision to Diff 510138. kastiglione added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139653/new/ https://reviews.llvm.org/D139653 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td cl

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Ok, you right. Fix all open issues, and update commit message to be more detailed. Except that, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 added a comment. In D147315#4236403 , @PiotrZSL wrote: > Add test with scoped enums, to validate that it works correctly. > In theory this change should suport them also. scoped enum not support to visit by member. `EnumName::` is needed for

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jplehr added a comment. In D140722#4219182 , @nextsilicon-itay-bookstein wrote: > Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test. > > @jdoerfert Does the PR CI run these, or are there build bots that cover the > different target-offloading v

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL marked an inline comment as done. PiotrZSL added a comment. I will leave this review open for 1 more week, in case someone have some comments, and by someone I mean you @carlosgalvezp. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:98 +

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base, sizeof(base)) : 0; + } else { browneee wrote: > `base, sizeof(base)` does not make sen

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL updated this revision to Diff 510132. PiotrZSL added a comment. Fix doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp cla

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL added a comment. There are 37 findings in llvm repository: 1. clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:96:12: warning: conversion from 'std::optional' into 'bool' and back into 'std::optional', remove potentially error-prone optional dereference [bugprone-optional-value-convers

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/optional-value-conversion.rst:46 +expressions that match the methods. +Default value is `"::value$;::get$`. Unintended quote in value. Repository: rG

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter accepted this revision. ccotter added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:98 + callExpr( + unless(isExpansionInSystemHeader()), argumentCountIs(1

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects potentially uni

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

cjdb abandoned this revision. cjdb added a comment. In D147288#4237413 , @royjacobson wrote: > There was some discussion of this last year in this review: > https://reviews.llvm.org/D128750 > > It's such an edge case that I don't think we should lose sl

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 510108. dkrupp added a comment. This is a totally rewritten version of the patch which solely relies on the existing "interestingness" utility to track back the taint propagation. (And does not introduce a new FlowID in the ProgramState as requested in the

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:4185 + /// For Verilog, put each port on its own line in module instantiations. + ///

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:949 + /// If unset, ``ContinuationIndentWidth`` is used. + /// \code + /// AlignAfterOpenBracket: AlwaysBreak jp4a50 wrote: > MyDeveloperDay wrote: > > did you check ge

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

royjacobson added a comment. There was some discussion of this last year in this review: https://reviews.llvm.org/D128750 It's such an edge case that I don't think we should lose sleep about it until/unless the committee finds time to clarify the issue. Repository: rG LLVM Github Monorepo

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

maryammo added a comment. It looks good to me, just added a minor question as I was not able to verify that. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector") +TARGET_BUILTIN(__builtin_altive

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman updated this revision to Diff 510099. aaron.ballman added a comment. Oops, previous diff missed a change that was only locally staged. Fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147349/new/ https://reviews.llvm.org/D147349 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, efriedma, erichkeane, cor3ntin, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This implements support for allowing `{}` to consistently z

[PATCH] D144603: Disable compiler launcher on external projects and multi stage clang

fangism added a comment. What's the current status of this changeset? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144603/new/ https://reviews.llvm.org/D144603 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

amyk added a comment. Overall looks OK to me, as well. I just had two questions that I wanted to ask. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector") +TARGET_BUILTIN(__builtin_altivec_vcmpne

[clang] 43825d1 - Revert "[Assignment Tracking] Enable by default"

Author: Haowei Wu Date: 2023-03-31T11:27:18-07:00 New Revision: 43825d19318695be48abe6f042369da00fbb808b URL: https://github.com/llvm/llvm-project/commit/43825d19318695be48abe6f042369da00fbb808b DIFF: https://github.com/llvm/llvm-project/commit/43825d19318695be48abe6f042369da00fbb808b.diff LOG

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

stefanp added a comment. Overall I think that this looks fine to me as well. I had a couple of minor comments and you may decide that you don't need to do either one so if that's the case just mention why in a comment and I will approve the patch. Comment at: clang/include/cl

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aprantl added a comment. I think `debug_trampoline` both captures the semantics and makes it clear that this is related to debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 _

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added a comment. Fragmented this patch into https://reviews.llvm.org/D147344 (lowering) and https://reviews.llvm.org/D147324 (driver/tool changes and application of attribute). I will keep this patch open until the others are closed to give a big picture for easier reference. Reposi

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. In D147256#4237099 , @probinson wrote: > I think we cannot be 100% sure about source paths in a cross-compile > situation. Cross-compiling on platform A targeting platform B does not mean > your sources and debugger UI are on platf

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added a comment. We're getting really close! Yes, that build error looks unrelated. Someone should fix it soon. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base, sizeof(base

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon updated this revision to Diff 510080. agozillon added a comment. - Add FIR -> LLVM Dialect test here, more fitting than the other patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147324/new/ https://reviews.llvm.org/D147324 Files: c

[PATCH] D146987: [Assignment Tracking] Enable by default

haowei added a comment. This patch (which enables assignment tracking) and D147312 breaks llvm runtime build for `runtimes-armv7-unknown-linux-gnueabihf` Error message: FAILED: libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o /b/s/w/ir/cache/goma/clie

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

ymandel accepted this revision. ymandel added a comment. Thank you! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:465 + /// referenced in `FuncDecl`. `FuncDecl` must have a body. + void initVars(const FunctionDecl *FuncDecl);

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

probinson added subscribers: debug-info, probinson. probinson added a comment. I think we cannot be 100% sure about source paths in a cross-compile situation. Cross-compiling on platform A targeting platform B does not mean your sources and debugger UI are on platform B. My users keep source and

[PATCH] D147282: [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG758bca648385: [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 758bca6 - [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules

Author: Ben Langmuir Date: 2023-03-31T09:43:22-07:00 New Revision: 758bca6483853a743297b68bd88a5dba9d5247f2 URL: https://github.com/llvm/llvm-project/commit/758bca6483853a743297b68bd88a5dba9d5247f2 DIFF: https://github.com/llvm/llvm-project/commit/758bca6483853a743297b68bd88a5dba9d5247f2.diff

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

cjdb added a comment. Thanks so much for seeing this through; I'm unusually looking forward to rebuilding LLVM this weekend! Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:82 + +.. option:: OverloadedOperators +

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4236522 , @hans wrote: > Thanks for working on this! > > The `-ffile-reproducible` flag name refers to making `#file` directives > reproducible, but `LangOptions.UseTargetPathSeparator` sounds a lot broader > :) I do

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 510057. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 Files: clang/include

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 510056. krzysz00 edited the summary of this revision. krzysz00 added a comment. Per discussion on the s.buffer.load revision, don't make those changes, and so revert this patch back to what it used to be. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

PiotrZSL abandoned this revision. PiotrZSL added a comment. Obsolete by D144522 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107294/new/ https://reviews.llvm.org/D107294 _

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

PiotrZSL abandoned this revision. PiotrZSL added a comment. Obsolete by D144522 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31308/new/ https://reviews.llvm.org/D31308 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] a084854 - [clang-tidy] Add readability-operators-representation check

Author: Piotr Zegar Date: 2023-03-31T16:07:16Z New Revision: a084854266ca60748982228a4c98d036bca5f762 URL: https://github.com/llvm/llvm-project/commit/a084854266ca60748982228a4c98d036bca5f762 DIFF: https://github.com/llvm/llvm-project/commit/a084854266ca60748982228a4c98d036bca5f762.diff LOG: [

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

This revision was automatically updated to reflect the committed changes. Closed by commit rGa084854266ca: [clang-tidy] Add readability-operators-representation check (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D144522?vs=508310&id=510055#toc Repository: rG LLVM

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added a comment. there is a strange build error which seems unrelated to my change - please let me know if that's an issue, I will try to rebase to newest master then CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 ___

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:100 +// used `StorageLocation` subclasses and make them use a `BumpPtrAllocat

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:465 + /// referenced in `FuncDecl`. `FuncDecl` must have a body. + void initVars(const FunctionDecl *FuncDecl); I wonder if we should rename this to

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510047. tkuchta added a comment. Updates after the review of strsep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_custom.cpp compiler-rt/lib/dfsan/done_abilist.txt

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510041. tkuchta marked an inline comment as done. tkuchta added a comment. Hello, I applied the review comments for strsep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/df

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510042. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Incl

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:264 +- Improved :doc:`readability-static-accessed-through-instance + ` check to Please keep alphabetical order (by check name) in this section. Repository: rG LLVM G

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/XRefs.cpp:1348 + auto Loc = SM.getFileLoc(Ref.RefLocation); + for (const auto &H : Providers) { +auto MatchingIncludes = ConvertedMainFileIncludes.match(H);

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:37 +// LINK: "-bforceimprw" +// LTO_ROPTR: "-bplugin_opt:-mxcoff-roptr" +// NO_ROPTR-NOT: "-mxcoff-roptr" qiongsiwu1 wrote: > hubert.reinterpretcast wrote: > > This needs the backend opti

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510039. VitaNuo added a comment. Rename function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clan

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

sstwcw updated this revision to Diff 510038. sstwcw added a comment. Generate doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147327/new/ https://reviews.llvm.org/D147327 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Form

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510036. VitaNuo added a comment. Remove extra formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added a comment. Could I get a re-review on this one please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D147329: [clang-format] Handle Verilog struct literals

sstwcw created this revision. Herald added subscribers: cfe-commits, ctetreau. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Previously `isVerilogIdentifier` was mistaking the

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510032. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Incl

[PATCH] D147328: [clang-format] Handle enum in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Verilog has enum just like C. Repository: rG LLVM Github

[PATCH] D147327: [clang-format] Add option for having one port on a line in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated Re

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The deduplicated code is moved into initVars().

[PATCH] D147325: Implement cross reference request for #include lines.

VitaNuo abandoned this revision. VitaNuo added a comment. Erroneously created patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147325/new/ https://reviews.llvm.org/D147325 ___ cfe-commits mailing lis

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510027. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-to

[PATCH] D147325: Implement cross reference request for #include lines.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG943ef0642010: [clang][Interp] Check This pointer without creating InterpFrame (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[clang] 943ef06 - [clang][Interp] Check This pointer without creating InterpFrame

Author: Timm Bäder Date: 2023-03-31T16:18:15+02:00 New Revision: 943ef06420105cad23e3caea24d6a274cdb0316f URL: https://github.com/llvm/llvm-project/commit/943ef06420105cad23e3caea24d6a274cdb0316f DIFF: https://github.com/llvm/llvm-project/commit/943ef06420105cad23e3caea24d6a274cdb0316f.diff LO

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon added a comment. The flag addition and FlagsAttr generation component of: https://reviews.llvm.org/D145264 the LLVM-IR generation will come in a subsequent phabricator patch once I have created some additional tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon created this revision. Herald added subscribers: sunshaoce, bzcheeseman, rriddle, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a reviewer: kiranchandramohan. Herald added projects: Flang, All. agozillon requested review of this re

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 510022. jp4a50 added a comment. Alphabetical ordering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Rel

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL added a comment. @carlosgalvezp Thank you, by any chance would you be able to look into other reviews ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 ___

[PATCH] D142448: [clang][Interp] Handle TypeTraitExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d2899acbcf1: [clang][Interp] Handle TypeTraitExprs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 8d2899a - [clang][Interp] Handle TypeTraitExprs

Author: Timm Bäder Date: 2023-03-31T15:54:44+02:00 New Revision: 8d2899acbcf1b8ce120bc219aeb30207d4422042 URL: https://github.com/llvm/llvm-project/commit/8d2899acbcf1b8ce120bc219aeb30207d4422042 DIFF: https://github.com/llvm/llvm-project/commit/8d2899acbcf1b8ce120bc219aeb30207d4422042.diff LO

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510017. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 9 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:119 + + std::unique_ptr GenModule(); + v.g.vassilev wrote: > We should not need this interface. `Interpreter::CompileDecl` needs it

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510014. junaire added a comment. Address more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/inclu

  1   2   >