[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These methods provide a less verbose way of allo

[clang] 068e0e0 - [clang][Interp][NFC] Add failing test case for InterpFrame::describe()

Author: Timm Bäder Date: 2023-03-31T08:32:42+02:00 New Revision: 068e0e001d63a76fcec0cb585ffe8832794115eb URL: https://github.com/llvm/llvm-project/commit/068e0e001d63a76fcec0cb585ffe8832794115eb DIFF: https://github.com/llvm/llvm-project/commit/068e0e001d63a76fcec0cb585ffe8832794115eb.diff LO

[clang] e9b150c - [clang][Interp][NFC] Add missing static_assert message

Author: Timm Bäder Date: 2023-03-31T08:22:34+02:00 New Revision: e9b150c2d9bb856f371d201d9968b504e12d98a3 URL: https://github.com/llvm/llvm-project/commit/e9b150c2d9bb856f371d201d9968b504e12d98a3 DIFF: https://github.com/llvm/llvm-project/commit/e9b150c2d9bb856f371d201d9968b504e12d98a3.diff LO

[PATCH] D147165: [Windows SEH] Fix catch+return crash for Windows -EHa

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, pls wait for 1 or 2 days in case there are comments from others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147165/new/ https://re

[PATCH] D109693: Driver: Remove major release version detection for RHEL

tstellar updated this revision to Diff 509912. tstellar added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Rebase and fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109693/new/ https://reviews.llvm.org/

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:45-49 +const auto *ProtoType = Decl->getType()->castAs(); +const Expr *NoexceptExpr = ProtoType->getNoexceptExpr(); +if (NoexceptExpr) { + Noexcept

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509911. AMS21 marked 3 inline comments as done. AMS21 added a comment. Fixed docs and cleanup tests a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files: clang

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 509910. alexander-shaposhnikov added a comment. Rebased + rerun all the tests + internal testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfce093ccb1c5: [clang][Interp] Fix parameter map when re-visiting function (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org

[clang] fce093c - [clang][Interp] Fix parameter map when re-visiting function

Author: Timm Bäder Date: 2023-03-31T08:06:06+02:00 New Revision: fce093ccb1c56b57bc26c47b47e2a0388953a27f URL: https://github.com/llvm/llvm-project/commit/fce093ccb1c56b57bc26c47b47e2a0388953a27f DIFF: https://github.com/llvm/llvm-project/commit/fce093ccb1c56b57bc26c47b47e2a0388953a27f.diff LO

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30f96a8fb451: [clang][Interp] Properly identify not-yet-defined functions (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 30f96a8 - [clang][Interp] Properly identify not-yet-defined functions

Author: Timm Bäder Date: 2023-03-31T07:27:04+02:00 New Revision: 30f96a8fb4511bed31a75863d4abec51c3d967a8 URL: https://github.com/llvm/llvm-project/commit/30f96a8fb4511bed31a75863d4abec51c3d967a8 DIFF: https://github.com/llvm/llvm-project/commit/30f96a8fb4511bed31a75863d4abec51c3d967a8.diff LO

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

MaskRay added a comment. Created a GCC feature request: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109349 The subject and summary should be fixed and `-march=help` references should be removed. Comment at: clang/lib/Driver/Driver.cpp:4236 + +// Use the -march=help flag

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper added a comment. There no backend tests in this patch. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:19625 if ((ICEArguments & (1 << i)) == 0) { Ops.push_back(EmitScalarExpr(E->getArg(i))); continue; Need to force ICEArguments for

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Aliasing `-march=help` to `--print-supported-extensions` looks weird. I think this patch should remove `-march=help`. Comment at: clang/test/Driver/print-support

[PATCH] D147281: Stop modifying trailing return types.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. Thanks! It looks much better indeed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147281/new/ https://reviews.llvm.org/D147281 ___ cfe-commit

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. This is great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147295/new/ https://reviews.llvm.org/D147295 _

[PATCH] D146947: [docs][clang] Add extra information inside -fsanitize=unsigned-shift-base for UndefinedBehaviorSanitizer

This revision was automatically updated to reflect the committed changes. Closed by commit rG9eccc145aa95: [docs][clang] Add extra information inside -fsanitize=unsigned-shift-base for… (authored by aabhinavg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 9eccc14 - [docs][clang] Add extra information inside -fsanitize=unsigned-shift-base for UndefinedBehaviorSanitizer

Author: aabhinavg Date: 2023-03-31T09:35:15+05:30 New Revision: 9eccc145aa957e56846f1587e543eb6310a404ae URL: https://github.com/llvm/llvm-project/commit/9eccc145aa957e56846f1587e543eb6310a404ae DIFF: https://github.com/llvm/llvm-project/commit/9eccc145aa957e56846f1587e543eb6310a404ae.diff LOG

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChain.cpp:638 + AddPath({getOSLibName(), llvm::Triple::getArchTypeName(getArch())}); + + return Paths; unneeded blan

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

owenpan added a comment. See https://reviews.llvm.org/D147295. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121584/new/ https://reviews.llvm.org/D121584 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. owenpan requested review of this revision. A left square can start a lambda only if it's not preceded by an i

[PATCH] D146947: [docs][clang] Add extra information inside -fsanitize=unsigned-shift-base for UndefinedBehaviorSanitizer

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146947/new/ https://reviews.llvm.org/D146947 __

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:158-159 + callee(cxxMethodDecl(BeginNameMatcher))), + callExpr(argumentCountIs(1), + call

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 509874. ccotter marked 3 inline comments as done. ccotter added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-t

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

cjdb added a comment. I'm going to keep this CL open till someone comments, but after reading the relevant GCC bug , I'm not sure it's worth committing anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

cjdb created this revision. cjdb added reviewers: erichkeane, aaron.ballman, shafik. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Issue #61857 identifies that there are some edge cases that aren't accoun

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 509860. HerrCai0907 marked an inline comment as done. HerrCai0907 added a comment. refactor some code and add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/ https://reviews.llvm.org/

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 added a comment. In D146595#4235333 , @aprantl wrote: > I hope I'm not kicking off a long bike-shedding thread, but I would propose > to either call the attribute `transparent` to match the DWARF attribute name, > or if we want to be more de

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145088/new/ https://reviews.llvm.org/D145088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aprantl added a comment. I hope I'm not kicking off a long bike-shedding thread, but I would propose to either call the attribute `transparent` to match the DWARF attribute name, or if we want to be more descriptive, `debug_transparent`, or `transparentdebug` to fit better with other attributes

[clang] bc62fb9 - Ignore constraints when determining a canonical template parameter.

Author: Richard Smith Date: 2023-03-30T17:00:16-07:00 New Revision: bc62fb9e1779043ba4ffa75bb2133cc670d4105c URL: https://github.com/llvm/llvm-project/commit/bc62fb9e1779043ba4ffa75bb2133cc670d4105c DIFF: https://github.com/llvm/llvm-project/commit/bc62fb9e1779043ba4ffa75bb2133cc670d4105c.diff

[clang] 3524a9f - Retain constraints in the canonical form of an auto type.

Author: Richard Smith Date: 2023-03-30T17:00:16-07:00 New Revision: 3524a9f84a0a1a106aa649a775066ba4d9e8ae0d URL: https://github.com/llvm/llvm-project/commit/3524a9f84a0a1a106aa649a775066ba4d9e8ae0d DIFF: https://github.com/llvm/llvm-project/commit/3524a9f84a0a1a106aa649a775066ba4d9e8ae0d.diff

[clang] fe73233 - Convert boolean flag in TemplateParameterListsAreEqual into an

Author: Richard Smith Date: 2023-03-30T17:00:16-07:00 New Revision: fe73233b3a8b7b9dbb457419b494200503ffd34a URL: https://github.com/llvm/llvm-project/commit/fe73233b3a8b7b9dbb457419b494200503ffd34a DIFF: https://github.com/llvm/llvm-project/commit/fe73233b3a8b7b9dbb457419b494200503ffd34a.diff

[clang] e3cba2f - Clean up template parameter list profiling. No functionality change.

Author: Richard Smith Date: 2023-03-30T17:00:16-07:00 New Revision: e3cba2f464d318213ba05361e635e9b3b862e174 URL: https://github.com/llvm/llvm-project/commit/e3cba2f464d318213ba05361e635e9b3b862e174 DIFF: https://github.com/llvm/llvm-project/commit/e3cba2f464d318213ba05361e635e9b3b862e174.diff

[clang] a07abe2 - Factor out helper to determine whether a function is a "member-like

Author: Richard Smith Date: 2023-03-30T17:00:16-07:00 New Revision: a07abe27b4d1d39ebb940a7f4e6235302444cbf0 URL: https://github.com/llvm/llvm-project/commit/a07abe27b4d1d39ebb940a7f4e6235302444cbf0 DIFF: https://github.com/llvm/llvm-project/commit/a07abe27b4d1d39ebb940a7f4e6235302444cbf0.diff

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 marked 3 inline comments as done. HerrCai0907 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:49 const LangOptions &LangOpts) { // FIXME: This logic breaks when there is a c

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

shafik added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:3315 Builder.Alignment, Builder.Alignment, CharUnits::Zero(), Builder.PrimaryBase, false, Builder.SharedVBPtrBase, + Builder.EndsWithZeroSizedObject, Builder.LeadsWithZe

[clang] 96a7e05 - [RISCV] Add Zicsr and Zifencei to CPUs in RISCVProcessors.td.

Author: Craig Topper Date: 2023-03-30T15:55:38-07:00 New Revision: 96a7e057567d37e7c65cfce00430ad383a1b URL: https://github.com/llvm/llvm-project/commit/96a7e057567d37e7c65cfce00430ad383a1b DIFF: https://github.com/llvm/llvm-project/commit/96a7e057567d37e7c65cfce00430ad383a1b.diff

[PATCH] D147261: [RISCV] Add Zicsr and Zifencei to CPUs in RISCVProcessors.td.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96a7e057567d: [RISCV] Add Zicsr and Zifencei to CPUs in RISCVProcessors.td. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. In D137327#4234463 , @thieta wrote: > This was released in LLVM 16.0.0. The prior behaviour was there before, it’s marked in GitHub as a regression, can you please revert, we’ll mark the issue to be cherry picked, then le

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 ___

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. I like both @owenpan suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D147281: Stop modifying trailing return types.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think this makes sense to me, so LGTM. But please give @ChuanqiXu a chance to look/ask questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D147068: Fix merging of member-like constrained friends across modules.

erichkeane added a comment. In D147068#4235155 , @rsmith wrote: > Hm, looks like rGdb1b827ecfed6 > landed > the actual functioal change here, making this just a no-functional-change

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak created this revision. ahatanak added reviewers: rsmith, aaron.ballman. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a bug where namespace scopes were being searched before template parameter scopes. Delay searching

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added inline comments. Comment at: clang/include/clang/Driver/Options.td:2692 def fno_openmp_assume_teams_oversubscription : Flag<["-"], "fno-openmp-assume-teams-oversubscription">, - Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; + Group, Flags<[CC1Option

[PATCH] D147282: [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules

benlangmuir created this revision. benlangmuir added reviewers: akyrtzi, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When not performing codegen, we can strip the coverage-data-file

[PATCH] D147068: Fix merging of member-like constrained friends across modules.

rsmith added a comment. Hm, looks like rGdb1b827ecfed6 landed the actual functioal change here, making this just a no-functional-change refactoring plus an added test, so I'm going to go ahead and land it. Repository: rG

[PATCH] D147281: Stop modifying trailing return types.

rsmith created this revision. rsmith added reviewers: erichkeane, ChuanqiXu. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change reverts the functional change from D144626

[PATCH] D147179: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc90af501f00: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version (authored by craig.topper). Repository: rG LLVM Github Monor

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon updated this revision to Diff 509837. agozillon added a comment. Squash commits, format and apply requested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145264/new/ https://reviews.llvm.org/D145264 Files: clang/include/clang/D

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG7df3c71b508b: [clang] Fix 2 bugs with parenthesized aggregate initialization (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/

[clang] 7df3c71 - [clang] Fix 2 bugs with parenthesized aggregate initialization

Author: Alan Zhao Date: 2023-03-30T15:06:37-07:00 New Revision: 7df3c71b508b65284483225685f1ba19777f2bbb URL: https://github.com/llvm/llvm-project/commit/7df3c71b508b65284483225685f1ba19777f2bbb DIFF: https://github.com/llvm/llvm-project/commit/7df3c71b508b65284483225685f1ba19777f2bbb.diff LOG

[PATCH] D147279: [HeterogeneousDWARF] Implement AMDGPU CFI, DebugInfo

scott.linder created this revision. Herald added subscribers: kosarev, foad, kerbowa, arphaman, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, emaste, arsenm, qcolombet, MatzeB. Herald added a project: All. scott.linder requested review of this revision. Herald added subscribers: llvm-commi

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6704 +}; +const FunctionDecl *PrimaryX = TryToGetPrimaryTemplatedFunction(FuncX); +const FunctionDecl *PrimaryY = TryToGetPrimaryTemplatedFunction(FuncY); If this is necessary here

[PATCH] D147068: Fix merging of member-like constrained friends across modules.

rsmith updated this revision to Diff 509818. rsmith added a comment. - Merge branch 'main' into merge-constrained-friends Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147068/new/ https://reviews.llvm.org/D147068 Files: clang/docs/ReleaseNotes.r

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc73ef0031b5: PR60985: Fix merging of lambda closure types across modules. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org

[clang] bc73ef0 - PR60985: Fix merging of lambda closure types across modules.

Author: Richard Smith Date: 2023-03-30T14:22:40-07:00 New Revision: bc73ef0031b50f7443615fef614fb4ecaaa4bd11 URL: https://github.com/llvm/llvm-project/commit/bc73ef0031b50f7443615fef614fb4ecaaa4bd11 DIFF: https://github.com/llvm/llvm-project/commit/bc73ef0031b50f7443615fef614fb4ecaaa4bd11.diff

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

shafik accepted this revision. shafik added a comment. LGTM, thank for adding the tests! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 ___ cfe-commits mailing

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 added a comment. @aaron.ballman @dblaikie I've changed the patch to introduce a more general "transparent_stepping" attribute, which doesn't take in a string (similar to what David suggested), please take a look and let me know what you think. Repository: rG LLVM Github Monorepo

[PATCH] D147179: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version

craig.topper updated this revision to Diff 509812. craig.topper added a comment. Updated release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147179/new/ https://reviews.llvm.org/D147179 Files: clang/test/CodeGen/RISCV/rvv-intrinsics-hand

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 509811. paulkirth added a comment. Remove blank lines added to test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerArgs.cp

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 updated this revision to Diff 509810. augusto2112 added a comment. Updating to "transparent_stepping" attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/include/clang/Bas

[PATCH] D147037: [Clang][ICE] Corrected invalid invalid parameter index on some attributes with invalid indices applied to varargs functions

shafik added a comment. For the benefit of those who have not seen the bug report: https://github.com/llvm/llvm-project/issues/61635 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147037/new/ https://reviews.llvm.org/D147037 __

[PATCH] D147037: [Clang][ICE] Corrected invalid invalid parameter index on some attributes with invalid indices applied to varargs functions

shafik added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3764-3767 if (!checkFunctionOrMethodParameterIndex(S, D, AL, 1, IdxExpr, Idx)) return; - + if (Idx.getASTIndex() >= getFunctionOrMethodNumParams(D)) +return; tbaeder wrote: > e

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

owenpan added a comment. In D147176#4232702 , @MyDeveloperDay wrote: > I can auto add us as all as reviewers if you'd like? This means if the title > contains `[clang-format]` or it impacts a file path of /clang/lib/Format it > should in theory run th

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 509802. zequanwu added a comment. Add test case from https://github.com/llvm/llvm-project/issues/45481#issuecomment-981028897. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.or

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

pranavk created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pranavk requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. VBSL intrinsics can be found here: https://developer.

[PATCH] D144511: [Clang] Fix how ReadMacroParameterList handles comments in macro parameter-list when in -CC mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20a3fb9740dd: [Clang] Fix how ReadMacroParameterList handles comments in macro parameter-list… (authored by shafik). Herald added a project: clang. H

[clang] 20a3fb9 - [Clang] Fix how ReadMacroParameterList handles comments in macro parameter-list when in -CC mode

Author: Shafik Yaghmour Date: 2023-03-30T13:37:21-07:00 New Revision: 20a3fb9740ddadc61fbc8bc76836935d1a408d83 URL: https://github.com/llvm/llvm-project/commit/20a3fb9740ddadc61fbc8bc76836935d1a408d83 DIFF: https://github.com/llvm/llvm-project/commit/20a3fb9740ddadc61fbc8bc76836935d1a408d83.dif

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 __

[PATCH] D147261: [RISCV] Add Zicsr and Zifencei to CPUs in RISCVProcessors.td.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. I also understand that Rocket and SCR-1 support zicsr and zifencei in all standard configurations (and their respective repos seem to confirm this). Repository: rG LLVM Github Monorepo CHA

[PATCH] D147263: Fix an assertion failure in unwrapSugar

ahatanak created this revision. ahatanak added reviewers: mizvekov, arphaman, fahad. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. An assertion in `Qualifiers::addObjCLifetime` fails when the ObjC lifetime bits are already set. Instead

[PATCH] D147179: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks (though see minor note about tweaking commit message to clarify the change). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147179/new/ h

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik added a comment. gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

owenpan added a comment. In D146101#4233535 , @jp4a50 wrote: > Broadly speaking, these include aggregate initialization and list > initialization (possibly direct initialization with braces too). See the > initialization

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine &moduleName) { +buf[task].first = moduleName.str(); return std::make_unique( int3 wrote: > Any reason why this doesn't instead store the module n

[PATCH] D147261: [RISCV] Add Zicsr and Zifencei to CPUs in RISCVProcessors.td.

craig.topper created this revision. craig.topper added reviewers: reames, asb, kito-cheng, jrtc27, philipp.tomsich, dnpetrov-sc. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, t

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

owenpan added a comment. In D137327#4233551 , @thieta wrote: > In D137327#4233290 , > @MyDeveloperDay wrote: > >> because of https://github.com/llvm/llvm-project/issues/61785 should this >> really be reverted?

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/Inputs/concat-nested-namespaces/modernize-concat-nested-namespaces.h:8 // CHECK-FIXES: void t(); -// CHECK-FIXES-NEXT: } // namespace nn1 +// CHECK-FIXES-NEXT: } // namespace nn2 --

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

PiotrZSL added a comment. You changed half of this check logic, please take a look into those issues for this check: https://github.com/llvm/llvm-project/issues/60051 https://github.com/llvm/llvm-project/issues/60048 https://github.com/llvm/llvm-project/issues/60035 https://github.com/llvm/llvm-p

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

owenpan added a comment. In D137327#4234463 , @thieta wrote: > This was released in LLVM 16.0.0. I think we should revert it in 16.0.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://re

[PATCH] D136103: OpenMP asynchronous memory copy support

This revision was automatically updated to reflect the committed changes. Closed by commit rG4753a4e31169: [OpenMP] asynchronous memory copy support (authored by jz10, committed by jplehr). Changed prior to commit: https://reviews.llvm.org/D136103?vs=509583&id=509775#toc Repository: rG LLVM

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu created this revision. zequanwu added reviewers: hans, aaron.ballman, ayzhao, aganea. Herald added a subscriber: hiraditya. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Thi

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. This was released in LLVM 16.0.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

HazardyKnusperkeks added a comment. In D137327#4233652 , @MyDeveloperDay wrote: > In D137327#4233551 , @thieta wrote: > >> In D137327#4233290 , >> @MyDeveloperDay wrote:

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert accepted this revision. jdoerfert added a comment. LG Comment at: openmp/libomptarget/src/api.cpp:386 + // Need to check this first to not return OFFLOAD_FAIL instead + if (!(Dst || Src)) { +DP("Call to omp_target_memcpy_rect returns max supported dimensions %d\

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

HazardyKnusperkeks added a comment. In D121584#4233165 , @carlosgalvezp wrote: > In D121584#3404704 , @curdeius > wrote: > >> Yes, let's revert this. I should have a fix soon though. > > @curdeius Did you manage

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 509761. krzysz00 edited the summary of this revision. krzysz00 added a comment. Rebase for splitting s.buffer.load effect change into earlier patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ htt

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

HazardyKnusperkeks added a comment. In D147176#4232633 , @MyDeveloperDay wrote: > Honestly these developers are pretty much 'OGs' , I'm happy to tidy up after > them if they don't quite follow our current conventions. Obviously at any > point you can

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

HazardyKnusperkeks added a comment. In D146101#4233535 , @jp4a50 wrote: > So at the risk of adding to the number of decisions we need to come to a > consensus on, I was about to update the KJ style guide to explicitly call out > the difference in indent

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

This revision was automatically updated to reflect the committed changes. Closed by commit rGa590d8634308: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments… (authored by chaitanyav). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] a590d86 - [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

Author: NagaChaitanya Vellanki Date: 2023-03-30T11:36:16-07:00 New Revision: a590d8634308aadc96e71c8dbbcbd4348f2efd1d URL: https://github.com/llvm/llvm-project/commit/a590d8634308aadc96e71c8dbbcbd4348f2efd1d DIFF: https://github.com/llvm/llvm-project/commit/a590d8634308aadc96e71c8dbbcbd4348f2ef

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

shafik added a comment. In D147073#4228290 , @zequanwu wrote: > I'm trying to add the test case from: > https://github.com/llvm/llvm-project/issues/45481#issuecomment-981028897, but > lit test fails in `` not found. You can just define your own `strong

[clang] e00a8d0 - Fix codegen for coroutine with function-try-block

Author: Matthias Braun Date: 2023-03-30T11:16:32-07:00 New Revision: e00a8d081d789cac606cf0749c332c4632132820 URL: https://github.com/llvm/llvm-project/commit/e00a8d081d789cac606cf0749c332c4632132820 DIFF: https://github.com/llvm/llvm-project/commit/e00a8d081d789cac606cf0749c332c4632132820.diff

[PATCH] D146758: Fix codegen for coroutine with function-try-block

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe00a8d081d78: Fix codegen for coroutine with function-try-block (authored by MatzeB). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3b919a5e01ef: [clang-tidy] Fix example provided by add_new_check.py (authored by PiotrZSL). Repository: rG LLVM Github

[clang-tools-extra] 3b919a5 - [clang-tidy] Fix example provided by add_new_check.py

Author: Piotr Zegar Date: 2023-03-30T18:15:29Z New Revision: 3b919a5e01ef35caa24fe3a4ccc3dd459e56449b URL: https://github.com/llvm/llvm-project/commit/3b919a5e01ef35caa24fe3a4ccc3dd459e56449b DIFF: https://github.com/llvm/llvm-project/commit/3b919a5e01ef35caa24fe3a4ccc3dd459e56449b.diff LOG: [

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt = S.getBody(); + CompoundStmt *Body = dyn_cast(BodyStmt); + if (Body == nullptr) { +Body = +CompoundStmt::Create(getContext(), {BodyStmt}, FPOpt

  1   2   3   >