[PATCH] D144707: [C++20] [Modules] Deprecate to load C++20 Named Modules eagerly

ChuanqiXu updated this revision to Diff 500662. ChuanqiXu added a comment. Don't emit the warning if we're compiling a .pcm file directly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144707/new/ https://reviews.llvm.org/D144707 Files: clang/include/clang/Basic/DiagnosticSerializati

[PATCH] D144802: clang: Add __builtin_elementwise_round

python3kgae added inline comments. Comment at: clang/docs/LanguageExtensions.rst:646 direction. + T __builtin_elementwise_round(T x) round x to the nearest integer value in floating point format, floating point types +

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cc91f977eaa: [Clang] Copy strictfp attribute from pattern to instantiation (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new

[clang] 5cc91f9 - [Clang] Copy strictfp attribute from pattern to instantiation

Author: Serge Pavlov Date: 2023-02-27T11:19:20+07:00 New Revision: 5cc91f977eaa0b0947ff1cf2a52ea6bc4479081d URL: https://github.com/llvm/llvm-project/commit/5cc91f977eaa0b0947ff1cf2a52ea6bc4479081d DIFF: https://github.com/llvm/llvm-project/commit/5cc91f977eaa0b0947ff1cf2a52ea6bc4479081d.diff

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 abandoned this revision. ym1813382441 added a comment. RISC-V International seem to have indicated they'd add new named extensions rather than add instructions to an existing extension in the future. Related discussions at D115921 Repository: rG

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

ChuanqiXu added a comment. In D144626#4150378 , @erichkeane wrote: > That looks reasonable to me, though I fear all the libcxx failures are going > to be related to this, please make sure to check them out! I tested locally that the libcxx failures are

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added a comment. Thanks for the name suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 ___ cfe-commit

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 500648. ccotter marked an inline comment as done. ccotter added a comment. - More clean option name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-too

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:142 +///e = end(container); it != e; ++it) { ... } +/// for (containerType::iterator it = std::begin(container), +///e = std::end(container); it != e; ++it) {

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 500647. ccotter added a comment. - Add comment regarding std::begin/end Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/moderniz

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter added a comment. Bump - anyone else have any thoughts here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 500645. ccotter added a comment. - Add more cases to swapped params Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files: clang-tools-extra/clang-tidy/bugprone/Str

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked 2 inline comments as done. ccotter added a comment. I'm not sure about the false positive case. Range based for loops reduce to calls to ADL lookup begin/end (or member function calls to begin/end). I believe the same "false positive" argument (whatever that may be) would apply i

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked 3 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:175 +callee(cxxMethodDecl(EndNameMatcher))), + callExpr(argumentCountIs(1), callee(functionDecl(EndNameMat

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:24 + unsigned Minor; + bool operator==(const RISCVExtensionVersion &Vers) const { +return this->Major == Vers.Major && this->Minor == Vers.Minor; eopXD wrote: > ym18133

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 500642. ccotter marked an inline comment as done. ccotter added a comment. - Add negative test case - Fix logic to only consider std:: or ADL calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ http

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 500638. bryanpkc edited the summary of this revision. bryanpkc added a comment. Fix some bugs in the range checks of immediate operands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://review

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

LuoYuanke added a comment. > Deal. And because I am on busy for a long time and it is also better to let > intel guy handle x86-related feature, I am happy with the patch being > commandeered. @nikic's proposal looks a promising solution, we can investigate more about it. Repository: rG LLV

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 500630. bryanpkc added a comment. Moved test case `acle_target_sme.c` into `clang/test/Sema/aarch64-sme-intrinsics/`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/Bu

[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

mstorsjo added inline comments. Comment at: llvm/lib/Support/Windows/Signals.inc:834 + int RetCode = (int)EP->ExceptionRecord->ExceptionCode; + if (RetCode == (0xE000 | EX_IOERR)) +return; erichkeane wrote: > aganea wrote: > > erichkeane wrote: > > > Th

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

owenpan added a comment. Should we revert this patch? Comment at: clang/unittests/Format/FormatTest.cpp:5175 verifyFormat("#pragma omp threadprivate( \\\n" - "y)), // expected-warning", + "y)), // expected-warning", get

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

This revision was automatically updated to reflect the committed changes. Closed by commit rG0303eafcb346: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer` (authored by isuckatcs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/ne

[clang-tools-extra] 0303eaf - [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

Author: isuckatcs Date: 2023-02-26T23:18:13+01:00 New Revision: 0303eafcb34647f7d5a4015aad266b5766f5dc5e URL: https://github.com/llvm/llvm-project/commit/0303eafcb34647f7d5a4015aad266b5766f5dc5e DIFF: https://github.com/llvm/llvm-project/commit/0303eafcb34647f7d5a4015aad266b5766f5dc5e.diff LOG

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 500620. DmitryPolukhin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D144709: [clang-format] Improve left to right const

HazardyKnusperkeks added a comment. In D144709#4151546 , @AlexanderHederstaf wrote: >> Highlight by me. That is not acceptable, running the output of >> `clang-format` through `clang-format` shall not result in any change. In >> that case it's better t

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 500601. ccotter added a comment. - fix bad merge in ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopC

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 500598. ccotter marked 2 inline comments as done. ccotter added a comment. - Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-ext

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:318 +// The returned Expr* is nullptr if any of the assumptions are not met. +static const std::tuple +getContainerExpr(const Expr *Call) { carlosgalvezp wrote:

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In [1], a few new insns are proposed to exgend BPF ISA t

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

vabridgers added a comment. Patch D144622 should be integrated into this one when a reduced reproducer has been prepared as a unittest and/or LIT case. I verified the patch stack D144273 , D140562

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

vabridgers added a comment. This patch needs a unit test (as @balazske mentioned). So far, the case we have is too large to be a suitable unittest or lit case - so requires reduction. @balazske , will you be adding this as a unittest or lit case? Also, I think this patch needs to be integrated

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

vabridgers added a comment. I tested this change in the cases that previously failed for us, and this patch addresses our problems. It would be good to note in the commit header that this patch is intended to fix the problem first described by review D136886 .

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

PiotrZSL added a comment. In short, better support like this than lack of suport. Consider adding option for disabling those free standing functions, reason why I'm telling this is that in case of false-positives, it may be easier just to disable part of functionality than disabling entire check

[clang] 19f74c9 - [Driver][OpenBSD] Simplify command-line option handling. NFC

Author: Brad Smith Date: 2023-02-26T10:48:37-05:00 New Revision: 19f74c911246e6bd13acdfbbd69c58ebdd79012d URL: https://github.com/llvm/llvm-project/commit/19f74c911246e6bd13acdfbbd69c58ebdd79012d DIFF: https://github.com/llvm/llvm-project/commit/19f74c911246e6bd13acdfbbd69c58ebdd79012d.diff LO

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

bryanpkc added a comment. @sdesmalen @rsandifo-arm @aaron.ballman @erichkeane What is the plan for this patch? Is it going to be abandoned in favor of D139028 , or can it be landed in its current form after addressing all outstanding review comments? Reposito

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 500578. bryanpkc added a comment. Removed `EltTypeBool128` as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/BuiltinsN

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:319 + */ + size_t Size; + /** The type is `size_t` instead of the agreed upon `unsigned`, because the addition of `unsigned GlobalOptions` below means that `unsigned Size` no longer redu

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7dac52203a0: [clang-tidy] Improved too-small-loop-variable with bit-field support (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1425

[clang-tools-extra] c7dac52 - [clang-tidy] Improved too-small-loop-variable with bit-field support

Author: Piotr Zegar Date: 2023-02-26T14:54:36Z New Revision: c7dac52203a0c056bfcb35735e62c37a64e50bfa URL: https://github.com/llvm/llvm-project/commit/c7dac52203a0c056bfcb35735e62c37a64e50bfa DIFF: https://github.com/llvm/llvm-project/commit/c7dac52203a0c056bfcb35735e62c37a64e50bfa.diff LOG: [

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:79 +Opts.PreambleStoragePath = NULL; +Opts.InvocationEmissionPath = getenv("CINDEXTEST_INVOCATION_EMISSION_PATH"); + When a libclang user needs to override a single option i

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

eopXD added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:24 + unsigned Minor; + bool operator==(const RISCVExtensionVersion &Vers) const { +return this->Major == Vers.Major && this->Minor == Vers.Minor; ym1813382441 wrote: > eopXD w

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

brad updated this revision to Diff 500553. brad added a comment. Missing header part of diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144823/new/ https://reviews.llvm.org/D144823 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Driver/To

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy updated this revision to Diff 500552. vedgy retitled this revision from "[libclang] Add API to set preferred temp dir path" to "[libclang] Add API to override preamble storage path". vedgy edited the summary of this revision. vedgy added a comment. Reimplement the API as discussed in review

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

RKSimon added a comment. In D143287#4150186 , @ManuelJBrito wrote: > There are some performance regressions with casts from 128 to 512. The > backend inserts vinsertf instructions. So that has to be fixed. > In D130339

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

vedgy updated this revision to Diff 500551. vedgy added a comment. Rebase on latest main branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143415/new/ https://reviews.llvm.org/D143415 Files: clang/unittests/libclang/LibclangTest.cpp clang/u

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 500547. Mordante added a comment. Rebased to test CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.txt c

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

brad created this revision. brad added reviewers: dim, emaste. brad added a project: clang. Herald added subscribers: hiraditya, kristof.beyls, krytarowski, arichardson. Herald added a project: All. brad requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald adde

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson added a comment. In D143851#4153270 , @carlosgalvezp wrote: > LGTM, thanks for the contribution! Do you have commit rights or would you > like that we land it for you? If so, please provide name and email for > attribution. I have commit r

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa56e66bf752: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor… (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang-tools-extra] aa56e66 - [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

Author: Roy Jacobson Date: 2023-02-26T15:55:54+02:00 New Revision: aa56e66bf7520512fd1209cbb7d099604a5f6277 URL: https://github.com/llvm/llvm-project/commit/aa56e66bf7520512fd1209cbb7d099604a5f6277 DIFF: https://github.com/llvm/llvm-project/commit/aa56e66bf7520512fd1209cbb7d099604a5f6277.diff

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142587/new/ https://reviews.llvm.org/D142587

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb2d04d41e47: [clangd] Hide inlay hints when using a macro as a calling argument that with a… (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] cb2d04d - [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

Author: Younan Zhang Date: 2023-02-26T19:06:44+08:00 New Revision: cb2d04d41e47e65812434f775215247bfe19b3dd URL: https://github.com/llvm/llvm-project/commit/cb2d04d41e47e65812434f775215247bfe19b3dd DIFF: https://github.com/llvm/llvm-project/commit/cb2d04d41e47e65812434f775215247bfe19b3dd.diff

[PATCH] D144594: [clang-tidy] Fix bugprone-copy-constructor-init documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGe168964ce1fb: [clang-tidy] Fix bugprone-copy-constructor-init documentation (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144594/new/

[clang-tools-extra] e168964 - [clang-tidy] Fix bugprone-copy-constructor-init documentation

Author: Piotr Zegar Date: 2023-02-26T08:58:04Z New Revision: e168964ce1fb3747746afcc46817eeb6706df6ed URL: https://github.com/llvm/llvm-project/commit/e168964ce1fb3747746afcc46817eeb6706df6ed DIFF: https://github.com/llvm/llvm-project/commit/e168964ce1fb3747746afcc46817eeb6706df6ed.diff LOG: [

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

PiotrZSL updated this revision to Diff 500523. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Review comments fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142587/new/ https://reviews.llvm.org/D142587 Files: clang-tools

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

carlosgalvezp added a comment. Looks good, thanks! Please document change in the Release Notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144594: [clang-tidy] Fix bugprone-copy-constructor-init documentation

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Great improvement, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144594/new/ https://reviews.llvm.org/D144594 ___

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

carlosgalvezp added a comment. LGTM, minor comments. I'm not familiar with the implementation so I'm not very confident reviewing it, would be good to get some more expert eyes on it. Tests look solid! Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:31

[PATCH] D144790: [clang-tidy] readability-identifier-naming.HungarianNotation: rename CharPrinter to CharPointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG00a71cb47c36: [clang-tidy] readability-identifier-naming.HungarianNotation: rename… (authored by amurzeau, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 00a71cb - [clang-tidy] readability-identifier-naming.HungarianNotation: rename CharPrinter to CharPointer

Author: Alexis Murzeau Date: 2023-02-26T08:22:56Z New Revision: 00a71cb47c36984dcd9f51492e1e831aec0e0460 URL: https://github.com/llvm/llvm-project/commit/00a71cb47c36984dcd9f51492e1e831aec0e0460 DIFF: https://github.com/llvm/llvm-project/commit/00a71cb47c36984dcd9f51492e1e831aec0e0460.diff LOG

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the contribution! Do you have commit rights or would you like that we land it for you? If so, please provide name and email for attribution. Repository: rG LL