[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDriverOptTa

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

carlosgalvezp added a comment. Please document fix in the Release Notes, as people might have adopted to the buggy behavior and should know they need to change to the proper one. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hunga

[PATCH] D144422: [clang-tidy] update docs for new hungarian identifier-naming types (unsigned char and void)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc43f7107e29: [clang-tidy] update docs for new hungarian identifier-naming types (unsigned… (authored by amurzeau, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang-tools-extra] dc43f71 - [clang-tidy] update docs for new hungarian identifier-naming types (unsigned char and void)

Author: Alexis Murzeau Date: 2023-02-21T07:37:42Z New Revision: dc43f7107e2916035b3503a10977182b03203046 URL: https://github.com/llvm/llvm-project/commit/dc43f7107e2916035b3503a10977182b03203046 DIFF: https://github.com/llvm/llvm-project/commit/dc43f7107e2916035b3503a10977182b03203046.diff LOG

[PATCH] D144317: [clang-format] Fix handling of TypeScript tuples with optional last member

taymonbeal added a comment. Can anyone please commit this? I don't have commit access. Thanks. Name: Taymon A. Beal Email: tay...@google.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144317/new/ https://reviews.llvm.org/D144317 __

[PATCH] D144447: [Clang] Teach buildFMulAdd to peek through fneg to find fmul.

craig.topper created this revision. craig.topper added reviewers: efriedma, aaron.ballman, andrew.w.kaylor, kpn, spatel, uweigand. Herald added a subscriber: StephenFan. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. Allows us to handle

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:45 +template +void never_moves_param_template(Obj&& o, T t) { + // CHECK-MESSAGES: :[[@LINE-1]]:33: warning: rvalue reference parameter

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked 4 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:45 +template +void never_moves_param_template(Obj&& o, T t) { + // CHECK-MESSAGES: :[[@LINE-1]

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. > If you add std::move you will get compilation error, if you add std::forward, everything will work fine. Simply Value& and && will evaluate to Value&, no rvalue reference here. I agree that examining the template definition alone is not correct. In your original ex

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3896 + if (D->hasAttrs()) +ToField->setAttrs(D->getAttrs()); ToField->setAccess(D->getAccess()); balazske wrote: > The import of attributes is handled in function `ASTImporter::Impor

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 499034. ccotter added a comment. - Ignore params of template type - Add option for unnamed params Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

brad updated this revision to Diff 499018. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 Files: clang/lib/Driver/ToolChains/Arch/PPC.cpp llvm/include/llvm/TargetParser/Triple.h llvm/lib/Target/Power

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

brad created this revision. brad added a reviewer: nemanjai. brad added a project: LLVM. Herald added subscribers: steven.zhang, shchenz, kbarton, hiraditya. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project:

[PATCH] D144341: [Driver][FreeBSD] Correct usage of --hash-style=both with triple without version

brad updated this revision to Diff 498980. Herald added a subscriber: fedor.sergeev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144341/new/ https://reviews.llvm.org/D144341 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang/test/Driver/cons

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

xazax.hun added a comment. Overall, I like the structure of this patch and the references back to the standard. But every time we compare type pointers, they might compare inequal when one of the types have sugar on it while the other does not. Please review all of those comparisons to see wher

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b09cb2b16eb: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI (authored by brad). Repository: rG LLVM Github Monorepo CHANGE

[clang] 4b09cb2 - [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

Author: Brad Smith Date: 2023-02-20T18:11:24-05:00 New Revision: 4b09cb2b16ebac179264b2bf5d99d19f363f24b8 URL: https://github.com/llvm/llvm-project/commit/4b09cb2b16ebac179264b2bf5d99d19f363f24b8 DIFF: https://github.com/llvm/llvm-project/commit/4b09cb2b16ebac179264b2bf5d99d19f363f24b8.diff LO

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a pr

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL added a comment. PiotrZSL published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commit

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498944. elmcdonough added a comment. Clang format + documentation update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/clang/Basic/Diagno

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. @nridge @kadircet please take another look, all tests now pass. As for the location of inserting driver mode please see my previous comment about MSVC CL check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/n

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. @aganea You can find my current changes on my D115103 branch . I am using the currently failing `use_stacks.cpp` test. Something like this should make debugging of this issue possible: > cd llvm-project

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2665 +if (Style.isVerilog() && Precedence == prec::Comma && +VerilogFirstOfType != nullptr) { + addFakeParenthesis(VerilogFirstOfType, prec::Comma); owenpan

[PATCH] D144422: [clang-tidy] update docs for new hungarian identifier-naming types (unsigned char and void)

amurzeau added a comment. I don't have commit access to the repo, so please commit this for me when accepted. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144422/new/ https://reviews.llvm.org/D144422 _

[PATCH] D144422: [clang-tidy] update docs for new hungarian identifier-naming types (unsigned char and void)

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscri

[PATCH] D115103: Leak Sanitizer port to Windows

aganea added a comment. @clemenswasser We hit this once in a while, when Microsoft update their libraries. But I'm surprised about the CC at the beginning. How can this issue be reproduced? Can you show a disassembly dump from the VS debugger, around the address of the function that fails? CH

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG997dc7e00f49: [debug-info][codegen] Prevent creation of self-referential SP node (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHAN

[clang] 997dc7e - [debug-info][codegen] Prevent creation of self-referential SP node

Author: Felipe de Azevedo Piovezan Date: 2023-02-20T14:22:49-05:00 New Revision: 997dc7e00f49663b60a78e18df1dfecdf62a4172 URL: https://github.com/llvm/llvm-project/commit/997dc7e00f49663b60a78e18df1dfecdf62a4172 DIFF: https://github.com/llvm/llvm-project/commit/997dc7e00f49663b60a78e18df1dfecdf

[PATCH] D144041: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void)

This revision was automatically updated to reflect the committed changes. Closed by commit rG37e6a4f9496c: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char… (authored by amurzeau, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang-tools-extra] 37e6a4f - [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void)

Author: Alexis Murzeau Date: 2023-02-20T19:18:51Z New Revision: 37e6a4f9496c8e35efc654d7619a79d6dbb72f99 URL: https://github.com/llvm/llvm-project/commit/37e6a4f9496c8e35efc654d7619a79d6dbb72f99 DIFF: https://github.com/llvm/llvm-project/commit/37e6a4f9496c8e35efc654d7619a79d6dbb72f99.diff LOG

[PATCH] D144037: [clang-tidy] allow tests to use --config-file instead of --config

This revision was automatically updated to reflect the committed changes. Closed by commit rG38b1a17c519d: [clang-tidy] allow tests to use --config-file instead of --config (authored by amurzeau, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang-tools-extra] 38b1a17 - [clang-tidy] allow tests to use --config-file instead of --config

Author: Alexis Murzeau Date: 2023-02-20T19:06:45Z New Revision: 38b1a17c519d3873f413156c302cb7ed0d39ee3d URL: https://github.com/llvm/llvm-project/commit/38b1a17c519d3873f413156c302cb7ed0d39ee3d DIFF: https://github.com/llvm/llvm-project/commit/38b1a17c519d3873f413156c302cb7ed0d39ee3d.diff LOG

[PATCH] D144041: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void)

amurzeau added a comment. I do not have commit access to the repo, can someone commit this patch for me ? (after D144037 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144041/new/ https://reviews.llvm.org/D144041

[PATCH] D144037: [clang-tidy] allow tests to use --config-file instead of --config

amurzeau added a comment. I do not have commit access to the repo, can someone commit this patch for me ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144037/new/ https://reviews.llvm.org/D144037 ___ cf

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

jhuber6 added a comment. If we're removing this feature it would probably make sense to remove the handling / flag altogether as `-fopenmp-implicit-rpath` isn't that much different from `-Wl,-rpath=/path/to/llvm/install/lib`. Overall, the problem is that we want to tie the `libomptarget.so` wit

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. In D141569#4139320 , @ccotter wrote: > I was split on handling the case where the parameter that was never moved > from was not named. For this guideline enforcement to flag all unmoved rvalue > reference parameters, code that

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tianshilei1992 added a comment. I prefer to follow established convention. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143306/new/ https://reviews.llvm.org/D143306 ___ cfe-commits mailing list cfe-comm

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. In D141569#4139290 , @ccotter wrote: > In > > template > struct SomeClass > { > public: > explicit SomeClass(T&& value) : value(std::forward(value)) {} >T value; > }; > > `T` is not a universal reference in the

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

davrec added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3630-3632 do { - ++CurPtr; -} while (isHorizontalWhitespace(*CurPtr)); + ++CurOffset; +} while (isHorizontalWhitespace(BufferStart[CurOffset])); davrec wrote: > ``` > for (is

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a subscriber: labath. Michael137 added a comment. > Hmm, I'd sort of still be inclined to look further at the linkage name option > - but maybe the existence of a situation where the usage is built with debug > info, but the out of line ctor definitions are all in another librar

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 updated this revision to Diff 498898. Michael137 added a comment. - Hide behind LLDB tuning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144181/new/ https://reviews.llvm.org/D144181 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/li

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:301 + } + void never_moves(T&& t) {} + // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: rvalue reference parameter 't' is never moved from

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. I was split on handling the case where the parameter that was never moved from was not named. For this guideline enforcement to flag all unmoved rvalue reference parameters, code that `std::moves` into an argument to a virtual method call could be especially confusing o

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. In template struct SomeClass { public: explicit SomeClass(T&& value) : value(std::forward(value)) {} T value; }; `T` is not a universal reference in the constructor, it's an rvalue reference to `T`. There is no deducing context, so universal references

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498878. DmitryPolukhin added a comment. Rebase and retest, cannot reproduce test failure locally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 498873. ccotter added a comment. - Remove duplicated matchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute r=aaron.ballman

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using attributes by plugins (both in cla

[PATCH] D144404: [clang] Extract function for generated part of clang::hasAttribute (NFC) r=aaron.ballman

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes it easier to add additional handli

[PATCH] D144403: [clang] Extract attribute plugin instantiation to function (NFC) r=aaron.ballman

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This moves the code to instantiate the attribute plugins to the same place where th

[PATCH] D144402: [clang] Move ParsedAttrInfo from Sema to Basic (NFC) r=aaron.ballman

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This moves the ParsedAttrInfo class and the registry for attribute plugin to be par

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM as long as the naming nit is addressed. Comment at: clang/lib/Headers/ppc_wrappers/emmintrin.h:57 typedef __vector unsigned char __v16qu; +typedef __vector float __

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:301 + } + void never_moves(T&& t) {} + // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: rvalue reference parameter 't' is never moved fro

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. And on something like this I still got reproduction in production code: template struct SomeClass { public: explicit SomeClass(T&& value) : value(std::forward(value)) {} T value; }; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. Other false-positive that I still see: void SomeClass::someVirtualFunction(SomeType&&) { BOOST_THROW_EXCEPTION(std::runtime_error("Unexpected call ")); } It shouldnt warn about virtual functions with unnamed parameter, because this can be required by interf

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

nemanjai accepted this revision. nemanjai added a comment. Thanks for doing this. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144321/new/ https://reviews.llvm.org/D144321 ___ cfe-commits mailing

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen added a comment. In D144179#4132597 , @MaskRay wrote: > Behaviors due to a new environment variable should be very careful. How is > this useful? If you want this, you can add a wrapper around `clang` to > specify `--config=` by yourself.

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 498826. jolanta.jensen added a comment. Extended the test to cover Windows OS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files: clang/include/clang/Con

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

davrec added a comment. Suggested a few adjustments in `LexTokenInternal` you might want to test for perf improvements (orthogonal to this patch, but could boost its numbers :). And also noted that `Lexer::getBuffer()` has same issue as `getBufferLocation()` re potential for pointer invalidation

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

jmmartinez added a comment. I've added just a few minor remarks. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:1082-1084 + if (!includeMinimalInlineScopes() && !Scope->getInlinedAt()) +for (const auto *Decl : DD->getLocalDeclsForScope(Scope->getScopeNode()))

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. I don't know why but with latest version I still got false positive with std::function on Clang 15. using Functor= std::function<... something ...>; std::unique_ptr Class::createSomething(::Functor&& functor) { return std::make_unique(std::move(functor));

[PATCH] D143767: [SVE][Builtins] Lower X forms of fp binop/mla arithmetic builtins to dedicated intrinsics

paulwalker-arm added a comment. In D143767#4138049 , @dewen wrote: > Hi, thank you. When will this patch be pushed to the master?@paulwalker-arm I expect to push the patch to main in the next day or so. I just need to look over some recent InstCombine

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 498795. dkrupp added a comment. Added documentation to the newly introduced types: TaintData, TaintBugReport. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144269/new/ https://reviews.llvm.org/D144269 Files: clang/include/clang/StaticAnalyzer/Chec

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

cor3ntin added a comment. Thanks for working on this issue. I don't feel confident commenting on this patch's approach (I think @erichkeane is your best bet), but the small typo does make a pretty big difference here! Comment at: clang/include/clang/AST/DeclCXX.h:1549 /// +

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

tschuett added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:89 - // End of the buffer. - const char *BufferEnd; + // Size of the buffer. + unsigned BufferSize; cor3ntin wrote: > Should that use `SourceLocation::UIntTy`? > Looking at comments

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:723-727 +case attr::Assume: { + llvm::Value *ArgValue = EmitScalarExpr(cast(A)->getCond()); + llvm::Function *FnAssume = CGM.getIntrinsic(llvm::Intrinsic::assume); + Builder.CreateCall(FnA

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

cor3ntin added a comment. Can you add a test to check `__has_cpp_attribute(assume)` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144334/new/ https://reviews.llvm.org/D144334 ___ cfe-commits mailing li

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:80 +- Removed the ``ATOMIC_VAR_INIT`` macro in C2x and later standards modes, which + implements `WG14 N2886 `_ Just confirming

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

cor3ntin added a comment. This is an impressive amount of work. I think it makes sense! Thanks a lot for doing that work. I only have a few nits after a first review of this. Comment at: clang/include/clang/Lex/Lexer.h:89 - // End of the buffer. - const char *BufferEnd; +

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

MaggieYi created this revision. MaggieYi added reviewers: vsk, zequanwu. MaggieYi added a project: clang. Herald added a project: All. MaggieYi requested review of this revision. Herald added a subscriber: cfe-commits. In the current coverage mapping implementation, we terminate the current region

[PATCH] D144244: [X86]rearange X86InstrInfo.td

XinWang10 added a comment. Thanks for your reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144244/new/ https://reviews.llvm.org/D144244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D144244: [X86]rearange X86InstrInfo.td

XinWang10 added a comment. In D144244#4134569 , @RKSimon wrote: > LGTM - although it might be nice to pull out more ISAs from X86InstrMisc into > their own files (X86InstrTBM, etc.) as its always annoying trying to find > their defs. Many instructions

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

dim accepted this revision. dim added a comment. Yeah, this looks quite a bit nicer, and should be more maintainable. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144321/new/ https://reviews.llvm.org/D144321 __

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

nikic resigned from this revision. nikic added a comment. (not a clang reviewer) Comment at: clang/test/CodeGenCXX/cxx2b-assume.cpp:55 +// CHECK-OPT-NEXT: tail call void @llvm.assume(i1 %[[CMP]]) +// CHECK-OPT-NEXT: ret i32 43 +// Isn't the assume expressio

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

jmmartinez added inline comments. Comment at: llvm/lib/IR/DIBuilder.cpp:789 + return createLocalVariable( + VMContext, getSubprogramNodesTrackingVector(Scope), Scope, Name, + /* ArgNo */ 0, File, LineNo, Ty, AlwaysPreserve, Flags, AlignInBits); I'll be

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal added a comment. In D138037#4134504 , @steakhal wrote: > I'm backporting this as #60834 > to the 16.x branch. Backported with 1ab37a25e463ea144289a1cbcf32a7659b2d60bb

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

jhenderson added inline comments. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1145 + // So far only supports ARM/Thumb, PowerPC and X86. + Triple triple = STI->getTargetTriple(); + if (!triple.isPPC() && !triple.isX86() && !triple.isARM() && covanam w

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

brad updated this revision to Diff 498748. Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144321/new/ https://reviews.llvm.org/D144321 Files: clang/lib/Basic/Targets/PPC.h clang/lib/Driver/ToolChains/Clang.cpp