[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

uabelho added a comment. In D142985#4093783 , @jhuber6 wrote: > If this fixes the issues on your side, please open a bug so it can be > backported. I wrote https://github.com/llvm/llvm-project/issues/60437 Repository: rG LLVM Github Monorepo CHANG

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

uabelho added a comment. @jhuber6 I really have no idea about the fix, but I've run the linker-wrapper.c testcase with asan built binaries with this fix 500 times now without seeing any failures. Without the fix it fails in like 1 out of 10 runs so it surely looks like the fix does something g

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/atlmfc/lib/x64"

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 493826. 4vtomat added a comment. NFC, some indentation fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. In D139774#4094619 , @aaron.ballman wrote: > Is there a middle ground where, instead of #2 for general temporary storage, > we went with #2 but with compiler-specific directories instead of system > directories. e.g., don't let t

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

umesh.kalappa0 added a comment. @nikic ,is that changes are ok ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:41 /// so we provide a rough mapping here. std::string Linux::getMultiarchTriple(const Driver &D, const llvm::Triple &TargetTriple, SixWeining

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta updated this revision to Diff 493810. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagno

[clang] a7fbca4 - [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

Author: Sergei Barannikov Date: 2023-02-01T05:23:43+03:00 New Revision: a7fbca40805ca414a9dc37b91075e89e6a3b75d5 URL: https://github.com/llvm/llvm-project/commit/a7fbca40805ca414a9dc37b91075e89e6a3b75d5 DIFF: https://github.com/llvm/llvm-project/commit/a7fbca40805ca414a9dc37b91075e89e6a3b75d5.d

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7fbca40805c: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142704/new/ https://reviews.llvm.org/D142704

[PATCH] D143040: [Clang][DependencyScanner] Remove secondary actions from -cc1

Bigcheese created this revision. Bigcheese added a reviewer: jansvoboda11. Bigcheese added a project: clang. Herald added a subscriber: ributzka. Herald added a project: All. Bigcheese requested review of this revision. The -arcmt-action= and -objcmt-migrate* actions were being passed to module bu

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n updated this revision to Diff 493796. xen0n added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142688/new/ https://reviews.llvm.org/D142688 Files: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp clang/lib/Driver/ToolCha

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4064298 , @dblaikie wrote: > Right - I was thinking more, as above, about directly using the existing > metadata generation (if it's too expensive to enable by default, then > possibly under an off-by-default

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

erikdesjardins added a comment. I don't have commit access, please commit this on my behalf: `Erik Desjardins ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142861/new/ https://reviews.llvm.org/D142861 ___

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:694 +// Return text representation of an `Expr`. In case unable to get the text +// representatiion of `E`, return `Default`. +static StringRef getExprTextOr(const Expr *E, const SourceManager &SM, -

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void accepted this revision. void added a comment. This revision is now accepted and ready to land. One small comment about the documentation but L:GTM. Comment at: clang/docs/LanguageExtensions.rst:1584 +Outputs may be used along any branches from the ``asm goto`` whether the

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. > Sorry, I'm still not really following - OK, sounds like you're saying this > test does fail at HEAD/without this patch in reverse iteration mode, and is a > bit larger than would be minimally necessary to achieve that, but also might > fail at HEAD without reverse i

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. @erichkeane ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] cd97675 - [hexagon] add a -mcabac flag

Author: Brian Cain Date: 2023-01-31T16:30:35-08:00 New Revision: cd97675e02368f31d56bd8f143c5987649d162d8 URL: https://github.com/llvm/llvm-project/commit/cd97675e02368f31d56bd8f143c5987649d162d8 DIFF: https://github.com/llvm/llvm-project/commit/cd97675e02368f31d56bd8f143c5987649d162d8.diff LO

[PATCH] D142947: [hexagon] add a -mcabac flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd97675e0236: [hexagon] add a -mcabac flag (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D143027: [clang][deps] Fix module context hash for constant strings

Bigcheese accepted this revision. Bigcheese added a comment. Thanks for fixing this. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143027/new/ https://reviews.llvm.org/D143027 ___ cfe-commits maili

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu updated this revision to Diff 493768. steven_wu added a comment. Try fix pre-merge build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139052/new/ https://reviews.llvm.org/D139052 Files: clang/include/clang/CodeGen/BackendUtil.

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 493766. haowei added a comment. Correct dependency issues on llvm-mt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D143027: [clang][deps] Fix module context hash for constant strings

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143027/new/ https://reviews.llvm.org/D143027 ___

[PATCH] D143027: [clang][deps] Fix module context hash for constant strings

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We were not hashing constant strings in the command-line, only

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

nicovank added a comment. Nevermind, this was fixed as I was looking at it. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 ___ cfe-commits mailing list c

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

nicovank added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:100 +auto cxxMemberCallExprOnContainer(StringRef MethodName, + const std::vector ContainerNames) { + return cxxMemberCallExpr( ---

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet updated this revision to Diff 493756. BigPeet added a comment. - fix passing vector by value instead of by ref-to-const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 Files: clang-tools-extra/c

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. llvm-mt and llvm-rc tools are capable of building clang

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

dblaikie added a comment. In D141625#4094942 , @steven_wu wrote: > In D141625#4094837 , @dblaikie > wrote: > >> In D141625#4094742 , @steven_wu >> wrote: >> >>> In D1416

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. Refactored the code a little bit to get rid of some repetitions. Should effectively match the same code as the accepted revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet updated this revision to Diff 493753. BigPeet added a comment. - additional deduplication of code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 Files: clang-tools-extra/clang-tidy/modernize/Us

[PATCH] D140897: [clang][dataflow] Fix handling of `DeclRefExpr`s to `BindingDecl`s.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. I hope we will be able to get rid of this `SkipPast` thing at some point by looking at the value categories of the AST instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. In D141625#4094837 , @dblaikie wrote: > In D141625#4094742 , @steven_wu > wrote: > >> In D141625#4067225 , @dblaikie >> wrote: >> >>> In D1416

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet updated this revision to Diff 493745. BigPeet added a comment. - reducing code repitition + further tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 Files: clang-tools-extra/clang-tidy/mode

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. This change looks good to me. I wonder, however, whether the behavior should be parameterized in the future. E.g., whether the user of the analysis should be able to make a decision whet

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

mdfazlay created this revision. mdfazlay added reviewers: ABataev, mikerice, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. mdfazlay requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Deprecate and

[PATCH] D139395: Add CFI integer types normalization

pcc accepted this revision. pcc added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D139395: Add CFI integer types normalization

rcvalle marked 4 inline comments as done. rcvalle added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1694 + getCXXABI().getMangleContext().mangleTypeName( + T, Out, !!getCodeGenOpts().SanitizeCfiICallNormalizeIntegers); + pcc wrote: > Is

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

dblaikie added a comment. In D141625#4094742 , @steven_wu wrote: > In D141625#4067225 , @dblaikie > wrote: > >> In D141625#4066961 , @steven_wu >> wrote: >> >>> No, reve

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 493732. rcvalle marked an inline comment as done. rcvalle added a comment. Changed as per review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/C

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 493726. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu updated this revision to Diff 493724. steven_wu added a comment. Rebase to main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139052/new/ https://reviews.llvm.org/D139052 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/Co

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

MaskRay added a comment. edeaf16f2c2f02d6e43312d48d26d354d87913f3 (2011) added the CMake variable `CLANG_RESOURCE_DIR` but did not explain why. The patch introduced conditions in C++ code like std::string path_to_clang_dir = std::string(CLANG_RESOURCE_DIR).empty()

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. In D141625#4067225 , @dblaikie wrote: > In D141625#4066961 , @steven_wu > wrote: > >> No, reverse iteration will not break diff test for a small number of decls. >> Everything will be

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094238 , @srj wrote: > In D141861#4094084 , @srj wrote: > >> In D141861#4094079 , @jhuber6 >> wrote: >> >>> In D141861#4094063

[PATCH] D142384: [C++20] Fix a crash with modules.

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:557-560 + RecordDecl::field_iterator field_begin() const { +assert(hasDefinition() && "Definition not available to get fields."); +return static_cast(getDefinition())->field_begin(); + } ---

[clang] eb469c2 - Fix Clang sphinx build

Author: Aaron Ballman Date: 2023-01-31T15:42:07-05:00 New Revision: eb469c2751227f789db40c75fae2143d313c91be URL: https://github.com/llvm/llvm-project/commit/eb469c2751227f789db40c75fae2143d313c91be DIFF: https://github.com/llvm/llvm-project/commit/eb469c2751227f789db40c75fae2143d313c91be.diff

[PATCH] D140489: Add builtin_elementwise_log

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. This looks pretty straightforward and similar to other changes you've been making. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

nicovank accepted this revision. nicovank added a comment. This revision is now accepted and ready to land. This is becoming repetitive, but I guess that's the nature of those things. Maybe something like this would help clean it up, not sure if any better for right now. template // Lambda t

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4092553 , @vedgy wrote: > In D139774#4091631 , @aaron.ballman > wrote: > >> My preference is still for specific API names. If we want to do something >> general to all t

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers updated this revision to Diff 493709. vabridgers added a comment. rebase, bump review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142822/new/ https://reviews.llvm.org/D142822 Files: clang-tools-extra/clang-tidy/altera/StructPackAli

[PATCH] D142999: [Clang] Adjust PIC handling for the AMDGPU ToolChain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9271c5da434b: [Clang] Adjust PIC handling for the AMDGPU ToolChain (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 9271c5d - [Clang] Adjust PIC handling for the AMDGPU ToolChain

Author: Joseph Huber Date: 2023-01-31T14:31:10-06:00 New Revision: 9271c5da434b0827ad21f43013be287f3637a9b4 URL: https://github.com/llvm/llvm-project/commit/9271c5da434b0827ad21f43013be287f3637a9b4 DIFF: https://github.com/llvm/llvm-project/commit/9271c5da434b0827ad21f43013be287f3637a9b4.diff

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added a comment. In D133392#4094524 , @dyung wrote: > Hi @hctim, the test you added is failing on buildbots where AArch64 is not > built, can you either update the test to not require that backend, or mark > the test as requiring it? > > https://l

[clang] 15e33c6 - Revert "[MTE] Add AArch64GlobalsTagging Pass"

Author: Mitch Phillips Date: 2023-01-31T12:25:58-08:00 New Revision: 15e33c699cefe0e8528ec661a2b6477f21b6cb10 URL: https://github.com/llvm/llvm-project/commit/15e33c699cefe0e8528ec661a2b6477f21b6cb10 DIFF: https://github.com/llvm/llvm-project/commit/15e33c699cefe0e8528ec661a2b6477f21b6cb10.diff

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers added subscribers: DavidSpickett, jrtc27. vabridgers added a comment. @DavidSpickett and/or @jrtc27 , I started with @mizvekov 's patch ( D136886 ) and attempted to address the problems with that patch on arm and aarch64. Is it possible for you to try

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. I've reverted this change from `main` branch, let me know if there's anything I can do to help with addressing the build issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 __

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:839-846 return Style.AlignConsecutiveAssignments.AlignCompound ? C.Tok->getPrecedence() == prec::Assignment - : C.Tok->is(tok::equal); +

[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/loops.cpp:278 + +namespace RangeForLoop { + constexpr int localArray() { tbaeder wrote: > aaron.ballman wrote: > > You should also add failure tests where the range-based for loop is not > >

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

dyung added a comment. Hi @hctim, the test you added is failing on buildbots where AArch64 is not built, can you either update the test to not require that backend, or mark the test as requiring it? https://lab.llvm.org/buildbot/#/builders/139/builds/35253 error: unable to create target: 'No

[PATCH] D142947: [hexagon] add a -mcabac flag

kparzysz accepted this revision. kparzysz added a comment. This revision is now accepted and ready to land. The cxx tests passed for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142947/new/ https://reviews.llvm.org/D142947 ___

[PATCH] D142277: [clang][Interp] Clear metadata when destroying locals

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:260-261 +// local variable is used after being destroyed. +InlineDescriptor &ID = *reinterpret_cast(B->rawData()); +std::memset(&ID, 0, sizeof(InlineDescriptor)); } --

[PATCH] D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacc3cc69e4d1: [-Wunsafe-buffer-usage] Introduce the unsafe_buffer_usage attribute (authored by t-rasmud). Herald added a project: clang. Herald added

[clang] acc3cc6 - [-Wunsafe-buffer-usage] Introduce the unsafe_buffer_usage attribute

Author: Rashmi Mudduluru Date: 2023-01-31T11:43:34-08:00 New Revision: acc3cc69e4d1c8e199fde51798a5a2a6edb35796 URL: https://github.com/llvm/llvm-project/commit/acc3cc69e4d1c8e199fde51798a5a2a6edb35796 DIFF: https://github.com/llvm/llvm-project/commit/acc3cc69e4d1c8e199fde51798a5a2a6edb35796.di

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

aaron.ballman added a comment. Some more comments, but there are unaddressed comments from earlier reviews as well. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +

[PATCH] D142675: [clang][CGDebugInfo] emit DW_LANG_C_plus_plus_{20|17} DW_LANG_C17

nickdesaulniers added a comment. Also noting that GCC 12.2.0 does not produce these newer `DW_AT_language` values when using -std={c17|c++17|c++20}`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142675/new/ https://reviews.llvm.org/D142675 _

[PATCH] D140415: [flang] stack arrays pass

tblah added inline comments. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:433 + llvm::DenseSet freedValues; + func->walk([&](mlir::func::ReturnOp child) { +const LatticePoint *lattice = solver.lookupState(child); kiranchandramohan wrote: > Do

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 493692. tblah marked 10 inline comments as done. tblah added a comment. Thanks for review. Changes: - Join the lattices at each return operation to ensure that values are freed at *all* returns, not only *some* return - Add tests with multiple return operatio

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc, llvm::Ope

[PATCH] D142999: [Clang] Adjust PIC handling for the AMDGPU ToolChain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.h:71 } - bool isPICDefaultForced() const override { return false; } + bool isPICDefaultForced() const override { return true; } bool SupportsProfiling() const override { return false; }

[PATCH] D142988: [AArch64] Make nosimd imply nocrypto

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00ce96b02e87: [AArch64] Make nosimd imply nocrypto (authored by dmgreen). Herald added a project: clang. Herald added a subscriber: cfe-commits. Rep

[clang] 00ce96b - [AArch64] Make nosimd imply nocrypto

Author: David Green Date: 2023-01-31T19:17:22Z New Revision: 00ce96b02e87c1ceba1857590f56c647ad91db91 URL: https://github.com/llvm/llvm-project/commit/00ce96b02e87c1ceba1857590f56c647ad91db91 DIFF: https://github.com/llvm/llvm-project/commit/00ce96b02e87c1ceba1857590f56c647ad91db91.diff LOG: [

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

aaron.ballman added inline comments. Comment at: clang/test/Sema/tautological-constant-compare.c:7-8 // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wtype-limits -DTEST -verify -x c++ %s -// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wextra -Wno-sign-co

[PATCH] D141858: [clang][Interp] Fix Pointer::toAPValue() for expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG given that other test coverage exists for this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141858/new/ https://reviews.llvm.org/D141858 __

[PATCH] D142999: [Clang] Adjust PIC handling for the AMDGPU ToolChain

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. I don't understand how the PIC options are supposed to propagate given that codegen seems to still use magic flags but removing a special case seems good Comment at: clang/l

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware updated this revision to Diff 493681. KyleFromKitware added a comment. Fixed crash when warning doesn't have associated location. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142991/new/ https://reviews.llvm.org/D142991 Files: clang-tools-extra/clang-tidy/ClangTidy.c

[PATCH] D142999: [Clang] Adjust PIC handling for the AMDGPU ToolChain

jhuber6 created this revision. jhuber6 added reviewers: arsenm, JonChesterfield, yaxunl, t-tye, msearles. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, Mas

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094084 , @srj wrote: > In D141861#4094079 , @jhuber6 wrote: > >> In D141861#4094063 , @srj wrote: >> >>> Yes please! >> >> Let me know if

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

dblaikie added a comment. > I'd be interested to see the fixit-hints for the first bit, also to see how > others feel about it here. My 2c is that `-Wparentheses` is already a very stylistic warning (even correct code, without knowing about this esoteric/specific suppression style of adding pa

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

tra added a comment. LGTM for the parts I've commented on. Comment at: clang/test/CodeGenCUDA/link-builtin-bitcode-denormal-fp-mode.cu:77 + +// CHECK: kernel_f32({{.*}}) #[[$KERNELATTR:[0-9]+]] +__global__ void kernel_f32(float* out, float* a, float* b, float* c) {

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added reviewers: MaskRay, thesamesam, tstellar. mgorny added a comment. Ok, this turned out to be surprisingly painless, at least within our packaging. However, I'd prefer if someone more experienced looked at the CMake changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

wenlei added a subscriber: davidxl. wenlei added a comment. Given llvm-profgen is in llvm tree, I'm wondering if it makes sense to treat it first option instead of alternative to out of tree create_llvm_prof. wdyt @davidxl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D139395: Add CFI integer types normalization

pcc accepted this revision. pcc added a comment. LGTM with nits Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1694 + getCXXABI().getMangleContext().mangleTypeName( + T, Out, !!getCodeGenOpts().SanitizeCfiICallNormalizeIntegers); + Is the !! necessary he

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D142690: [libc++] Fixes the Clang modular build.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7f8ddc4e2e3: [libc++] Fixes the Clang modular build. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

hoy created this revision. Herald added subscribers: modimo, wenlei. Herald added a project: All. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Test Plan: Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142994 File

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094079 , @jhuber6 wrote: > In D141861#4094063 , @srj wrote: > >> Yes please! > > Let me know if this fixes anything rG9f64fbb882dc >

[clang] d8982f7 - [AST] assert(false) -> llvm_unreachable

Author: Benjamin Kramer Date: 2023-01-31T18:57:01+01:00 New Revision: d8982f72282bb88da6a3793f9d55fccd5621c825 URL: https://github.com/llvm/llvm-project/commit/d8982f72282bb88da6a3793f9d55fccd5621c825 DIFF: https://github.com/llvm/llvm-project/commit/d8982f72282bb88da6a3793f9d55fccd5621c825.dif

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4094063 , @srj wrote: > Yes please! Let me know if this fixes anything rG9f64fbb882dc . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 9f64fbb - [Clang] Do not attempt to directly link arch tools in 32-bit mode

Author: Joseph Huber Date: 2023-01-31T11:56:24-06:00 New Revision: 9f64fbb882dc3c76712ec70316253ca396baa824 URL: https://github.com/llvm/llvm-project/commit/9f64fbb882dc3c76712ec70316253ca396baa824 DIFF: https://github.com/llvm/llvm-project/commit/9f64fbb882dc3c76712ec70316253ca396baa824.diff

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm updated this revision to Diff 493653. arsenm added a comment. Fix dropping target-cpu. Also skip interposable functions if we aren't internalizing (this seems to be a theoretical concern, since PropagateAttrs and Internalize are set as a pair) CHANGES SINCE LAST ACTION https://reviews

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094059 , @jhuber6 wrote: > In D141861#4094058 , @srj wrote: > >> In D141861#4094043 , @jhuber6 >> wrote: >> >>> Would this just require c

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 493652. usaxena95 added a comment. Use definition based field access only for CXXRecordDecl. Avoid dynamic dispatch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4094058 , @srj wrote: > In D141861#4094043 , @jhuber6 wrote: > >> Would this just require checking `LLVM_BUILD_32_BITS`? Should be an easy >> change. > > I think so. (It might

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094043 , @jhuber6 wrote: > Would this just require checking `LLVM_BUILD_32_BITS`? Should be an easy > change. I think so. (It might be tempting to check `if (CMAKE_SIZEOF_VOID_P EQUAL 8)` but LLVM_BUILD_32_BITS is likel

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 493651. VitaNuo added a comment. Remove comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/StandardLibrary.h

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/Sta

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: u

  1   2   3   >