[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

iains added a comment. I think we need to find a way to proceed - because this causes a regression on the llvm-16 branch, and that should be resolved soon, if possible. What is your suggestion for a way forward? Comment at: clang/lib/Sema/SemaDecl.cpp:15265 FD->getForma

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

iains added a comment. I think we need to find a way to proceed - because this causes a regression on the llvm-16 branch, and that should be resolved soon, if possible. What is your suggestion for a way forward? Comment at: clang/lib/Sema/SemaDecl.cpp:15265 FD->getForma

[PATCH] D142917: [Fuchsia] Re-enable HWASan for globals in runtimes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4308166403b4: [Fuchsia] Re-enable HWASan for globals in runtimes (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 4308166 - [Fuchsia] Re-enable HWASan for globals in runtimes

Author: Petr Hosek Date: 2023-01-31T07:31:05Z New Revision: 4308166403b4c28b6db7094a4e202e42da6e28a8 URL: https://github.com/llvm/llvm-project/commit/4308166403b4c28b6db7094a4e202e42da6e28a8 DIFF: https://github.com/llvm/llvm-project/commit/4308166403b4c28b6db7094a4e202e42da6e28a8.diff LOG: [F

[clang-tools-extra] c0afb6d - [clangd] Stop filtering lit tests based on target-triple

Author: Kadir Cetinkaya Date: 2023-01-31T08:01:38+01:00 New Revision: c0afb6de4fc837d634d99b76ae73636a1f3ca73d URL: https://github.com/llvm/llvm-project/commit/c0afb6de4fc837d634d99b76ae73636a1f3ca73d DIFF: https://github.com/llvm/llvm-project/commit/c0afb6de4fc837d634d99b76ae73636a1f3ca73d.dif

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 493489. usaxena95 marked an inline comment as done. usaxena95 added a comment. Add message in the assertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384 Files:

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140011/new/ https://reviews.llvm.org/D140011 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15265 FD->getFormalLinkage() == Linkage::ExternalLinkage && - !FD->isInvalidDecl() && BodyKind != FnBodyKind::Delete && + !FD->isInvalidDecl() && !IsFnTemplate && BodyKind != FnBodyKind::Del

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. In D139774#4091631 , @aaron.ballman wrote: > My preference is still for specific API names. If we want to do something > general to all temp files, I think `FileSystemOptions` is the way to go. > > My concern with not using a cons

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta added a comment. In D142826#4090415 , @aaron.ballman wrote: > Heh, I literally started working on this on Friday afternoon. :-D Yeah, I saw someone asking about it on discord on Sunday. so thought to look. Repository: rG LLVM Github Monorepo

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta updated this revision to Diff 493479. xgupta added a comment. update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Di

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. I both like it and can't foresee any issues from the vendor side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://revi

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaChecking.cpp:15186 + if (ChildExpr == CSE->getOperand()) +// Do not recurse over a CoroutineSuspendExpr's operand. +

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta updated this revision to Diff 493477. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/test/Sem

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added a comment. In D142595#4092435 , @MaskRay wrote: > How does avr-gcc know whether the user provides a linker script? > > I really don't like adding a default `-Tdata=` when it can interfere with > common uses of specifying a linker script.

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added a comment. In D142595#4092435 , @MaskRay wrote: > How does avr-gcc know whether the user provides a linker script? > > I really don't like adding a default `-Tdata=` when it can interfere with > common uses of specifying a linker script.

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

MaskRay added a comment. How does avr-gcc know whether the user provides a linker script? I really don't like adding a default `-Tdata=` when it can interfere with common uses of specifying a linker script. In these situations drivers not adding default options is usually better than guessing t

[PATCH] D142925: [Clang] Improve error message for violations of -fmodules-decluse.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142925/new/ https://reviews.llvm.org/D142925

[PATCH] D142948: [OpenCL] Disable vector to scalar types coercion for OpenCL

cdai2 updated this revision to Diff 493470. cdai2 added a comment. Forget code format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142948/new/ https://reviews.llvm.org/D142948 Files: clang/include/clang/Basic/LangOptions.def clang/include/cla

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu added a comment. In D117087#4082454 , @alkis wrote: > Does this change the semantics of `get_return_value()` such that it is > eagerly converted to R the return value of the coro? AFAIU before this change > one could return T convertible to R

[PATCH] D142948: [OpenCL] Disable vector to scalar types coercion for OpenCL

cdai2 created this revision. Herald added subscribers: Naghasan, ldrumm, pengfei, Anastasia, yaxunl. Herald added a project: All. cdai2 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For x86 target, vector types (both result and arguments)

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added a comment. In D142595#4091176 , @MaskRay wrote: > In D142595#4089391 , @benshi001 > wrote: > >> In D142595#4089124 , @MaskRay >> wrote: >> >>> OK. If thi

[PATCH] D142947: [hexagon] add a -mcabac flag

bcain created this revision. bcain added a reviewer: kparzysz. bcain added a project: clang. Herald added a project: All. bcain requested review of this revision. Herald added a subscriber: cfe-commits. For v73 and later, clang users who wish to use the cabac instructions need a way to add the 'ca

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142144/new/ https://reviews.llvm.org/D142144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

tra added a comment. For what it's worth, NVIDIA has started deprecating 32-bit binaries long ago (https://forums.developer.nvidia.com/t/deprecation-plans-for-32-bit-linux-x86-cuda-toolkit-and-cuda-driver/31356) and the process had finally come to the end with the release of CUDA-12: CUDA-12 r

[PATCH] D139547: [NFC] Correct argument comment typo

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f5d881206ce: [NFC] Correct argument comment typo (authored by gAlfonso-bit, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/

[clang] 9f5d881 - [NFC] Correct argument comment typo

Author: Gregory Alfonso Date: 2023-01-30T16:06:45-08:00 New Revision: 9f5d881206ce24f6f1e6ca35aeaaf1b6f6fc3c66 URL: https://github.com/llvm/llvm-project/commit/9f5d881206ce24f6f1e6ca35aeaaf1b6f6fc3c66 DIFF: https://github.com/llvm/llvm-project/commit/9f5d881206ce24f6f1e6ca35aeaaf1b6f6fc3c66.dif

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4092190 , @jhuber6 wrote: > In D141861#4092182 , @srj wrote: > >> In D141861#4092096 , @srj wrote: >> >>> Update: I may have a way to make

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4092182 , @srj wrote: > In D141861#4092096 , @srj wrote: > >> Update: I may have a way to make this work from my side; testing now. > > Alas, that didn't work, stlll broken. In

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4092096 , @srj wrote: > Update: I may have a way to make this work from my side; testing now. Alas, that didn't work, stlll broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D142675: [clang][CGDebugInfo] emit DW_LANG_C_plus_plus_{20|17} DW_LANG_C17

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. In D142675#4084279 , @dblaikie wrote: > This was discussed in D138597 & we decided > not to implement these due to the risk of breaking existing

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4092034 , @srj wrote: > In D141861#4091987 , @jhuber6 wrote: > >> Can you let me know if adding this fixes it. > > Unfortunately, no. (That is: It does not fix it. CMAKE_CROSSCOMPIL

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2571 // No driver mode exposes -x and /TC or /TP; we don't support mixing them. assert(!Args.hasArg(options::OPT_x) && "-x and /TC or /TP is not allowed"); } Fznamznon wrote: > Ma

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Ping @aaron.ballman @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. BigPeet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes #55869 Repository: rG LLV

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay added a comment. > In CL mode values of /clang: arguments end up at the end of arguments list so > passing /clang:-x doesn't make sense and produces confusing warning. The description needs updating. `clang:-x` emits an error instead of a warning. And if the error is suppressed, `/clan

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/docs/ReleaseNotes.rst:60 `Issue 59446 `_. +- Fix confusing warning message when `/clang:-x` is

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091987 , @jhuber6 wrote: > Can you let me know if adding this fixes it. Unfortunately, no. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141861/new/ https://reviews.llvm.o

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

erikdesjardins updated this revision to Diff 493426. erikdesjardins added a comment. Improve code style. `ninja check-clang` still passes (as expected) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142861/new/ https://reviews.llvm.org/D142861 File

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

nridge added a comment. In D142692#4090867 , @erichkeane wrote: > We have a good amount of AST-dump tests around that are likely the right > place to put them perhaps? What is the reproducer that caused you to > discover this issue? The following is

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. Thanks for the updates! In D139926#4064769 , @kadircet wrote: > LMK if you're going to take a look at the implementation @nridge, otherwise I > am happy to do that as well. The implementation looks good to me now. (I admit I don

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091961 , @srj wrote: > In D141861#4091949 , @jhuber6 wrote: > >> In D141861#4091922 , @srj wrote: >> >>> Crosscompiling to x86-32 on a

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091949 , @jhuber6 wrote: > In D141861#4091922 , @srj wrote: > >> Crosscompiling to x86-32 on an x86-64 host doesn't strike me as particularly >> weird at all (especially on Window

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091922 , @srj wrote: > Crosscompiling to x86-32 on an x86-64 host doesn't strike me as particularly > weird at all (especially on Windows), but apparently it is quite weird for > LLVM at this point in time as we keep

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091903 , @jhuber6 wrote: > In D141861#4091897 , @srj wrote: > >> It's finding a 64-bit CUDAToolkit, which it can't link against because the >> rest of the build is 32-bit. > > Won

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm created this revision. arsenm added reviewers: spetrovic, nemanjai, rjmccall, hfinkel, fhahn. Herald added subscribers: StephenFan, kbarton, arichardson. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Avoid using ptrtoint/inttoptr.

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091897 , @srj wrote: > It's finding a 64-bit CUDAToolkit, which it can't link against because the > rest of the build is 32-bit. Wondering why it didn't find it before then. But that's definitely a weird configurati

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091869 , @jhuber6 wrote: > In D141861#4091851 , @srj wrote: > >>> https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515. >>> Does it work if you rev

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 493411. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings created this revision. michaelplatings added reviewers: phosek, lenary, simon_tatham. Herald added subscribers: abrachet, mgrang. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: c

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091851 , @srj wrote: >> https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515. >> Does it work if you revert this? I wouldn't think it wouldn't affect >> anything. That's the only chang

[PATCH] D142932: Multilib YAML parsing

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4085171 , @tmatheson wrote: > This patch has made it considerably harder to understand what is going on in > the TargetParser. If you get a chance, please could you add some clarifying > comments and tidy-ups. I apprec

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. > https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515. > Does it work if you revert this? I wouldn't think it wouldn't affect > anything. That's the only change that happened after the 16 release as far as > I'm aware. Reverting this (well,

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 493401. francii added a comment. Move check to Clang.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/D

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2bd8aeea7e7d: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is… (authored by shafik). Herald added a project: clang. R

[clang] 2bd8aee - [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

Author: Shafik Yaghmour Date: 2023-01-30T13:28:29-08:00 New Revision: 2bd8aeea7e7d885fbf6c70c0e181b1e8e6b808a5 URL: https://github.com/llvm/llvm-project/commit/2bd8aeea7e7d885fbf6c70c0e181b1e8e6b808a5 DIFF: https://github.com/llvm/llvm-project/commit/2bd8aeea7e7d885fbf6c70c0e181b1e8e6b808a5.dif

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

shafik added a comment. The build failures look unrelated to this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142799/new/ https://reviews.llvm.org/D142799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

shafik updated this revision to Diff 493389. shafik marked an inline comment as done. shafik added a comment. - Fix up release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142799/new/ https://reviews.llvm.org/D142799 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTran

[PATCH] D142892: [clangd] Publish diagnostics from stale preambles

kadircet updated this revision to Diff 493382. kadircet added a comment. Well, turns out presumed location patching was not handled in clangd at all for diagnostics. So add that to translate ranges, at least when we have ranges or locations that point to preamble patch. Repository: rG LLVM Git

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1417-1418 + assert(!BD->getHoldingVar()); // FIXME + if (!this->allocateVariable(BD, BD->getBinding())) +return false; +} tbaeder wrote: > aaron.ballma

[PATCH] D141472: [clang][Interp] Add function pointers

aaron.ballman added a comment. Design question -- do you anticipate this class handling *all* function pointers, including pointer to member functions that might be virtual: https://godbolt.org/z/hT8fMY37n CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc, llvm::Ope

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { browneee wrote: > tkuchta wrote: > > browneee wrote: > > > The

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4081888 , @vedgy wrote: > 3 out of 4 alternatives remain: > >> 1. Add an option to store the preamble-*.pch files in RAM instead of /tmp >> and add a corresponding option in KDevelop configuration UI. This would

[PATCH] D142925: [Clang] Improve error message for violations of -fmodules-decluse.

jyknight created this revision. jyknight added a reviewer: ChuanqiXu. Herald added a project: All. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now it reports the name of the indirectly-used module which is missing. Repository

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 __

[PATCH] D142723: [C2x] Stop diagnosing member and array access in offsetof as an extension

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2389 const int ext1 = __builtin_offsetof(struct U { int i; }, i); // C extension - const int ext2 = __builtin_offsetof(struct S, t.f[1]); // C & C++ extension + const int ext2 = __builtin_offs

[clang] 9367bd0 - Improve example documentation for __builtin_offsetof; NFC

Author: Aaron Ballman Date: 2023-01-30T14:54:59-05:00 New Revision: 9367bd05913b11aaadf89c4edeced4321c65b605 URL: https://github.com/llvm/llvm-project/commit/9367bd05913b11aaadf89c4edeced4321c65b605 DIFF: https://github.com/llvm/llvm-project/commit/9367bd05913b11aaadf89c4edeced4321c65b605.diff

[clang-tools-extra] 7db780d - Fix handling of braced-init temporaries for modernize-use-emplace

Author: BigPeet Date: 2023-01-30T14:52:20-05:00 New Revision: 7db780d51212a7ee68a9e196cfcf0737807273d6 URL: https://github.com/llvm/llvm-project/commit/7db780d51212a7ee68a9e196cfcf0737807273d6 DIFF: https://github.com/llvm/llvm-project/commit/7db780d51212a7ee68a9e196cfcf0737807273d6.diff LOG:

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

This revision was automatically updated to reflect the committed changes. Closed by commit rG7db780d51212: Fix handling of braced-init temporaries for modernize-use-emplace (authored by BigPeet, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though needs a release note. Comment at: clang/lib/AST/ExprConstant.cpp:13503-13505 +if (Value.isSigned() && Value.isMinSignedValue() && E->canOverflo

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:43 + conforming GNU extensions. Projects incompatible with C++17 can add + ``-std=gnu++14`` to their build settings to restore the previous behaviour. royjacobson wrote: > aaron.ball

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

tra added a comment. My $.02, mostly on the style and the mechanics of applying the new attribute. FP semantics aspects are above my pay grade. Comment at: clang/lib/CodeGen/CGCall.cpp:2059-2061 + F.removeFnAttrs(AttrsToRemove); + addDenormalModeAttrs(Merged, MergedF32, Func

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:16 Release notes for previous releases can be found on - `the Download Page `_. + `the Releases Page `_.

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 493360. royjacobson marked 2 inline comments as done. royjacobson added a comment. 15 -> Clang 15 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578 Files: clang/d

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091408 , @srj wrote: > In D141861#4091403 , @jhuber6 wrote: > >> In D141861#4091383 , @srj wrote: >> >>> It looks like this change (bu

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091403 , @jhuber6 wrote: > In D141861#4091383 , @srj wrote: > >> It looks like this change (but not the rG4ce454c654bd >>

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091383 , @srj wrote: > It looks like this change (but not the rG4ce454c654bd > ) is in > the 17 branch, as the latter is now failing in the same wa

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm closed this revision. arsenm added a comment. 647925648a0fde06b5b44086843f0d8f164a71df CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141620/new/ https://reviews.llvm.org/D141620 __

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:60 `Issue 59446 `_. +- Fix crash when diagnosing incorrect usage of _Nullable involing alias + templates. This fixes

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

nathanchance added a comment. I tested this against the kernel and left my feedback above (no issues) so this can be merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 __

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm closed this revision. arsenm added a comment. 00f6a7f02f9c8d542ce8ff1c9c037d9fdb421b88 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141449/new/ https://reviews.llvm.org/D141449 __

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

arsenm closed this revision. arsenm added a comment. 52c28d7cf9018f3558268217f6cf91271eb4ac39 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141447/new/ https://reviews.llvm.org/D141447 __

[clang] d12ee4b - clang/OpenCL: Extend tests for enqueued block attributes

Author: Matt Arsenault Date: 2023-01-30T15:03:15-04:00 New Revision: d12ee4bf7c14a00b14890fc3042edd659dde7fb2 URL: https://github.com/llvm/llvm-project/commit/d12ee4bf7c14a00b14890fc3042edd659dde7fb2 DIFF: https://github.com/llvm/llvm-project/commit/d12ee4bf7c14a00b14890fc3042edd659dde7fb2.diff

[clang] 00f6a7f - clang/OpenCL: Fix not setting convergent on block invoke kernels

Author: Matt Arsenault Date: 2023-01-30T15:03:14-04:00 New Revision: 00f6a7f02f9c8d542ce8ff1c9c037d9fdb421b88 URL: https://github.com/llvm/llvm-project/commit/00f6a7f02f9c8d542ce8ff1c9c037d9fdb421b88 DIFF: https://github.com/llvm/llvm-project/commit/00f6a7f02f9c8d542ce8ff1c9c037d9fdb421b88.diff

[clang] 52c28d7 - clang/OpenCL: Don't use a Function for the block type

Author: Matt Arsenault Date: 2023-01-30T15:03:14-04:00 New Revision: 52c28d7cf9018f3558268217f6cf91271eb4ac39 URL: https://github.com/llvm/llvm-project/commit/52c28d7cf9018f3558268217f6cf91271eb4ac39 DIFF: https://github.com/llvm/llvm-project/commit/52c28d7cf9018f3558268217f6cf91271eb4ac39.diff

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4060100 , @jhuber6 wrote: > In D141861#4060028 , @srj wrote: > >> This change appears to have broken the build when crosscompiling to x86-32 >> on a Linux x86-64 system; on the Hal

[PATCH] D142917: [Fuchsia] Re-enable HWASan for globals in runtimes

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is now supported. Repository: rG LLVM Gith

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

dblaikie added a comment. (heh, don't mind my feedback being duplicate - didn't refresh before submitting - glad other folks got to it before me! :) ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142861/new/ https://reviews.llvm.org/D142861

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

dblaikie added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:881 + // Sort options by key to avoid relying on StringMap iteration order. + SmallVector, 4> SortedConfigOpts; for (const auto &C : Opts.Config) { jansvoboda11 wrote: > ja

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay added a comment. In D140270#4089857 , @wzssyqa wrote: > ping I don't know how to test this, so this will be up to @nathanchance ... (Thanks for improving the mips port, though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis created this revision. TIFitis added reviewers: kiranchandramohan, clementval, jdoerfert. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[PATCH] D142384: [C++20] Fix a crash with modules.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6233 + assert(RD->hasDefinition()); + RD->getDefinition(); if (RD->getNumVBases()) { I think it would make sense to use the definition of the class as `RD` here, since we're going to b

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

goldstein.w.n added a comment. FWIW, if the only use if hashtables `xxhash` has a slight perf bug in `XXH3_len_129to240_128b` and `XXH3_len_129to240_64b` where it will repeat the last the block if length is a factor of `32`/`16` respectively. `XXH3_len_129to240_128b`: - https://github.com/Cyan4

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

shafik updated this revision to Diff 493351. shafik added a comment. - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142799/new/ https://reviews.llvm.org/D142799 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTransform.h clang/test/SemaCXX/nullability.cpp

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D142595#4089391 , @benshi001 wrote: > In D142595#4089124 , @MaskRay wrote: > >> OK. If this do

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

MaskRay added a comment. To enable smooth hash function migration in the future, we can explore the idea of adding `#ifdef EXPENSIVE_CHECKS\nshuffle` (see https://github.com/llvm/llvm-project/issues/34483). That means we should fix these tests properly to be non-dependent on the iteration order

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:886 + llvm::sort(SortedConfigOpts, [](const auto &A, const auto &B) { +return std::get<0>(A) < std::get<0>(B); + }); If you use `pair` inste

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm created this revision. arsenm added reviewers: scanon, spatel, cameron.mcinally, andrew.w.kaylor, tra, jlebar, Anastasia, yaxunl, efriedma, jcranmer-intel, kpn, sepavloff. Herald added subscribers: kosarev, foad, StephenFan, wenlei, jdoerfert, kerbowa, pengfei, hiraditya, jvesely. Herald a

  1   2   >