aaron.ballman added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:43 + conforming GNU extensions. Projects incompatible with C++17 can add + ``-std=gnu++14`` to their build settings to restore the previous behaviour. ---------------- royjacobson wrote: > aaron.ballman wrote: > > Do we want to mention that this may also impact build-time performance of > > projects relying on the default language standard mode, because C++17 pulls > > in a lot more compile-time-intensive APIs like constexpr and more template > > metaprogramming? > I agree this change is annoying and has real life impact - I'm not trying to > minimize it - but I think newer language versions bring enough benefits that > we shouldn't warn users about using them in the Clang release notes. > Especially since this doesn't come with any balancing context (like 'you can > now use template variables instead of instantiating a struct every time you > check if two types are equal' ;) ) That's fair! I was thinking of it from the perspective of whether we'll get bug reports or not. When we made the switch in-tree, some folks thought we introduced a compile time perf regression bad enough to warrant reverting the changes, which made me think users may probably think the same thing. However, on reflection, I doubt that mentioning it in the release notes will actually mean less bug reports about it. :-P Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
