[clang] ebd3eef - [Frontend] Use std::optional in TextDiagnostic.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T23:22:41-08:00 New Revision: ebd3eef0b2b0255e4cf1cd825019ff66d3cd1426 URL: https://github.com/llvm/llvm-project/commit/ebd3eef0b2b0255e4cf1cd825019ff66d3cd1426 DIFF: https://github.com/llvm/llvm-project/commit/ebd3eef0b2b0255e4cf1cd825019ff66d3cd1426.diff L

[clang] cd45f1b - [Rewrite] Use std::optional in InclusionRewriter.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T23:21:35-08:00 New Revision: cd45f1be8f9e218aebf2c20511bba6b0a5e34b96 URL: https://github.com/llvm/llvm-project/commit/cd45f1be8f9e218aebf2c20511bba6b0a5e34b96 DIFF: https://github.com/llvm/llvm-project/commit/cd45f1be8f9e218aebf2c20511bba6b0a5e34b96.diff L

[clang] 1ce8e35 - [Frontend] Use std::optional in CompilerInvocation.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T23:19:23-08:00 New Revision: 1ce8e3543bba774e5200c73574420f1afd9d2fcd URL: https://github.com/llvm/llvm-project/commit/1ce8e3543bba774e5200c73574420f1afd9d2fcd DIFF: https://github.com/llvm/llvm-project/commit/1ce8e3543bba774e5200c73574420f1afd9d2fcd.diff L

[clang] 8d83867 - [Frontend] Use std::optional in CompilerInstance.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T23:16:32-08:00 New Revision: 8d83867dc913bb1b40571c8b36726e22ff824a0d URL: https://github.com/llvm/llvm-project/commit/8d83867dc913bb1b40571c8b36726e22ff824a0d DIFF: https://github.com/llvm/llvm-project/commit/8d83867dc913bb1b40571c8b36726e22ff824a0d.diff L

[clang] e90e848 - [Frontend] Use std::optional in ASTUnit.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T23:12:19-08:00 New Revision: e90e8487dce37ace5cfabb5b27cb0dc0ba5b566f URL: https://github.com/llvm/llvm-project/commit/e90e8487dce37ace5cfabb5b27cb0dc0ba5b566f DIFF: https://github.com/llvm/llvm-project/commit/e90e8487dce37ace5cfabb5b27cb0dc0ba5b566f.diff L

[clang] 538401d - [Format] Use std::optional in QualifierAlignmentFixer.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T23:09:06-08:00 New Revision: 538401da1d16e4ca84423f6da3526c72b2fdb493 URL: https://github.com/llvm/llvm-project/commit/538401da1d16e4ca84423f6da3526c72b2fdb493 DIFF: https://github.com/llvm/llvm-project/commit/538401da1d16e4ca84423f6da3526c72b2fdb493.diff L

[clang] 7d3178d - [Format] Use std::optional in Format.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T23:07:59-08:00 New Revision: 7d3178d76aa8d67bfbacd45794ef5740823a43c0 URL: https://github.com/llvm/llvm-project/commit/7d3178d76aa8d67bfbacd45794ef5740823a43c0 DIFF: https://github.com/llvm/llvm-project/commit/7d3178d76aa8d67bfbacd45794ef5740823a43c0.diff L

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

manojgupta added a comment. The removal is also breaking ChromeOS builds which use -Xpattern in some cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 ___

[clang] 7edc552 - [Format] Use std::optional in ContinuationIndenter.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T23:06:32-08:00 New Revision: 7edc552d0ae4d0b2e3525bc64d428e7b3bc96db0 URL: https://github.com/llvm/llvm-project/commit/7edc552d0ae4d0b2e3525bc64d428e7b3bc96db0 DIFF: https://github.com/llvm/llvm-project/commit/7edc552d0ae4d0b2e3525bc64d428e7b3bc96db0.diff L

[clang] f655cb0 - [ExtractAPI] Use std::optional in ExtractAPIConsumer.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T23:03:10-08:00 New Revision: f655cb0f580ffab1a7d2ffb73043661bba449a44 URL: https://github.com/llvm/llvm-project/commit/f655cb0f580ffab1a7d2ffb73043661bba449a44 DIFF: https://github.com/llvm/llvm-project/commit/f655cb0f580ffab1a7d2ffb73043661bba449a44.diff L

[clang] e8aee7e - [linux] Use std::optional in DirectoryWatcher-linux.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T22:55:06-08:00 New Revision: e8aee7ef73a759e9307fccb0fc3329d676eca737 URL: https://github.com/llvm/llvm-project/commit/e8aee7ef73a759e9307fccb0fc3329d676eca737 DIFF: https://github.com/llvm/llvm-project/commit/e8aee7ef73a759e9307fccb0fc3329d676eca737.diff L

[clang] 0a4c70f - [Targets] Use std::optional in RISCV.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T22:52:29-08:00 New Revision: 0a4c70feb19fd95689e9a99d27114e217ada5da0 URL: https://github.com/llvm/llvm-project/commit/0a4c70feb19fd95689e9a99d27114e217ada5da0 DIFF: https://github.com/llvm/llvm-project/commit/0a4c70feb19fd95689e9a99d27114e217ada5da0.diff L

[clang] defa6ee - [Basic] Use std::optional in TargetID.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T22:51:10-08:00 New Revision: defa6eec7d00057cf4d481fe64e745f1b688c646 URL: https://github.com/llvm/llvm-project/commit/defa6eec7d00057cf4d481fe64e745f1b688c646 DIFF: https://github.com/llvm/llvm-project/commit/defa6eec7d00057cf4d481fe64e745f1b688c646.diff L

[clang] 3e1856e - [Basic] Use std::optional in FileManager.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T22:49:47-08:00 New Revision: 3e1856edb062b4e3d4848c03bac59b3c4953000e URL: https://github.com/llvm/llvm-project/commit/3e1856edb062b4e3d4848c03bac59b3c4953000e DIFF: https://github.com/llvm/llvm-project/commit/3e1856edb062b4e3d4848c03bac59b3c4953000e.diff L

[clang] a12b82a - [Basic] Use std::optional in DarwinSDKInfo.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T22:48:14-08:00 New Revision: a12b82adb82eda76d6d7afd340b890f56f62771d URL: https://github.com/llvm/llvm-project/commit/a12b82adb82eda76d6d7afd340b890f56f62771d DIFF: https://github.com/llvm/llvm-project/commit/a12b82adb82eda76d6d7afd340b890f56f62771d.diff L

[clang] d009b98 - [AST] Use std::optional in OSLog.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T22:21:54-08:00 New Revision: d009b985a84ce5a4251255dd138da6a687e9466b URL: https://github.com/llvm/llvm-project/commit/d009b985a84ce5a4251255dd138da6a687e9466b DIFF: https://github.com/llvm/llvm-project/commit/d009b985a84ce5a4251255dd138da6a687e9466b.diff L

[clang] 50ba59d - [AST] Use std::optional in ExprConstant.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T22:19:46-08:00 New Revision: 50ba59d1b659558a06273003bbf28227323a055f URL: https://github.com/llvm/llvm-project/commit/50ba59d1b659558a06273003bbf28227323a055f DIFF: https://github.com/llvm/llvm-project/commit/50ba59d1b659558a06273003bbf28227323a055f.diff L

[clang] 17d779b - [AST] Use std::optional in ASTImporter.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-09T22:17:46-08:00 New Revision: 17d779be76d9597fe13478392b266543761fedca URL: https://github.com/llvm/llvm-project/commit/17d779be76d9597fe13478392b266543761fedca DIFF: https://github.com/llvm/llvm-project/commit/17d779be76d9597fe13478392b266543761fedca.diff L

[PATCH] D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG048612050a2f: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 0486120 - [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr

Author: gonglingqin Date: 2022-12-10T14:05:19+08:00 New Revision: 048612050a2fc0a89b84632a48da0d86f0d13646 URL: https://github.com/llvm/llvm-project/commit/048612050a2fc0a89b84632a48da0d86f0d13646 DIFF: https://github.com/llvm/llvm-project/commit/048612050a2fc0a89b84632a48da0d86f0d13646.diff L

[PATCH] D139768: [SPARC][clang] Add SPARC target feature flags

koakuma created this revision. koakuma added reviewers: jrtc27, brad, ro, dcederman. Herald added subscribers: fedor.sergeev, jyknight. Herald added a project: All. koakuma requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This adds s

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

h-vetinari added inline comments. Comment at: clang/test/Driver/save-std-c++-module-file.cpp:1 +// RUN: rm -rf %t +// RUN: mkdir %t The filename of this test still reflects the old option name and should presumably be changed. CHANGES SINCE LAST ACTION https

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a reviewer: shafik. v1nh1shungry marked an inline comment as done. v1nh1shungry added a comment. @shafik Thank you for reviewing and giving suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.ll

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry updated this revision to Diff 481819. v1nh1shungry added a comment. address the comment's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 Files: clang/lib/Sema/SemaInit.cpp cla

[PATCH] D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr

SixWeining accepted this revision. SixWeining added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139612/new/ https://reviews.llvm.org/D139612 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D139397: [LoongArch] Add testcases for privileged intrinsic macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a5e5402cf80: [LoongArch] Add testcases for privileged intrinsic macros (authored by gonglingqin). Changed prior to commit: https://reviews.llvm.o

[clang] 9a5e540 - [LoongArch] Add testcases for privileged intrinsic macros

Author: gonglingqin Date: 2022-12-10T11:36:56+08:00 New Revision: 9a5e5402cf809ea22ed771f59144543f9ea78ff1 URL: https://github.com/llvm/llvm-project/commit/9a5e5402cf809ea22ed771f59144543f9ea78ff1 DIFF: https://github.com/llvm/llvm-project/commit/9a5e5402cf809ea22ed771f59144543f9ea78ff1.diff L

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than x + T__builtin_elementwise_canonicalize(T x) return the platform specific canonical encoding of

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

arsenm updated this revision to Diff 481812. arsenm added a comment. Try to fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139640/new/ https://reviews.llvm.org/D139640 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/

[clang] 37a3e98 - [clang] Use std::nullopt instead of None in comments (NFC)

Author: Kazu Hirata Date: 2022-12-09T18:39:01-08:00 New Revision: 37a3e98c841e5d33f7e77e97dfb058965105eb4b URL: https://github.com/llvm/llvm-project/commit/37a3e98c841e5d33f7e77e97dfb058965105eb4b DIFF: https://github.com/llvm/llvm-project/commit/37a3e98c841e5d33f7e77e97dfb058965105eb4b.diff L

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers added a comment. Some debug context ... (gdb) frame 4 #4 0x06f55b73 in clang::ento::BasicValueFactory::getAPSIntType (this=0x1088e470, T=...) at /clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:155 155 assert(T->isIntegralOrEnumera

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers updated this revision to Diff 481809. vabridgers added a comment. update commit header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139759/new/ https://reviews.llvm.org/D139759 Files: clang/include/clang/StaticAnalyzer/Core/PathSensi

[PATCH] D139760: Revert "[clang-format] Link the braces of a block in UnwrappedLineParser"

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, MyDeveloperDay, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. But keep the add

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. vabridgers requested review of this revision. Her

[PATCH] D139387: [NFC][Clang] Add missing test cases for segment load

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139387/new/ https://reviews.llvm.org/D139387 ___ cfe-commits mailing list cfe-commits

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

benlangmuir added a comment. Thanks, the libclang change LGTM other than my comment about the function names. Comment at: clang/include/clang-c/Documentation.h:589 + */ +CINDEX_LINKAGE CXString clang_getSingleSymbolSymbolGraphForUSR(const char *usr, +

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. Thanks! Cleaned up version: struct string { constexpr string(const char*) {}; constexpr ~string(); }; struct AutocompleteParsingResult; struct optional { template constexpr optional(U &&) {} }; struct AutocompleteParsingResult { s

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. When building with the 17.5.0 preview toolset for MSVC and building with modules, the definition of `_addcarry_u64` and

[PATCH] D139742: [HLSL] Add trunc library function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. LGTM. Remember to double check the commit message updated to trunc too. Just noticed we don't have double trunc(double) for hlsl now (hlsl 2021). Need make sure to generate float ove

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than x + T__builtin_elementwise_canonicalize(T x) return the platform specific canonical encoding of a floating-point number floati

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 481770. davidtgoldblatt added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/include/clang/Basic/Builtins.def clang/includ

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3386 + + if (!Result || CurPtr - StartPtr == (ptrdiff_t)(Buffer.size() + 4)) StartPtr = CurPtr; tahonermann wrote: > cor3ntin wrote: > > tahonermann wrote: > > > cor3ntin wrote: > > > > cor

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 481767. cor3ntin added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/lib/L

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 481766. cor3ntin added a comment. - Rebase - Add/Improve comments - Add more trigrahs tests - Fix crash when a trigraph appears at the end of a named escape sequence and trigraphs are disabled - Fix when getAndAdvanceChar is called - alas there is no way to

[PATCH] D139745: Use poison instead of undef where its used as placeholder[NFC]

ManuelJBrito created this revision. ManuelJBrito added a reviewer: nlopes. Herald added subscribers: Enna1, ThomasRaoux, hiraditya. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a reviewer: zuban32. Herald added projects: clang, LLVM. Herald added subscri

[PATCH] D128372: [Clang-Tidy] Empty Check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGec3f8feddf81: [Clang-Tidy] Empty Check (authored by abrahamcd, committed by cjdb). Repository: rG LLVM Github Monorepo

[clang-tools-extra] ec3f8fe - [Clang-Tidy] Empty Check

Author: Abraham Corea Diaz Date: 2022-12-09T23:19:45Z New Revision: ec3f8feddf81f2868c840f8e9af8587f055c713c URL: https://github.com/llvm/llvm-project/commit/ec3f8feddf81f2868c840f8e9af8587f055c713c DIFF: https://github.com/llvm/llvm-project/commit/ec3f8feddf81f2868c840f8e9af8587f055c713c.diff

[PATCH] D139742: [HLSL] Add acos library function

python3kgae added a comment. The PR title is acos but trunc is added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139742/new/ https://reviews.llvm.org/D139742 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D139503: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG106a99276f9e: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139503/new/

[clang] 106a992 - [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h

Author: Ryan Prichard Date: 2022-12-09T15:16:20-08:00 New Revision: 106a99276f9e7b9eec9542cc2b4dcd8489eb1a6b URL: https://github.com/llvm/llvm-project/commit/106a99276f9e7b9eec9542cc2b4dcd8489eb1a6b DIFF: https://github.com/llvm/llvm-project/commit/106a99276f9e7b9eec9542cc2b4dcd8489eb1a6b.diff

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

arsenm added inline comments. Comment at: clang/lib/Headers/__clang_hip_math.h:145 // BEGIN FLOAT -#if defined(__cplusplus) __DEVICE__ doru1004 wrote: > arsenm wrote: > > Why not introduce __clang_hip_stdlib.h now? > Do we want to do this in this patch or as a

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/ExtractAPI/DeclarationFragments.h:91 +/// The associated declaration, if applicable. +const Decl *Declaration; + zixuw wrote: > Is the decl guaranteed to be

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 481742. koops added a comment. git pull & reloading the earlier patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h c

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

doru1004 added inline comments. Comment at: clang/lib/Headers/__clang_hip_math.h:145 // BEGIN FLOAT -#if defined(__cplusplus) __DEVICE__ arsenm wrote: > Why not introduce __clang_hip_stdlib.h now? Do we want to do this in this patch or as a separate patch? Is t

[PATCH] D136554: Implement CWG2631

aeubanks added a comment. a really bad reduced repro which also has random syntax errors: using string = struct basic_string { constexpr basic_string(char *) {} constexpr ~basic_string( } struct AutocompleteParsingResult struct optional { template constexpr optional(U

[PATCH] D139742: [HLSL] Add acos library function

bob80905 updated this revision to Diff 481748. bob80905 added a comment. The commit still isn't included, adding ^ character Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139742/new/ https://reviews.llvm.org/D139742 Files: clang/lib/Headers/hlsl

[clang] be30567 - Revert "Implement CWG2631"

Author: Arthur Eubanks Date: 2022-12-09T14:20:30-08:00 New Revision: be305674bfd9e559b5e2d9297519124c70c65789 URL: https://github.com/llvm/llvm-project/commit/be305674bfd9e559b5e2d9297519124c70c65789 DIFF: https://github.com/llvm/llvm-project/commit/be305674bfd9e559b5e2d9297519124c70c65789.diff

[PATCH] D139742: [HLSL] Add acos library function

bob80905 updated this revision to Diff 481747. bob80905 added a comment. dont just paste the clang format commit onto the revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139742/new/ https://reviews.llvm.org/D139742 Files: clang/lib/Header

[PATCH] D139742: [HLSL] Add acos library function

bob80905 created this revision. bob80905 added reviewers: beanz, python3kgae. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D136554: Implement CWG2631

aeubanks reopened this revision. aeubanks added a comment. This revision is now accepted and ready to land. I've bisected another crash to this change. Reverting, and currently creducing a repro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops added a comment. mstorsjo, I have uploaded a new patch which has __kmpc_omp_taskwait_51 in dllexports. Can you please check the patch on windows? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 _

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

tahonermann added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3323 if (Diagnose) Diag(StartPtr, diag::warn_ucn_escape_incomplete); return llvm::None; I was able to confirm that `StartPtr` does point to `N`. See the diagnostic generated

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked 3 inline comments as done. tuliom added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:74 +const Driver &D, +const llvm::opt::ArgList &Args) const { + if (Args.hasArg(options::OPT_nostdlib, options::OPT_nostdlibxx)) n

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 481740. koops added a comment. Addition of __kmpc_omp_taskwait_51 in dllexports. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRun

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 updated this revision to Diff 481739. qiongsiwu1 added a comment. Update to include a new test case against the unknown target error message. Thanks for the suggestion @amyk ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 Files:

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

arsenm added inline comments. Comment at: clang/lib/Headers/__clang_hip_math.h:145 // BEGIN FLOAT -#if defined(__cplusplus) __DEVICE__ Why not introduce __clang_hip_stdlib.h now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

doru1004 updated this revision to Diff 481738. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139723/new/ https://reviews.llvm.org/D139723 Files: clang/lib/Headers/__clang_hip_math.h clang/test/Headers/Inputs/include/stdlib.h clang/test/Headers

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom updated this revision to Diff 481730. tuliom added a comment. Fix the issues pointed by @nikic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139450/new/ https://reviews.llvm.org/D139450 Files: clang/lib/Driver/ToolChains/PPCLinux.cpp c

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

thieta added a comment. It still looks odd to me, but since the rest of the file has comments like that I am fine with it. But I think we should figure out if they are like that because some tool is parsing them or if it's just legacy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev created this revision. dzhidzhoev added reviewers: kjdyck, rjmccall, efriedma, majnemer, aaron.ballman, rsmith. Herald added a project: All. dzhidzhoev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. RecordLayoutBuilder assumes

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

saudi added a comment. In D139632#3985341 , @thakis wrote: > LG (except for thieta's nit.) > > Do you have commit permissions, or do you need someone to land this for you? > If the latter, which name and email should we use for landing it? I have commit

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

amyk added a comment. It might be good to add a test case to illustrate the 'unknown target CPU' error that is issued as a result of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 __

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 481732. schittir added a comment. Add `(Initializer && ` and assert to else branch per Tom's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaInit.cpp Index: clang/l

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. LG (except for thieta's nit.) Do you have commit permissions, or do you need someone to land this for you? If the latter, which name and email should we use for landing it? Repository: rG

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5959 if (DestType->isRecordType()) { +assert(Initializer && "Intializer must be non-null"); // - If the initialization is direct-initialization, or if it is It looks like t

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

doru1004 added a comment. In D139723#3984846 , @jdoerfert wrote: > I'm not 100% sure if this was excluded on purpose or not. FWIW, in C, these > functions are not defined in math.h > (https://en.cppreference.com/w/c/numeric/math/abs), but in C++ they ar

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

tahonermann added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3386 + + if (!Result || CurPtr - StartPtr == (ptrdiff_t)(Buffer.size() + 4)) StartPtr = CurPtr; cor3ntin wrote: > tahonermann wrote: > > cor3ntin wrote: > > > cor3ntin wrote: > > > > tah

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

doru1004 updated this revision to Diff 481722. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139723/new/ https://reviews.llvm.org/D139723 Files: clang/lib/Headers/__clang_hip_math.h clang/test/Headers/Inputs/include/stdlib.h clang/test/Headers

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, t-rasmud, malavikasamak, aaron.ballman, xazax.hun, gribozavr. Herald added a subscriber: rnkovacs. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald adde

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7b6660243d1: [flang] Add -ffast-math and -Ofast (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3378-3379 - if (LooseMatch) + // If no diagnostic has been emitted yet we do not want to recover here + // to make sure this function will be called again and a diagnostic emitted then. + if (LooseMatch &&

[clang] e7b6660 - [flang] Add -ffast-math and -Ofast

Author: Tom Eccles Date: 2022-12-09T19:55:58Z New Revision: e7b6660243d1a4548f7aaac992b777ef0f0ba5b7 URL: https://github.com/llvm/llvm-project/commit/e7b6660243d1a4548f7aaac992b777ef0f0ba5b7 DIFF: https://github.com/llvm/llvm-project/commit/e7b6660243d1a4548f7aaac992b777ef0f0ba5b7.diff LOG: [f

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

ahatanak added inline comments. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:767 +const ColorVector &CV = BlockColors.find(BB)->second; +assert(CV.size() == 1 && "non-unique color for block!"); +BasicBlock *EHPadBB = CV.front(); sgraenitz w

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

shafik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:3870-3872 +} +if (const ASTTemplateArgumentListInfo *Info = VTSD->getTemplateArgsInfo()) + EndLoc = Info->getRAngleLoc(); If I understand correctly we either have a `VarTemplatePa

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. just small comment, thanks @ilinpv LGTM, just let others to chime in. Comment at: clang/lib/Basic/Targets/AArch64.cpp:652 + // AARCH64_ARCH_EXT_NAME feature with top

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added a comment. I'll wait for the revert and then look how to go forth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 ___ cf

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D139257#3983332 , @owenpan wrote: > I have second thoughts about linking block braces in `UnwrappedLineParser`. > Consider the following example: > > #if A > while (a) { // Linked to the r_brace below > #else

[clang] ef783af - Move Clang's per-suite test targets into a folder

Author: Chris Bieneman Date: 2022-12-09T13:44:38-06:00 New Revision: ef783af0b9d299e0912a17f4841f74fae4352fee URL: https://github.com/llvm/llvm-project/commit/ef783af0b9d299e0912a17f4841f74fae4352fee DIFF: https://github.com/llvm/llvm-project/commit/ef783af0b9d299e0912a17f4841f74fae4352fee.diff

[clang] d16c590 - Resolve possible test failure on Windows

Author: Chris Bieneman Date: 2022-12-09T13:43:52-06:00 New Revision: d16c59013056f1bf8844ded8faeb0cf01b1c3613 URL: https://github.com/llvm/llvm-project/commit/d16c59013056f1bf8844ded8faeb0cf01b1c3613 DIFF: https://github.com/llvm/llvm-project/commit/d16c59013056f1bf8844ded8faeb0cf01b1c3613.diff

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

tahonermann added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3378-3379 - if (LooseMatch) + // If no diagnostic has been emitted yet we do not want to recover here + // to make sure this function will be called again and a diagnostic emitted then. + if (LooseMatch

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jdoerfert added a comment. Could we elaborate on the benefits, please. Now we support two versions? Why is this helpful: > DeviceRTL uses rocm-device-libs instead of directly calling amdgcn builtins > for the functions which are affected by cov5. Comment at: openmp/libomptar

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7085 if (Triple.isAMDGPU()) { -handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs); +handleAMDGPUCodeObjectVersionOptions(D, C.getArgs(), CmdArgs, +

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

compnerd added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added a comment. I'm not fully up-to-date, what's the main difference and advantage of the new code object version? What do all the new implicit arguments do. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:953 getAMDGPUCodeObjectVersion(getDriver(), DriverAr

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added a comment. Maybe we should wait until D138389 lands and we can update both, otherwise we'd need a second patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D13

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5380 + } + InitExprs.push_back(ER.get()); +} ilya-biryukov wrote: > ayzhao wrote: > > ayzhao wrote: > > > So the libc++ test compile failures are due to this line. > >

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam created this revision. saiislam added reviewers: jdoerfert, JonChesterfield, jhuber6, yaxunl. Herald added subscribers: kosarev, kerbowa, guansong, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: openmp-

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. In D131858#3984855 , @arphaman wrote: > Ping @mizvekov. > > Unfortunately I'm unable to revert this commit now so we won't be able to get > the bot back to green until it's fixed. Hello, sorry for the long time to respond. Can

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 481700. ayzhao marked 6 inline comments as done. ayzhao added a comment. address comments + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/

  1   2   3   >