arsenm added inline comments.
================ Comment at: clang/lib/Headers/__clang_hip_math.h:145 // BEGIN FLOAT -#if defined(__cplusplus) __DEVICE__ ---------------- doru1004 wrote: > arsenm wrote: > > Why not introduce __clang_hip_stdlib.h now? > Do we want to do this in this patch or as a separate patch? Is the work on > libc_gpu/libm_gpu going to build up on these headers or will these headers be > replaced in the process? Yes. I think this kind of thing is hard to untangle once people start using it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139723/new/ https://reviews.llvm.org/D139723 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits