[PATCH] D139395: Add support for integer types normalization

rcvalle updated this revision to Diff 480349. rcvalle retitled this revision from "Add support for integer types notmalization" to "Add support for integer types normalization". rcvalle added a comment. Fixed typo in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang-tools-extra] 2402c46 - [clang-tools-extra] Use std::nullopt instead of llvm::None (NFC)

Author: Kazu Hirata Date: 2022-12-05T23:55:23-08:00 New Revision: 2402c46b7155d04dc2a1ec618294fc6bb70f3e18 URL: https://github.com/llvm/llvm-project/commit/2402c46b7155d04dc2a1ec618294fc6bb70f3e18 DIFF: https://github.com/llvm/llvm-project/commit/2402c46b7155d04dc2a1ec618294fc6bb70f3e18.diff L

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

Szelethus added a comment. Do I understand correctly that for the time being, the strategy is to assume apiModeling to be enabled by default and not enforce it explicitly? I suppose I have the ol' reliable question: did you evaluate this on any project yet? In D135247#3839543

[PATCH] D139395: Add support for integer types notmalization

rcvalle created this revision. Herald added a subscriber: JDevlieghere. Herald added a project: All. rcvalle requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This commit adds support for normalizing integer types as vendor extended t

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

kadircet added a comment. thanks, mostly LG. some small changes. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:261 if (Symbol.empty()) +F.Message = llvm::formatv("{0} {1}", nit: `llvm::StringLiteral DirectiveSpelling = Directive == tooling::In

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

dnpetrov-sc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:637 +def : ProcessorModel<"scr1-min", SCR1Model, + [FeatureRV32E, FeatureStdExtC], + [TuneNoDefaultUnroll]>; craig.topper wrote: > Shouldn't this

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder added a comment. @tahonermann Anything still missing here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:44 + + // Cache for decl to header mappings, as the same decl might be referenced in + // multiple locations and finding providers for each location is expensive. hok

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 480340. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 Files: clang-tools-

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. vitalybuka marked an inline comment as done. Closed by commit rG166c8cccde01: [msan][CodeGen] Set noundef for C return value (authored by vitalybuka). Repository: rG

[clang] 166c8cc - [msan][CodeGen] Set noundef for C return value

Author: Vitaly Buka Date: 2022-12-05T22:58:29-08:00 New Revision: 166c8cccde010ea01fdc20945a2a25fa1971cb73 URL: https://github.com/llvm/llvm-project/commit/166c8cccde010ea01fdc20945a2a25fa1971cb73 DIFF: https://github.com/llvm/llvm-project/commit/166c8cccde010ea01fdc20945a2a25fa1971cb73.diff L

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 !Module.MayDropFunctionReturn(Module.getContext(), RetTy) || Module.getLangOpts().Sanitize.has(SanitizerKind::Memory) || Modu

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka updated this revision to Diff 480335. vitalybuka added a comment. remove redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeG

[clang-tools-extra] 15ba27e - [clang-tools-extra] Use std::nullopt instead of llvm::None (NFC)

Author: Kazu Hirata Date: 2022-12-05T22:37:22-08:00 New Revision: 15ba27ebd0cbf96659b729399f89eb9f11ae1d5e URL: https://github.com/llvm/llvm-project/commit/15ba27ebd0cbf96659b729399f89eb9f11ae1d5e DIFF: https://github.com/llvm/llvm-project/commit/15ba27ebd0cbf96659b729399f89eb9f11ae1d5e.diff L

[clang-tools-extra] 649ef33 - [clang-tools-extra] Use std::nullopt instead of llvm::None (NFC)

Author: Kazu Hirata Date: 2022-12-05T21:49:31-08:00 New Revision: 649ef3386b90363af3c807ebe82d0facc75fa381 URL: https://github.com/llvm/llvm-project/commit/649ef3386b90363af3c807ebe82d0facc75fa381 DIFF: https://github.com/llvm/llvm-project/commit/649ef3386b90363af3c807ebe82d0facc75fa381.diff L

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:155 +// CHECK-MAKE: [[PREFIX]]/impl_part.o: +// CHECK-MAKE: [[PREFIX]]/impl_part.cppm ben.boeckel wrote: > ben.boeckel wrote: > > ChuanqiXu wrote: > > > ben.boeckel wrote: > > >

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu updated this revision to Diff 480329. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h clang/lib/Tooling/D

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

iains added a comment. In D137059#3973016 , @ben.boeckel wrote: > In D137059#3934448 , @dblaikie > wrote: > >> I'm still curious what about the details of other compilers - I think from >> the sounds of it, @ia

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added a comment. In D137762#3969770 , @owenpan wrote: > @gedare do you need us to commit this patch on your behalf (using "Gedare > Bloom ")? Yes, please. I don't have any llvm permissions, this is my first patch set for llvm actually. Anything

[PATCH] D139387: [Clang] Support policy function for all vector segment load.

4vtomat updated this revision to Diff 480321. 4vtomat added a comment. Resolved Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139387/new/ https://reviews.llvm.org/D139387 Files: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 480320. 4vtomat added a comment. Resolved Craig's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocessor/riscv-target-features.c l

[PATCH] D139387: [Clang] Support policy function for all vector segment load.

craig.topper added a comment. Title is not clear this is NFC and only adding tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139387/new/ https://reviews.llvm.org/D139387 ___ cfe-commits mailing list

[PATCH] D139387: [Clang] Support policy function for all vector segment load.

4vtomat created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All. 4vtom

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ben.boeckel added a comment. In D137059#3934448 , @dblaikie wrote: > I'm still curious what about the details of other compilers - I think from > the sounds of it, @iains suggested GCC doesn't support this yet so we'll need > to pick/name the flag ourse

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138105/new/ https://reviews.llvm.org/D138105

[PATCH] D139154: [clang-doc] Add template support

paulkirth added a comment. Can we also update the end-to-end tests with some relevant test cases? I think that's especially important, given that I'm not sure the unittests are running as part of the normal test suite. Overall this is mostly LGTM with some minor comments/questions. =

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:155-176 +class ArraySubscriptGadget : public UnsafeGadget { + const ArraySubscriptExpr *ASE; + +public: + ArraySubscriptGadget(const MatchFinder::MatchResult &Result) + : UnsafeGadget(Kind::Arr

[clang] def7207 - [X86][clang] Lift _BitInt() supported max width.

Author: Freddy Ye Date: 2022-12-06T11:02:27+08:00 New Revision: def720726b73e0d7ab139376ab3ea955f25f4d89 URL: https://github.com/llvm/llvm-project/commit/def720726b73e0d7ab139376ab3ea955f25f4d89 DIFF: https://github.com/llvm/llvm-project/commit/def720726b73e0d7ab139376ab3ea955f25f4d89.diff LOG

[PATCH] D139170: [X86][clang] Lift _BitInt() supported max width.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdef720726b73: [X86][clang] Lift _BitInt() supported max width. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:168-169 + static Matcher matcher() { +// FIXME: What if the index is integer literal 0? Should this be +// a safe gadget in this case? +return stmt( xazax.hun wrote: > No

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def:1 +//=- UnsafeBufferUsageGadgets.def - List of ways to use a buffer --*- C++ -*-=// +// NoQ wrote: > aaron.ballman wro

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

NoQ updated this revision to Diff 480310. NoQ marked 17 inline comments as done. NoQ added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137348/new/ https://reviews.llvm.org/D137348 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadg

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat added a comment. In D138807#3972441 , @craig.topper wrote: > In D138807#3962417 , @craig.topper > wrote: > >> Anything that uses OP-P needs to have a DecoderNamespace assigned and >> RISCVDisassembler::

[PATCH] D139170: [X86][clang] Lift _BitInt() supported max width.

FreddyYe added a comment. THX for review. I'll land! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139170/new/ https://reviews.llvm.org/D139170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D139170: [X86][clang] Lift _BitInt() supported max width.

FreddyYe updated this revision to Diff 480305. FreddyYe added a comment. Rebase and add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139170/new/ https://reviews.llvm.org/D139170 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic

[PATCH] D139025: [NFC][RISCV] Extract utility to calculate value through MajorVersion and MinorVersion

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139025/new/ https://reviews.llvm.org/D1390

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie added a comment. In D138597#3966638 , @probinson wrote: > One not-yet-asked question, does gcc produce the C++17/20 codes? If so, does > fstrict-dwarf affect that? Looks like GCC uses C++17 for both 17 and 20: https://gcc.gnu.org/git/?p=gcc.gi

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie updated this revision to Diff 480296. dblaikie added a comment. Don't use the since-v5-published codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139025: [NFC][RISCV] Extract utility to calculate value through MajorVersion and MinorVersion

eopXD marked an inline comment as done. eopXD added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139025/new/ https://reviews.llvm.org/D139025 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie updated this revision to Diff 480292. dblaikie added a comment. Rebase on top of committed LLVM changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

thakis added a comment. This breaks check-clang: http://45.33.8.238/linux/93300/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/ https://reviews.llvm.org/D137275

[PATCH] D138326: [CodeView] Don't generate dummy unnamed strcut/class/union type.

zequanwu added a comment. Landed at: https://reviews.llvm.org/rGbb5bcddcdbc151119f449be2d1e0d90f2e9c4258. Forgot to add the "Revision" line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138326/new/ https://reviews.llvm.org/D138326 __

[clang] bb5bcdd - [CodeView] Don't generate dummy unnamed strcut/class/union type.

Author: Zequan Wu Date: 2022-12-06T08:29:55+08:00 New Revision: bb5bcddcdbc151119f449be2d1e0d90f2e9c4258 URL: https://github.com/llvm/llvm-project/commit/bb5bcddcdbc151119f449be2d1e0d90f2e9c4258 DIFF: https://github.com/llvm/llvm-project/commit/bb5bcddcdbc151119f449be2d1e0d90f2e9c4258.diff LOG

Re: [clang] a446827 - [NFC][Clang][Driver][AMDGPU] Avoid temporary copies of std::string by using Twine and StringRef

On Mon, Dec 5, 2022 at 5:27 AM Juan Manuel MARTINEZ CAAMAÑO via cfe-commits wrote: > > > Author: Juan Manuel MARTINEZ CAAMAÑO > Date: 2022-12-05T07:27:10-06:00 > New Revision: a446827249bdeb2f27e55a9f4942bd7425ecb0ff > > URL: > https://github.com/llvm/llvm-project/commit/a446827249bdeb2f27e55a9f4

[PATCH] D138983: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 3 or 3)

jmciver updated this revision to Diff 480267. jmciver added a comment. Updating D138983 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 3 or 3) The following tests have been updated: - matrix-type-operators.c Repository: rG LLVM Gi

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#3972493 , @pcc wrote: > Isn't that just a bug in the optimization? It shouldn't be applying this to > symbols where `VisibleToRegularObj` is set. The current patch simply replicates ibt-seal behavior, but sure, l

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSchedSCR1.td:208 +} \ No newline at end of file Add new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139302/new/ https://reviews.ll

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:637 +def : ProcessorModel<"scr1-min", SCR1Model, + [FeatureRV32E, FeatureStdExtC], + [TuneNoDefaultUnroll]>; Shouldn't this also need Feature32B

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 3)

jmciver updated this revision to Diff 480265. jmciver added a comment. Updating D134410 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 3) The following tests have been updated: - avx512f-builtins.c - avx512fp16-builtins.c - matri

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b992bcce0c5: [Driver][test] Fix test by creating empty archive instead of empty file (authored by lamb-j). Repository: rG LLVM Github Monorepo C

[clang] 6b992bc - [Driver][test] Fix test by creating empty archive instead of empty file

Author: Jacob Lambert Date: 2022-12-05T15:39:09-08:00 New Revision: 6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521 URL: https://github.com/llvm/llvm-project/commit/6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521 DIFF: https://github.com/llvm/llvm-project/commit/6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521.diff

[clang] bc06177 - Revert "[-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffers."

Author: Artem Dergachev Date: 2022-12-05T15:38:52-08:00 New Revision: bc0617795f8bdcd5deab3e48b120107cc2833cdc URL: https://github.com/llvm/llvm-project/commit/bc0617795f8bdcd5deab3e48b120107cc2833cdc DIFF: https://github.com/llvm/llvm-project/commit/bc0617795f8bdcd5deab3e48b120107cc2833cdc.dif

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

pcc added a comment. In D138337#3972138 , @samitolvanen wrote: > In D138337#3972009 , @pcc wrote: > >> Can't this be implicit if LTO is being used? > > I would prefer to keep this behind a flag (similarly to `-mi

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

xazax.hun added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:168-169 + static Matcher matcher() { +// FIXME: What if the index is integer literal 0? Should this be +// a safe gadget in this case? +return stmt( NoQ wrote: > aa

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ec85f8: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffers. (authored by Artem Dergachev ). Heral

[clang] 200007e - [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffers.

Author: Artem Dergachev Date: 2022-12-05T15:13:42-08:00 New Revision: 27ec85f81122fd260a4e68308e54607ca37a URL: https://github.com/llvm/llvm-project/commit/27ec85f81122fd260a4e68308e54607ca37a DIFF: https://github.com/llvm/llvm-project/commit/27ec85f81122fd260a4e68308e54607ca37a.dif

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

aeubanks added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 !Module.MayDropFunctionReturn(Module.getContext(), RetTy) || Module.getLangOpts().Sanitize.has(SanitizerKind::Memory) || Module.getLangOpts().Sanitize.has(SanitizerKind::Re

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added a comment. In D138807#3962417 , @craig.topper wrote: > Anything that uses OP-P needs to have a DecoderNamespace assigned and > RISCVDisassembler::getInstruction will need to lookup that table when V/Zve > is enabled. Otherwise we wil

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480251. brettw added a reviewer: paulkirth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D139137: add floor library function

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. @bob80905 if you haven't already, you should follow the steps here (https://www.llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) to get commit access. Repository: rG LLVM Gi

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 ___ cfe-c

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added a comment. > I don't see any after this point. You're right! I thought I had seen some, but upon checking, I agree. That is a good sign we're on the right path! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 __

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka added a comment. In D139296#3972142 , @kda wrote: > Is there a risk of this being too strict for standard C? > > Should there be a test case for our specific problem? (C calling C++) Probably not. It's cross module mismatch. To reproduce we n

[libunwind] 96d6399 - Revert "[CMake] Use LLVM_TARGET_TRIPLE in runtimes"

Author: Leonard Chan Date: 2022-12-05T22:20:51Z New Revision: 96d63993dd3698bbf2d6a83c035cd05faed7317b URL: https://github.com/llvm/llvm-project/commit/96d63993dd3698bbf2d6a83c035cd05faed7317b DIFF: https://github.com/llvm/llvm-project/commit/96d63993dd3698bbf2d6a83c035cd05faed7317b.diff LOG:

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added a comment. (-Wglobal-constructors warning is still not implemented.) Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderG

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5660 +"-header-include-filtering=" + +std::string(D.CCPrintHeadersFiltering ? "on" : "off"))); } Let's change "on" to something that won't interfere with pote

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

kda added a comment. Is there a risk of this being too strict for standard C? Should there be a test case for our specific problem? (C calling C++) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 __

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#3972009 , @pcc wrote: > Can't this be implicit if LTO is being used? I would prefer to keep this behind a flag (similarly to `-mibt-seal`), so we can better control when and where the optimization enabled. For ex

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. In D139148#3969383 , @tahonermann wrote: > When committing changes to address Coverity reported issues, I think it would > be useful to include the Coverity analysis in the commit message. A textual > representation can be obt

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. > Perhaps the` assert` should be added after line 5926 above. Done. > I think the checks for `Initializer` being non-null following the addition of > an `assert` should be removed. I don't see any after this point. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D139137: add floor library function

bob80905 updated this revision to Diff 480218. bob80905 added a comment. - update with clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139137/new/ https://reviews.llvm.org/D139137 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clan

[PATCH] D139360: [clang][dataflow] Support (in)equality operators in `optional` model.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139360/new/ https://reviews.llvm.org/D139360

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 480217. schittir added a comment. Move the assert to after the branches that handle the cases where Initializer may be null CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaIni

[clang] 7d58c95 - [Clang] Don't consider default constructors ineligible if the more constrained constructor is a template

Author: Roy Jacobson Date: 2022-12-05T23:02:37+02:00 New Revision: 7d58c95635cce63ce6acd43c953b57f10bf5c686 URL: https://github.com/llvm/llvm-project/commit/7d58c95635cce63ce6acd43c953b57f10bf5c686 DIFF: https://github.com/llvm/llvm-project/commit/7d58c95635cce63ce6acd43c953b57f10bf5c686.diff

[PATCH] D139038: [Clang] Don't consider default constructors ineligible if the more constrained constructor is a template

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d58c95635cc: [Clang] Don't consider default constructors ineligible if the more constrained… (authored by royjacobson). Repository: rG LLVM Githu

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

pcc added a comment. Can't this be implicit if LTO is being used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138337/new/ https://reviews.llvm.org/D138337 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D139360: [clang][dataflow] Support (in)equality operators in `optional` model.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds interpretation of the overloa

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Please don't ping every day. We haven't lost track of your patch, we're just busy reviewing other things. This seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 480198. zahiraam edited the summary of this revision. Herald added subscribers: pcwang-thead, nlopes, abrachet, sstefan1, phosek, s.egerton, ormris, mstorsjo, simoncook, fedor.sergeev, aheejin, dschuff. Herald added a reviewer: jdoerfert. Herald added a revie

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

MaskRay added a comment. See `clang/lib/Driver/ToolChains/Clang.cpp:6191` `if (TC.SupportsProfiling()) {`. You can define `SupportsProfiling` as false for zos. It's a `-Wunused-command-line-argument` warning, not an error, but may be good enough. `-p` has already been handled. Repository:

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 480189. ayzhao marked 2 inline comments as done. ayzhao added a comment. add missing EOF newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/Re

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:581 + Expr *filler = nullptr; + if (auto *ILE = dyn_cast(ExprToVisit)) +filler = ILE->getArrayFiller(); ayzhao wrote: > ilya-biryukov wrote: > > ilya-biryukov wrote: > > > ayzhao wrot

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a formatting nit fixed, but you should add a release note for the fix when landing. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:1688 for (cons

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. (ping, maybe) In D138958#3968118 , @lebedev.ri wrote: > I've been thinking, and it seems to me that explicitly opting into > `__attribute__((nounwind))`-provided semantics should override > the `__attribute__((nothrow))`/`noe

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 480184. ayzhao added a comment. use NumUserSpecifiedExprs instead of syntatic/semantic forms, also address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D12953

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao marked 4 inline comments as done. ayzhao added a comment. In D129531#3971392 , @ilya-biryukov wrote: > Thanks! > > I have two major comments and also inline NITs. Not sure if we should block > on those, just wanted to hear your opinions: > > - `I

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:177-178 + case tok::kw___attribute: + case tok::kw_const: + case tok::kw_volatile: + case tok::star: urazoff wrote: > aaron.ballman wrote: > > What about other qualifiers? `_Nullab

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * efriedma wrote: > lebedev.ri wrote: > > tentzen wrote

[PATCH] D139326: [clang] Add test for CWG952

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though I would appreciate another test (that I expect to pass). Comment at: clang/test/CXX/drs/dr9xx.cpp:76 +namespace dr952 { // dr952: yes +struct A { + typedef int I; // #dr952-typedef-decl -

[PATCH] D139172: [clang] Mark CWG554 as N/A

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139172/new/ https://reviews.llvm.org/D139172 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D139343: [Driver][PPC] Support -mtune=auto

qiongsiwu1 abandoned this revision. qiongsiwu1 added a comment. It is decided that we no longer need this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139343/new/ https://reviews.llvm.org/D139343 ___

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 480159. abidmalikwaterloo marked 3 inline comments as done. abidmalikwaterloo added a comment. Update the patch based on the feedback and comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

efriedma added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * lebedev.ri wrote: > tentzen wrote: > > lebedev.ri wrote: > > > This test broke once we always starte

[PATCH] D139343: [Driver][PPC] Support -mtune=auto

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, nemanjai, MaskRay. qiongsiwu1 added projects: clang, PowerPC. Herald added subscribers: StephenFan, shchenz, kbarton. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-comm

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ilya-biryukov added a comment. Thanks! I have two major comments and also inline NITs. Not sure if we should block on those, just wanted to hear your opinions: - `InitListExpr` and `CXXParenInitListExpr` have some code in common. Code duplication is substantial and I think sharing the common i

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin added a comment. pin~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

  1   2   >