[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

jmciver added a comment. Added GitHub issue 58553 , which provides the full error message and repeatability information. If this patch is accepted can someone please commit on my behalf? - User name: `John McIver` - User email: `john.mciver

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen updated this revision to Diff 469963. ychen added a comment. - add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136545/new/ https://reviews.llvm.org/D136545 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaOverload.

[PATCH] D136090: Handle errors in expansion of response files

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1029 if (llvm::sys::path::is_relative(CfgFilePath)) { - if (getVFS().makeAbsolute(CfgFilePath)) -return true; - auto Status = getVFS().status(CfgFilePath); - if (

[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

jmciver created this revision. Herald added a project: All. jmciver added reviewers: Izaron, Ericson2314, thieta, tstellar. jmciver published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Resolves undefined references to vtable for clang::ASTConsu

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p2.cpp:10 }; - bool k1 = A() < A(); // not ordered by constraints: prefer non-rewritten form - bool k2 = A() < A(); // prefer more-constrained 'operator<=>' Remove this

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen created this revision. ychen added reviewers: erichkeane, royjacobson, mizvekov. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per wordings in - https://eel.is/c++draft/over.match#best.general-2.6

[PATCH] D136090: Handle errors in expansion of response files

sepavloff added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1188 + // macros. + if (!RelativeNames && !InConfigFile) return Error::success(); rovka wrote: > Why do you need to add `!InConfigFile` here and below? It is not necessary, beca

[PATCH] D136090: Handle errors in expansion of response files

sepavloff updated this revision to Diff 469957. sepavloff added a comment. Small changes proposed by reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136090/new/ https://reviews.llvm.org/D136090 Files: clang/include/clang/Basic/Diagnostic

[clang] c9447c6 - [Clang] fold expression is considered atomic during constraints normalization

Author: Yuanfang Chen Date: 2022-10-22T20:48:57-07:00 New Revision: c9447c62966e5ec60ec277e4a7d75420224f53f6 URL: https://github.com/llvm/llvm-project/commit/c9447c62966e5ec60ec277e4a7d75420224f53f6 DIFF: https://github.com/llvm/llvm-project/commit/c9447c62966e5ec60ec277e4a7d75420224f53f6.diff

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4354 + +// Emit codeview command line if requested. +if (Args.hasFlag(options::OPT_gcodeview_command_line, aganea wrote: > aeubanks wrote: > > MaskRay wrote: > > > This need

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks updated this revision to Diff 469954. aeubanks added a comment. default to off Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 Files: clang/include/clang/Basic/CodeGenOptions.def clang/includ

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 469953. calebzulawski added a comment. Try to fix windows test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files: clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D136022: [clang] Add time profile for constant evaluation

Izaron added a comment. In D136022#3877399 , @dyung wrote: > Hi @Izaron, several of our internal tests that run tests using `-ftime-trace` > started crashing when run which I bisected back to your change. I have filed > issue #58551

[PATCH] D136022: [clang] Add time profile for constant evaluation

dyung added a comment. Hi @Izaron, several of our internal tests that run tests using `-ftime-trace` started crashing when run which I bisected back to your change. I have filed issue #58551 for it, can you take a look? Repository: rG LLVM

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 added a comment. Regarding this, can we just move those two helper functions to private.h ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:366 + "'Zcmt' (table jump instuctions for code-size reduction)", + [FeatureExtZca]>; // TODO: add Zicsr as another dependence +def HasStdExtZcmt : Predicate<

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 469947. VincentWu marked 12 inline comments as done. VincentWu edited the summary of this revision. VincentWu added a comment. - update the document - Throw an error when `+c` and `+zcmt` are both specified - test CSR Repository: rG LLVM Github Monorepo

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 469948. calebzulawski added a comment. Fix test using `RUN` in `CHECK` prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files: clang/lib/Driver/ToolChai

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 added a comment. > we used both kmp relevent data structure/types and APIs, so should I wrap all > those relevant code into several tool functions and put them into separate > header file? IMO we can put all KMP related code into one header and include it where needed. For the o

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136539/new/ https://reviews.llvm.org/D136539

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski marked an inline comment as done. calebzulawski added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2147 +default: + // We shouldn't get here, unless the target OS doesn't have an SDK. + break; calebzulawski wrote

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 469940. calebzulawski added a comment. Fix formatting, error on unrecognized OS, skip tests if xcrun isn't present. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D1363

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson added a comment. friendly ping @njames93 FWIW I ran this over the LLVM codebase and have seen no crashes or false positives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404 __

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. The magic number 50 was removed in D134942 , as a behavior change for performance reason. Whil

[PATCH] D136437: [clang-format] Insert closing braces after an unaffected line

owenpan planned changes to this revision. owenpan added a comment. The assertions failed on the new examples in #58161. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13643

[PATCH] D136437: [clang-format] Insert closing braces after an unaffected line

owenpan added a comment. In D136437#3874832 , @MyDeveloperDay wrote: > Does this need a unit test? or are we good? I will add the tests from https://github.com/llvm/llvm-project/issues/58161 in another patch after moving InsertBraces tests out of Forma

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

owenpan added a comment. Can you add a test to `TokenAnnotatorTest.cpp`? Comment at: clang/unittests/Format/FormatTest.cpp:19973-19974 + verifyFormat("#pragma region TEST(FOO: NOSPACE)", Style); + EXPECT_EQ("#pragma region TEST(FOO: NOSPACE)", +format("#pragma reg

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Fixes GH58547. Signed-off-by: Matheus Izvekov Repository: rG

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. I think the type printer's purpose is for printing types for diagnostics, not for generating a lossless representation of types as strings, as the ast dumper does. So packing so much information in them that hurts readability would be against that purpose. I do agree w

[PATCH] D136532: [clang][Interp] Implement left and right shifts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a test case based on `test/SemaCXX/shift.cpp`.

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2147 +default: + // We shouldn't get here, unless the target OS doesn't have an SDK. + break; carlocab wrote: > `llvm_unreachable`? Or `assert`, at least. I'm no

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

carlocab added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2147 +default: + // We shouldn't get here, unless the target OS doesn't have an SDK. + break; `llvm_unreachable`? Or `assert`, at least. Comment at

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2120 +Optional SDKName = None; +if (getTriple().isWatchOS()) { + if (getTriple().isSimulatorEnvironment()) tschuett wrote: > Will there be an enum over the Apple

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 469909. calebzulawski added a comment. Use switch when detecting OS. Limit sdkroot test to darwin platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Fi

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

tschuett added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2120 +Optional SDKName = None; +if (getTriple().isWatchOS()) { + if (getTriple().isSimulatorEnvironment()) Will there be an enum over the Apple variants to make this l

[PATCH] D135885: [clang][LTO][NFC] Adding More Tests for AIX Options

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdd11bbace5e: [clang][LTO][NFC] Adding More Tests for AIX Options (authored by Qiongsi Wu ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] bdd11bb - [clang][LTO][NFC] Adding More Tests for AIX Options

Author: Qiongsi Wu Date: 2022-10-22T11:09:03-04:00 New Revision: bdd11bbace5ee74036912a534ff5a7e07dd102de URL: https://github.com/llvm/llvm-project/commit/bdd11bbace5ee74036912a534ff5a7e07dd102de DIFF: https://github.com/llvm/llvm-project/commit/bdd11bbace5ee74036912a534ff5a7e07dd102de.diff LO

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 469901. calebzulawski added a comment. Change tests to specifically remove `SDKROOT` environment variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files

[PATCH] D134958: [clang][Interp] Support __builtin_clz calls

tbaeder abandoned this revision. tbaeder added a comment. Let's shelve this until later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134958/new/ https://reviews.llvm.org/D134958 ___ cfe-commits mailing

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo added a comment. In D136355#3875265 , @aaron.ballman wrote: > LGTM aside from a tiny grammar nit. Thank you for the fix! If you'd like me > to commit this on your behalf, I can fix up the release note myself when > landing, but please let me kno

[PATCH] D136528: [clang][Interp] Implement add and sub compound assign operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

tbaeder updated this revision to Diff 469875. tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135858/new/ https://reviews.llvm.org/D135858 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Inter

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc79ddb52c31: [clang][Interp] Check instance pointers before calling functions on them (authored by tbaeder). Repository: rG LLVM Github Monorepo

[clang] 0e754cf - [clang][Interp][NFC] Unify Call() implementations

Author: Timm Bäder Date: 2022-10-22T10:32:05+02:00 New Revision: 0e754cfadc9487282d9b6119c41962c5c6c3660f URL: https://github.com/llvm/llvm-project/commit/0e754cfadc9487282d9b6119c41962c5c6c3660f DIFF: https://github.com/llvm/llvm-project/commit/0e754cfadc9487282d9b6119c41962c5c6c3660f.diff LO

[clang] cc79ddb - [clang][Interp] Check instance pointers before calling functions on them

Author: Timm Bäder Date: 2022-10-22T10:32:05+02:00 New Revision: cc79ddb52c310be50d2ed0e0307b695cc7c142ce URL: https://github.com/llvm/llvm-project/commit/cc79ddb52c310be50d2ed0e0307b695cc7c142ce DIFF: https://github.com/llvm/llvm-project/commit/cc79ddb52c310be50d2ed0e0307b695cc7c142ce.diff LO

[clang] 8013ab4 - [clang][Interp][NFC] Simplify creating parameter descriptors

Author: Timm Bäder Date: 2022-10-22T10:32:05+02:00 New Revision: 8013ab4f98c2ed3bb11dcb83179664cb595c31bb URL: https://github.com/llvm/llvm-project/commit/8013ab4f98c2ed3bb11dcb83179664cb595c31bb DIFF: https://github.com/llvm/llvm-project/commit/8013ab4f98c2ed3bb11dcb83179664cb595c31bb.diff LO

[clang] d49fe7c - [clang][Interp][NFC] Add another failing test case

Author: Timm Bäder Date: 2022-10-22T10:32:05+02:00 New Revision: d49fe7c95bdf35dcb39068550a7c4039769de414 URL: https://github.com/llvm/llvm-project/commit/d49fe7c95bdf35dcb39068550a7c4039769de414 DIFF: https://github.com/llvm/llvm-project/commit/d49fe7c95bdf35dcb39068550a7c4039769de414.diff LO

[clang] 4abd868 - [clang][Interp][NFC] Trim InterpFrame includes

Author: Timm Bäder Date: 2022-10-22T10:32:05+02:00 New Revision: 4abd8683043811792dcbc597abaa02bb482bb959 URL: https://github.com/llvm/llvm-project/commit/4abd8683043811792dcbc597abaa02bb482bb959 DIFF: https://github.com/llvm/llvm-project/commit/4abd8683043811792dcbc597abaa02bb482bb959.diff LO

[clang] c29f063 - [clang][Interp] Add a missing static_assert message

Author: Timm Bäder Date: 2022-10-22T10:32:05+02:00 New Revision: c29f0638c1e17635ad0c0f2fc37bd16c81db1a9b URL: https://github.com/llvm/llvm-project/commit/c29f0638c1e17635ad0c0f2fc37bd16c81db1a9b DIFF: https://github.com/llvm/llvm-project/commit/c29f0638c1e17635ad0c0f2fc37bd16c81db1a9b.diff LO

[clang] d78a395 - [clang][Interp][NFC] Add two more array tests

Author: Timm Bäder Date: 2022-10-22T10:19:42+02:00 New Revision: d78a3957ea35eda2a50530d7afed9c7cc30a0d18 URL: https://github.com/llvm/llvm-project/commit/d78a3957ea35eda2a50530d7afed9c7cc30a0d18 DIFF: https://github.com/llvm/llvm-project/commit/d78a3957ea35eda2a50530d7afed9c7cc30a0d18.diff LO

[clang] c01ac37 - [clang][Interp][NFC] Add assertions to VM entry points

Author: Timm Bäder Date: 2022-10-22T10:19:42+02:00 New Revision: c01ac372fc3308e4c6c31361e44e604410cd1573 URL: https://github.com/llvm/llvm-project/commit/c01ac372fc3308e4c6c31361e44e604410cd1573 DIFF: https://github.com/llvm/llvm-project/commit/c01ac372fc3308e4c6c31361e44e604410cd1573.diff LO

[clang] 7a66e6e - [clang][Interp][NFC] Unify Div/Rem operation checks

Author: Timm Bäder Date: 2022-10-22T10:19:42+02:00 New Revision: 7a66e6e19bd42bdb53dcca9156f2ca52c5931f7e URL: https://github.com/llvm/llvm-project/commit/7a66e6e19bd42bdb53dcca9156f2ca52c5931f7e DIFF: https://github.com/llvm/llvm-project/commit/7a66e6e19bd42bdb53dcca9156f2ca52c5931f7e.diff LO

[PATCH] D136454: [clangd] Make file limit for textDocument/rename configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ed4a543b8b3: [clangd] Make file limit for textDocument/rename configurable (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136454/new

[clang-tools-extra] 6ed4a54 - [clangd] Make file limit for textDocument/rename configurable

Author: Christian Kandeler Date: 2022-10-22T10:17:41+02:00 New Revision: 6ed4a543b8b3ab38ddb30cf4c15b70ed11266388 URL: https://github.com/llvm/llvm-project/commit/6ed4a543b8b3ab38ddb30cf4c15b70ed11266388 DIFF: https://github.com/llvm/llvm-project/commit/6ed4a543b8b3ab38ddb30cf4c15b70ed11266388.

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

wzssyqa added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. I don't think that we need that option: what we need to do is to update the old tools. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80392/new/ https://re

[PATCH] D136154: [clang-format] Fix the continuation indenter

owenpan added a comment. In D136154#3867328 , @MyDeveloperDay wrote: > Can we log a GitHub issue I can’t see what you are trying to fix @hel-ableton Can you log an issue for this and add a link to it in `SUMMARY`? In D136154#3867441