VincentWu added inline comments.
================ Comment at: llvm/lib/Target/RISCV/RISCV.td:366 + "'Zcmt' (table jump instuctions for code-size reduction)", + [FeatureExtZca]>; // TODO: add Zicsr as another dependence +def HasStdExtZcmt : Predicate<"Subtarget->hasStdExtZcmt() && !Subtarget->hasStdExtC()">, ---------------- jrtc27 wrote: > This is an odd implication, Zcmt works just fine without Zca? the [[ https://github.com/riscv/riscv-code-size-reduction/releases/tag/v1.0.0-RC5.7 | spec ]] says: > The Zcmt extension depends on the Zca and Zicsr extensions. I think maybe `zcmt` needs to be aligned using `c.nop`? That might be one of the reasons why `zcmt` required `zca`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
