[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3848539 , @ChuanqiXu wrote: > In D134267#3847399 , @iains wrote: > >> >> I am concerned that with the current scheme (with or without the change in >> this review) we could e

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 466710. tingwang added a comment. Rebase && Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeG

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

tingwang updated this revision to Diff 466708. tingwang added a comment. Rebase on opaque-pointers test case changes && Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133488/new/ https://reviews.llvm.org/D133488 Files: clang/test/Cod

[PATCH] D135555: [libclang] CIndex: Visit UsingTypeLoc as TypeRef

kiloalphaindia added a comment. @sammccall I don't think I can commit anything. Can you please do it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13/new/ https://reviews.llvm.org/D13 ___ cfe-co

[PATCH] D135558: [Clang][NFC]Use isa instead of dyn_cast in shouldAddReversedEqEq

tbaeder added a comment. This was fixed as https://github.com/llvm/llvm-project/commit/6c49d5db30227d21e929bb12dc046c36ede67fad. Note that for such patches, you don't need to wait for review, like Erich didn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

kees added a comment. In D134902#3848595 , @serge-sans-paille wrote: > I second the opinion here. C99 says nothing about flexible array member for > unions, that's already a "language extension". (and so not be considered as > FAM by `-fstrict-flex-arr

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

kees added a comment. In D134902#3848246 , @void wrote: > @rsmith, @serge-sans-paille, and @kees, I need some advice. There's a test in > `clang/test/CodeGen/bounds-checking.c` that's checking bounds stuff on > unions. The behavior is...weird to me. It

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

serge-sans-paille added a comment. In D134902#3848246 , @void wrote: > @rsmith, @serge-sans-paille, and @kees, I need some advice. There's a test in > `clang/test/CodeGen/bounds-checking.c` that's checking bounds stuff on > unions. The behavior is...wei

[PATCH] D135555: [libclang] CIndex: Visit UsingTypeLoc as TypeRef

kiloalphaindia updated this revision to Diff 466701. kiloalphaindia added a comment. renamed function `from_CXString` -> `fromCXString` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13/new/ https://reviews.llvm.org/D13 Files: clang/tools

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder updated this revision to Diff 466700. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135366/new/ https://reviews.llvm.org/D135366 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/I

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:445-446 +const CharacterLiteral *E) { + if (Optional T = classify(E->getType())) +return this->emitConst(E, E->getValue()); + ta

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1166 +// TODO: CheckCallable + } + I think this is okay to do for now, but in the long run we need to check *all* the parameters passed to function calls... CHANGES SINCE LAST ACTION

[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

tbaeder added a comment. In D135569#3847493 , @aaron.ballman wrote: > This function is testing whether something is potentially a constant > expression. Something might not be a valid constant expression for two > reasons: 1) it uses some prohibited la

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3847399 , @iains wrote: > FAOD: I think this should not be about "who's patches" - but about the > compilation model and command lines that we want to end up with. Yeah, of course. > I am concerned that with the cu

[PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + mizvekov wrote: > ChuanqiXu

[PATCH] D135422: [clang-format] Fix misattributing preprocessor directives to macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0758f62afb6: [clang-format] Fix mis-attributing preprocessor directives to macros (authored by jacob-abraham, committed by owenpan). Changed prior

[clang] b0758f6 - [clang-format] Fix mis-attributing preprocessor directives to macros

Author: Jacob Abraham Date: 2022-10-10T19:57:58-07:00 New Revision: b0758f62afb6945edfb2046da10b338bb6ced474 URL: https://github.com/llvm/llvm-project/commit/b0758f62afb6945edfb2046da10b338bb6ced474 DIFF: https://github.com/llvm/llvm-project/commit/b0758f62afb6945edfb2046da10b338bb6ced474.diff

[PATCH] D135422: [clang-format] Fix misattributing preprocessor directives to macros

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:654 break; + if(Line->InMacroBody != InMacroBody) +break; Did you run `git-clang-format`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/n

[PATCH] D131698: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

michele.scandale added a comment. @rjmccall would you be able to land this on my behalf? Thanks in advance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131698/new/ https://reviews.llvm.org/D131698 ___

[PATCH] D131698: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

michele.scandale updated this revision to Diff 466686. michele.scandale added a comment. Final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131698/new/ https://reviews.llvm.org/D131698 Files: clang/lib/Sema/TreeTransform.h clang/test/S

[PATCH] D135637: [clang][deps] Prevent emitting diagnostics outside of source file

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner

[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

jansvoboda11 created this revision. jansvoboda11 added reviewers: akyrtzi, benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With implicitl

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3846907 , @aaron.ballman wrote: > In D133066#3845136 , @zhouyizhou > wrote: > >> After 4 weeks' study, I think the comment didn't need to be changed, sorry >> to have brin

[PATCH] D135628: [clang][codegen] Don't emit atomic loads for threadsafe init if they aren't inline

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Makes sense. Nice code-size optimization at any rate. Hmm, actually, along those lines, should we do the same thing at `-Oz`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D131698: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131698/new/ https://reviews.llvm.org/D131698 ___

[PATCH] D135339: [clang] makes `__is_destructible` KEYALL instead of KEYMS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14e64cb8d594: [clang] makes `__is_destructible` KEYALL instead of KEYMS (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa089defa24dd: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable` (authored by cjdb). Repository: rG LLVM Github Monorepo C

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd3f48eefc11: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins (authored by cjdb). Repository: rG LLVM Github Monorepo CH

[clang] 14e64cb - [clang] makes `__is_destructible` KEYALL instead of KEYMS

Author: Christopher Di Bella Date: 2022-10-11T00:13:58Z New Revision: 14e64cb8d594c16c722da83d3e8af9fc0d013c4e URL: https://github.com/llvm/llvm-project/commit/14e64cb8d594c16c722da83d3e8af9fc0d013c4e DIFF: https://github.com/llvm/llvm-project/commit/14e64cb8d594c16c722da83d3e8af9fc0d013c4e.dif

[clang] bd3f48e - [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

Author: Christopher Di Bella Date: 2022-10-11T00:13:58Z New Revision: bd3f48eefc11c2f1ef6eb034418697e24e9a965d URL: https://github.com/llvm/llvm-project/commit/bd3f48eefc11c2f1ef6eb034418697e24e9a965d DIFF: https://github.com/llvm/llvm-project/commit/bd3f48eefc11c2f1ef6eb034418697e24e9a965d.dif

[clang] a089def - [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

Author: Christopher Di Bella Date: 2022-10-11T00:13:58Z New Revision: a089defa24dd4050192e1e8d7e704188d2214787 URL: https://github.com/llvm/llvm-project/commit/a089defa24dd4050192e1e8d7e704188d2214787 DIFF: https://github.com/llvm/llvm-project/commit/a089defa24dd4050192e1e8d7e704188d2214787.dif

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands updated this revision to Diff 48. anderslanglands added a comment. Fixed clang-format error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135557/new/ https://reviews.llvm.org/D135557 Files: clang/bindings/python/clang/cindex.

[PATCH] D135422: [clang-format] Fix misattributing preprocessor directives to macros

jacob-abraham added a comment. > We need your name and email address for the authorship. Name: Jacob Abraham Email: jacob.r.abra...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 ___ cfe-

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added a comment. +#clang-vendors for ABI changes Comment at: clang/include/clang/Basic/TargetInfo.h:1569 + virtual bool areDefaultedSMFStillPOD(const LangOptions&) const; + Please add a doc comment for this,

[PATCH] D135595: [HLSL] Add utility to convert environment to stage

beanz added a comment. We should absolutely add utility functions when we have uses for them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135595/new/ https://reviews.llvm.org/D135595 ___ cfe-commits ma

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added a reviewer: rsmith. void added a subscriber: rsmith. void added a comment. @rsmith, @serge-sans-paille, and @kees, I need some advice. There's a test in `clang/test/CodeGen/bounds-checking.c` that's checking bounds stuff on unions. The behavior is...weird to me. It says that an array

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron updated this revision to Diff 41. Izaron added a comment. Removed excessive newline. Thanks to @Eugene.Zelenko! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ https://reviews.llvm.org/D118743 Files: clang-tools-extra/clang

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/use-inline-const-variables-in-headers.rst:5 +=== + + Excessive newline. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D135422: [clang-format] Fix misattributing preprocessor directives to macros

owenpan accepted this revision. owenpan added a comment. LGTM. In D135422#3847053 , @jacob-abraham wrote: > I do not have commit access, can someone make this commit on my behalf? Thank > you! We need your name and email address for the authorship.

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron updated this revision to Diff 40. Izaron added a comment. Rebased onto main (after a long long time). Thanks to @LegalizeAdulthood for instructions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ https://reviews.llvm.org/D118

[PATCH] D131698: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

michele.scandale added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131698/new/ https://reviews.llvm.org/D131698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D135628: [clang][codegen] Don't emit atomic loads for threadsafe init if they aren't inline

efriedma updated this revision to Diff 466657. efriedma added a comment. Upload correct version of patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135628/new/ https://reviews.llvm.org/D135628 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clan

[PATCH] D135595: [HLSL] Add utility to convert environment to stage

python3kgae added a comment. In D135595#3847158 , @beanz wrote: > In D135595#3847056 , @python3kgae > wrote: > >> Backend needs the same thing. >> Is it possible to move this to llvm and share it between frontend

[PATCH] D135628: [clang][codegen] Don't emit atomic loads for threadsafe init if they aren't inline

efriedma created this revision. efriedma added reviewers: rjmccall, nikic. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. Performing a load before calling __cxa_guard_acquire is supposed to be an optimization, but it isn't much of one if we

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

rnk added a comment. I think in the end, perhaps it is not worth disturbing this code. Comment at: clang/lib/Basic/Targets/OSTargets.h:169 +if (T.getOS() == llvm::Triple::WatchOS || +this->getCXXABI().getKind() == TargetCXXABI::AppleARM64) + return TargetInfo::

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

rjmccall added a comment. If you have `char`, would you want it to promote? Because turning `char` to `_BitInt(8)` is breaking with C on other grounds (like aliasing), for better or worse. So if you just don't want promotion, maybe you really should just disable promotion. Repository: rG

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen updated this revision to Diff 466635. samitolvanen added a comment. Switched to `instructions(F)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135411/new/ https://reviews.llvm.org/D135411 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

dblaikie added a comment. In D135551#3847607 , @aaron.ballman wrote: > In D135551#3847444 , @dblaikie > wrote: > >> I thought this was settled quite a while ago and enshrined in the style >> guide: https://llvm

[PATCH] D135411: Add generic KCFI operand bundle lowering

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:48-49 + SmallVector KCFICalls; + for (inst_iterator I = inst_begin(F), E = inst_end(F); I != E; ++I) { +if (auto *CI = dyn_cast(&*I)) + if (CI->getOperandBundle(LLVMContext:

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

beanz added a comment. In D133668#3847871 , @rjmccall wrote: > But that's purely on the implementation level, right? Everything is > implicitly vectorized and you're just specifying the computation of a single > lane, but as far as that lane-wise compu

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae updated this revision to Diff 466623. python3kgae added a comment. Add end of file newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135429/new/ https://reviews.llvm.org/D135429 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:143 + +}; tahonermann wrote: > As others already noted, additional testing of multicharacter literals and > UCNs (including named universal characters like `\N{LATIN_CAPITAL_LETTER_E}`

[PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

aeubanks updated this revision to Diff 466622. aeubanks added a comment. update python test, although those changes don't actually test the code path changed here, the code path here is tested via the existing `self.expect("image lookup -t A")` Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

aeubanks added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1298 + case BuiltinType::WChar_U: +break; // no suffix. } DavidSpickett wrote: > Is there any reason to have a suffix here? > > I admit this function is puzzling to me anyway given

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

rjmccall added a comment. In D133668#3847807 , @beanz wrote: > In D133668#3847163 , @rjmccall > wrote: > >> Sure, but it's extremely easy to unpromote that arithmetic for most >> operators, and I'm sure LLVM alr

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tahonermann added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:445-446 +const CharacterLiteral *E) { + if (Optional T = classify(E->getType())) +return this->emitConst(E, E->getValue()); + `T` isn't used and `classify()` already

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:48-49 + SmallVector KCFICalls; + for (inst_iterator I = inst_begin(F), E = inst_end(F); I != E; ++I) { +if (auto *CI = dyn_cast(&*I)) + if (CI->getOperandBundle(LLVMContext::OB

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen updated this revision to Diff 466612. samitolvanen marked 2 inline comments as done. samitolvanen added a comment. Addressed feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135411/new/ https://reviews.llvm.org/D135411 Files:

[clang] 52b8f3a - [LinkerWrapper] Fix failing linker wrapper save temps test

Author: Joseph Huber Date: 2022-10-10T15:56:46-05:00 New Revision: 52b8f3a80c6b2b1efcd91e2278bd9d63a0b1567b URL: https://github.com/llvm/llvm-project/commit/52b8f3a80c6b2b1efcd91e2278bd9d63a0b1567b DIFF: https://github.com/llvm/llvm-project/commit/52b8f3a80c6b2b1efcd91e2278bd9d63a0b1567b.diff

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

jhuber6 added a comment. In D135614#3847775 , @tra wrote: > Is that really something we need/want to do? I've never seen anyone > complaining about this particular issue. > > clang/gcc are case-sensitive for similar options, like `-march`: > https://god

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

beanz added a comment. In D133668#3847163 , @rjmccall wrote: > Sure, but it's extremely easy to unpromote that arithmetic for most > operators, and I'm sure LLVM already has a pass that will do that. Okay... but HLSL explicitly doesn't promote. Having t

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

tra added a comment. Is that really something we need/want to do? I've never seen anyone complaining about this particular issue. clang/gcc are case-sensitive for similar options, like `-march`: https://godbolt.org/z/3jKzTda7h I think offloading options should behave consistently in that regard

[PATCH] D135091: Fix assert in generated `direct` property getter/setters due to removal of `_cmd` parameter.

mwyman updated this revision to Diff 466602. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135091/new/ https://reviews.llvm.org/D135091 Files: clang/lib/CodeGen/CGObjC.cpp clang/test/CodeGenObjC/direct-method.m Index: clang/test/CodeGenObjC/direct-method.m =

[PATCH] D135500: [Clang] reject bit-fields as instruction operands in Microsoft style inline asm blocks.

tahonermann marked 2 inline comments as done. tahonermann added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:937 for (uint64_t I = 0; I < NumOutputs + NumInputs; ++I) { -if (Exprs[I]->getType()->isBitIntType()) - return StmtError( - Diag(Exprs[

[PATCH] D135518: [clangAST] support TypeLoc in TextNodeDumper

aaron.ballman added a comment. Thank you for working on this! Should we make similar changes to the `JSONNodeDumper` as well? (It doesn't seem to have `TypeLoc` support.) Comment at: clang/include/clang/AST/ASTDumperUtils.h:55-56 static const TerminalColor TypeColor = {llvm::

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Is it worth it and possible to fully decompose `LocalSLocEntryTable` into arrays of its constituent parts, and only construct a `SLocEntry` when necessary? I'm ok with the c

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added subscribers: kosarev, mattd, guansong, hiraditya, t-tye, tpr, dstuttard, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-co

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

hokein added a comment. More data on clang memory usage (measured with the `clang -cc1 -fsyntax-only -print-stats`, AST size = ASTContext + Decl + Stmt/Expr; Total = AST size + SourceManager size) The memory increase for C++ is negligible (< 1%), but for C, we have ~5% memory increase. |

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

hokein added a comment. >> SemaExpr.cpp: 149529494 -> 149502874 > > Are these numbers backwards? Why would memory usage go down? Oops, you're right, I made a mistake, correct it in the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1354

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

hokein updated this revision to Diff 466595. hokein added a comment. print memory usage in SourceManager::PrintStats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135440/new/ https://reviews.llvm.org/D135440 Files: clang/include/clang/Basic/Sou

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

troyj added a comment. I agree. I wouldn't want to mislead people into thinking that they'll see this improvement on everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D135370 __

[clang] 6b89e89 - Reword diagnostics for style; NFC

Author: Aaron Ballman Date: 2022-10-10T15:53:48-04:00 New Revision: 6b89e897e7dc73dc6a112b18920deb8282aaca97 URL: https://github.com/llvm/llvm-project/commit/6b89e897e7dc73dc6a112b18920deb8282aaca97 DIFF: https://github.com/llvm/llvm-project/commit/6b89e897e7dc73dc6a112b18920deb8282aaca97.diff

[PATCH] D135500: [Clang] reject bit-fields as instruction operands in Microsoft style inline asm blocks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0982db188b66: [Clang] reject bit-fields as instruction operands in Microsoft style inline asm… (authored by tahonermann). Repository: rG LLVM Gith

[clang] 0982db1 - [Clang] reject bit-fields as instruction operands in Microsoft style inline asm blocks.

Author: Tom Honermann Date: 2022-10-10T15:45:02-04:00 New Revision: 0982db188b661d6744b06244fda64d43dd80206e URL: https://github.com/llvm/llvm-project/commit/0982db188b661d6744b06244fda64d43dd80206e DIFF: https://github.com/llvm/llvm-project/commit/0982db188b661d6744b06244fda64d43dd80206e.diff

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bb86b674476: [clang] Mention -Werror changes revived for Clang 16 (authored by thesamesam, committed by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 2bb86b6 - [clang] Mention -Werror changes revived for Clang 16

Author: Sam James Date: 2022-10-10T21:44:30+02:00 New Revision: 2bb86b67447661077e30674eab7b8a27f8234b3f URL: https://github.com/llvm/llvm-project/commit/2bb86b67447661077e30674eab7b8a27f8234b3f DIFF: https://github.com/llvm/llvm-project/commit/2bb86b67447661077e30674eab7b8a27f8234b3f.diff LOG

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

bruno added a comment. > LGTM! Should we also add a release note or do we think this isn't enough of a > compile-time performance improvement to warrant that? Good point @aaron.ballman, given we have only observed in a few corner case large TUs I'd say it's probably not that normally perceiva

[PATCH] D135500: [Clang] reject bit-fields as instruction operands in Microsoft style inline asm blocks.

tahonermann updated this revision to Diff 466589. tahonermann added a comment. Rebased and addressed code review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135500/new/ https://reviews.llvm.org/D135500 Files: clang/docs/ReleaseNotes.

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

mgorny accepted this revision. mgorny added a comment. Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135545/new/ https://reviews.llvm.org/D135545 ___ cfe-commits mailing list cfe-c

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

dexonsmith added a comment. I would think we could convert every assert(0) to either `llvm::report_fatal_error` (guaranteed trap) or `llvm_unreachable()` (trap or optimize, depending on CMAKE configuration). The C API usage checks seem like good candidates for the former. Also, not sure if eve

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

aaron.ballman added a comment. In D135551#3847444 , @dblaikie wrote: > I thought this was settled quite a while ago and enshrined in the style > guide: https://llvm.org/docs/CodingStandards.html#assert-liberally > > `assert(0)` should not be used if some

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. I tried an out-of-tree flang build. check-flang passes in that case too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D135608: Update implementation status of P2468R2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe66cfb63ceed: Update implementation status of P2468R2 (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] e66cfb6 - Update implementation status of P2468R2

Author: Utkarsh Saxena Date: 2022-10-10T20:56:42+02:00 New Revision: e66cfb63ceed769f6ba61c733b9137fdc6acb1e0 URL: https://github.com/llvm/llvm-project/commit/e66cfb63ceed769f6ba61c733b9137fdc6acb1e0 DIFF: https://github.com/llvm/llvm-project/commit/e66cfb63ceed769f6ba61c733b9137fdc6acb1e0.diff

Re: [clang-tools-extra] 5d2d527 - [clangd] Avoid scanning up to end of file on each comment!

On Mon, Oct 10, 2022 at 11:13 AM Sam McCall wrote: > > On Mon, 10 Oct 2022, 19:57 David Blaikie, wrote: >> >> Could the underlying API be made more robust to handle StringRefs >> rather than null terminated char* in the first place? (like >> SourceManager::getCharacterData could return StringRef?

[clang] 9d69c60 - Fix a typo in the Release Notes; NFC

Author: Aaron Ballman Date: 2022-10-10T14:45:38-04:00 New Revision: 9d69c60357c8349774cbb592742593fb459c1a47 URL: https://github.com/llvm/llvm-project/commit/9d69c60357c8349774cbb592742593fb459c1a47 DIFF: https://github.com/llvm/llvm-project/commit/9d69c60357c8349774cbb592742593fb459c1a47.diff

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

royjacobson added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1476 is false. Note this trait will also return false when the initialization of ``T`` from ``U`` is ill-formed. +* ``__reference_constructs_from_temporary(T, U)`` (C++) We sho

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Whoops, I thought I had already added those release notes, but I didn't! Thank you for catching that! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 6c49d5d - Fix unused variable warning from D134529

Author: Erich Keane Date: 2022-10-10T11:42:43-07:00 New Revision: 6c49d5db30227d21e929bb12dc046c36ede67fad URL: https://github.com/llvm/llvm-project/commit/6c49d5db30227d21e929bb12dc046c36ede67fad DIFF: https://github.com/llvm/llvm-project/commit/6c49d5db30227d21e929bb12dc046c36ede67fad.diff L

[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

aaron.ballman added a comment. This function is testing whether something is potentially a constant expression. Something might not be a valid constant expression for two reasons: 1) it uses some prohibited language construct, 2) it hit undefined behavior. You don't know if you hit undefined be

[PATCH] D135608: Update implementation status of P2468R2

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135608/new/ https://reviews.llvm.org/D135608 __

[PATCH] D135608: Update implementation status of P2468R2

usaxena95 updated this revision to Diff 466571. usaxena95 marked an inline comment as done. usaxena95 added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135608/new/ https://reviews.llvm.org/D135608 Files: clang/www

[PATCH] D135490: [clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused-variable` diagnostic

akyrtzi added a comment. In D135490#3847454 , @steven_wu wrote: > I don't know too much about this. I guess have a DiagReceiver to force the > emitting order is a good thing but it is kind of weird to have this just for > unused warning. > > I am guessi

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:293 + LabelTy CondLabel = this->getLabel(); // Label before the condition. + LabelTy EndLabel = thi

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

dblaikie added a comment. Can't seem to find an llvm-dev/commits discussion for r166821, but I remember discussing it several times before, perhaps this one happened on IRC and so we may not have any record of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D135490: [clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused-variable` diagnostic

steven_wu added a comment. I don't know too much about this. I guess have a DiagReceiver to force the emitting order is a good thing but it is kind of weird to have this just for unused warning. I am guessing my suspect of removing decl from the scope is the cause of the slow down. Maybe we ju

[PATCH] D135608: Update implementation status of P2468R2

cor3ntin added a comment. Thanks for working on this Comment at: clang/www/cxx_status.html:1435 https://wg21.link/P2468R2";>P2468R2 - No + Clang 16 Should be "unreleased" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

dblaikie added a comment. I thought this was settled quite a while ago and enshrined in the style guide: https://llvm.org/docs/CodingStandards.html#assert-liberally `assert(0)` should not be used if something is reachable. We shouldn't have a "this violates an invariant, but if you don't have a

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added a comment. Sent out https://reviews.llvm.org/D135608 to update implementation status. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 ___ cfe-co

  1   2   >