akyrtzi added a comment.

In D135490#3847454 <https://reviews.llvm.org/D135490#3847454>, @steven_wu wrote:

> I don't know too much about this. I guess have a DiagReceiver to force the 
> emitting order is a good thing but it is kind of weird to have this just for 
> unused warning.
>
> I am guessing my suspect of removing decl from the scope is the cause of the 
> slow down. Maybe we just force order on iteration?

Ordering the decls every time `ActOnPopScope` is called is not cheap; ordering 
only the diagnostics (if any is emitted) is the most efficient way I could find.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135490/new/

https://reviews.llvm.org/D135490

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to