[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a8bd00c8f1: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks` (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Gith

[clang] a3a8bd0 - [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

Author: Alvin Wong Date: 2022-09-09T09:55:40+03:00 New Revision: a3a8bd00c8f1e094967a80e56485c421e312dd2e URL: https://github.com/llvm/llvm-project/commit/a3a8bd00c8f1e094967a80e56485c421e312dd2e DIFF: https://github.com/llvm/llvm-project/commit/a3a8bd00c8f1e094967a80e56485c421e312dd2e.diff LO

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 458966. python3kgae added a comment. Only add HLSLExternalSemaSource when ExternalSource is not HLSLExternalSemaSource. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D1

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132867/new/ https://reviews.llvm.org/D132867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 458965. python3kgae added a comment. Only add HLSLSema when not has it in ExternalSource. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files: clang/include/c

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

MaskRay added a comment. In D132727#3779237 , @tbaeder wrote: > Thanks @MaskRay, I thought this was fixed by > https://github.com/llvm/llvm-project/commit/86271798e51a7866dd2af44e0ee183d1331089e6, > at least all the emails I got about failing msan build

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder added a comment. Thanks @MaskRay, I thought this was fixed by https://github.com/llvm/llvm-project/commit/86271798e51a7866dd2af44e0ee183d1331089e6, at least all the emails I got about failing msan builds were missing that change. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D132975: [CMake] Add clang-bolt target

MaskRay added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +-DCMAKE_CXX_COMPILER=${CLANGXX_INSTRUMENTED} +-DCMAKE

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 458958. Navidem added a comment. Add __sanitizer_cov_cfs_init Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/includ

[PATCH] D133405: [Linux] Hack around Linux/sparc

MaskRay accepted this revision. MaskRay added a subscriber: zatrazz. MaskRay added a comment. This revision is now accepted and ready to land. So, sparc64 gcc does seem to define the macro by default. ¯\_(ツ)_/¯ % sparc64-linux-gnu-gcc -E -dM -xc /dev/null -nostdinc | grep NO_INLINE #define __

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. You may want to split the patch, with refactoring as the first, and the Mach-O specific change as the second one. Comment at: clang/

[PATCH] D133539: [OpenMP] Replace OpenMP register requires constructor with a global array

jhuber6 updated this revision to Diff 458948. jhuber6 added a comment. Fix LLVM test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133539/new/ https://reviews.llvm.org/D133539 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGO

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

dblaikie added a comment. In D133354#3778281 , @ningvin wrote: > In D133354#3778237 , @dblaikie > wrote: > >> Got any pointers to the commits/authors that added this functionality in the >> first place? (would b

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

dblaikie added a comment. > In D133425#3778433 , @dblaikie > wrote: > >> So previously/currently-without-this-patch the diagnostic was suppressed if >> the use of ctad was in a system header (suppression based on the >> generic/builtin diagnostic suppre

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1135 +QualType RHSElementType = +RHSComplexType ? RHSComplexType->getElementType() : RHSType; +QualType ResultType = Can you collapse this check with the next line? It just look

[clang] e261b03 - [sanitizers] Add experimental flag to insert sanitizers earlier

Author: Vitaly Buka Date: 2022-09-08T19:05:17-07:00 New Revision: e261b03396078feba2246340f81160f76f7d5e92 URL: https://github.com/llvm/llvm-project/commit/e261b03396078feba2246340f81160f76f7d5e92 DIFF: https://github.com/llvm/llvm-project/commit/e261b03396078feba2246340f81160f76f7d5e92.diff L

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp:1 -// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- -- -fno-delayed-template-parsing +// RUN: %check_clang_tidy %s readability-cont

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 updated this revision to Diff 458943. felix642 added a comment. Changed tests to check with and without config. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 Files: clang-tools-extra/clang-ti

[PATCH] D133539: [OpenMP] Replace OpenMP register requires constructor with a global array

jhuber6 updated this revision to Diff 458937. jhuber6 added a comment. Herald added subscribers: mattd, asavonic. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133539/new/ https://reviews.llvm.org/D133539 Files: clang/lib/CodeGen/CGOpe

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

shafik added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:203 +LLVM_DUMP_METHOD void DeclContext::dumpDecl() const { + if (const Decl *D = dyn_cast(this)) Interesting ` DeclContext::dumpDeclContext()` is in `DeclPrinter.cpp` I wonder why these wer

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. In D133522#3778693 , @ronlieb wrote: > emailed a hopeful reproducer to you I reduced it and confirm it was also fixed by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 458930. ayzhao marked 2 inline comments as done. ayzhao added a comment. p5.cpp -> p4.cpp, removed debug statements haven't yet fully grokked this patch. still looking into fixing test failures and PrevLookupResult. Repository: rG LLVM Github Monorepo CH

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 458924. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. Since the affected patch just got reverted, I will squash these fixes in the original MR instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133522/new/ https://reviews.llvm.org/D133522 ___

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

MaskRay added a comment. In D111509#3778882 , @mizvekov wrote: > In D111509#3778879 , @MaskRay wrote: > >> Since the fix was not merged, I will revert this soon. >> >> I saw a clang segfault with `clang++ libstdc+

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778879 , @MaskRay wrote: > Since the fix was not merged, I will revert this soon. > > I saw a clang segfault with `clang++ libstdc++-v3/src/c++98/complex_io.cc` Would you mind if I just merge it? I was hoping there w

[clang] d8c09b7 - Revert D111509 "[clang] use getCommonSugar in an assortment of places"

Author: Fangrui Song Date: 2022-09-08T17:09:18-07:00 New Revision: d8c09b7bbc09ca5c08299edbf7d32631d3e5bcb8 URL: https://github.com/llvm/llvm-project/commit/d8c09b7bbc09ca5c08299edbf7d32631d3e5bcb8 DIFF: https://github.com/llvm/llvm-project/commit/d8c09b7bbc09ca5c08299edbf7d32631d3e5bcb8.diff

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

MaskRay added a comment. Since the fix was not merged, I will revert this soon. I saw a clang segfault with `clang++ libstdc++-v3/src/c++98/complex_io.cc` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509

[PATCH] D133539: [OpenMP] Replace OpenMP register requires constructor with a global array

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tianshilei1992, ABataev, ronlieb, doru1004, RaviNarayanaswamy. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-comm

[clang] 1f6a86b - [cc1as] Support --compress-debug-sections=zstd

Author: Fangrui Song Date: 2022-09-08T16:31:45-07:00 New Revision: 1f6a86b3097855d321438718daa8b98c58db8137 URL: https://github.com/llvm/llvm-project/commit/1f6a86b3097855d321438718daa8b98c58db8137 DIFF: https://github.com/llvm/llvm-project/commit/1f6a86b3097855d321438718daa8b98c58db8137.diff

[PATCH] D133520: [clang] Use std::size instead of llvm::array_lengthof

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b3a78d1d534: [clang] Use std::size instead of llvm::array_lengthof (authored by jloser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133520/new/ https://

[clang] 1b3a78d - [clang] Use std::size instead of llvm::array_lengthof

Author: Joe Loser Date: 2022-09-08T17:20:25-06:00 New Revision: 1b3a78d1d534550b2f85a81b2e9ac6d7a94a478e URL: https://github.com/llvm/llvm-project/commit/1b3a78d1d534550b2f85a81b2e9ac6d7a94a478e DIFF: https://github.com/llvm/llvm-project/commit/1b3a78d1d534550b2f85a81b2e9ac6d7a94a478e.diff LOG

[clang] 4d4ca6c - [Driver] Rename Z to Zlib

Author: Fangrui Song Date: 2022-09-08T16:14:31-07:00 New Revision: 4d4ca6c9d036a06bf0723786112dd17e491b2f53 URL: https://github.com/llvm/llvm-project/commit/4d4ca6c9d036a06bf0723786112dd17e491b2f53 DIFF: https://github.com/llvm/llvm-project/commit/4d4ca6c9d036a06bf0723786112dd17e491b2f53.diff

[clang] 781dea0 - [Support] Rename DebugCompressionType::Z to Zlib

Author: Fangrui Song Date: 2022-09-08T16:11:29-07:00 New Revision: 781dea021a4a38aed89ea0cbf8c0d3641b16d56d URL: https://github.com/llvm/llvm-project/commit/781dea021a4a38aed89ea0cbf8c0d3641b16d56d DIFF: https://github.com/llvm/llvm-project/commit/781dea021a4a38aed89ea0cbf8c0d3641b16d56d.diff

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao marked an inline comment as done. ayzhao added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4321 + isCXXDeclarationSpecifier(ITC_Never, TPResult::True) != + TPResult::True) || +(!getLangOpts().CPlusPlus && !isDeclaratio

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

tra resigned from this revision. tra added a comment. I can confirm that this patch does address the compiler crash seen on CUDA build bots. I'm not familiar enough with the code to review it otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 458901. ayzhao added a comment. remove obsolete FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/i

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 458900. ayzhao added a comment. Fix failing test in p5.cpp where typename should be required for enum-base (N.B. due to https://github.com/llvm/llvm-project/commit/c90e198107431f64b73686bdce31c293e3380ac7, the correct error should now be missing 'typename' r

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. In D133522#3778693 , @ronlieb wrote: > emailed a hopeful reproducer to you Thanks, seen! Going to start running creduce on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13352

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

ronlieb added a comment. emailed a hopeful reproducer to you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133522/new/ https://reviews.llvm.org/D133522 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. In D133522#3778655 , @ronlieb wrote: > hopefully will fix this ? > invalid cast kind for complex value > UNREACHABLE executed at /clang/lib/AST/ExprConstant.cpp:14263! > PLEASE submit a bug report to https://github.com/llvm/llvm-

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

ronlieb added a comment. hopefully will fix this ? invalid cast kind for complex value UNREACHABLE executed at /clang/lib/AST/ExprConstant.cpp:14263! PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and as sociated ru

[clang] 48203b3 - Revert D130308 "[clang] extend getCommonSugaredType to merge sugar nodes"

Author: Fangrui Song Date: 2022-09-08T15:09:39-07:00 New Revision: 48203b327d8ddf2cb785a1ac30b3cd9fa1e54b44 URL: https://github.com/llvm/llvm-project/commit/48203b327d8ddf2cb785a1ac30b3cd9fa1e54b44 DIFF: https://github.com/llvm/llvm-project/commit/48203b327d8ddf2cb785a1ac30b3cd9fa1e54b44.diff

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

ldionne added a comment. FWIW I just created https://reviews.llvm.org/D133535. IMO that is a safer alternative, in the sense that we only opt-in those types that we know are safe to use with CTAD, but the remaining classes still get a warning. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

royjacobson added a comment. In D133262#3778555 , @mizvekov wrote: > The snippets from the bug reports are using libc++ and > std::make_integer_sequence directly, which we avoid in these kinds of > regression tests, we tend to make very reduced test cas

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov added a comment. In D133262#3778532 , @royjacobson wrote: > In D133262#3775375 , @mizvekov > wrote: > >> @royjacobson I decided to do a complete job here and fix all those issues >> except #54993. Can

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov added a comment. I just included a similar fix for another problem I found inspecting nearby code for the same kind of bug: typedef __complex__ float ComplexFloat; int cc = 1 + (ComplexFloat)(1.0iF); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov updated this revision to Diff 458881. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133522/new/ https://reviews.llvm.org/D133522 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/complex-int.c clang/test/SemaCXX/complex-conversion.cp

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

royjacobson added a comment. In D133262#3775375 , @mizvekov wrote: > @royjacobson I decided to do a complete job here and fix all those issues > except #54993. Can you confirm? > > I also applied the same idea to `type_pack_element` as I saw a crash rela

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov retitled this revision from "[clang] Fix Complex x Float conversions so it handles type sugar" to "[clang] Fix Complex x Float x Int conversions so it handles type sugar". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 458877. Repository: rG LLVM

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

ldionne added a comment. In D133425#3777598 , @aaron.ballman wrote: > In D133425#3775353 , @ldionne wrote: > >> Wouldn't re-applying >> https://github.com/llvm/llvm-project/commit/fcd549a7d8284a8e7c763fee3da2206

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz updated this revision to Diff 458867. beanz added a comment. Adding Sema errors for specifying initializer priority, and a test case for library shaders. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132977/new/ https://reviews.llvm.org/D132

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

dblaikie accepted this revision. dblaikie added a comment. In D133425#3777615 , @aaron.ballman wrote: > In D133425#3777598 , @aaron.ballman > wrote: > >> In D133425#3775353

[PATCH] D132874: [clang] Don't emit debug vtable information for consteval functions

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1763-1766 if (Method->isPure()) SPFlags |= llvm::DISubprogram::SPFlagPureVirtual; else SPFlags |= llvm::DISubprogram::SPFlagVirtual; Seems this change means the

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Fix at https://reviews.llvm.org/D133522 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D133522: [clang] Fix Complex x Float conversions so it handles type sugar

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The included test case was broken by D111509 since now those types can have sugar. Re

[clang] 2f23dc9 - [AST/Interp] Fix left shift overflow bug in D64146

Author: Fangrui Song Date: 2022-09-08T13:49:07-07:00 New Revision: 2f23dc9127e6c0ef392f163cbaa58afcb7b61a09 URL: https://github.com/llvm/llvm-project/commit/2f23dc9127e6c0ef392f163cbaa58afcb7b61a09 DIFF: https://github.com/llvm/llvm-project/commit/2f23dc9127e6c0ef392f163cbaa58afcb7b61a09.diff

[clang] 49c2898 - [AST/Interp] Fix latent unitialized use of memory bug in D64146

Author: Fangrui Song Date: 2022-09-08T13:39:30-07:00 New Revision: 49c289879c7aa9737429f7342c7149a8ba958667 URL: https://github.com/llvm/llvm-project/commit/49c289879c7aa9737429f7342c7149a8ba958667 DIFF: https://github.com/llvm/llvm-project/commit/49c289879c7aa9737429f7342c7149a8ba958667.diff

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778277 , @ronlieb wrote: > i am seeing similar issues in openmp buildbot failing with this patch I got a small patch coming up soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin added a comment. In D133354#3778237 , @dblaikie wrote: > Got any pointers to the commits/authors that added this functionality in the > first place? (would be good to have any review history, etc, to check against > the change here) That would

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

ronlieb added a comment. i am seeing similar issues in openmp buildbot failing with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ cfe-commits m

[PATCH] D133520: [clang] Use std::size instead of llvm::array_lengthof

jloser created this revision. jloser added reviewers: MaskRay, kazu, dblaikie, aaron.ballman. Herald added subscribers: mattd, gchakrabarti, asavonic, StephenFan. Herald added a project: All. jloser requested review of this revision. Herald added subscribers: cfe-commits, jholewinski. Herald added

[clang] 8d03328 - [clang] NFC: Add a missing const qualifier to Decl::isLocalExternDecl().

Author: Tom Honermann Date: 2022-09-08T13:21:10-07:00 New Revision: 8d03328e7be4778f8b5d5f3ea2f77b1f8b8ea38a URL: https://github.com/llvm/llvm-project/commit/8d03328e7be4778f8b5d5f3ea2f77b1f8b8ea38a DIFF: https://github.com/llvm/llvm-project/commit/8d03328e7be4778f8b5d5f3ea2f77b1f8b8ea38a.diff

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

dblaikie added a comment. The code change looks like it's creating `inlinedAt` scopes, but none of the test cases seem to test any `inlinedAt` debug info? Looks like this is lacking some test coverage - could you add some? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

dblaikie added subscribers: hansw, dblaikie. dblaikie added a comment. Got any pointers to the commits/authors that added this functionality in the first place? (would be good to have any review history, etc, to check against the change here) @hansw for windows compatibility discussions Repos

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

ldionne added a comment. I think this is quite interesting, but it also raises the obvious question of: where do we stop? I think the following elements need to be taken into account: 1. Implementing more stuff in the compiler adds complexity to the compiler, and does not decrease the complexit

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

dblaikie added a comment. any chance of generalizing this beyond a special case for `std::vector` - an attribute we could add to any class template (perhaps particular template parameters to the class template) to document the requirement? (is std::vector the only type in the standard library t

[PATCH] D133518: [HLSL] Call global destructors from entries

beanz created this revision. beanz added reviewers: aaron.ballman, bogner, python3kgae, pow2clk, tex3d, eli.friedman. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL doesn't have a C++ runtime that sup

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 8 inline comments as done. Mordante added a comment. Thanks for all review comments! I'm a bit out of time so I will look at the other comments later. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. T

[PATCH] D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac77b3fde120: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin… (authored by ddcc). Repository: rG LLVM Github Monorep

[clang] ac77b3f - [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header

Author: Dominic Chen Date: 2022-09-08T12:46:08-07:00 New Revision: ac77b3fde120d1c871b770fade67a413c418b94e URL: https://github.com/llvm/llvm-project/commit/ac77b3fde120d1c871b770fade67a413c418b94e DIFF: https://github.com/llvm/llvm-project/commit/ac77b3fde120d1c871b770fade67a413c418b94e.diff

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7651-7652 + Expr *FirstArg = TheCall->getArg(0); + if (auto *CE = dyn_cast(FirstArg)) +FirstArg = CE->getSubExprAsWritten(); rjmccall wrote: > yronglin wrote: > > rjmccall wrote: >

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. In D132131#3776956 , @MyDeveloperDay wrote: > an example of the exact reason why we should not reuse the same struct... > https://github.com/llvm/llvm-project/issues/57464 Just a bit rephrasing. In D132131#3777004

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

steven_wu updated this revision to Diff 458823. steven_wu edited the summary of this revision. steven_wu added a comment. Rebase patch and fix the problem when the input is '-' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95497/new/ https://review

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

ldionne added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator. + -

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

shafik added a comment. Nice, thank you for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133499/new/ https://reviews.llvm.org/D133499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Thanks for the repro! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:863 + Tok.addModifier(HighlightingModifier::Declaration); +if (const auto Func = dyn_cast(Decl)) { + if (Func->isThisDeclarationADefinition()) -

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

tra added a comment. It appears that this change may result in clang crashing (e.g. it broke CUDA compilation: https://lab.llvm.org/buildbot/#/builders/55/builds/35047/steps/3/logs/stdio). Reproducer: class { typedef __complex__ a; operator=(double b){c *= b} a c $bin/clang++ -c

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + python3kgae wrote: > aaron.ballman wrote: > > Just double-ch

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

steven_wu requested changes to this revision. steven_wu added a comment. This revision now requires changes to proceed. Actually, we need to fix the case when output is '-'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95497/new/ https://reviews.llvm.org/D95497 ___

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

tra added a comment. The culprit appears to be D111509 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 ___ cfe-commits maili

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. I will commit this if no objection. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95497/new/ https://reviews.llvm.org/D95497 _

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

jcranmer-intel added a comment. Some general comments on the documentation here: One of the lesser-known issues of `-ffast-math` is the fact that it (or `-funsafe-math-optimizations`) causes `crtfastmath.o` to be linked, which adds a static constructor that sets the FTZ/DAZ bits in MXCSR, affec

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + aaron.ballman wrote: > Just double-checking, but this

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae updated this revision to Diff 458807. python3kgae marked 4 inline comments as done. python3kgae added a comment. Use cast to simplify code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/ https://reviews.llvm.org/D129883 File

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (const Decl *D = dyn_cast(this)) +D->dump(); +} erichkeane wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > One thing to note is that the 'else' case here is a lit

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

aaron.ballman added a comment. (I didn't have the chance to do a complete review, but I did a partial one and spotted some things) Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMi

[PATCH] D133509: Frontend: Adopt llvm::vfs::OutputBackend in CompilerInstance

steven_wu created this revision. steven_wu added reviewers: sammccall, benlangmuir, raghavmedicherla, kzhuravl, dexonsmith. Herald added a subscriber: ributzka. Herald added a project: All. steven_wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D132977: [HLSL] Call global constructors inside entry

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167-170 +assert(cast(CS->getOperand(0))->getValue() == 65535 && + "HLSL doesn't support setting priority for global ctors."); +assert(isa(CS->getOperand(2)) && + "HLSL

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167-170 +assert(cast(CS->getOperand(0))->getValue() == 65535 && + "HLSL doesn't support setting priority for global ctors."); +assert(isa(CS->getOperand(2)) && + "HLSL doesn't

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

rjmccall added a comment. Please look into the history of that test case to see why we're specifically testing for the ability to redeclare this builtin. We could certainly allow this builtin to be redeclared using the `const void*` type — that doesn't really reflect the generic nature of the b

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

erichkeane added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (const Decl *D = dyn_cast(this)) +D->dump(); +} aaron.ballman wrote: > erichkeane wrote: > > One thing to note is that the 'else' case here is a little uninformative. > > Se

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

tra added a comment. It looks like some of these changes are causing compiler to crash in `clang::ASTContext::getFloatTypeSemantics` during CUDA compilation: https://lab.llvm.org/buildbot/#/builders/55/builds/35047 I'm currently working on narrowing down which commit is the culprit. Here's a sn

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:204 +LLVM_DUMP_METHOD void DeclContext::dumpDecl() const { + if (const Decl *D = dyn_cast(this)) +D->dump(); Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (c

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

MaskRay added a comment. Heads-up: after D132832 and D132727 , clang/test/AST/Interp/arrays.cpp.test has a msan failure. It can be pre-existing or can be newly introduced. There seems another issue about an integer overflow in

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a request for a comment in the test, thanks! Comment at: clang/test/AST/Interp/references.cpp:91 + +static_assert(RefToMemberExpr() == 11, "");

[PATCH] D132977: [HLSL] Call global constructors inside entry

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167-170 +assert(cast(CS->getOperand(0))->getValue() == 65535 && + "HLSL doesn't support setting priority for global ctors."); +assert(isa(CS->getOperand(2)) && + "HLSL

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG16e5d6d7f98f: [clang] extend getCommonSugaredType to merge sugar nodes (authored by mizvekov). Changed prior to commit:

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd42122cd5db0: [clang] use getCommonSugar in an assortment of place

  1   2   >