[clang] fae656b - [test] Add 'hwasan' feature and disable a test

Author: Vitaly Buka Date: 2022-08-17T23:50:35-07:00 New Revision: fae656b2dd80246c3c6f01e9c77c49560368752c URL: https://github.com/llvm/llvm-project/commit/fae656b2dd80246c3c6f01e9c77c49560368752c DIFF: https://github.com/llvm/llvm-project/commit/fae656b2dd80246c3c6f01e9c77c49560368752c.diff L

[clang] 4ceff69 - [test][Sema] Ignore stderr in test

Author: Vitaly Buka Date: 2022-08-17T23:50:35-07:00 New Revision: 4ceff69636e63fcfd5180f2edb88288b4a5cf278 URL: https://github.com/llvm/llvm-project/commit/4ceff69636e63fcfd5180f2edb88288b4a5cf278 DIFF: https://github.com/llvm/llvm-project/commit/4ceff69636e63fcfd5180f2edb88288b4a5cf278.diff L

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

carlosgalvezp updated this revision to Diff 453536. carlosgalvezp added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131780/new/ https://reviews.llvm.org/D131780 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCo

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

njames93 added a comment. In D131623#3730833 , @joeywatts wrote: > Thanks for the review @njames93! This is my first contribution so I don't > think I have permission to land this myself, is there someone that can do > that for me? Sure thing, In D131

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp:191 + auto r5 = [&x5]{}; +} njames93 wrote: > njames93 wrote: > > Can you add some cases with implicit capture (usi

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

carlosgalvezp updated this revision to Diff 453535. carlosgalvezp added a comment. Update implicit lambda captures to use the captured variables inside the lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131780/new/ https://reviews.llvm.org/

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:123 - default: { -// TODO: implement other casts. -return this->bail(CE); - } + case CK_IntegralToBoolean: +if (Optional T = classify(SubExpr->getType())) { Imple

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

tbaeder created this revision. tbaeder added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement inverting and negating values Repository: rG LLVM Github M

[PATCH] D132031: Do not evaluate dependent immediate invocations

usaxena95 added a comment. Addressed comments. Added release note. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:665 +Bar f; +Bar g; +} // namespace issue_55601 aaron.ballman wrote: > Do you think it's worth it to add a test case like: > ``` > struct derp

[PATCH] D132031: Do not evaluate dependent immediate invocations

usaxena95 updated this revision to Diff 453526. usaxena95 marked an inline comment as done. usaxena95 edited the summary of this revision. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132031/new/ http

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added a comment. Anyone have any idea what this Debian test failure is about? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 ___ cfe-commits mailin

[PATCH] D132097: [clang-format] Fix BeforeHash indent of comments above PPDirective

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2a5470fc249: [clang][Interp] Implement boolean and nullptr literals (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131942/new/ https:

[clang] a2a5470 - [clang][Interp] Implement boolean and nullptr literals

Author: Timm Bäder Date: 2022-08-18T07:11:48+02:00 New Revision: a2a5470fc2499981ad8b4e2aa98ef7ea9893df6c URL: https://github.com/llvm/llvm-project/commit/a2a5470fc2499981ad8b4e2aa98ef7ea9893df6c DIFF: https://github.com/llvm/llvm-project/commit/a2a5470fc2499981ad8b4e2aa98ef7ea9893df6c.diff LO

[PATCH] D131662: [clang] Try to improve diagnostics about uninitialized constexpr variables

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaFixItUtils.cpp:208-210 + if (T->isArrayType()) { +return " = {}"; + } aaron.ballman wrote: > I don't think this is a good change, consider: > ``` > int array[] = {}; > ``` > zero-sized arrays are

[PATCH] D131662: [clang] Try to improve diagnostics about uninitialized constexpr variables

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:8063 // handled in the Failed() branch above. -QualType DestType = Entity.getType(); -S.Diag(Kind.getLocation(), DiagID) -<< DestType << (bool)Des

[PATCH] D101479: [Driver] Support libc++ in MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4230319f7af: [Driver] Support libc++ in MSVC (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D1014

[clang] a423031 - [Driver] Support libc++ in MSVC

Author: Petr Hosek Date: 2022-08-18T04:04:40Z New Revision: a4230319f7af786f4d947f39a870f339b32a6fe7 URL: https://github.com/llvm/llvm-project/commit/a4230319f7af786f4d947f39a870f339b32a6fe7 DIFF: https://github.com/llvm/llvm-project/commit/a4230319f7af786f4d947f39a870f339b32a6fe7.diff LOG: [D

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 updated this revision to Diff 453515. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt clang-tools-extra/clang-

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 updated this revision to Diff 453514. pfultz2 added a comment. Update review comments and added fixit hints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 Files: clang-tools-extra/clang-tidy/b

[clang] 3f5f290 - [test] Propagate HWASAN_OPTIONS

Author: Vitaly Buka Date: 2022-08-17T18:59:49-07:00 New Revision: 3f5f2905c48fb13275fd74048fb07c5676e86d94 URL: https://github.com/llvm/llvm-project/commit/3f5f2905c48fb13275fd74048fb07c5676e86d94 DIFF: https://github.com/llvm/llvm-project/commit/3f5f2905c48fb13275fd74048fb07c5676e86d94.diff L

[clang] 36c9f5a - [NFC][OpenMP] Simplify 2f9be69d843

Author: Vitaly Buka Date: 2022-08-17T18:59:48-07:00 New Revision: 36c9f5a58b8644389385a87e3ea43805a3b24665 URL: https://github.com/llvm/llvm-project/commit/36c9f5a58b8644389385a87e3ea43805a3b24665 DIFF: https://github.com/llvm/llvm-project/commit/36c9f5a58b8644389385a87e3ea43805a3b24665.diff L

[PATCH] D131137: [clang][misexpect] Add support to clang for profitable annotation diagnostics

paulkirth created this revision. Herald added a subscriber: ormris. Herald added a project: All. paulkirth updated this revision to Diff 450194. paulkirth added a comment. paulkirth added reviewers: tejohnson, nickdesaulniers, phosek. paulkirth published this revision for review. Herald added a pro

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts added a comment. Thanks for the review @njames93! This is my first contribution so I don't think I have permission to land this myself, is there someone that can do that for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131623/new/ h

[PATCH] D131685: [clang][AST] RecursiveASTVisitor should visit owned TagDecl of friend type.

davrec added inline comments. Comment at: clang/unittests/AST/ASTContextParentMapTest.cpp:145 + EXPECT_THAT(Ctx.getParents(FrBLoc), ElementsAre(DynTypedNode::create(FrB))); + if (FrATagDecl) +EXPECT_THAT(Ctx.getParents(*FrATagDecl), sammccall wrote: > I'm c

[PATCH] D132079: [AMDGPU] Add iglp_opt builtin and MFMA GEMM Opt strategy

jrbyrnes added a comment. Hey Austin -- Just have a small question about the purpose of shouldApplyStrategy -- other than that, LGTM. Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:758 + + bool shouldApplyStrategy(ScheduleDAGInstrs *DAG) override { return true; } + --

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

mnadeem marked 9 inline comments as done. mnadeem added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:151 +static llvm::Reloc::Model getRelocationFromName(llvm::StringRef model) { + if (model.equals("static")) +return llvm::Reloc::Static; ---

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

mnadeem updated this revision to Diff 453472. mnadeem edited the summary of this revision. mnadeem added a subscriber: chrisj. mnadeem added a comment. - Moved mrelocation_model in Option.td to be near Codegen Options and put it in a `let` block. - Moved all the options from FrontendOptions to Co

[PATCH] D132074: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

jhuber6 updated this revision to Diff 453474. jhuber6 added a comment. Tweak ordering of comparisons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132074/new/ https://reviews.llvm.org/D132074 Files: clang/include/clang/Basic/LangOptions.def c

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sbc100 added a comment. I'm not totally sure but I think the change is responsible for the emscripten integration bot failing `InterpreterTest.CatchException`: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8807160007692150337/+/u/LLVM_regression/stdout [===

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

tra added a comment. In D129507#3730464 , @jhuber6 wrote: > Update, still having problems making the test but I figured I'd just update > now. You could try something like this: https://github.com/llvm/llvm-project/blob/d20e632853ad978e8008747d838d51b51

[PATCH] D132008: [clang-format] Handle return type auto followed by l_paren

This revision was automatically updated to reflect the committed changes. Closed by commit rG777b6ad168a0: [clang-format] Handle return type auto followed by l_paren (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132008/new/ ht

[clang] 777b6ad - [clang-format] Handle return type auto followed by l_paren

Author: owenca Date: 2022-08-17T16:06:34-07:00 New Revision: 777b6ad168a07d1116fc0488f959b494d06f7f29 URL: https://github.com/llvm/llvm-project/commit/777b6ad168a07d1116fc0488f959b494d06f7f29 DIFF: https://github.com/llvm/llvm-project/commit/777b6ad168a07d1116fc0488f959b494d06f7f29.diff LOG: [

[PATCH] D132066: [clang][deps] Allow switching between lazily/eagerly loaded PCMs

benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:50 +bool OptimizeArgs = false, +bool EagerLoadModules = false); Since you're chang

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 updated this revision to Diff 453456. jhuber6 edited the summary of this revision. jhuber6 added a comment. Update, still having problems making the test but I figured I'd just update now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129507

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:609 + ComplexPairTy Op; + PromotionType = getPromotionType(E->getSubExpr()->getType()); + if (!PromotionType.isNull()) zahiraam wrote: > rjmccall wrote: > > This is overwriting the

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: clang/test/Driver/offload-packager.c:12-14 +// RUN: clang-offload-packager %t.out \ +// RUN: --image=file=%t-sm_70.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ +// RUN: --image=fil

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

chrish_ericsson_atx updated this revision to Diff 453442. chrish_ericsson_atx added a comment. Removed `// FIXME` comments, per @aaron.ballman's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131926/new/ https://reviews.llvm.org/D131926 Files: clang-tools-extra/clang-tidy/bu

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

chrish_ericsson_atx added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/sizeof-expression.cpp:236-238 - // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(A*)'; pointer to aggregate sum += sizeof(PMyStruct); - // CHE

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

tra added inline comments. Comment at: clang/test/Driver/offload-packager.c:12-14 +// RUN: clang-offload-packager %t.out \ +// RUN: --image=file=%t-sm_70.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ +// RUN: --image=file=%t-gfx908.o,kind=openmp,triple=amdgcn-amd-am

[PATCH] D132074: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

jhuber6 created this revision. jhuber6 added reviewers: tianshilei1992, JonChesterfield, jdoerfert, ronlieb, carlo.bertolli, gregrodgers. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: openmp-commits, cf

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y updated this revision to Diff 453427. vaibhav.y edited the summary of this revision. vaibhav.y added a comment. Address review comments: - Drop include line that added `llvm/Support/ErrorHandling.h` - Use `llvm::Optional::value_or(...)` instead of bare conditional - Add `SarifResultLeve

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 marked 3 inline comments as done. jhuber6 added a comment. Thanks for the comments. Comment at: clang/test/Driver/offload-packager.c:12-14 +// RUN: clang-offload-packager %t.out \ +// RUN: --image=file=%t-sm_70.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ +/

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG8de51375f12d: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant… (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 8de5137 - [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

Author: Shafik Yaghmour Date: 2022-08-17T14:14:00-07:00 New Revision: 8de51375f12d91675a18d17f262276e65f43fbe0 URL: https://github.com/llvm/llvm-project/commit/8de51375f12d91675a18d17f262276e65f43fbe0 DIFF: https://github.com/llvm/llvm-project/commit/8de51375f12d91675a18d17f262276e65f43fbe0.dif

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y marked 4 inline comments as done. vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:157 +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317648";>level property +enum class SarifResultLevel { Note, Warnin

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129755/new/ https://reviews.llvm.org/D129755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

beanz updated this revision to Diff 453418. beanz added a comment. Handling function attributes appropriately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131203/new/ https://reviews.llvm.org/D131203 Files: clang/lib/AST/Mangle.cpp clang/lib

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 ___

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:494-497 +- Implemented "Conditionally Trivial Special Member Functions" (`P0848 `_). + Note: The handling of deleted functions is not yet compliant, as Clang + does not implem

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 453411. royjacobson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/DeclCXX.cpp cla

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453409. ckissane added a comment. - small compression test cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/index/Serializat

[PATCH] D132066: [clang][deps] Allow switching between lazily/eagerly loaded PCMs

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces new option for `clang-scan-deps`: `-ea

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453404. ckissane marked 3 inline comments as done. ckissane added a comment. - remove Compression{Spec,Impl}Ref typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D13199

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

ychen updated this revision to Diff 453403. ychen added a comment. - add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGe

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks added a comment. In D131978#3729644 , @rymiel wrote: > It seems that even with this patch, there is seemingly weird formatting with > the negation in requires clauses, such as: > > template > requires !F > int bar(T

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131874/new/ https://reviews.llvm.org/D131874 ___ cfe-commits mailing lis

[PATCH] D131662: [clang] Try to improve diagnostics about uninitialized constexpr variables

aaron.ballman added a comment. Thanks for working on this, I like the direction it's heading! One question I'm kicking around my head is, should we do something similar for `const` variables? const int i; // error: default initialization of an object of const type 'const int' it sure seems l

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:609 + ComplexPairTy Op; + PromotionType = getPromotionType(E->getSubExpr()->getType()); + if (!PromotionType.isNull()) rjmccall wrote: > This is overwriting the argument, so the co

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:580 +I = DelayedCXXInitPosition.find(D); +unsigned LexOrder = I == DelayedCXXInitPosition.end() ? ~0U : I->second; +AddGlobalCtor(Fn, 65535, LexOrder, COMDATKey); ychen wrote:

[PATCH] D130510: Missing tautological compare warnings due to unary operators

rtrieu added a comment. In D130510#3728719 , @aaron.ballman wrote: > In D130510#3727096 , @rtrieu wrote: > >> This patch has been moving back and forth between >> `IsIntegerLiteralConstantExpr` and `getIntegerLi

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

tra added inline comments. Comment at: clang/test/Driver/offload-packager.c:12-14 +// RUN: clang-offload-packager %t.out \ +// RUN: --image=file=%t-sm_70.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ +// RUN: --image=file=%t-gfx908.o,kind=openmp,triple=amdgcn-amd-am

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

shafik updated this revision to Diff 453389. shafik marked an inline comment as done. shafik added a comment. - Added `consteval` test with default parameters CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131874/new/ https://reviews.llvm.org/D131874 Files: clang/lib/AST/ExprConstant.

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 453388. Codesbyusman added a comment. updated test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/docs/ReleaseNotes.rst clang/lib/Analys

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda updated this revision to Diff 453386. arda added a comment. Replace section name from .fatlto to .llvm.lto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131618/new/ https://reviews.llvm.org/D131618 Files: clang/include/clang/Basic/CodeGenOp

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked 6 inline comments as done. ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:40 +CompressionSpecRef getCompressionSpec(CompressionKind Kind); +CompressionSpecRef getSchemeDetails(CompressionImplRef Implementation); + -

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453379. ckissane added a comment. - remove CompressionSpecRefs::{Zlib,ZStd} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/index/S

[PATCH] D132056: [HLSL] Restrict to supported targets

beanz created this revision. beanz added reviewers: aaron.ballman, bogner, python3kgae, pow2clk, jcranmer-intel. Herald added subscribers: Anastasia, JDevlieghere. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Someday we would like to support

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel added a comment. It seems that even with this patch, there is seemingly weird formatting with the negation in requires clauses, such as: template requires !F int bar(T t); This is because the "fake parens" of the unary expression opened is never closed by the special

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

ychen added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:580 +I = DelayedCXXInitPosition.find(D); +unsigned LexOrder = I == DelayedCXXInitPosition.end() ? ~0U : I->second; +AddGlobalCtor(Fn, 65535, LexOrder, COMDATKey); efriedma wrote:

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

ychen updated this revision to Diff 453373. ychen added a comment. - add more explanation as comments - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 Files: clang/lib/CodeGen/CGDeclCXX.cpp cl

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa8f8616028a: [clang-tidy] hicpp-signed-bitwise - Return location of the operand (and not of… (authored by vladimir.plyashkun, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] fa8f861 - [clang-tidy] hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

Author: Vladimir Plyashkun Date: 2022-08-17T19:25:59+01:00 New Revision: fa8f8616028abbc10aa5a3ad4641e8a40ec20cc8 URL: https://github.com/llvm/llvm-project/commit/fa8f8616028abbc10aa5a3ad4641e8a40ec20cc8 DIFF: https://github.com/llvm/llvm-project/commit/fa8f8616028abbc10aa5a3ad4641e8a40ec20cc8.

[PATCH] D129507: [llvm-objcopy] Add option to dump embedded offloading images

jhuber6 updated this revision to Diff 453354. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Moving to clang packager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129507/new/ https://reviews.llvm.o

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

shafik updated this revision to Diff 453350. shafik marked 2 inline comments as done. shafik added a comment. - Simplify condition to set `ConstexprVar` even more CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131874/new/ https://reviews.llvm.org/D131874 Files: clang/lib/AST/ExprConst

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:213 TestAndClearIgnoreImag(); +PromotionType = getPromotionType(E->getSubExpr()->getType()); +if (!PromotionType.isNull()) Same problem Comment at: cla

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 453346. abrahamcd added a comment. Removed Clang name from FileCheck test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SAR

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

aaron.ballman added a comment. In D131942#3729379 , @tbaeder wrote: > In D131942#3729057 , @aaron.ballman > wrote: > >> In D131942#3728994 , @erichkeane >> wrote: >> >>>

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda updated this revision to Diff 453345. arda added a comment. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Add clang and llvm related changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131618/new/ https://rev

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. With this last patch, the behaviors of CodeGen/volatile-1.c and CodeGenCXX/volatile-1.cpp have changed ( change with __imag). I have uploaded the changes but still trying to figure out what exactly changed and why. Thanks. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

tbaeder added a comment. In D131942#3729057 , @aaron.ballman wrote: > In D131942#3728994 , @erichkeane > wrote: > >> In D131942#3728974 , >> @aaron.ballman wrote: >> >>

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3140 + return CGF.Builder.CreateFPExt(result, ConvertType(E->getType())); + } + return result; rjmccall wrote: > zahiraam wrote: > > rjmccall wrote: > > > Please extract this bl

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from removing some comments now that we figured out what's going on. Please hold off on landing for a day or two in case @njames93 has other opinions though. Comment at: clang-tools-extra/test/cl

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:95-98 + static CompressionSpecRef Unknown; + static CompressionSpecRef None; + static CompressionSpecRef Zlib; + static CompressionSpecRef ZStd; dblaikie wrote: > ckissane wro

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource updated this revision to Diff 453334. tomasz-kaminski-sonarsource added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132030/new/ https://reviews.llvm.org/D132030 Files: clang/include/clan

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added a comment. After some more thought and some offline discussions, I think I have a reasonable way forward: let's add `-Wsingle-bit-bitfield-constant-conversion` as a new warning group under `-Wbitfield-constant-conversion` that controls the diagnostic for one-bit bitfields. T

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 453328. Ericson2314 marked an inline comment as done. Ericson2314 added a comment. Rebase, fix outdated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Fi

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

mizvekov added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/sizeof-expression.cpp:236-238 - // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(A*)'; pointer to aggregate sum += sizeof(PMyStruct); - // CHECK-MESSAGES

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131555/new/ https://reviews.llvm.org/D131555 _

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen added a comment. In D131547#3728867 , @dmgreen wrote: > In D131547#3728842 , @sdesmalen > wrote: > >> In D131547#3723083 , @dmgreen >> wrote: >> >>> I think we

[PATCH] D132031: Do not evaluate dependent immediate invocations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you, this LGTM, though I did have a testing question. Also, please be sure to add a release note for the fix. Comment at: clang/test/SemaCXX/cxx2a-conste

[PATCH] D131685: [clang][AST] RecursiveASTVisitor should visit owned TagDecl of friend type.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks like a reasonable representation of such record decls to me. Changing the AST to nest them under typelocs instead is indeed a bigger project (and it's hard to say whether it's

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

aaron.ballman added a comment. In D131942#3728994 , @erichkeane wrote: > In D131942#3728974 , @aaron.ballman > wrote: > >> LGTM as well; should we add a release note for this? I suspect not because >> it's impr

[PATCH] D131683: Diagnosing the Future Keywords

aaron.ballman added a comment. Precommit CI is failing with a failure that looks like it's relevant: TEST 'Clang :: Parser/static_assert.c' FAILED Script: -- : 'RUN: at line 1'; c:\ws\w9\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

erichkeane added a comment. In D131942#3728974 , @aaron.ballman wrote: > LGTM as well; should we add a release note for this? I suspect not because > it's improving an experimental feature that's not really ready for prime time > yet, but I don't know

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well; should we add a release note for this? I suspect not because it's improving an experimental feature that's not really ready for prime time yet, but I don't know how others feel. CHANGES SINCE LAST ACTION https

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske updated this revision to Diff 453297. balazske added a comment. StdLibraryFunctionsChecker should not overwrite errno constraints that are set by StreamChecker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132017/new/ https://reviews.llvm

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/sizeof-expression-2.c:42 + sum += sizeof(__typeof(&TS)); + sum += sizeof(STRKWD MyStruct*); + sum += sizeof(__typeof(STRKWD MyStruct*)); Based on the document

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonars

  1   2   >