[PATCH] D131345: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture

kito-cheng accepted this revision. kito-cheng added a comment. > It relies on a runtime check: during init runtime makes > PR_{SET,GET}_TAGGED_ADDR_CTRL calls and if they're not supported, it fails > with an error. So burden of checking if J extension is present is on Linux > kernel. Sounds go

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

shafik created this revision. shafik added reviewers: erichkeane, aaron.ballman, thakis, mstorsjo. Herald added a project: All. shafik requested review of this revision. The restrictions added in D131704 were not sufficient to avoid all non-constant expression c

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

shafik added a comment. In D131528#3719561 , @mstorsjo wrote: > In D131528#3719414 , @shafik wrote: > >> In D131528#3718405 , @mstorsjo >> wrote: >> >>> In D131528#371687

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

shafik added a comment. In D131528#3719430 , @ayermolo wrote: > Was this and previous change intended to capture this case? > const enum NumberType neg_one = (enum NumberType) ((enum NumberType) 0 - > (enum NumberType) 1); That was not intended and I p

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

alexander-shaposhnikov updated this revision to Diff 452590. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131872/new/ https://reviews.llvm.org/D131872 Files: clang/test/CodeGenCXX/threadlocal_address.cpp llvm/include/llvm/IR/Intrinsics.td llv

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: nikic, ChuanqiXu. alexander-shaposhnikov created this object with visibility "All Users". Herald added a subscriber: pengfei. Herald added a project: All. alexander-shaposhnikov requested review of this revision.

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625 + void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen, + ConstantInt *Safelen); shraiysh wrote: > [nit] Please set the def

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 452579. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTemplate.h

[clang] f5a68fe - Use llvm::none_of (NFC)

Author: Kazu Hirata Date: 2022-08-14T16:25:39-07:00 New Revision: f5a68feab30a529280c2912dc464e3a81e276f9a URL: https://github.com/llvm/llvm-project/commit/f5a68feab30a529280c2912dc464e3a81e276f9a DIFF: https://github.com/llvm/llvm-project/commit/f5a68feab30a529280c2912dc464e3a81e276f9a.diff L

[clang-tools-extra] 55f0a87 - [clangd] Use llvm::any_of (NFC)

Author: Kazu Hirata Date: 2022-08-14T16:25:38-07:00 New Revision: 55f0a87ea46ee787dbef425200a718db775ef381 URL: https://github.com/llvm/llvm-project/commit/55f0a87ea46ee787dbef425200a718db775ef381 DIFF: https://github.com/llvm/llvm-project/commit/55f0a87ea46ee787dbef425200a718db775ef381.diff L

[clang] 6d9cd91 - Use llvm::all_of (NFC)

Author: Kazu Hirata Date: 2022-08-14T16:25:36-07:00 New Revision: 6d9cd9199a6fdeab0412117bcefc28f625510b61 URL: https://github.com/llvm/llvm-project/commit/6d9cd9199a6fdeab0412117bcefc28f625510b61 DIFF: https://github.com/llvm/llvm-project/commit/6d9cd9199a6fdeab0412117bcefc28f625510b61.diff L

[PATCH] D131866: [clang] fix frontend crash in auto type templates

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5735-5736 // Find the insert position again. -AutoTypes.FindNodeOrInsertPos(ID, InsertPos); +if (AutoType *AT = AutoTypes.FindNodeOrInsertPos(ID, InsertPos)) + return QualTy

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/include/clang/AST/Type.h:1838 /// metaprogramming we'd prefer to keep it as large as possible. -/// At the moment it has been left as a non-bitfield since this type -/// safely fits in 64 bits as an unsigned, so there

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 452574. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D131866: [clang] fix frontend crash in auto type templates

inclyc updated this revision to Diff 452572. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131866/new/ https://reviews.llvm.org/D131866 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX/sugared-auto.cpp Index:

[PATCH] D131866: [clang] fix frontend crash in auto type templates

inclyc updated this revision to Diff 452571. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131866/new/ https://reviews.llvm.org/D131866 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX/sugared-auto.cpp In

[PATCH] D131866: [clang] fix frontend crash in auto type templates

inclyc updated this revision to Diff 452569. inclyc added a comment. update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131866/new/ https://reviews.llvm.org/D131866 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX/sugared-auto

[PATCH] D131866: [clang] fix frontend crash in auto type templates

inclyc updated this revision to Diff 452568. inclyc added a comment. rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131866/new/ https://reviews.llvm.org/D131866 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX/sugared-auto.cpp In

[PATCH] D131866: [clang] fix frontend crash in auto type templates

inclyc updated this revision to Diff 452567. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131866/new/ https://reviews.llvm.org/D131866 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX/sugared-auto.cpp Index:

[PATCH] D131866: [clang] fix frontend crash in auto type templates

inclyc created this revision. Herald added a project: All. inclyc added reviewers: mizvekov, aaron.ballman. inclyc updated this revision to Diff 452566. inclyc added a comment. inclyc added subscribers: cfe-commits, clang. inclyc published this revision for review. Herald added a project: clang. i

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6afcc4a459ea: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering… (authored by ychen). Repository: rG LLVM Github Monor

[clang] 6afcc4a - [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

Author: Yuanfang Chen Date: 2022-08-14T14:37:40-07:00 New Revision: 6afcc4a459ead8809a0d6d9b4bf7b64bcc13582b URL: https://github.com/llvm/llvm-project/commit/6afcc4a459ead8809a0d6d9b4bf7b64bcc13582b DIFF: https://github.com/llvm/llvm-project/commit/6afcc4a459ead8809a0d6d9b4bf7b64bcc13582b.diff

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen updated this revision to Diff 452564. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm.org/D128745 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 452562. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D131858: [clang] Track the templated entity in type substitution.

davrec added a comment. It was very good to separate this out, thanks. Can you can do some TMP performance testing, to verify the impacts are negligible before taking resugaring into consideration, to allay potential concerns? Comment at: clang/include/clang/AST/Type.h:1838

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3721441 , @royjacobson wrote: > Some documentation/test nits, and one question, but otherwise LGTM. > Could you fix the merge conflict? It would be nice to see pre-commit CI > results. > > Given the complexity of the te

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5183 if (!Better1 && !Better2) // Neither is better than the other -return JudgeByConstraints(); +return nullptr; + royjacobson wrote: > Previously we continued to check

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 452561. ychen marked 3 inline comments as done. ychen added a comment. - address Roy's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/Rel

[PATCH] D131532: [Sema] Avoid isNullPointerConstant invocation

nickdesaulniers added a comment. https://llvm-compile-time-tracker.com/compare.php?from=0299ebc1bdc9fca176ebcacd590c90dc77a47551&to=333771f3558c81390a0e5d715ad8d1e419050b66&stat=cycles should be the link, once it gets picked up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131532: [Sema] Avoid isNullPointerConstant invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG333771f3558c: [Sema] Avoid isNullPointerConstant invocation (authored by justinstitt, committed by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 333771f - [Sema] Avoid isNullPointerConstant invocation

Author: Justin Stitt Date: 2022-08-14T13:39:57-07:00 New Revision: 333771f3558c81390a0e5d715ad8d1e419050b66 URL: https://github.com/llvm/llvm-project/commit/333771f3558c81390a0e5d715ad8d1e419050b66 DIFF: https://github.com/llvm/llvm-project/commit/333771f3558c81390a0e5d715ad8d1e419050b66.diff

[PATCH] D131532: [Sema] Avoid isNullPointerConstant invocation

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Awesome! This makes a measurable improvement in my Linux kernel build times! Thanks for the patch, and thanks @rtrieu for suggestions that will improve C++ code compilation times as well. I'll commit this for you since you

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

thakis added a comment. Reverted this (and follow-ups) in aacf1a9742f714dd432117d82d19a007289c3dee for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://rev

[PATCH] D131789: [clang-tools-extra] Rewrite prints in python3 compatible way

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Maybe add the [NFC] tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131789/new/ https://reviews.llvm.org/D131789 ___

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

mstorsjo added a comment. This also broke building with GCC 9 on Ubuntu 20.04: [5/225] ASTNodeAPI.json FAILED: tools/clang/lib/Tooling/ASTNodeAPI.json cd /home/martin/code/llvm-project/llvm/build/tools/clang/lib/Tooling && /home/martin/code/llvm-project/llvm/build/bin/clang-ast-dump --ski

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

aaronpuchert added a comment. In D129160#3721943 , @isuruf wrote: > Sure. If an application links to `libclang.so` when the application is being > built, the application will hardcode `libclang.so.13` in it and will look for > it. > When the SONAME chan

[clang] c85abbe - [Sema] Fix a warning

Author: Kazu Hirata Date: 2022-08-14T11:25:19-07:00 New Revision: c85abbe879ef3257de4db862ce249b060cc3d2a4 URL: https://github.com/llvm/llvm-project/commit/c85abbe879ef3257de4db862ce249b060cc3d2a4 DIFF: https://github.com/llvm/llvm-project/commit/c85abbe879ef3257de4db862ce249b060cc3d2a4.diff L

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

davrec added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12767 +Ctx.getQualifiedType(Underlying), +::getCommonDecl(EX->getOwnedTagDecl(), EY->getOwnedTagDecl())); + } This last argument should probably be omitted/nullptr passed, sin

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

thakis added a comment. This breaks building on windows: http://45.33.8.238/win/64423/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

davrec added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12218 +CTN, +NExpX && NExpY ? Optional(std::min(*NExpX, *NExpY)) : None); + } I'm not clear on how `NExpX` could not equal `NExpY` - could you add a test which demonstrates t

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

isuruf added a comment. > Could you elaborate on this? Sure. If an application links to `libclang.so` when the application is being built, the application will hardcode `libclang.so.13` in it and will look for it. When the SONAME changes to `libclang.so.15` in LLVM 15, the application will not

[PATCH] D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`

Mordante added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp:10 #include "ConstCorrectnessCheck.h" #include "../utils/FixItHintUtils.h" #include "clang/AST/ASTContext.h" This is already included in the header. =

[PATCH] D131859: [clang-tidy] Adds QualifierAlignment to misc-const-correctness.

Mordante abandoned this revision. Mordante added a comment. In D131859#3721877 , @njames93 wrote: > Duplicate of D131386 Thanks for the information. Can you integrate the additional fixes of this patch in yours; specif

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

aaronpuchert added a comment. > Also, this change did not really acheive it's purpose of allowing apps to use > newer versions of libclang.so without rebuilding, because a new version of > libclang.so requires a new version of libLLVM.so, which does not have a > stable ABI. Could you elaborate

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

davrec added a comment. > The second paragraph is talking about 'Canonical nodes', not 'Canonical > types'. > > A canonical node is a type node for which 'isSugared' method returns false. Thanks for the clarification, but note that that term is not in general use so far as I'm aware. But inst

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

shraiysh added a comment. Minor comments. Thank you for working on this! Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625 + void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen, + ConstantInt *Safelen);

[PATCH] D131859: [clang-tidy] Adds QualifierAlignment to misc-const-correctness.

njames93 added a comment. Duplicate of D131386 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131859/new/ https://reviews.llvm.org/D131859 ___ cfe-commits mailing list c

[PATCH] D131859: [clang-tidy] Adds QualifierAlignment to misc-const-correctness.

Eugene.Zelenko added a comment. Shouldn't `east/west` added as aliases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131859/new/ https://reviews.llvm.org/D131859 ___ cfe-commits mailing list cfe-commits

[PATCH] D131859: [clang-tidy] Adds QualifierAlignment to misc-const-correctness.

Mordante created this revision. Mordante added reviewers: aaron.ballman, alexfh, JonasToth, LegalizeAdulthood, njames93. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang-tools-extra. Herald ad

[clang] 2fd2f26 - [clang][doc] Removes an extra space.

Author: Mark de Wever Date: 2022-08-14T15:16:43+02:00 New Revision: 2fd2f2644b45c6e95b7554c9a9c28daff01fc3cb URL: https://github.com/llvm/llvm-project/commit/2fd2f2644b45c6e95b7554c9a9c28daff01fc3cb DIFF: https://github.com/llvm/llvm-project/commit/2fd2f2644b45c6e95b7554c9a9c28daff01fc3cb.diff

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 452519. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov created this revision. Herald added subscribers: steakhal, carlosgalvezp, martong, usaxena95, kadircet, arphaman. Herald added a reviewer: shafik. Herald added a reviewer: NoQ. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, libc++, c

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

eoanermine updated this revision to Diff 452513. eoanermine added a comment. - Add examples to comments - Reformat comments right Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129926/new/ https://reviews.llvm.org/D129926 Files: clang/lib/Format/

[PATCH] D129628: [clang-format] Fix aligning of java-style declarations

eoanermine added a comment. I don't have an access to commit the patch by myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129628/new/ https://reviews.llvm.org/D129628 ___ cfe-commits mailing list c

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

eoanermine added a comment. In D129926#3705342 , @MyDeveloperDay wrote: > Can we land this for you? Yes Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2869-2870 + // Handle array initialization syntax if (FormatTok-

[PATCH] D131853: [clangd] Add doxygen parsing for Hover

tom-anders created this revision. Herald added subscribers: wenlei, usaxena95, kadircet, arphaman, mgorny. Herald added a project: All. tom-anders published this revision for review. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM, clang-tool

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452487. alexiprof added a comment. replase text hint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files: clang/docs/ClangCommandLineReference.rst clang/docs/