[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. In D130138#3667172 , @MaskRay wrote: > In D130138#3664913 , @iains wrote: > >> makes sense to me... >> >> I gue

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp added a comment. Ping to reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd updated this revision to Diff 446359. animeshk-amd added a comment. Herald added a subscriber: zzheng. [OpenMP] Update remaining tests for OpenMP version update to 5.1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129635/new/ https://r

[PATCH] D130210: [SemaCXX] Set promotion type for enum bool to integer type.

shafik added a comment. We seem to have a few tests with enums that bool as a specified type. Maybe this belongs better in one of those under the namespace `GH56560` I am curious that this does not change the test results of `clang/test/CXX/conv/conv.prom/p4.cpp` Repository: rG LLVM Github

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61fa7a88c7b6: [clang][OpenMP] Add IRBuilder support for taskgroup (authored by shraiysh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 61fa7a8 - [clang][OpenMP] Add IRBuilder support for taskgroup

Author: Shraiysh Vaishay Date: 2022-07-21T11:13:57+05:30 New Revision: 61fa7a88c7b6360222d4107e938529f2dccc1176 URL: https://github.com/llvm/llvm-project/commit/61fa7a88c7b6360222d4107e938529f2dccc1176 DIFF: https://github.com/llvm/llvm-project/commit/61fa7a88c7b6360222d4107e938529f2dccc1176.di

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

njames93 accepted this revision. njames93 added a comment. LGTM with those changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 ___ cfe-commits mailing list c

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:42 +// O2: @llvm.lifetime.start.p0i8(i64 1 bar(&x, 1); +// O2: @llvm.lifetime.end.p0i8(i64 1 StephenFan wrote: > vitalybuka wrote: > > It assume this will break Msan > > Tr

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

shraiysh updated this revision to Diff 446355. shraiysh added a comment. Rebase with main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129992/new/ https://reviews.llvm.org/D129992 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/ta

[PATCH] D129982: [clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4c62f66545d: [clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest (authored by owenpan). Repository: rG LLVM Github Monorepo CHANG

[clang] a4c62f6 - [clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest

Author: owenca Date: 2022-07-20T21:56:48-07:00 New Revision: a4c62f66545d11253ef76384b78d9dc196fc8e0e URL: https://github.com/llvm/llvm-project/commit/a4c62f66545d11253ef76384b78d9dc196fc8e0e DIFF: https://github.com/llvm/llvm-project/commit/a4c62f66545d11253ef76384b78d9dc196fc8e0e.diff LOG: [

[PATCH] D130136: [clang-format] Indent tokens after hash only if it starts a line

This revision was automatically updated to reflect the committed changes. Closed by commit rG892a9968ec77: [clang-format] Indent tokens after hash only if it starts a line (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130136/ne

[clang] 892a996 - [clang-format] Indent tokens after hash only if it starts a line

Author: owenca Date: 2022-07-20T21:52:17-07:00 New Revision: 892a9968ec7753467a7663cb91ee1e5a299844cf URL: https://github.com/llvm/llvm-project/commit/892a9968ec7753467a7663cb91ee1e5a299844cf DIFF: https://github.com/llvm/llvm-project/commit/892a9968ec7753467a7663cb91ee1e5a299844cf.diff LOG: [

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:238 +// Stores the mapping between an operand and its BFS traversal information. +DenseMap operandToItsBFSMap; + srishti-pm wrote: > Mogball wrote: > > Why can't y

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm marked an inline comment as done. srishti-pm added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:238 +// Stores the mapping between an operand and its BFS traversal information. +DenseMap operandToItsBFSMap; + Mo

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:238 +// Stores the mapping between an operand and its BFS traversal information. +DenseMap operandToItsBFSMap; + Why can't you sort the OperandBFS directly to avoi

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the enablement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 _

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf updated this revision to Diff 446335. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Headers/ppc_wrapp

[PATCH] D130168: [CUDA] remove duplicate condition

VitalyR added a comment. @yaxunl Hi! Could you commit this on my behalf? I read the documentation and it seems the appropriate way to commit changes for a newcomer not having commit access like me. My name is "VitalyR" and my email address is "vitalya...@gmail.com". Thanks! Repository: rG L

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3665900 , @erichkeane wrote: > The more I look at this... the more I question my approach. I now am > definitely sure we won't make Clang15, and hope that I can figure something > better out for 16 :/ I feel like

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

MaskRay added a comment. In D129855#3662457 , @quinnp wrote: > In D129855#3657006 , @MaskRay wrote: > >> This is not right as using `ld.lld` as the default linker isn't the majority >> case. If you want to change

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28213/new/ https://reviews.llvm.org/D28213 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

MaskRay added a comment. `forwardOptions` will be better if you are renaming it anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130078/new/ https://reviews.llvm.org/D130078 ___ cfe-commits mailing

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

MaskRay added a comment. In D130138#3664913 , @iains wrote: > makes sense to me... > > I guess the name looks long at first, but it's specific (I find that > easy-to-remember flag names are more important than short-to-type ones, but > maybe that's just

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 446310. python3kgae added a comment. Use CLDXCOption for opt level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128845/new/ https://reviews.llvm.org/D128845 Files: clang/include/clang/Basic/TargetOptio

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

rprichard added subscribers: t.p.northover, EricWF, rsmith. rprichard edited reviewers, added: efriedma, craig.topper; removed: t.p.northover, EricWF, rsmith. rprichard added a comment. Herald added a subscriber: StephenFan. @efriedma @craig.topper Could you review this patch (or suggest someone

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

rprichard updated this revision to Diff 446302. rprichard added a comment. Stylistic change: keep the -ALIGN32 and -ALIGN64 suffixes in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28213/new/ https://reviews.llvm.org/D28213 Files: cla

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 updated this revision to Diff 446301. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 Files: bolt/tools/CMakeLists.txt bolt/tools/driver/CMakeLists.txt

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); rnk wrote: > Ariel-Burton wrote: > > rnk wrote: > > > This seems like a good p

[PATCH] D130205: [Darwin toolchain] Tune the logic for finding arclite.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0728260577d: [Darwin toolchain] Tune the logic for finding arclite. (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] d072826 - [Darwin toolchain] Tune the logic for finding arclite.

Author: Steven Wu Date: 2022-07-20T16:45:52-07:00 New Revision: d0728260577d66b4b4d922adf0a40de86f09ccf5 URL: https://github.com/llvm/llvm-project/commit/d0728260577d66b4b4d922adf0a40de86f09ccf5 DIFF: https://github.com/llvm/llvm-project/commit/d0728260577d66b4b4d922adf0a40de86f09ccf5.diff LOG

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 446295. srishti-pm added a comment. Used the `stable_sort` function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files: mlir/include/mlir/Transforms/Commutat

[PATCH] D130210: [SemaCXX] Set promotion type for enum bool to integer type.

zequanwu created this revision. zequanwu added reviewers: hans, aaron.ballman. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. EnumDecl's promotion type is set either to the parsed type or calculated ty

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

tejohnson added a comment. In D128955#3666830 , @aeubanks wrote: > the assert that there are no public.type.tests in LTT fails on > `CodeGenCXX/thinlto-distributed-type-metadata.cpp`. for some reason clang > doesn't go through the LTO API at [1], it jus

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

jdoerfert updated this revision to Diff 446286. jdoerfert added a comment. Use <...> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129536/new/ https://reviews.llvm.org/D129536 Files: clang/lib/Headers/__clang_cuda_intrinsics.h clang/test/CodeG

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

jdoerfert added a comment. In D129536#3666884 , @tra wrote: > In D129536#3666860 , @jdoerfert > wrote: > >> The assertion is arguably not great but doesn't really matter, does it? How >> would I detect if they a

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

jdoerfert updated this revision to Diff 446285. jdoerfert added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129536/new/ https://reviews.llvm.org/D129536 Files: clang/lib/Headers/__clang_cuda_intrinsics.h clang/tes

[PATCH] D130207: [HLSL] Move DXIL validation version out of ModuleFlags

python3kgae created this revision. python3kgae added reviewers: Anastasia, kuhar, bogner, beanz, pow2clk. Herald added a subscriber: hiraditya. Herald added a project: All. python3kgae requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG304027206c88: [ThinLTO] Support aliased GlobalIFunc (authored by SchrodingerZhu, committed by MaskRay). Changed prior to commit: https://reviews.l

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

mizvekov added a comment. Yeah, turning off `LLVM_OPTIMIZED_TABLEGEN` made cmake instantly generate the correct CXXSymbols.inc. So while I think there is a bug out there somewhere, it might not necessarily be in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay updated this revision to Diff 446277. MaskRay added a comment. Add blank lines remove trailing whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/include/llvm/IR/GlobalIFunc.

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added a comment. In D129009#3665664 , @SchrodingerZhu wrote: > Hi, is there anything else I should do for this patch？ There is no. I am waiting a bit to collect more response. I'll do some testing and push this. Thanks for your contribution.

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

mizvekov added a comment. The clang-pseudo-gen that sits in `.\llvm\RelWithDebInfo\bin\clang-pseudo-gen` generates correct output, the one that sits in `.\llvm\NATIVE\Release\bin\clang-pseudo-gen.exe` doesn't, which seems to be the one cmake is picking up for this job. This could have somethin

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

mizvekov added a comment. Running `clang-pseudo-gen --grammar ..\clang-tools-extra\pseudo\lib\cxx\cxx.bnf --emit-symbol-list` does seem to generate something that would work. But even if I delete `CXXSymbols.inc`, the cmake rule seems to be regenerating a wrong CXXSymbols.inc again, so I suspec

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

tra added a comment. In D129536#3666860 , @jdoerfert wrote: > The assertion is arguably not great but doesn't really matter, does it? How > would I detect if they are supported? The latest revision of the patch is fine in this regard. My comment pointin

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

MaskRay added a comment. See https://clang.llvm.org/docs/SanitizerSpecialCaseList.html , -fsanitize-ignorelist and `*san_ignorelist.txt` in the Clang resource directory. If you can state your motivation, I am happy to implement it as I just modified related code for sanitizers. Repository: r

[PATCH] D130130: [clang-tidy] Add an IgnoreMacros option to readability-avoid-const-params-in-decls

thomasetter added a comment. In D130130#3666111 , @njames93 wrote: > Please can you upload your diff with full context(or use arcanist which does > it for you). Sorry about that, should be fixed now CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D130130: [clang-tidy] Add an IgnoreMacros option to readability-avoid-const-params-in-decls

thomasetter updated this revision to Diff 446274. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130130/new/ https://reviews.llvm.org/D130130 Files: clang-tools-extra/clang-tidy/readability/AvoidConstParamsInDecls.cpp clang-tools-extra/clang-tidy/readability/AvoidConstParamsInDecls.h

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

jdoerfert added a comment. In D129536#3666257 , @tra wrote: > In D129536#3663957 , @jdoerfert > wrote: > >> @tra, unsure about the crash. For me this passes fine (no gpu), is anything >> missing? > > The tests i

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks added a comment. the assert that there are no public.type.tests in LTT fails on `CodeGenCXX/thinlto-distributed-type-metadata.cpp`. for some reason clang doesn't go through the LTO API at [1], it just ends up calling the normal optimization pipeline. any ideas why? [1] https://github

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

mizvekov added a comment. I un-reverted this locally to take a better look. It does not seem to me to be a compiler bug, because both cl.exe and intellisense are picking this error up, and I believe the MSVC intellisense is based on a completely different frontend (EDG). What I see is that `en

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks updated this revision to Diff 446269. aeubanks marked 3 inline comments as done. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 Files: clang/lib/CodeGen/CGClas

[PATCH] D130205: [Darwin toolchain] Tune the logic for finding arclite.

doug.gregor created this revision. doug.gregor added a reviewer: arphaman. doug.gregor added a project: clang. Herald added a project: All. doug.gregor requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. The heuristic used to determine where the arclite libraries are

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

mizvekov added a comment. `Microsoft (R) C/C++ Optimizing Compiler Version 19.33.31627.1 for x64` As included in `Microsoft Visual Studio 2022` `Version 17.3.0 Preview 4.0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129222/new/ https://reviews.

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); cor3ntin wrote: > erichkeane wr

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) + D.Diag(clang::diag::err_drv_riscv_unsupported_with_linker_re

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 446264. royjacobson added a comment. Add a test for the CRTP constraints timings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.

[PATCH] D129784: [HIP] Allow the new driver to compile HIP in non-RDC mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c1b32717bcf: [HIP] Allow the new driver to compile HIP in non-RDC mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129784/new/ htt

[clang] 0c1b327 - [HIP] Allow the new driver to compile HIP in non-RDC mode

Author: Joseph Huber Date: 2022-07-20T16:52:23-04:00 New Revision: 0c1b32717bcffcf8edf95294e98933bd4c1e76ed URL: https://github.com/llvm/llvm-project/commit/0c1b32717bcffcf8edf95294e98933bd4c1e76ed DIFF: https://github.com/llvm/llvm-project/commit/0c1b32717bcffcf8edf95294e98933bd4c1e76ed.diff

[PATCH] D129784: [HIP] Allow the new driver to compile HIP in non-RDC mode

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129784/new/ https://reviews.llvm.org/D129784 __

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 446255. njames93 added a comment. Fix pre-build failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-extra/clang-tidy/readability/CMakeLists

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

rprichard abandoned this revision. rprichard added a comment. Abandoning this patch because D127465 is a better fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127267/new/ https://reviews.llvm.org/D127267 ___

[PATCH] D130199: [pseudo] Add ambiguity & unparseability metrics to -print-statistics

sammccall added a comment. As mentioned offline, we may want a length-weighted version of the ambiguity metric when prioritizing, but I think this one is easier to understand in isolation. If we end up preferring the weighted version we can change this. Repository: rG LLVM Github Monorepo C

[PATCH] D130199: [pseudo] Add ambiguity & unparseability metrics to -print-statistics

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. These can be used to quantify parsing improvements from

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) + D.Diag(cl

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:10 #include "RISCV.h" +#include "../Clang.h" #include "ToolChains/CommonArgs.h" compnerd wrote: > This feels like a layering violation. I suppose that as long as modular > b

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:10 #include "RISCV.h" +#include "../Clang.h" #include "ToolChains/CommonArgs.h" This feels like a layering violation. I suppose that as long as modular builds are okay ...

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

MaskRay added inline comments. Comment at: clang/test/Driver/forwarding-sections-liblto.c:2 +// RUN: touch %t.o +// RUN: %clang %t.o -### -flto 2>&1 | FileCheck %s +// RUN: %clang %t.o -### -flto 2>&1 -ffunction-sections -fdata-sections | \ Using a default triple

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

vsapsai added a comment. Looks like GCC has some naming pattern there, thanks for sharing, Iain. So I want to share the pattern I'm aiming for. I'd like the flag to start with `-Rmodule-...` to be consistent with `-Rmodule-build`, `-Rmodule-import`, `-Rmodule-lock`. Repository: rG LLVM Gith

[PATCH] D130160: [pseudo] Eliminate the dangling-else syntax ambiguity.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Language.h:25 + const TokenStream &Tokens; + SymbolID Lookahead; +}; passing the positi

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay updated this revision to Diff 446239. MaskRay added a comment. incompatible => unsupported since it is implementable (but difficult). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130190/new/ https://reviews.llvm.org/D130190 Files: clan

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall added a comment. In D129222#3666043 , @mizvekov wrote: > I confirm reverting just this patch fixes the build for me. Hi @mizvekov, Can you provide details about the compiler version? Neither the presubmit nor postsubmit bots (e.g.

[PATCH] D67025: Add .inl as valid C++ header type

tschuett added a comment. Note that in this directory is an ,inl file: https://github.com/openucx/ucx/tree/master/src/uct/ib/mlx5 It is a pure C library with C++ gtest. I believe that .inl is about inlining, but it is not tied to a language. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

kimgr added a comment. From a purely personal perspective, I'd prefer if this landed after the branch for llvm-15. We try to co-release IWYU shortly after LLVM/Clang are released, to get a public API-compatible release out there. So it would be really nice if we didn't have to spend time worki

[PATCH] D67025: Add .inl as valid C++ header type

sammccall added a comment. > ! In D67025#3665293 , @aaron.ballman > wrote: > this is why we have the `-x` option so that users can specify a specific > language mode to use. Is there a reason that option does not suffice for > clangd? The difficulty he

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

tahonermann added a comment. > Personally, the problem is not serializing class template specializations > "too early". The problem is that we are deserializing class template > specializations "too early". Yes, I agree. > The key point here is that Modules would read declarations lazily for

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

teemperor added a comment. import-std-module test changes look good to me, thanks for fixing that up. And yes, ideally the tests should never use any libc++ internal names (and LLDB should never print them for those tests). So I think not having those in the here is a step in the right directio

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); erichkeane wrote: > royjacobson wr

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); royjacobson wrote: > erichkeane

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp added a comment. In D129401#3666238 , @MaskRay wrote: > Mostly looks good, with a nit in the test and some suggestion to the summary. > > In D129401#3662857 , @quinnp wrote: > >>> If this is for the legacy

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); erichkeane wrote: > royjacobson

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446228. quinnp marked an inline comment as done. quinnp added a comment. Addressing review comments. Changing test cases to use `llvm-objdump -t` instead of `obj2yaml`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a comment. In D112374#3665989 , @mizvekov wrote: > If anyone wants to take a look at the new changes to lldb tests, be my guest. > Otherwise I will try to land this again soon. It might well be that we figure > out some other in-tree

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); royjacobson wrote: > erichkeane

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay created this revision. MaskRay added reviewers: compnerd, jrtc27, kito.cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jone

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

egorzhdan updated this revision to Diff 446223. egorzhdan added a comment. - Add a test for OpenBSD - Modify existing test file instead of adding a new file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews.llvm.org/D129654

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17899 + ConstraintSatisfaction Satisfaction; + if (S.CheckFunctionConstraints(Method, Satisfaction)) +SatisfactionStatus.push_back(false); erichkeane wrote: > cor3ntin wr

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 446219. njames93 added a comment. Added logic to infer WrapInBraces option if unspecified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-extra

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare abandoned this revision. jlegare added a comment. I appear to have butchered something in trying to apply a patch. I will revisit and resubmit later when I've straightened things out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. In D130096#3666155 , @yaxunl wrote: > The current patch does not consider HIP/OpenCL compile options, therefore the > value of these variables are not correct for OpenCL/HIP. They need to be > overridden by the variables with th

[PATCH] D128462: [HLSL] add -I option for dxc mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa73a84c44753: [HLSL] add -I option for dxc mode. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.o

[clang] a73a84c - [HLSL] add -I option for dxc mode.

Author: Xiang Li Date: 2022-07-20T11:03:22-07:00 New Revision: a73a84c44753402b33d619035d2c5acec3b04859 URL: https://github.com/llvm/llvm-project/commit/a73a84c44753402b33d619035d2c5acec3b04859 DIFF: https://github.com/llvm/llvm-project/commit/a73a84c44753402b33d619035d2c5acec3b04859.diff LOG:

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); Ariel-Burton wrote: > rnk wrote: > > This seems like a good place to use getSingleStepD

[clang] 7e77d31 - [test] Remove unnecessary -verify-machineinstrs=0

Author: Arthur Eubanks Date: 2022-07-20T10:55:54-07:00 New Revision: 7e77d31af75e48e2ac7899026040a66fe601961a URL: https://github.com/llvm/llvm-project/commit/7e77d31af75e48e2ac7899026040a66fe601961a DIFF: https://github.com/llvm/llvm-project/commit/7e77d31af75e48e2ac7899026040a66fe601961a.diff

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

tra added a comment. In D129536#3663957 , @jdoerfert wrote: > @tra, unsure about the crash. For me this passes fine (no gpu), is anything > missing? The tests in the patch are running with `-emit-llvm`, so they are not actually lowering to NVPTX and th

[PATCH] D67025: Add .inl as valid C++ header type

MaskRay added a comment. I agree that this is not suitable in clang, but can be in clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67025/new/ https://reviews.llvm.org/D67025 ___ cfe-commits mailing

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare added a comment. @hans To address your concern about loose matching: I went with this approach because it fit my use-case. Do you think that an exact match would be more appropriate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130161/new

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

MaskRay added a comment. Mostly looks good, with a nit in the test and some suggestion to the summary. In D129401#3662857 , @quinnp wrote: >> If this is for the legacy LTO interface, please state so. `lld/*/LTO.cpp` >> sets `c.Options.DataSections = tr

[PATCH] D130161: Added command-line options to exclude functions from function instrumentation output.

jlegare updated this revision to Diff 446210. jlegare added a comment. Addressing review comments. - Dropped argument to ShouldInstrumentFunction(). - Added file name based exclusion, which had accidentally been left out of previous commit. - Added demangler. - Applied git clang-format. Reposi

[PATCH] D67025: Add .inl as valid C++ header type

nridge added a comment. In D67025#3665293 , @aaron.ballman wrote: > this is why we have the `-x` option so that users can specify a specific > language mode to use. Is there a reason that option does not suffice for > clangd? One reason is that the mos

  1   2   >