[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added inline comments. Comment at: llvm/test/LTO/Resolution/X86/alias-indirect-function-lto.ll:1 +; RUN: opt -module-summary -o %t.bc %s + Testing a command does not crash does not make good use of the test. Please check basic properties. And add a file-

[PATCH] D30538: Add documentation for -fno-strict-aliasing

simonbyrne removed subscribers: jeroen.dobbelaere, carlosgalvezp. simonbyrne added a comment. i have no idea. It looks like it may have been resolved in https://reviews.llvm.org/rL303851? In that case, the NOTE should be removed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D30538/new/

[clang] 68050c2 - Revert "[CMake][Fuchsia] Use libunwind as the default unwinder"

Author: Petr Hosek Date: 2022-07-02T04:51:16Z New Revision: 68050c235432eeb5cfe9b58609cecc3efd13f567 URL: https://github.com/llvm/llvm-project/commit/68050c235432eeb5cfe9b58609cecc3efd13f567 DIFF: https://github.com/llvm/llvm-project/commit/68050c235432eeb5cfe9b58609cecc3efd13f567.diff LOG: Re

[clang] 40d2ef8 - [clang-format][NFC] Replace an EXPECT_EQ with a verifyFormat

Author: owenca Date: 2022-07-01T21:20:54-07:00 New Revision: 40d2ef841b68f6b493ce88bd750a92105a2b567d URL: https://github.com/llvm/llvm-project/commit/40d2ef841b68f6b493ce88bd750a92105a2b567d DIFF: https://github.com/llvm/llvm-project/commit/40d2ef841b68f6b493ce88bd750a92105a2b567d.diff LOG: [

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ABataev, MaskRay, tianshilei1992. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. jhuber6 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscriber

[PATCH] D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb52d33e6de55: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D129014: rewording static_assert to more generic static assertion

xgupta added a comment. Running check-clang after applying the patch, results into 36 failed test cases. Please update them all. Also add a description of patch motivation(via the Edit Revision option on the top) for why you are making the changes (like any wrong behavior you are seeing etc).

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441850. SchrodingerZhu added a comment. - adjust comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D123450: [clang-format] Parse Verilog if statements

owenpan added a comment. `clang/docs/ClangFormatStyleOptions.rst` was out of sync because `dump_format_style.py` had not been run. Fixed in cc55d97 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] cc55d97 - [clang-format] Run dump_format_style.py for LK_Verilog

Author: owenca Date: 2022-07-01T19:01:09-07:00 New Revision: cc55d97cebf22994663c514d0b909df63bfbac43 URL: https://github.com/llvm/llvm-project/commit/cc55d97cebf22994663c514d0b909df63bfbac43 DIFF: https://github.com/llvm/llvm-project/commit/cc55d97cebf22994663c514d0b909df63bfbac43.diff LOG: [

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441849. SchrodingerZhu added a comment. - move to proper place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441848. SchrodingerZhu added a comment. - address cr: use IR instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAn

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2275-2276 + llvm::SmallPtrSet SeenDecls; + llvm::SmallPtrSet SeenTypes; + These names seem too general to live directly in `Sema`. Comment at: clang/include/clang/Sem

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441846. SchrodingerZhu added a comment. - address cr: code brace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalys

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp:655 + if (isa(Aliasee)) { +return; + } https://llvm.org/docs/CodingStandards.ht

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441844. SchrodingerZhu added a comment. - specify target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 added a comment. In D128314#3605588 , @NoQ wrote: > Nice! > > There's usually some bureaucracy when creating new matchers, i.e. there > should be documentation and unittests covering them. I have added a unit test and auto-generated documen

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 441832. ziqingluo-90 added a comment. adding a unit test for the ASTMatcher `objcMessageCallee` added in ASTMatcher.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/ https://reviews.llvm.org/D128

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. Sorry for the noise during the process. I am really new to LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 ___ cfe-commits

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441830. SchrodingerZhu added a comment. - adjust run arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441829. SchrodingerZhu added a comment. address CR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llvm/

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441828. SchrodingerZhu edited the summary of this revision. SchrodingerZhu added a comment. address CR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files:

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG927156a67445: Generate the capture for the field when the field is used in openmp (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES

[clang] 927156a - Generate the capture for the field when the field is used in openmp

Author: Jennifer Yu Date: 2022-07-01T17:09:01-07:00 New Revision: 927156a67445a6edb1b09e3d6246b0e5a9cf8a16 URL: https://github.com/llvm/llvm-project/commit/927156a67445a6edb1b09e3d6246b0e5a9cf8a16 DIFF: https://github.com/llvm/llvm-project/commit/927156a67445a6edb1b09e3d6246b0e5a9cf8a16.diff L

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. Sure! Ishaan Gandhi ishaangandhi AT gmail DOT com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D129030: [Driver] Ignore the clang modules validation-related flags if clang modules are not enabled

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. If clang modules are not enabled it becomes unnecessary to read the session timestamp file in order to pass `-fbuil

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441821. SchrodingerZhu added a comment. undo wrong patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: clang/test/Analysis/alias-indirect-function-l

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441820. SchrodingerZhu added a comment. address CR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llvm/

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441819. SchrodingerZhu added a comment. address CR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llvm/

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 441816. ziqingluo-90 added a comment. I saw @aaron.ballman 's comment "//We typically don't add AST matchers until we have a need for them to be used in-tree (ASTMatchers.h is already really expensive to parse; adding matchers for everything possible wi

[PATCH] D128766: Update references to Discourse instead of the mailing lists.

tonic updated this revision to Diff 441800. tonic added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128766/new/ https://reviews.llvm.org/D128766 Files: clang/docs/ExternalClangExamples.rst clang/www/get_involved.html

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 441793. pscoro added a comment. Combined aix and linux IR lit tests into a single file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Bas

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. In D126907#3623377 , @vitalybuka wrote: > FYI. The same on a different bot > https://lab.llvm.org/buildbot/#/builders/5/builds/25486/steps/19

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11150 + +const uint64_t XORWord = 0x; // XORing with 0b111...111 will never + // result in the original word To address a com

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro added a comment. Sorry about making a separate review for this again, I encountered some troubles with git and decided that moving my code to a fresh branch would be quicker than figuring out how to fix the problem, the previous review will be abandoned. Repository: rG LLVM Github Mo

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Herald added a project: All. pscoro requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d3a2b4c6601: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[clang-tools-extra] 0d3a2b4 - [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

Author: Argyrios Kyrtzidis Date: 2022-07-01T14:22:31-07:00 New Revision: 0d3a2b4c6601d4ff341119aa537db184197d83de URL: https://github.com/llvm/llvm-project/commit/0d3a2b4c6601d4ff341119aa537db184197d83de DIFF: https://github.com/llvm/llvm-project/commit/0d3a2b4c6601d4ff341119aa537db184197d83de.

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

nikic added inline comments. Comment at: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp:654 + // summary for aliasee will not be emitted. + if (Aliasee->getValueID() != Value::ValueTy::GlobalIFuncVal) { +bool NonRenamableLocal = isNonRenamableLocal(A); MaskRay

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

nicovank added a comment. I do not have commit access for the LLVM repository, could one of you commit this for me (Nicolas van Kempen )? I can keep an eye on this today, otherwise I will discuss with someone internally and commit Tuesday. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:130 +- New :doc:`cppcoreguidelines-avoid-const-or-ref-data-members + ` check. Sort new checks by check name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:131 +- New :doc:`cppcoreguidelines-avoid-const-or-ref-data-members + ` check. + This link is wrong, please install Sphinx and build the target `docs-clang-tools-html` t

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood added a comment. In D128157#3612741 , @myhsu wrote: > You forgot to add > > "Differential Revison: https://reviews.llvm.org/DXX"; in the commit

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added a comment. > As https://github.com/llvm/llvm-project/issues/56290 indicates Write the description, followed by `Fix(es)? https://github.com/llvm/llvm-project/issues/56290` on a separate line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D129009: [Analysis][LTO] Fix LTO for aliased IFuncs.

MaskRay added a comment. LG but the test needs a change. Comment at: clang/test/Analysis/alias-indirect-function-lto.c:1 +// RUN: %clang_analyze_cc1 -flto -c +void f() __attribute__((ifunc("g"))); The test is added to the wrong place. clang Analysis != llvm Ana

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Improved :doc:`bugprone-signal-handler + ` check. Partial sort by check name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D129009: [Analysis][LTO] Fix LTO for aliased IFuncs.

SchrodingerZhu updated this revision to Diff 441784. SchrodingerZhu added a comment. fix integration test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: clang/test/Analysis/alias-indirect-functi

[PATCH] D128511: [clang-tidy] Make the cert/uppercase-literal-suffix-integer fully hermetic.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/integral_constant.h:1 +#ifndef _INTEGRAL_CONSTANT_H_ +#define _INTEGRAL_CONSTANT_H_ Identifiers beginning with `_` followed by an uppercase letter are

[PATCH] D119296: KCFI sanitizer

MaskRay added inline comments. Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:125 + + // Emit int3 padding to allow runtime patching of the preamble. + EmitAndCountInstruction(MCInstBuilder(X86::INT3)); A previous comment isn't done. This doesn't explain tha

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

MaskRay accepted this revision. MaskRay added a comment. Thanks! Comment at: llvm/lib/Support/Compression.cpp:25 using namespace llvm; using namespace llvm::compression; if a previous patch introduces a blank line between two `using`. please drop it from t

[PATCH] D119296: KCFI sanitizer

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1434 + + /// Emit KCFI type identifier constants and remove unused identifiers + void FinalizeKCFITypes(); End with a period. This function can be lower-case as well. There is no stro

[PATCH] D129014: rewording static_assert to more generic static assertion

Codesbyusman created this revision. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129014 Files: clang/include/clang/Basic/Diagno

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Crash that required the revert : https://reviews.llvm.org/rGbefa8cf087dbb8159a4d9dc8fa4d6748d6d5049a reduces to : template concept sentinel_for = requires(_Ip __i) { __i++; }; template concept bidirectional_iterator = sentinel_for

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

njames93 accepted this revision. njames93 added a comment. I'd say land this, but keep a close eye on the build bots as it may need reverting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127807/new/ https://reviews.llvm.org/D127807

[PATCH] D119296: KCFI sanitizer

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2280 +void CodeGenModule::setKCFIType(const FunctionDecl *FD, llvm::Function *F) { + + if (isa(FD) && !cast(F

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. I think you should also at least support promoted arithmetic through the `_Real` and `_Imag` scalar operators before calling this complete. That should be simple — just a matter of calling EmitPromotedComplexExpr from the scalar path. Comment at: c

[PATCH] D119296: KCFI sanitizer

MaskRay added a comment. There are 30+ comments not marked as "done". Having so many is distracting to reviewers as it's unclear whether this is in a ready-for-review state. Comment at: clang/include/clang/Basic/Features.def:233 FEATURE(modules, LangOpts.Modules) +FEATURE(kcf

[PATCH] D119296: KCFI sanitizer

MaskRay added a comment. > It uses LLVM prefix data to store a type identifier for each function and > injects verification code before indirect calls. Is "prefix data" stale now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

vitalybuka added a comment. In D115844#3625781 , @ychen wrote: > In D115844#3625776 , @vitalybuka > wrote: > >> @ychen This patch causes 20% .o size increase (x86_64) Is this expected? > > No, it is not expecte

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. In D115844#3625776 , @vitalybuka wrote: > @ychen This patch causes 20% .o size increase (x86_64) Is this expected? No, it is not expected. Do you have a test case? I'll take a look. Repository: rG LLVM Github Monorepo CHAN

[clang-tools-extra] bbcd8e5 - [pseudo] NFC, polish the fix of c99827349927a44334f2b04139168efd0bc87cd3

Author: Haojian Wu Date: 2022-07-01T21:25:46+02:00 New Revision: bbcd8e5271f4af3adc28e458642a0dc65d253acd URL: https://github.com/llvm/llvm-project/commit/bbcd8e5271f4af3adc28e458642a0dc65d253acd DIFF: https://github.com/llvm/llvm-project/commit/bbcd8e5271f4af3adc28e458642a0dc65d253acd.diff LO

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

vitalybuka added a comment. @ychen This patch causes 20% .o size increase (x86_64) Is this expected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-c

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D127803 ___

[PATCH] D128754: [llvm] Refactor LLVM compression namespaces (Part 1: remove crc32)

ckissane updated this revision to Diff 441770. ckissane added a comment. updated diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 Files: llvm/docs/ReleaseNotes.rst llvm/include/llvm/Support/Compression.h llvm/lib/Support/Compression.

[PATCH] D128754: [llvm] Refactor LLVM compression namespaces (Part 1: remove crc32)

ckissane marked 3 inline comments as done. ckissane added a comment. addressed comments marked done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 ___ cfe-comm

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. This looks reasonable, LGTM for what it's worth :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128012/new/ https://reviews.llvm.org/D12801

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 updated this revision to Diff 441765. jyu2 added a comment. Thank Alexey for the review. This is remove check for omp region just use hasDSA. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D127803 Files:

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

phosek accepted this revision. phosek added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2273-2274 +bool Sema::isOpenMPRebuildMemberExpr(ValueDecl *D) { + if (getCurCapturedRegion() && + getCurCapturedRegion()->CapRegionKind == CR_OpenMP) { +DSAStackTy::DSAVarData DVarPrivate = DSAStack->

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane marked 2 inline comments as done. ckissane added a comment. comments addressed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 441763. ckissane edited the summary of this revision. ckissane added a comment. remove compression namespace alias work CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 Files: clang-tools-extra/clangd/in

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 441757. ckissane added a comment. discard debug string changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 Files: clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/unittest

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz updated this revision to Diff 441759. beanz added a comment. Updates based on review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128012/new/ https://reviews.llvm.org/D128012 Files: clang/include/clang/Sema/HLSLExternalSemaSourc

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

ymandel added a comment. > For my particular case, I just need multiple notes per rule. I don't need > them to be associated to a particular edit (and in that very particular case, > I don't even need a source location). I'm not sure I understand: you need this additional note, but it doesn't n

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

jrbyrnes added a comment. Hey Austin -- I like the removal of canAddMIs. In the original design, I was leaving open the possibility for users to pass in canAddMIs rather than a mask / SchedGroup name, but it looks like this isn't the direction we're going, and the classification functions defin

[PATCH] D129009: [Analysis] Fix LTO for aliased IFuncs.

SchrodingerZhu updated this revision to Diff 441758. SchrodingerZhu retitled this revision from "[llvm.analysis] Fix LTO for aliased IFuncs. As https://github.com/llvm/llvm-project/issues/56290 indicates, when an ifunc is aliased in LTO, clang will attempt to create an alias summary; however, as

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

MaskRay accepted this revision. MaskRay added a comment. LGTM. Happy when @phosek is happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 ___ cfe-commits maili

[PATCH] D129009: [llvm.analysis] Fix LTO for aliased IFuncs. As https://github.com/llvm/llvm-project/issues/56290 indicates, when an ifunc is aliased in LTO, clang will attempt to create an alias su

SchrodingerZhu updated this revision to Diff 441756. SchrodingerZhu retitled this revision from "[llvm.analysis] Fix LTO for aliased IFuncs." to "[llvm.analysis] Fix LTO for aliased IFuncs. As https://github.com/llvm/llvm-project/issues/56290 indicates, when an ifunc is aliased in LTO, clang wil

[PATCH] D129009: [llvm.analysis] Fix LTO for aliased IFuncs.

SchrodingerZhu created this revision. Herald added subscribers: steakhal, ormris, jeroen.dobbelaere, steven_wu, hiraditya, inglorion. Herald added a project: All. SchrodingerZhu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commi

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane added inline comments. Comment at: llvm/lib/ProfileData/InstrProf.cpp:154 +OS << ("profile uses " + compression::profile::AlgorithmName + + " compression but the profile reader was built " + "without " + + compression::profile::AlgorithmName + " s

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3625600 , @vitalybuka wrote: > @erichkeane can you please make sure that committed revisions in git have > "Differential Revision: ". Usually it's added by "arc" when you upload > review. > Also it would be ni

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

vitalybuka added a comment. @erichkeane can you please make sure that committed revisions in git have "Differential Revision: ". Usually it's added by "arc" when you upload review. Also it would be nice if reapply have the same link. Regarding reproducer, you can follow https://github.com/

[clang] 258c3ae - Revert "Re-apply "Deferred Concept Instantiation Implementation"""

Author: Erich Keane Date: 2022-07-01T11:20:16-07:00 New Revision: 258c3aee54e11bc5c5d8ac137eb15e8d5bbcc7e4 URL: https://github.com/llvm/llvm-project/commit/258c3aee54e11bc5c5d8ac137eb15e8d5bbcc7e4 DIFF: https://github.com/llvm/llvm-project/commit/258c3aee54e11bc5c5d8ac137eb15e8d5bbcc7e4.diff L

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:49-51 +namespace profile = llvm::compression::zlib; + +namespace serialize = llvm::compression::zlib; phosek wrote: > I think we will need to support dynamically selecting (de)com

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

hokein added a comment. Thanks for the report. There is an out-of-bound issue in LRTable::getReduceRules, fixed in c99827349927a44334f2b04139168efd0bc87cd3 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c998273 - [pseudo] Fix an out-of-bound issue in getReduceRules.

Author: Haojian Wu Date: 2022-07-01T20:16:06+02:00 New Revision: c99827349927a44334f2b04139168efd0bc87cd3 URL: https://github.com/llvm/llvm-project/commit/c99827349927a44334f2b04139168efd0bc87cd3 DIFF: https://github.com/llvm/llvm-project/commit/c99827349927a44334f2b04139168efd0bc87cd3.diff LO

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 441748. cor3ntin added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnost

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:270 This fixes `Issue 55962 `_. +- Added ``-Winvalid-utf8`` which diagnose invalid UTF-8 code unit sequences in + comments. Reposi

[clang] 6450dad - Test a few more C99 DRs

Author: Aaron Ballman Date: 2022-07-01T13:54:11-04:00 New Revision: 6450daddd20a83327118c0c6fa8f844a99cd1f0f URL: https://github.com/llvm/llvm-project/commit/6450daddd20a83327118c0c6fa8f844a99cd1f0f DIFF: https://github.com/llvm/llvm-project/commit/6450daddd20a83327118c0c6fa8f844a99cd1f0f.diff

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Thanks for this, like Nathan James this has been pestering me for a while `:)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. Please provide the name and email address you wish to use on the commit and I will submit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. I can submit after you address additional comments by Nathan James. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

MaskRay added inline comments. Comment at: llvm/lib/ProfileData/InstrProf.cpp:154 +OS << ("profile uses " + compression::profile::AlgorithmName + + " compression but the profile reader was built " + "without " + + compression::profile::AlgorithmName + " su

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 updated this revision to Diff 441742. tianshilei1992 added a comment. fix unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129008/new/ https://reviews.llvm.org/D129008 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:122 set(RUNTIMES_${target}_LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. @aaron.ballman FYI this is now core-approved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 ___ cfe-commits mailing list cfe-commits@

[PATCH] D127887: [CMake][Fuchsia] Use libunwind as the default unwinder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6213dba19fc0: [CMake][Fuchsia] Use libunwind as the default unwinder (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 6213dba - [CMake][Fuchsia] Use libunwind as the default unwinder

Author: Petr Hosek Date: 2022-07-01T17:24:00Z New Revision: 6213dba19fc0d65ab8b366b6d78c56cbd63c9d7d URL: https://github.com/llvm/llvm-project/commit/6213dba19fc0d65ab8b366b6d78c56cbd63c9d7d DIFF: https://github.com/llvm/llvm-project/commit/6213dba19fc0d65ab8b366b6d78c56cbd63c9d7d.diff LOG: [C

[PATCH] D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

MaskRay added a comment. > [NFC] refactor compression namespaces making way for a possible introduction > of alternatives to zlib compression in the llvm toolchain. I'd use `[NFC] Refactor llvm::zlib namespace` and place supplementary wording to the body. `in the llvm toolchain` is redundant i

  1   2   >