MaskRay added a comment.

LG but the test needs a change.



================
Comment at: clang/test/Analysis/alias-indirect-function-lto.c:1
+// RUN: %clang_analyze_cc1 -flto -c
+void f() __attribute__((ifunc("g")));
----------------
The test is added to the wrong place. clang Analysis != llvm Analysis.

Find somewhere in `llvm/test/ThinLTO`.




================
Comment at: clang/test/Analysis/alias-indirect-function-lto.c:5
+void h() __attribute__((alias("f")));
\ No newline at end of file

----------------
No newline at end of file


================
Comment at: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp:654
+  // summary for aliasee will not be emitted.
+  if (Aliasee->getValueID() != Value::ValueTy::GlobalIFuncVal) {
+    bool NonRenamableLocal = isNonRenamableLocal(A);
----------------
Use an early return to avoid indenting so many lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129009/new/

https://reviews.llvm.org/D129009

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D129009: [An... Schrodinger ZHU Yifan via Phabricator via cfe-commits
    • [PATCH] D129009... Fangrui Song via Phabricator via cfe-commits

Reply via email to