[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. Thanks @MaskRay for the quick patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

MaskRay added a comment. The CPython usage is a real UB: https://github.com/python/cpython/issues/94250 In D126864#3609497 , @efriedma wrote: > I suspect the refactoring in the latest version of the patch accidentally > made UBSan a bit more strict by d

[PATCH] D128574: [clang-format] Quit analyzing solution space for large state count

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[clang] 262b409 - [Driver] Fix -fstrict-flex-arrays= help message after D126864

Author: Fangrui Song Date: 2022-06-24T22:20:37-07:00 New Revision: 262b4091f9724994f4675fa0bab14b4988f10308 URL: https://github.com/llvm/llvm-project/commit/262b4091f9724994f4675fa0bab14b4988f10308 DIFF: https://github.com/llvm/llvm-project/commit/262b4091f9724994f4675fa0bab14b4988f10308.diff

[clang] 572b087 - [clang] Add back -fsanitize=array-bounds workaround for size-1 array after -fstrict-flex-arrays change

Author: Fangrui Song Date: 2022-06-24T22:15:47-07:00 New Revision: 572b08790a69f955ae0cbb1b4a7d4a215f15dad9 URL: https://github.com/llvm/llvm-project/commit/572b08790a69f955ae0cbb1b4a7d4a215f15dad9 DIFF: https://github.com/llvm/llvm-project/commit/572b08790a69f955ae0cbb1b4a7d4a215f15dad9.diff

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

vsapsai added a comment. Sorry for changing my mind. I've thought about the errors more and especially about the case mentioned by Chuanqi export module A; [export] inline void func(); I'm afraid it can complicate the implementation but we can achieve some consistency with errors like e

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. I'll take care next time. Thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei created this revision. pengfei added reviewers: zahiraam, rjmccall, bkramer, alexfh. Herald added a subscriber: jsji. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is split from D113107

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

phosek added a comment. In D128567#3609644 , @leonardchan wrote: > I'm thinking `LLVM_TOOL_LLD_BUILD` might be a remnant of times before the > monorepo since lld doesn't exist under `llvm/tools` anymore. Yes, that's correct. The proposed cleanup is the

[PATCH] D128496: [clang-format] Further improve requires clause detection

This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rGb3aeca3962bb: [clang-format] Further improve requires clause detection (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES

[clang] b3aeca3 - [clang-format] Further improve requires clause detection

Author: Björn Schäpers Date: 2022-06-25T04:43:38+02:00 New Revision: b3aeca3962bb39dfe110472ea033bda32044455d URL: https://github.com/llvm/llvm-project/commit/b3aeca3962bb39dfe110472ea033bda32044455d DIFF: https://github.com/llvm/llvm-project/commit/b3aeca3962bb39dfe110472ea033bda32044455d.diff

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. @zahiraam I'm going to enable the FE support when I reland the backend patch. Community people report correctness issue due to the ABI issue in compiler-rt. See https://github.com/llvm/llvm-project/issues/56204 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1131

[PATCH] D128359: [clang][dataflow] Move logic for `createStorageLocation` from `DataflowEnvironment` to `DataflowAnalysisContext`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:47 +/// Gets the set of all fields in the type. +llvm::DenseSet getObjectFields(QualType Type); Repository:

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz created this revision. beanz added reviewers: Anastasia, spyffe, kuhar, bogner, python3kgae. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Most of the change here is fleshing out the HLSLExternalSemaSource with builder implementations to

[PATCH] D128372: [Clang-Tidy] Empty Check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:55 + +auto Methods = MemberCall->getRecordDecl()->methods(); +auto Clear = llvm::find_if(Methods, [](const CXXMethodDecl *F) { Please don't us

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 439938. abrahamcd marked 7 inline comments as done. abrahamcd retitled this revision from "Clang-Tidy Empty Check" to "[Clang-Tidy] Empty Check". abrahamcd added a comment. Herald added a subscriber: xazax.hun. Added functionality to check if member functio

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan added a comment. In D128567#3609635 , @leonardchan wrote: > Won't be landing this until I'm sure any new tests that will be running from > this won't fail locally. Or given https://reviews.llvm.org/D126936 and this could just pass magically

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan added a comment. An alternative approach to this is update this bit of cmake in compiler-rt/CMakeLists.txt: set(COMPILER_RT_LLD_PATH ${LLVM_MAIN_SRC_DIR}/tools/lld) if(EXISTS ${COMPILER_RT_LLD_PATH}/ AND LLVM_TOOL_LLD_BUILD) set(COMPILER_RT_HAS_LLD TRUE) else() set(COMP

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan added a comment. Won't be landing this until I'm sure any new tests that will be running from this won't fail locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128567/new/ https://reviews.llvm.org/D128567

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: clang. Herald added subscribers: abrachet, kristof.beyls, mgorny. Herald added a project: All. leonardchan requested review of this revision. Herald added a subscriber: cfe-commits. `LLVM_TOOL_LLD

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME: Metadata should be attched directly to the global directly instead - // of being

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

MaskRay added a comment. In addition, don't use `Reland "Reland "Reland "Reland ...` One `Reland` is sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082 __

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

cmtice added a comment. I did some testing and verified that this commit is causing some of the Sanitizer issues we are seeing. Is there any chance of a revert? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 _

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 marked 2 inline comments as done. sagarkulkarni19 added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:342 + if (HasSME) +Builder.defineMacro("__ARM_FEATURE_SME", "1"); + sdesmalen wrote: > sagarkulkarni19 wrote: > > sdesmal

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

MaskRay added a comment. Please include `Differential Revision: ` line for reland commits as well so that people know that this patch has a reland. https://github.com/llvm/llvm-project/issues/56204 is related to 655ba9c8a1d22075443711cc749f0b032e07adee

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 updated this revision to Diff 439919. sagarkulkarni19 edited the summary of this revision. sagarkulkarni19 added a comment. Updated testcases and also added the `vnum` variant of the ld1 and st1 intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439918. hctim marked 3 inline comments as done. hctim added a comment. Vitaly's comments, round 2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/Co

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address | Sanit

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

fmayer added a comment. FWIW this is not really NFC, I found this as the culprit in bisecting the Android LLVM toolchain build, causing the following error: FAILED: tools/clang/tools/extra/pseudo/include/CXXBNF.inc /usr/local/google/home/fmayer/llvm-toolchain/out/stage2/tools/clang/tools/extr

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

efriedma added a comment. I suspect the refactoring in the latest version of the patch accidentally made UBSan a bit more strict by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-c

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added a comment. The rest is LGTM Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address |

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439912. hctim marked 2 inline comments as done. hctim added a comment. Vitaly's comments - round 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/C

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2100 +GlobalVariable *Metadata = CreateMetadataGlobal( +M, Initializer, llvm::demangle(std::string(G->getName(;

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

tahonermann accepted this revision as: tahonermann. tahonermann added a comment. This revision is now accepted and ready to land. > @tahonermann gentle ping (Aaron told me you might have further comments) I'm sorry for the delay. I ran out of time to do the thorough review I would have liked to

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:201 + const FieldDecl *FD = nullptr; + size_t Sz = -1; + VarDecl *VD = nullptr; ABataev wrote: > What is Sz here? Better to give a better name and add a description for the > st

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 updated this revision to Diff 439906. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D127803 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/default_firstprivate_ast_print.cpp clang/test/OpenMP/d

[PATCH] D128363: [clang][dataflow] Implement functionality for flow condition variable substitution.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:209 + /// `Substitutions`, it will be substituted with the value it maps to. + BoolValue &buildAndSubstituteFlowCondition( +

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:34 /// Return whether `Var` was changed in `LoopStmt`. static bool isChanged(const Stmt *LoopStmt, const VarDecl *Var, ASTContext *Context) { -

[PATCH] D128556: Make Objective-C++ match Objective-C's behavior on implicit ivar access when `self` is shadowed

gribozavr2 added a comment. Please add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128556/new/ https://reviews.llvm.org/D128556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439903. ziqingluo-90 added a comment. I missed the part of coding standard about the usage of `auto`. Now change to conform to it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-too

[PATCH] D128521: [clang][dataflow] Implement functionality to compare if two boolean values are equivalent.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f65a3e61005: [clang][dataflow] Implement functionality to compare if two boolean values are… (authored by wyt, committed by gribozavr). Repository:

[clang] 0f65a3e - [clang][dataflow] Implement functionality to compare if two boolean values are equivalent.

Author: Wei Yi Tee Date: 2022-06-25T00:10:35+02:00 New Revision: 0f65a3e610051fc319372eea647fb50f60b2b21c URL: https://github.com/llvm/llvm-project/commit/0f65a3e610051fc319372eea647fb50f60b2b21c DIFF: https://github.com/llvm/llvm-project/commit/0f65a3e610051fc319372eea647fb50f60b2b21c.diff LO

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hubert.reinterpretcast added a comment. In D127544#3609393 , @hctim wrote: > I see that the clang-ppc64le-linux bot is green with the second attempt > (https://lab.llvm.org/buildbot/#/builders/105/builds/27200). Please let me > know if you have further

[PATCH] D128520: [clang][dataflow] Refactor function that queries the solver for satisfiability checking.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42a7ddb428c9: [clang][dataflow] Refactor function that queries the solver for satisfiability… (authored by wyt, committed by gribozavr). Repository

[clang] 42a7ddb - [clang][dataflow] Refactor function that queries the solver for satisfiability checking.

Author: Wei Yi Tee Date: 2022-06-25T00:05:43+02:00 New Revision: 42a7ddb428c999229491b0effbb1a4059149fba8 URL: https://github.com/llvm/llvm-project/commit/42a7ddb428c999229491b0effbb1a4059149fba8 DIFF: https://github.com/llvm/llvm-project/commit/42a7ddb428c999229491b0effbb1a4059149fba8.diff LO

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. I see that the clang-ppc64le-linux bot is green with the second attempt (https://lab.llvm.org/buildbot/#/builders/105/builds/27200). Please let me know if you have further issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D128521: [clang][dataflow] Implement functionality to compare if two boolean values are equivalent.

wyt updated this revision to Diff 439899. wyt added a comment. Propagate change from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128521/new/ https://reviews.llvm.org/D128521 Files: clang/include/clang/Analysis/FlowSensitive/Dataf

[PATCH] D128520: [clang][dataflow] Refactor function that queries the solver for satisfiability checking.

wyt updated this revision to Diff 439898. wyt marked an inline comment as done. wyt added a comment. Rename `checkUnsatisfiable` to `isUnsatisfiable` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128520/new/ https://reviews.llvm.org/D128520 Files:

[clang] 243fc3d - fix-forward hwasan-globals.cpp (round 2)

Author: Mitch Phillips Date: 2022-06-24T14:49:37-07:00 New Revision: 243fc3daf675ea047bb80c21c62d24a331da8b16 URL: https://github.com/llvm/llvm-project/commit/243fc3daf675ea047bb80c21c62d24a331da8b16 DIFF: https://github.com/llvm/llvm-project/commit/243fc3daf675ea047bb80c21c62d24a331da8b16.diff

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

dblaikie added subscribers: cmtice, dblaikie. dblaikie added a comment. Herald added a subscriber: steakhal. Looks like this got committed in 886715af962de2c92fac4bd37104450345711e4a though it was missing the `Differential Rev

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. In D127544#3609343 , @hubert.reinterpretcast wrote: > In D127544#3609335 , @hctim wrote: > >> Sent fadc98b06befb674fa47da4f3d8606bf61bed681 >>

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hubert.reinterpretcast added a comment. In D127544#3609335 , @hctim wrote: > Sent fadc98b06befb674fa47da4f3d8606bf61bed681 > to > fix-forward. I thought `*-registered-target` is true

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. Sent fadc98b06befb674fa47da4f3d8606bf61bed681 to fix-forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544

[clang] fadc98b - Don't run hwasan-globals.cpp test on non-x86/aarch64

Author: Mitch Phillips Date: 2022-06-24T14:33:41-07:00 New Revision: fadc98b06befb674fa47da4f3d8606bf61bed681 URL: https://github.com/llvm/llvm-project/commit/fadc98b06befb674fa47da4f3d8606bf61bed681 DIFF: https://github.com/llvm/llvm-project/commit/fadc98b06befb674fa47da4f3d8606bf61bed681.diff

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. In D127544#3609312 , @hubert.reinterpretcast wrote: > This is causing "unsupported architecture" errors on bots. Looking, I see this on the sanitizer-ppc64 bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hubert.reinterpretcast added a comment. From the content of this patch, it probably is `llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp`: switch (TargetTriple.getArch()) { case Triple::x86_64: // The signal handler will find the data address in rdi. Asm = InlineAsm::get(

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hubert.reinterpretcast added a comment. This is causing "unsupported architecture" errors on bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544 ___ cfe-commi

[PATCH] D128520: [clang][dataflow] Refactor function that queries the solver for satisfiability checking.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:224 + /// assignment for `Constraints` + bool checkUnsatisfiable(llvm::DenseSet Constraints) { +return querySolver(std::mov

[PATCH] D128519: [clang][dataflow] Move logic for creating implication and iff expressions into `DataflowAnalysisContext` from `DataflowEnvironment`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG00e9d53453ab: [clang][dataflow] Move logic for creating implication and iff expressions into… (authored by wyt, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D128519?vs=4397

[clang] 00e9d53 - [clang][dataflow] Move logic for creating implication and iff expressions into `DataflowAnalysisContext` from `DataflowEnvironment`.

Author: Wei Yi Tee Date: 2022-06-24T23:16:44+02:00 New Revision: 00e9d53453abc8f2e3d69e9c7fba83dc65a74259 URL: https://github.com/llvm/llvm-project/commit/00e9d53453abc8f2e3d69e9c7fba83dc65a74259 DIFF: https://github.com/llvm/llvm-project/commit/00e9d53453abc8f2e3d69e9c7fba83dc65a74259.diff LO

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2100 +GlobalVariable *Metadata = CreateMetadataGlobal( +M, Initializer, llvm::demangle(std::string(G->getName(; was this demanded before? ==

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:160 + if (const auto *Call = dyn_cast(StmtNode)) { +const auto *Callee = Call->getDirectCallee(); + Please don't use `auto` when type is not spelled

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439884. ziqingluo-90 added a comment. trying to be consistent in that `auto` is used wherever possible CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tools-extra/clang-tidy/bugprone/In

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439883. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-extra/test/clang-tidy/checkers/bugprone/infinite-loop.cpp cla

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439882. ziqingluo-90 added a comment. addressing more comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-extra/

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439880. hctim added a comment. Rebase on main / landed changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/C

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 439878. samestep added a comment. - Merge branch 'main' into diagnose-api - WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files: clang/include/clang/Analysi

[PATCH] D128556: Make Objective-C++ match Objective-C's behavior on implicit ivar access when `self` is shadowed

mwyman created this revision. mwyman added a project: clang. Herald added a project: All. mwyman requested review of this revision. Herald added a subscriber: cfe-commits. When compiling Objective-C++, name lookup uses the C++ lookup behavior that skips the filtering of non-implicit-self referenc

[PATCH] D128554: [Driver][Minix] -r: imply -nostdlib like GCC

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Similar to D116843 . Repository: rG LLVM Github Monorepo https

[PATCH] D128357: [clang][dataflow] Store flow condition constraints in a single `FlowConditionConstraints` map.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb88ea62602c: [clang][dataflow] Store flow condition constraints in a single… (authored by wyt, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] fb88ea6 - [clang][dataflow] Store flow condition constraints in a single `FlowConditionConstraints` map.

Author: Wei Yi Tee Date: 2022-06-24T21:52:16+02:00 New Revision: fb88ea62602c90f8f7c80560fd6a14f1c8c6d520 URL: https://github.com/llvm/llvm-project/commit/fb88ea62602c90f8f7c80560fd6a14f1c8c6d520 DIFF: https://github.com/llvm/llvm-project/commit/fb88ea62602c90f8f7c80560fd6a14f1c8c6d520.diff LO

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/TokenManager.h:33 + /// The syntax-tree Leaf node holds a Key. + using Key = const void *; + /// Gets the text of token identified by the key. ilya-biryukov wrote: > I have just reali

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 439853. jhuber6 added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Fr

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 439851. jhuber6 added a comment. Simplify interface now that we use -1 to indicate a lack of teams. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6720-6722 } else if (DefaultNT == -1) { -return nullptr; +return llvm::ConstantInt::get(CGF.Int32Ty, -1); } This code can be removed safely in this form Repository:

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 added a comment. This currently fails about 180 Clang tests. Of those about half can be automatically updated. I tried to manually update the other 90 but gave up, attempting to auto generate those tests as well would most likely result in over half a million new lined added to LLVM, th

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfaf5e0ec737a: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op). (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES S

[clang] faf5e0e - Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

Author: Mitch Phillips Date: 2022-06-24T12:04:11-07:00 New Revision: faf5e0ec737a676088649d7c13cb50f3f91a703a URL: https://github.com/llvm/llvm-project/commit/faf5e0ec737a676088649d7c13cb50f3f91a703a DIFF: https://github.com/llvm/llvm-project/commit/faf5e0ec737a676088649d7c13cb50f3f91a703a.diff

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 created this revision. jhuber6 added reviewers: ABataev, JonChesterfield, jdoerfert, tianshilei1992. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1.

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

efriedma added a comment. Under this scheme, is it illegal to link together object files built with -ffine-grained-bitfield-accesses and object files built with -fno-fine-grained-bitfield-accesses? Do we want to add a temporary option to control this, to make it easier for people to benchmark

[PATCH] D128535: [analyzer] Improve loads from reinterpret-cast fields

steakhal added a comment. No runtime diff. No crashes. 8 disappeared: - 4 core.CallAndMessage (1st arg is uninitialized) - 2 alpha.deadcode.UnreachableCode (sinked before reaching it) - 2 core.UndefinedBinaryOperatorResult 2 new reports: - 1 core.UndefinedBinaryOperatorResult - 1 alpha.security

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. I get a test failure when I run with your change: -- Testing: 972 tests, 12 workers -- FAIL: Clang Tools :: clang-apply-replacements/basic.cpp (680 of 97

[PATCH] D128436: [OpenCL] Remove fast_ half geometric builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128436/new/ https://reviews.llvm.org/D128436 _

[PATCH] D128512: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD.

MaskRay added inline comments. Comment at: clang/test/Driver/coverage-ld.c:43 +// RUN: | FileCheck --check-prefix=CHECK-OPENBSD-X86-64 %s +// +// CHECK-OPENBSD-X86-64: "{{(.*[^-.0-9A-Z_a-z])?}}ld{{(.exe)?}}" Don't add `//\n` by cargo cult. It's not a recommende

[PATCH] D128434: [OpenCL] Remove half scalar vload/vstore builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128434/new/ https://reviews.llvm.org/D128434 _

[PATCH] D128449: [clang] Introduce -Warray-parameter

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3220 + + // `type[]` is equivalent to `type *` and `type[*]` + if (NoSizeInfo(Old) && NoSizeInfo(New)) Comment at: clang/lib/Sema/SemaDecl.cpp:3224 + + // Don't tr

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. In D127579#3598308 , @nikic wrote: > In D127579#3598306 , @Anastasia > wrote: > >> In D127579#3595461 , @nikic wrote: >> >>> In D127579#3588626

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

aaron.ballman added a comment. In general, I think this is looking pretty close to good. Whether clang-tidy should get this functionality in this form or not is a bit less clear to me. *I* think it's helpful functionality and the current approach is reasonable, but I think it might be worthwhil

[PATCH] D119296: KCFI sanitizer

samitolvanen planned changes to this revision. samitolvanen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6694 - if (isExternallyVisible(T->getLinkage())) { + if (isExternallyVisible(T->getLinkage()) || !OnlyExternal) { std::string OutName; -

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:201 + const FieldDecl *FD = nullptr; + size_t Sz = -1; + VarDecl *VD = nullptr; What is Sz here? Better to give a better name and add a description for the struct and all fie

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11071-11073 + if (!getDerived().AlwaysRebuild() && !getSema().getLangOpts().OpenMP && + Base.get() == E->getBase() && QualifierLoc == E->getQualifierLoc() && + Member == E->getMemberDecl() && Fou

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11071-11073 + if (!getDerived().AlwaysRebuild() && !getSema().getLangOpts().OpenMP && + Base.get() == E->getBase() && QualifierLoc == E->getQualifierLoc() && + Member == E->getMemberDecl() && FoundD

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 updated this revision to Diff 439812. jyu2 added a comment. Remove change in TreeTransform.h. Will deal that in other patch. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D127803 Files: clang/l

[clang] 4821508 - Revert "DebugInfo: Fully integrate ctor type homing into 'limited' debug info"

Author: David Blaikie Date: 2022-06-24T17:07:47Z New Revision: 4821508d4db75a535d02b8938f81fac6de66cc26 URL: https://github.com/llvm/llvm-project/commit/4821508d4db75a535d02b8938f81fac6de66cc26 DIFF: https://github.com/llvm/llvm-project/commit/4821508d4db75a535d02b8938f81fac6de66cc26.diff LOG:

[PATCH] D128363: [clang][dataflow] Implement functionality for flow condition variable substitution.

wyt updated this revision to Diff 439810. wyt marked 2 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128363/new/ https://reviews.llvm.org/D128363 Files: clang/include/clang/Analysis

[PATCH] D128482: [clang codegen] Add dso_local/hidden/etc. markings to VTT declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe11bf8de729a: [clang codegen] Add dso_local/hidden/etc. markings to VTT declarations (authored by efriedma). Repository: rG LLVM Github Monorepo

[clang] e11bf8d - [clang codegen] Add dso_local/hidden/etc. markings to VTT declarations

Author: Eli Friedman Date: 2022-06-24T09:58:31-07:00 New Revision: e11bf8de729a4d6eb0d3b5cf154f900cddc522d3 URL: https://github.com/llvm/llvm-project/commit/e11bf8de729a4d6eb0d3b5cf154f900cddc522d3 DIFF: https://github.com/llvm/llvm-project/commit/e11bf8de729a4d6eb0d3b5cf154f900cddc522d3.diff

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood added a comment. In D128157#3605829 , @jspam wrote: > I see :) Yes, looks like Git's rename detection did its job. > > Thanks for the review. Could you or someone else please merge this for me? > Author: Joachim Priesner I can submit,

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:190 + +containsFunc |= (CanDecl == Func); +overlap |= Callees.contains(CanDecl); Personally I'm not a fan of using bitwise operators with bool

  1   2   >