[PATCH] D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks

jmciver created this revision. Herald added a subscriber: mgorny. Herald added a project: All. jmciver published this revision for review. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. When building in debug mode, ABI breaking assertion checks are

[PATCH] D127260: [clang-format] Remove braces of else blocks that embody an if block

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2620 + } else if (IfLBrace && !IfLBrace->Optional) { +KeepIfBraces = true; +markOptionalBraces(ElseLeftBrace); To be precise. It doesn't matter now but will w

[PATCH] D127260: [clang-format] Remove braces of else blocks that embody an if block

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: clang/unittests/Format/FormatTest.cpp:25570-25575 + " else {\n" + "if (d) {\n" + " e;\n" +

[PATCH] D127260: [clang-format] Remove braces of else blocks that embody an if block

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25570-25575 + " else {\n" + "if (d) {\n" + " e;\n" + " f;\n" + "}\n" + " }\n"

[PATCH] D127270: [clang-format] Add space in placement new expression

curdeius added a comment. Apart from some missing tests, looks promising! Comment at: clang/unittests/Format/FormatTest.cpp:15276-15286 + FormatStyle SpacePlacementNew = getLLVMStyle(); + SpacePlacementNew.SpaceBeforeParens = FormatStyle::SBPO_Custom; + SpacePlacementNew.Spa

[PATCH] D127260: [clang-format] Remove braces of else blocks that embody an if block

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25570-25575 + " else {\n" + "if (d) {\n" + " e;\n" + " f;\n" + "}\n" + " }\n"

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 updated this revision to Diff 435049. Ericson2314 added a comment. Herald added a subscriber: bzcheeseman. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 F

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 updated this revision to Diff 435048. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 Files: bolt/tools/CMakeLists.txt bolt/tools/driver/CMakeLists.txt

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Herald added a subscriber: bzcheeseman. Herald added a project: All. I moved the `openmp` definitions so they should be used. Don't need the other variables yet I don't think? Comment at: openmp/tools/CMakeLists.txt:1-3 +set(OPENMP_TOOLS_INSTALL_DI

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. Oh, the diff part is small really. The change looks good to me and I've tested it for libcxx. But it crashed at "clang/lib/Sema/SemaTemplateInstantiate.cpp:1852: clang::QualType {anonymous}::TemplateInstantiator::TransformTemplateTypeParmType(clang::TypeLocBuilder&,

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed created this revision. omarahmed added a reviewer: MyDeveloperDay. Herald added a project: All. omarahmed requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add AfterPlacementNew option to SpaceBeforeParensOptions to have more contro

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

rprichard added a comment. This change is needed for D28213 , so that the `__GCC_ATOMIC_LLONG_LOCK_FREE` macro matches for `-target i386-unknown-linux-gnu` between `--cuda-host-only` and `--cuda-device-only`. This is tested in clang/test/Preprocessor/cuda-types.

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#3564629 , @iains wrote: > the first failure is like this: > > x-h.h: > struct A { > friend int operator+(const A &lhs, const A &rhs) { > return 0; > } > }; > > X.cpp: > module; > #include

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

rprichard updated this revision to Diff 435037. rprichard edited the summary of this revision. rprichard added a comment. Rebase this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28213/new/ https://reviews.llvm.org/D28213 Files: clang

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:428 +} + void AVR::Linker::ConstructJob(Compilation &C, const JobAction &JA, 1. Though I expect each device family has its own optimized build of compiler-rt binary, I found most t

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 435036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127269: Add llvm's Support lib to the psuedoCXX library

lanza created this revision. Herald added a subscriber: mgorny. Herald added a project: All. lanza requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This is failing to find `EnableABIBreakingCheck` at link time. Add Support to pro

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

khchen added a comment. > Store to null will be changed to unreachable, so all instructions after vleff > intrinsic call will be deleted and it causes runtime errors. If destination > to store is null, we won't extract and store the new vl. > Yes, but only for vleff instructions, since it has

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

rprichard created this revision. Herald added subscribers: jsji, kosarev, mattd, gchakrabarti, asavonic, kerbowa, pengfei, jvesely. Herald added a project: All. rprichard requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, jholewinski. Herald added a reviewer: jdoer

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3563356 , @erichkeane wrote: > Ping! > > @ChuanqiXu : i was hoping you could take a look at this, since you did such a > great job reviewing the rest of this (note this is mostly the same patch as > the last one, j

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 435004. junaire added a comment. I believe that `OldBuilder` is always valid in the normal cases, so remove the if condition and replace it with an assertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 435000. junaire added a comment. Address @rjmccall 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/lib/

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3562409 , @MaskRay wrote: > ELF linkers don't error for two `SHN_ABS` `STB_GLOBAL` symbols of the same > `st_value`. > When the `st_value` fields differ, there will be a diagnostic. If needed, the > specialized d

[PATCH] D127260: [clang-format] Remove braces of else blocks that embody an if block

owenpan created this revision. owenpan added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D127177: Add checks for -lresolv to sanitizer-ld test. These were missed in https://reviews.llvm.org/D127145.

This revision was automatically updated to reflect the committed changes. Closed by commit rG69cd7417f01a: Add checks for -lresolv to sanitizer-ld test. (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127177/new/ https://reviews.llv

[clang] 69cd741 - Add checks for -lresolv to sanitizer-ld test.

Author: Kevin Athey Date: 2022-06-07T16:07:02-07:00 New Revision: 69cd7417f01abef6f23d6768f71ce5995972f4b6 URL: https://github.com/llvm/llvm-project/commit/69cd7417f01abef6f23d6768f71ce5995972f4b6 DIFF: https://github.com/llvm/llvm-project/commit/69cd7417f01abef6f23d6768f71ce5995972f4b6.diff L

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

akyrtzi updated this revision to Diff 434980. akyrtzi added a comment. Disable `clang-format` checks for the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127251/new/ https://reviews.llvm.org/D127251 Files: clang/include/clang/Lex/Pre

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

johannes added a comment. Ok thanks, I will take a look later. Might be a locale issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126651/new/ https://reviews.llvm.org/D126651 ___ cfe-commits mailing

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

vitalybuka added a comment. In D127163#3564919 , @hctim wrote: > We already have `-fsanitize=memtag` that implies `-fsanitize=memtag-heap` and > `-fsanitize=memtag-stack`. > > It makes the most sense IMHO in the world where we want heap MTE. > `-fsaniti

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen created this revision. ychen added reviewers: rsmith, rnk. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Based on the Richard's suggestion in D126341 : `If we can

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: lld/ELF/Symbols.cpp:553 + // incompatible declarations for the same function. + if (isWeak() && getName().startswith("__kcfi_typeid_") && + cast(this)->value != other.value) samitolvanen wrote: > MaskRay wrot

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 434974. samitolvanen marked 9 inline comments as done. samitolvanen added a comment. - Addressed Fangrui's feedback. - Renamed `KCFI_*` DAG nodes and pseudo instructions to `CFI_*` for now based on Joao's feedback. Still looking for more feedback on the

[clang] b5b33fb - [clang-format] Skip parsing a block if it's nested too deep

Author: owenca Date: 2022-06-07T15:28:03-07:00 New Revision: b5b33fbffb087f69f54b9a7bce70828ef6e82601 URL: https://github.com/llvm/llvm-project/commit/b5b33fbffb087f69f54b9a7bce70828ef6e82601 DIFF: https://github.com/llvm/llvm-project/commit/b5b33fbffb087f69f54b9a7bce70828ef6e82601.diff LOG: [

[PATCH] D127183: [clang-format] Skip parsing a block if it's nested too deep

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b33fbffb08: [clang-format] Skip parsing a block if it's nested too deep (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127183/new/ h

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

tlively updated this revision to Diff 434968. tlively added a comment. - dot_add takes three operands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127170/new/ https://reviews.llvm.org/D127170 Files: clang/include/clang/Basic/BuiltinsWebAssembly

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim added a comment. We already have `-fsanitize=memtag` that implies `-fsanitize=memtag-heap` and `-fsanitize=memtag-stack`. It makes the most sense IMHO in the world where we want heap MTE. `-fsanitize=memtag-heap` is the most reasonable instead of `-fsanitize-memtag-heap`, as "do i need `

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

eugenis added a comment. I don't have a lot of arguments either way, do you? Ignorelist support is one for the new sanitizer type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 _

[clang] 7805ae2 - Revert "[clang-diff] Fix assertion error when dealing with wide strings"

Author: Douglas Yung Date: 2022-06-07T14:58:10-07:00 New Revision: 7805ae257f6babf51c4290d0ff80c1c47b173def URL: https://github.com/llvm/llvm-project/commit/7805ae257f6babf51c4290d0ff80c1c47b173def DIFF: https://github.com/llvm/llvm-project/commit/7805ae257f6babf51c4290d0ff80c1c47b173def.diff

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

vitalybuka added a comment. Why do we want this as a separate -fsanitize= Maybe better to have some modifier flag like -fsanitize-memtag-globals=1 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 __

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 434960. ahatanak marked an inline comment as done. ahatanak added a comment. Check that the destructor is called at the end of the asm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

akyrtzi updated this revision to Diff 434959. akyrtzi added a comment. Remove the parameter from documentation comment as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127251/new/ https://reviews.llvm.org/D127251 Files: clang/include/clang

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added a comment. I simplified this a little bit, but I guess this is effectively the same. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2767-2781 + if (NoSanitizeL.containsGlobal(LangOpts.Sanitize.Mask, GV->getName(), Category)) return true; - if (NoSaniti

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka updated this revision to Diff 434956. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/Sanitiz

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka updated this revision to Diff 434955. vitalybuka added a comment. fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: llvm/include/llvm/AsmParser/LLParser.h llvm/include/llvm/

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + + struct KeepLazyEmiitedSymRAII { +std::unique_ptr OldBuilder; rjmccall wrote: > junaire wrote: > > rjmccall wrote: > > > I think a RAII object is an odd way to express this

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

tlively planned changes to this revision. tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:190 +TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_s_i16x8, "V8sV16ScV16Sc", "nc", "relaxed-simd") +TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x1

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka updated this revision to Diff 434947. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/Sanitiz

[clang] d7df3f0 - [NFC] Exctract getNoSanitizeMask lambda

Author: Vitaly Buka Date: 2022-06-07T14:08:43-07:00 New Revision: d7df3f0a4b8dd089ade1805ab150efc5b1c84fe7 URL: https://github.com/llvm/llvm-project/commit/d7df3f0a4b8dd089ade1805ab150efc5b1c84fe7 DIFF: https://github.com/llvm/llvm-project/commit/d7df3f0a4b8dd089ade1805ab150efc5b1c84fe7.diff L

[clang] f32ad57 - [NFC] Move part of SanitizerMetadata into private method

Author: Vitaly Buka Date: 2022-06-07T14:08:43-07:00 New Revision: f32ad5703e83435522df18b862979b83cc5bf7c3 URL: https://github.com/llvm/llvm-project/commit/f32ad5703e83435522df18b862979b83cc5bf7c3 DIFF: https://github.com/llvm/llvm-project/commit/f32ad5703e83435522df18b862979b83cc5bf7c3.diff L

[clang] 5d9de5f - [NFC] Clang-format parts of D126929 and D126100

Author: Mitch Phillips Date: 2022-06-07T14:08:43-07:00 New Revision: 5d9de5f446601d80ebbe5e281f783912b3585bad URL: https://github.com/llvm/llvm-project/commit/5d9de5f446601d80ebbe5e281f783912b3585bad DIFF: https://github.com/llvm/llvm-project/commit/5d9de5f446601d80ebbe5e281f783912b3585bad.diff

[clang] f49a584 - [NFC][CodeGen] Rename method

Author: Mitch Phillips Date: 2022-06-07T14:08:42-07:00 New Revision: f49a5844b6c8804985743061a994f42b9d54ebc5 URL: https://github.com/llvm/llvm-project/commit/f49a5844b6c8804985743061a994f42b9d54ebc5 DIFF: https://github.com/llvm/llvm-project/commit/f49a5844b6c8804985743061a994f42b9d54ebc5.diff

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

akyrtzi updated this revision to Diff 434940. akyrtzi added a comment. No need to add '#' for the fixit since we have the range of the directive identifier to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127251/new/ https://reviews.llvm.org/

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `EndLoc` parameter was always unset so no fixit was emitted. But it is also unnecessary for determining the range so we

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:403 case DW_AT_type: - type = form_value; + if (!type.IsValid()) +type = form_value; Could you add a com

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:397 + // GV's mentioned in -fsanitize-ignorelist=. + kw_no_sanitize, + // GV's with __attribute__((no_sanitize("address"))). do we need no_sanitize on IR level? We should map i

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains added a comment. the first failure is like this: x-h.h: struct A { friend int operator+(const A &lhs, const A &rhs) { return 0; } }; X.cpp: module; #include "x-h.h" export module X; export using ::A; This does not mark *anything* in the GMF (x-h.h) as 'u

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, tra, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The linker wrapper currently eag

[clang] f06731e - [Binary] Make the OffloadingImage type own the memory

Author: Joseph Huber Date: 2022-06-07T15:56:09-04:00 New Revision: f06731e3c367c481acc8bc6b1f8244039992fa65 URL: https://github.com/llvm/llvm-project/commit/f06731e3c367c481acc8bc6b1f8244039992fa65 DIFF: https://github.com/llvm/llvm-project/commit/f06731e3c367c481acc8bc6b1f8244039992fa65.diff

[clang] d46e7ae - Update the C2x status page from latest working draft

Author: Aaron Ballman Date: 2022-06-07T15:53:47-04:00 New Revision: d46e7aecb4b1006062a327c14024f7b22bc08a63 URL: https://github.com/llvm/llvm-project/commit/d46e7aecb4b1006062a327c14024f7b22bc08a63 DIFF: https://github.com/llvm/llvm-project/commit/d46e7aecb4b1006062a327c14024f7b22bc08a63.diff

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

efriedma added inline comments. Comment at: llvm/test/CodeGen/Thumb/frame-access.ll:335 +; CHECK-FP-AAPCS: mov r1, r11 +; CHECK-FP-AAPCS: ldr r0, [r0, r1] +; CHECK: bl i This sequence requires, in general, scavenging two registers. I'm not sure we can do that i

[PATCH] D127229: [clang][deps] Set -disable-free for module compilations

benlangmuir updated this revision to Diff 434916. benlangmuir added a comment. Attempt to fix Windows path issue in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127229/new/ https://reviews.llvm.org/D127229 Files: clang/lib/Tooling/Depende

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

efriedma added a comment. > As for SOCK_MAXADDRLEN, that's a horrid hack, and the definition of struct > sockaddr needs to change. :) Do we want some builtin define so headers can check if we're in -fstrict-flex-arrays mode? It might be hard to mess with the definitions otherwise. CHANGES S

[PATCH] D127243: [clang][deps] Make order of module dependencies deterministic

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a subscriber: mgrang. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes the underlying m

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

eugenis added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:767 + if (IsAArch64) { +Res |= SanitizerKind::MemtagGlobals; + } Hmm why are all the other memtag* not here? Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7892

[clang] dcb4950 - [clang][dataflow][NFC] Fix filename typos in tests

Author: Sam Estep Date: 2022-06-07T19:20:20Z New Revision: dcb4950d5b5bd025fe436cfdc6db3d366a11299c URL: https://github.com/llvm/llvm-project/commit/dcb4950d5b5bd025fe436cfdc6db3d366a11299c DIFF: https://github.com/llvm/llvm-project/commit/dcb4950d5b5bd025fe436cfdc6db3d366a11299c.diff LOG: [cl

[PATCH] D127008: [clang][dataflow] Fix filename typos in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb4950d5b5b: [clang][dataflow][NFC] Fix filename typos in tests (authored by samestep, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

dyung added a comment. Hi, the test you modified in your change seems to be failing on the PS4 linux build bot at https://lab.llvm.org/buildbot/#/builders/139/builds/22964. TEST 'Clang :: Tooling/clang-diff-ast.cpp' FAILED Script: -- : 'RUN: at

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Grammar.h:22 // +// The grammar supports extensions, which have the syntax form of +// [key=value;key=value]. Extensions are associated with a grammar symbol ( sammccall wr

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein updated this revision to Diff 434906. hokein marked 5 inline comments as done. hokein added a comment. - bring back the attribute concept, narrow down the ExtensionID scope (only used for semantic); - loose and simplify the BNF annotations parsing; ([] only allows single attribute, attrib

[PATCH] D127207: [flang][driver] Fix support for `-x`

ekieri added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:268 + // pre-processed inputs. +.Case("f95", Language::Fortran) +.Case("f95-cpp-input", Language::Fortran) Is there a reason to cha

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

kees added a comment. In D126864#3556262 , @efriedma wrote: > I'm a little concerned about the premise of this, though. See > https://github.com/llvm/llvm-project/issues/29694 for why we relaxed this > check in the first place. I mean, the Linux kerne

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

kees added a comment. Thanks for working on this! Doing test builds with the Linux kernel correctly detects a number of trailing arrays that were being treated as flexible arrays (and need to be fixed in the kernel). This is exactly what was expected and wanted. :) Comment a

[clang] 5c3bde9 - [CodeGen] Fix an issue when the 'extern C' replacement names broke

Author: Erich Keane Date: 2022-06-07T11:30:59-07:00 New Revision: 5c3bde96250c5260773009e691f92cb4823372df URL: https://github.com/llvm/llvm-project/commit/5c3bde96250c5260773009e691f92cb4823372df DIFF: https://github.com/llvm/llvm-project/commit/5c3bde96250c5260773009e691f92cb4823372df.diff L

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

This revision was automatically updated to reflect the committed changes. Closed by commit rGe80748ff8840: [clang-diff] Fix assertion error when dealing with wide strings (authored by PRESIDENT810, committed by johannes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] e80748f - [clang-diff] Fix assertion error when dealing with wide strings

Author: Kaining Zhong Date: 2022-06-07T20:24:34+02:00 New Revision: e80748ff8840a10bd7c7336eb5e98664480ba1ba URL: https://github.com/llvm/llvm-project/commit/e80748ff8840a10bd7c7336eb5e98664480ba1ba DIFF: https://github.com/llvm/llvm-project/commit/e80748ff8840a10bd7c7336eb5e98664480ba1ba.diff

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. https://discourse.llvm.org/t/rfc-improving-clang-s-diagnostics/62584/8 There is an ongoing RFC similar to the work here, worth noting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D1

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); sepavloff wrote:

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

ychen updated this revision to Diff 434884. ychen added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenModule.cpp cla

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7fa4e8a8bc4: [analyzer] Fix null pointer deref in CastValueChecker (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] c7fa4e8 - [analyzer] Fix null pointer deref in CastValueChecker

Author: Vince Bridgers Date: 2022-06-07T13:34:06-04:00 New Revision: c7fa4e8a8bc41e52cc49a27e0495d67d730fa167 URL: https://github.com/llvm/llvm-project/commit/c7fa4e8a8bc41e52cc49a27e0495d67d730fa167 DIFF: https://github.com/llvm/llvm-project/commit/c7fa4e8a8bc41e52cc49a27e0495d67d730fa167.diff

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

ychen created this revision. ychen added reviewers: rnk, rsmith. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/55804 The lexing order is already bookkep

[PATCH] D127229: [clang][deps] Set -disable-free for module compilations

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The command-line arguments for module builds are cc1 commands,

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); efriedma wrote:

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); sepavloff wrote:

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3562409 , @MaskRay wrote: > a) Naming > > About the 'k' prefix: this is generic and does not need to be coupled with > "kernel", > but perhaps an argument can be made that the 'k' does not need to refer to > "ker

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

nlee updated this revision to Diff 434842. nlee added a comment. After some investigation, I think it is not always explicit that removing `const` makes any improvements when we are "constructing." For example, in this case , the two codes which differ in the re

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

browneee added a comment. Bump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126944/new/ https://reviews.llvm.org/D126944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked 2 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:732 + // AAPCS requires use of R11, and PACBTI gets in the way of regular pushes, + // so FP ends up on area two. if (HasFP) { e

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 434846. pratlucas marked 2 inline comments as done. pratlucas added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files: clang/i

[clang] 1fd6f06 - [format] Fix an uninitialized variable

Author: Benjamin Kramer Date: 2022-06-07T18:18:29+02:00 New Revision: 1fd6f06b9e975386f4bb30ce8a1d044abeb1b633 URL: https://github.com/llvm/llvm-project/commit/1fd6f06b9e975386f4bb30ce8a1d044abeb1b633 DIFF: https://github.com/llvm/llvm-project/commit/1fd6f06b9e975386f4bb30ce8a1d044abeb1b633.dif

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:651 +BasicBlock *IsNotNull = createBasicBlock("newvl.isNotNull", this->CurFn); +BasicBlock *IsNull = createBasicBlock("newvl.isNull", this->CurFn); +Builder.CreateCo

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:650 + cast(NewVL->getType(; +BasicBlock *IsNotNull = createBasicBlock("newvl.isNotNull", this->CurFn); +BasicBlock *IsNull = createBasic

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Thanks for the review. Could you commit this? I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-

[PATCH] D127197: [ARM] Fix how size-0 bitfields affect homogeneous aggregates.

simon_tatham updated this revision to Diff 434838. simon_tatham added a comment. Added tests with `extern "C"`, at @lenary's (offline) suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127197/new/ https://reviews.llvm.org/D127197 Files:

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains added a comment. again, thanks for review - but please do not spend any effort on style points yet - the debug and dump stuff is intentionally present this is "for comment on the approach" i.e. what is important is to establish that this is a reasonable approach. As of now we have the fo

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains updated this revision to Diff 434834. iains marked 8 inline comments as done. iains added a comment. rebased and removed dependency on p1874 initializer patch. Some tidying - added 104. ex2 testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:222 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned RealTypeUsesObjCFPRet : 6; unsigned ComplexLongDoubleUsesFP2Ret : 1; Good find.

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

jcranmer-intel created this revision. Herald added a subscriber: ormris. Herald added a project: All. jcranmer-intel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127221 Fi

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Thanks for the review. Comments addressed in new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-commits mailing

  1   2   >