[PATCH] D125052: [HLSL] Enable vector types for hlsl.

rastogishubham added a comment. Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command: xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=Debug -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILER=/usr/bi

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433659. junaire added a comment. Fix the unittest failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Cod

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

pcwang-thead added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125875/new/ https://reviews.llvm.org/D125875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added a comment. In D125862#3552465 , @tbaeder wrote: > Ping. @MaskRay Can you take a quick look and check if this is what you had in > mind? LG Comment at: clang/unittests/Driver/ToolChainTest.cpp:615 +TEST(ToolChainTest, To

[PATCH] D126855: [clang-tidy] check_clang_tidy.py: Print output nicely in Python 3.

mboehme created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In Python 3, `encode()` produces a `bytes`. The way this is printed makes

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

uabelho added a comment. @steakhal : Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198/new/ https://reviews.llvm.org/D126198 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder added a comment. Ping. @MaskRay Can you take a quick look and check if this is what you had in mind? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 ___ cfe-commits mailing list cfe-commits@

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. > OK, as I mentioned. I think we need an attorney to review this change and > confirm that it actually accomplishes this goal. Can you add an attorney as a reviewer of this change so that we can proceed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. I know this is a rather huge diff, but the part that needs to be reviewed is the python script changes. I've rebuilt the HTML docs with sphinx and tested all the manually modified links to verify that they still go to the correct page. The existing Release No

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

shchenz added a comment. Thanks for doing this. I am not familiar with the frontend, so I may be wrong/stupid in the follow comments : ) Hope other experts like @hubert.reinterpretcast can give more meaningful comments. I tested on AIX, seems for static variable `static int x = foo();` in globa

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb418ef5cb90b: [clang-tidy] Reject invalid enum initializers in C files (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANG

[clang-tools-extra] b418ef5 - [clang-tidy] Reject invalid enum initializers in C files

Author: Richard Date: 2022-06-01T22:25:39-06:00 New Revision: b418ef5cb90b32657dee46b068ac367787a8d2d6 URL: https://github.com/llvm/llvm-project/commit/b418ef5cb90b32657dee46b068ac367787a8d2d6 DIFF: https://github.com/llvm/llvm-project/commit/b418ef5cb90b32657dee46b068ac367787a8d2d6.diff LOG:

[PATCH] D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

mboehme created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood updated this revision to Diff 433648. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125622/new/ https://reviews.llvm.org/D125622 Files: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMat

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.c:3-7 +// C requires enum values to fit into an int. +#define TOO_BIG1 1L +#define TOO_BIG2 1UL +#define TO

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

MaskRay added a comment. Your commit message seems to use the original summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D125847 ___ cfe-commits mailing list cfe

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. In D125624#3552284 , @khchen wrote: > IMO, maybe we could keep the DLLVM_BINUTILS_INCDIR option support but default > is using the Plugin.h? We can, but I wonder what is the motivation of doing it. Repository: rG LLVM Github Mo

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

khchen added a comment. IMO, maybe we could keep the DLLVM_BINUTILS_INCDIR option support but default is using the Plugin.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125624/new/ https://reviews.llvm.org/D125624 __

[libunwind] 13b8bfc - [libunwind] Add more information to eh_frame_hdr version error

Author: Florian Mayer Date: 2022-06-01T19:48:19-07:00 New Revision: 13b8bfc51451fcfc00f3e3480abaf64b337a43d4 URL: https://github.com/llvm/llvm-project/commit/13b8bfc51451fcfc00f3e3480abaf64b337a43d4 DIFF: https://github.com/llvm/llvm-project/commit/13b8bfc51451fcfc00f3e3480abaf64b337a43d4.diff

[PATCH] D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics.

pcwang-thead added a comment. In D125323#3550307 , @khchen wrote: > In D125323#3549794 , @pcwang-thead > wrote: > >> Is there an easy way to update tests? Or we need to add passthru operands >> manually? I will

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. > So what happens if LLVMgold.so uses one of the new structs or constants and > then is built and run on system where binutils is old enough to not have > these new structs and constants? The same thing can happen with GCC and binutils. Imagine that you install a newer

[clang] 4463bd0 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 8c8a2679a20f

Author: Nico Weber Date: 2022-06-01T22:33:36-04:00 New Revision: 4463bd0f89181234e0cef982e21de2e96038f873 URL: https://github.com/llvm/llvm-project/commit/4463bd0f89181234e0cef982e21de2e96038f873 DIFF: https://github.com/llvm/llvm-project/commit/4463bd0f89181234e0cef982e21de2e96038f873.diff LO

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a comment. In D125624#3552238 , @ruiu wrote: > The motivation of doing this is to be able to build LLVMgold.so without > binutils' source files and make it clear that LLVMgold.so does not include > any GPL code. OK, as I mentioned. I th

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. The motivation of doing this is to be able to build LLVMgold.so without binutils' source files and make it clear that LLVMgold.so does not include any GPL code. The header file defines the public interface between linker plugins and compilers (and other tools such as `ar`

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

sstwcw updated this revision to Diff 433626. sstwcw added a comment. - add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124748/new/ https://reviews.llvm.org/D124748 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/FormatT

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433624. junaire added a comment. Forget to use helpers again... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/l

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433623. junaire added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGe

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. What is the motivation for this change? I really don't like bundling external headers like this, because it can lead to subtle hard to catch bugs. It also makes it harder to di

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw updated this revision to Diff 433614. sstwcw added a comment. - use raw string for regex - use default style in test - remove parentheses - use seek now that skipOver no longer exists Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. I'm not sure if my credential is still valid. Do you mind if I ask you to submit this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125624/new/ https://reviews.llvm.org/D125624 ___

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.96

Jim updated this revision to Diff 433612. Jim added a comment. Herald added subscribers: sunshaoce, StephenFan, arichardson. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108189/new/ https://reviews.llvm.org/D108

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTestVerilog.cpp:179 + verifyFormat("`x = (`x1 + `x2 + x);"); + // Lines starting with a preprocessor directive should not be indented. + std::string Directives[] = {

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433610. junaire added a comment. Only use heplers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/Cod

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433607. junaire added a comment. Fix the broken build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. Does it? What is your test command? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125624/new/ https://reviews.llvm.org/D125624 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG850d53a197f9: LTO: Decide upfront whether to use opaque/non-opaque pointer types (authored by MatzeB). Repository: rG LLVM Github Monorepo CHANGE

[clang] 850d53a - LTO: Decide upfront whether to use opaque/non-opaque pointer types

Author: Matthias Braun Date: 2022-06-01T18:05:53-07:00 New Revision: 850d53a197f9ffbf5708b7bd795056335e81e9b7 URL: https://github.com/llvm/llvm-project/commit/850d53a197f9ffbf5708b7bd795056335e81e9b7 DIFF: https://github.com/llvm/llvm-project/commit/850d53a197f9ffbf5708b7bd795056335e81e9b7.diff

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

MaskRay added a comment. It's better to remove LLVM_BINUTILS_INCDIR for test directories in another patch. This change may expose some failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125624/new/ https://reviews.llvm.org/D125624 __

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added inline comments. Herald added a subscriber: Enna1. Comment at: llvm/tools/gold/gold-plugin.cpp:44-52 // FIXME: remove this declaration when we stop maintaining Ubuntu Quantal and // Precise and Debian Wheezy (binutils 2.23 is required) #define LDPO_PIE 3 #define

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

browneee added a comment. It looks like the leak is rooted at the allocation here: https://github.com/llvm/llvm-project/blob/1a155ee7de3b62a2fabee86fb470a1554fadc54d/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp#L3857 The VarTemplateSpecializationDecl is allocated using placement new which uses

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

MaskRay added inline comments. Comment at: llvm/lib/Object/OffloadBinary.cpp:18 - -namespace llvm { tra wrote: > tra wrote: > > Nit: `using namespace` seems a bit too heavy-handed when you only need one > > enum > > `using object_error = llvm::object::object_e

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3551834 , @tschuett wrote: > In D126796#3551781 , @cjdb wrote: > >> In D126796#3551312 , @tschuett >> wrote: >> >>> Would a JSON dump hel

[PATCH] D120007: [OMPIRBuilder] Add the support for compare capture

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb673be5ac85: [OMPIRBuilder] Add the support for compare capture (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120007/new/ htt

[clang] eb673be - [OMPIRBuilder] Add the support for compare capture

Author: Shilei Tian Date: 2022-06-01T19:53:43-04:00 New Revision: eb673be5ac8510646692f82a606a1f2c10f24828 URL: https://github.com/llvm/llvm-project/commit/eb673be5ac8510646692f82a606a1f2c10f24828 DIFF: https://github.com/llvm/llvm-project/commit/eb673be5ac8510646692f82a606a1f2c10f24828.diff L

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB added a comment. In D125847#3551972 , @MaskRay wrote: > In D125847#3551841 , @MatzeB wrote: > >> address review feedback. I assume this is accepted and good to push when the >> buildkit builds look reasona

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay added inline comments. Comment at: llvm/tools/gold/gold-plugin.cpp:966 + Config.OpaquePointers = options.opaque_pointers; + MatzeB wrote: > MaskRay wrote: > > `Conf`? > > > > > Ouch, good catch. Guess we have no form of direct testing of the gold plu

[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

daiyousei-qz updated this revision to Diff 433590. daiyousei-qz added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. added unit test moved redundant visit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1267

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB updated this revision to Diff 433591. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D125847 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/CodeGen/thinlto-inline-asm2.c clang/test/Drive

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay added a comment. In D125847#3551841 , @MatzeB wrote: > address review feedback. I assume this is accepted and good to push when the > buildkit builds look reasonable. (I changed myself to a blocking review to check the component I mostly care a

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB added inline comments. Comment at: llvm/tools/gold/gold-plugin.cpp:966 + Config.OpaquePointers = options.opaque_pointers; + MaskRay wrote: > `Conf`? > > Ouch, good catch. Guess we have no form of direct testing of the gold plugin in LLVM... Reposit

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay added inline comments. Comment at: llvm/tools/gold/gold-plugin.cpp:966 + Config.OpaquePointers = options.opaque_pointers; + `Conf`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://re

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > LTO: Decide upfront whether to use opaque/non-opaque pointer types This may need to mention "add options" to decide <...> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

mizvekov added a reviewer: mizvekov. mizvekov added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:373-374 case TemplateExpansion: -return TemplateArg.Name == Other.TemplateArg.Name && +return getAsTemplateOrTemplatePattern().getAsTemplateDecl() == +

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafd2f7e99197: [Binary] Promote OffloadBinary to inherit from Binary (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D1268

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB updated this revision to Diff 433577. MatzeB added a comment. address review feedback. I assume this is accepted and good to push when the buildkit builds look reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://re

[clang] afd2f7e - [Binary] Promote OffloadBinary to inherit from Binary

Author: Joseph Huber Date: 2022-06-01T18:40:57-04:00 New Revision: afd2f7e9919737e30f9fae2d3cff892189301a55 URL: https://github.com/llvm/llvm-project/commit/afd2f7e9919737e30f9fae2d3cff892189301a55 DIFF: https://github.com/llvm/llvm-project/commit/afd2f7e9919737e30f9fae2d3cff892189301a55.diff

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

tschuett added a comment. In D126796#3551781 , @cjdb wrote: > In D126796#3551312 , @tschuett > wrote: > >> Would a JSON dump help you for your tools? > > Do you think a JSON dump would be more appropriate? I was

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:118-119 TokenType NextLBracesType = TT_Unknown, + bool *HasDoWhile = nullptr, bool *HasLabel = nullptr);

[PATCH] D126084: [Sema] Reject list-initialization of a scoped enum variable from an element of a different scoped enum type

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Building on D126796

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3551312 , @tschuett wrote: > Would a JSON dump help you for your tools? Do you think a JSON dump would be more appropriate? I was just going for something not unlike `--help` here. Repository: rG LLVM Github Monorepo

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c8a2679a20f: [clang][AIX] add option mdefault-visibility-export-mapping (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[clang] 8c8a267 - [clang][AIX] add option mdefault-visibility-export-mapping

Author: David Tenty Date: 2022-06-01T18:07:17-04:00 New Revision: 8c8a2679a20f621994fa904bcfc68775e7345edc URL: https://github.com/llvm/llvm-project/commit/8c8a2679a20f621994fa904bcfc68775e7345edc DIFF: https://github.com/llvm/llvm-project/commit/8c8a2679a20f621994fa904bcfc68775e7345edc.diff L

[PATCH] D120007: [OMPIRBuilder] Add the support for compare capture

tianshilei1992 updated this revision to Diff 433558. tianshilei1992 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120007/new/ https://reviews.llvm.org/D1

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a comment. > But that's not a problem of this patch, and we will address that later if > needed. Thanks for looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699 _

[PATCH] D126602: [Clang][OpenMP] Replace IgnoreImpCasts with IgnoreImplicitAsWritten in atomic compare

tianshilei1992 added a comment. In D126602#3548997 , @ABataev wrote: > Can you add the test? I don't have a good test off the top of my head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126602/new/ http

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Object/OffloadBinary.cpp:28 + if (identify_magic(Buf.getBuffer()) != file_magic::offload_binary) return errorCodeToError(llvm::object::object_error::

[PATCH] D126816: Only issue warning for subtraction involving null pointers on live code paths

anarazel added a comment. So far the tests in pointer-subtraction.c are mirrored in pointer-subtraction.cpp - worth continuing to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126816/new/ https://reviews.llvm.org/D126816 _

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

jhuber6 updated this revision to Diff 433534. jhuber6 added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126812/new/ https://reviews.llvm.org/D126812 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm-c

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 added a comment. @rsmith polite ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

jhuber6 added a comment. Thanks for the comments, I'll address them real quick. Comment at: llvm/include/llvm/Object/OffloadBinary.h:121 const Entry *TheEntry) - : Buffer(Buffer), TheHeader(TheHeader), TheEntry(TheEntry) { - + : Binary(Binary::ID_Offl

[PATCH] D126804: [scan-build-py] Change scripts to explicitly require python3

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126804/new/ https://reviews.llvm.org/D126804 ___

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane added a subscriber: rsmith. erichkeane added a comment. Note this was mentioned as a 'must also do' in my discussion on deferred constraints with @rsmith, however as this already fails, I don't see this as a prerequisite. However, I think this is easy enough to just do. THAT SAID: T

[clang] 5d005d8 - Refactor PS4OSTargetInfo into a base class and PS4 subclass; prep for PS5

Author: Paul Robinson Date: 2022-06-01T13:30:29-07:00 New Revision: 5d005d8256ecd7d57c72e24e7169c4e3d40a773a URL: https://github.com/llvm/llvm-project/commit/5d005d8256ecd7d57c72e24e7169c4e3d40a773a DIFF: https://github.com/llvm/llvm-project/commit/5d005d8256ecd7d57c72e24e7169c4e3d40a773a.diff

[clang] 8869ba3 - [PS5] Add PS5OSTargetInfo class, update affected tests

Author: Paul Robinson Date: 2022-06-01T13:30:29-07:00 New Revision: 8869ba366268c644200784b15c4e6b8efe891397 URL: https://github.com/llvm/llvm-project/commit/8869ba366268c644200784b15c4e6b8efe891397 DIFF: https://github.com/llvm/llvm-project/commit/8869ba366268c644200784b15c4e6b8efe891397.diff

[PATCH] D126816: Only issue warning for subtraction involving null pointers on live code paths

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126816/new/ https://reviews.llvm.org/D126816 ___

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

tra added a comment. LGTM in principle, with new nits. Comment at: llvm/include/llvm/Object/OffloadBinary.h:121 const Entry *TheEntry) - : Buffer(Buffer), TheHeader(TheHeader), TheEntry(TheEntry) { - + : Binary(Binary::ID_Offload, Source), Buffer(Sour

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane created this revision. erichkeane added reviewers: rjmccall, clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. Thanks to concepts, C++ can now have friends that differ by their containing function. Because of this, we need to differentiate on

[PATCH] D126816: Only issue warning for subtraction involving null pointers on live code paths

jamieschmeiser created this revision. jamieschmeiser added reviewers: anarazel, efriedma. Herald added a project: All. jamieschmeiser requested review of this revision. Herald added a project: clang. Change the warning produced for subtraction from (or with) a null pointer to only be produced when

[PATCH] D126759: [clang][dataflow] Model calls returning optionals

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:161 +auto possiblyAliasedOptionalType() { + return hasUnqualifiedDesugaredType( Does alias refers to a type

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/has_unique_object_reps_bitint.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -verify -std=c++17 -Wno-bitfield-width %s +// expected-no-diagnostics browneee wrote: > This

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

tschuett added a comment. Would a JSON dump help you for your tools? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

browneee added inline comments. Comment at: clang/test/SemaCXX/has_unique_object_reps_bitint.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -verify -std=c++17 -Wno-bitfield-width %s +// expected-no-diagnostics This unit test appears to t

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

jhuber6 updated this revision to Diff 433504. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126812/new/ https://reviews.llvm.org/D126812 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm-c/Object.h

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

aaron.ballman added a comment. In D126796#3551280 , @MaskRay wrote: > In D126796#3551261 , @cjdb wrote: > >> In D126796#3550848 , @MaskRay >> wrote: >> >>> FYI `diagtool

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong updated this revision to Diff 433502. steplong added a comment. - Change UnsupportedArches to SupportedArches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 Files: clang/include/clang/Basic/La

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

aaron.ballman added a comment. In D126796#3551261 , @cjdb wrote: > In D126796#3550848 , @MaskRay wrote: > >> FYI `diagtool tree` dumps the diagnostics. You can even provide -W options >> and observe the differenc

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

MaskRay added a comment. In D126796#3551261 , @cjdb wrote: > In D126796#3550848 , @MaskRay wrote: > >> FYI `diagtool tree` dumps the diagnostics. You can even provide -W options >> and observe the differences. >

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, JonChesterfield, MaskRay. Herald added a reviewer: deadalnix. Herald added subscribers: ormris, StephenFan, hiraditya. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commi

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3550848 , @MaskRay wrote: > FYI `diagtool tree` dumps the diagnostics. You can even provide -W options > and observe the differences. Is `diagtool tree` something that users widely know about? Repository: rG LLVM Git

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie marked an inline comment as done. dblaikie added a comment. In D102122#3550590 , @aaron.ballman wrote: > In D102122#3544655 , @dblaikie > wrote: > >> How's this look now, then? > > I think it's heading

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie updated this revision to Diff 433499. dblaikie added a comment. Fix/update the unsupported syntax warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102122/new/ https://reviews.llvm.org/D102122 Files: clang/include/clang/Basic/Attr.t

[PATCH] D126806: Add an overload to ASTUnit::LoadFromASTFile that accepts a virtual file system.

ymandel added a comment. To be clear, I'm fine with the change either way, just want to understand a bit better first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126806/new/ https://reviews.llvm.org/D126806

[PATCH] D126806: Add an overload to ASTUnit::LoadFromASTFile that accepts a virtual file system.

ymandel added a comment. Why add an overload rather than adding it before `UseDebugInfo` and defaulting it to `getRealFileSystem()`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126806/new/ https://reviews.llvm.org/D126806 __

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie updated this revision to Diff 433492. dblaikie marked 4 inline comments as done. dblaikie added a comment. Check through multiple typedef layers to find the warn_unused_result attribute Rephrase unsupported syntax warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126719: [clang-cl] Add support for /kernel

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7620 + else if (Arch == llvm::Triple::x86_64) + UnsupportedArches = {"AVX", "AVX2", "AVX512"}; + Making this list opt-in instead of opt-out (ie "SupportedArchs") seems a bit

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

iains added a comment. I guess Chuanqi's TZ is in sleep mode at the moment, so the revert makes sense. Please let's not use -fmodules-ts to mean anything - we want to phase it out and make it a NOP (we are implementing the standardised modules; I do not see anyone putting effort into finishing

[PATCH] D126806: Add an overload to ASTUnit::LoadFromASTFile that accepts a virtual file system.

asoffer created this revision. Herald added a project: All. asoffer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126806 Files: clang/include/clang/Frontend/ASTUnit.h c

[clang-tools-extra] d951ca5 - Revert "[Driver] Enable to use C++20 standalne by -fcxx-modules"

Author: Adrian Prantl Date: 2022-06-01T12:11:57-07:00 New Revision: d951ca5439bb8726cfe1ceb2d12e220f29fe5125 URL: https://github.com/llvm/llvm-project/commit/d951ca5439bb8726cfe1ceb2d12e220f29fe5125 DIFF: https://github.com/llvm/llvm-project/commit/d951ca5439bb8726cfe1ceb2d12e220f29fe5125.diff

  1   2   3   >