[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 updated this revision to Diff 433299. benshi001 retitled this revision from "[Driver] Support linking with lld for target AVR" to "[Driver] Improve linking options for target AVR". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG160798ab9be8: [analyzer] Handle SymbolCast in SValBuilder (authored by martong). Repository: rG LLVM Git

[clang] 160798a - [analyzer] Handle SymbolCast in SValBuilder

Author: Gabor Marton Date: 2022-06-01T08:42:04+02:00 New Revision: 160798ab9be87a9be323966c5f5816a5b7ca818f URL: https://github.com/llvm/llvm-project/commit/160798ab9be87a9be323966c5f5816a5b7ca818f DIFF: https://github.com/llvm/llvm-project/commit/160798ab9be87a9be323966c5f5816a5b7ca818f.diff

[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

daiyousei-qz created this revision. daiyousei-qz added reviewers: nridge, klimek. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. daiyousei-qz requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. The ori

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

gamesh411 added a comment. Thanks for the quick review! Fixed the double backtick in the release notes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126186/new/ https://reviews.llvm.org/D126186

[clang-tools-extra] e290fce - [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

Author: Endre Fülöp Date: 2022-06-01T08:23:23+02:00 New Revision: e290fcef111c24ed833c9768809eb900a21c94e0 URL: https://github.com/llvm/llvm-project/commit/e290fcef111c24ed833c9768809eb900a21c94e0 DIFF: https://github.com/llvm/llvm-project/commit/e290fcef111c24ed833c9768809eb900a21c94e0.diff L

[clang-tools-extra] 1c459a2 - Revert "[clang-tidy] Extend cert-oop57-cpp to check non-zero memset values"

Author: Endre Fülöp Date: 2022-06-01T08:21:16+02:00 New Revision: 1c459a20ea5626264d867aaf65882c9cc6d0bf8a URL: https://github.com/llvm/llvm-project/commit/1c459a20ea5626264d867aaf65882c9cc6d0bf8a DIFF: https://github.com/llvm/llvm-project/commit/1c459a20ea5626264d867aaf65882c9cc6d0bf8a.diff L

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

This revision was automatically updated to reflect the committed changes. Closed by commit rGd33f199910fa: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12618

[clang-tools-extra] d33f199 - [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

Author: Endre Fülöp Date: 2022-06-01T08:15:03+02:00 New Revision: d33f199910fa02cf7072f3227913e670c98d03a9 URL: https://github.com/llvm/llvm-project/commit/d33f199910fa02cf7072f3227913e670c98d03a9 DIFF: https://github.com/llvm/llvm-project/commit/d33f199910fa02cf7072f3227913e670c98d03a9.diff L

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

rsmith added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1150 + continue; +if (!D->isUsed(false) && !D->isReferenced()) + WorkList.push_back(D); rsmith wrote: > ChuanqiXu wrote: > > Should we check for `D->isUsed()` simply? It l

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

rsmith added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1150 + continue; +if (!D->isUsed(false) && !D->isReferenced()) + WorkList.push_back(D); ChuanqiXu wrote: > Should we check for `D->isUsed()` simply? It looks more straight

[PATCH] D124753: [HLSL] Set main as default entry.

MaskRay added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:6 +// Make sure not mangle entry. +// CHECK:define void @main() [[MAIN_ATTR:#[0-9]]] +// CHECK:define void @_Z3foov() [[FOO_ATTR:#[0-9]]] space between `:` and the value. =

[PATCH] D126192: [Driver] Support linking with lld for target AVR

MaskRay added a comment. I am still uncomfortable with such a change. Trying to be smart sometimes may get in the way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cf

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

vitalybuka added a comment. In D124699#3549191 , @kstoimenov wrote: > This change is breaking memory sanitizer in some cases. We observed that > when the argument is not actually removed the pass is dropping the noundef > attribute. See the diff snipp

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

kstoimenov added a comment. This change is breaking memory sanitizer in some cases. We observed that when the argument is not actually removed the pass is dropping the noundef attribute. See the diff snippet below. Is that an intended behavior? We would like to revert this as it is breaking MS

[clang] 1013967 - [PowerPC] Remove const from paired vector store builtins

Author: Nemanja Ivanovic Date: 2022-05-31T21:51:15-05:00 New Revision: 1013967436694f362097a7c12f675c0ad7de90b7 URL: https://github.com/llvm/llvm-project/commit/1013967436694f362097a7c12f675c0ad7de90b7 DIFF: https://github.com/llvm/llvm-project/commit/1013967436694f362097a7c12f675c0ad7de90b7.di

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

ChuanqiXu added inline comments. Comment at: clang/test/CXX/basic/basic.scope/basic.scope.namespace/p2.cpp:32 void test_early() { - in_header = 1; // expected-error {{missing '#include "foo.h"'; 'in_header' must be declared before it is used}} - // expected-note@*{{not visibl

[clang] 92a606f - [HIP] Pass -Xoffload-linker option to device linker

Author: Yaxun (Sam) Liu Date: 2022-05-31T22:17:40-04:00 New Revision: 92a606f6de77f69f9eb86498deaeeeb8f821f4e1 URL: https://github.com/llvm/llvm-project/commit/92a606f6de77f69f9eb86498deaeeeb8f821f4e1 DIFF: https://github.com/llvm/llvm-project/commit/92a606f6de77f69f9eb86498deaeeeb8f821f4e1.dif

[PATCH] D126704: [HIP] Pass -Xoffload-linker option to device linker

This revision was automatically updated to reflect the committed changes. Closed by commit rG92a606f6de77: [HIP] Pass -Xoffload-linker option to device linker (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay added inline comments. Comment at: clang/test/Driver/lto-no-opaque-pointers.c:2 +// UNSUPPORTED: enable-opaque-pointers +// RUN: %clang -target x86_64-unknown-linux -### %s -flto 2> %t +// RUN: FileCheck %s < %t -target is a legacy option. Use `--target=`

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay added a comment. > Adds -opaque-pointers/-no-opaque-pointers options to the gold plugin; > disabled by default. `-plugin-opt=[no-]opaque-pointers` > --opaque-pointers/--no-opaque-pointers options with > -plugin-opt=-opaque-pointers/-plugin-opt=-no-opaque-pointers aliases to lld; > dis

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1130 DiagnoseUseOfUnimplementedSelectors(); +// For C++20 modules, we are permitted to elide decls in the Global I prefer to wrap this logic to a function to make it easier to read.

[PATCH] D126681: [HIP] Fix static lib name on windows

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG377806a65ea9: [HIP] Fix static lib name on windows (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D126681

[clang] 377806a - [HIP] Fix static lib name on windows

Author: Yaxun (Sam) Liu Date: 2022-05-31T22:13:50-04:00 New Revision: 377806a65ea97837c99d9791db9d462b63b9135a URL: https://github.com/llvm/llvm-project/commit/377806a65ea97837c99d9791db9d462b63b9135a DIFF: https://github.com/llvm/llvm-project/commit/377806a65ea97837c99d9791db9d462b63b9135a.dif

[PATCH] D126691: ASTContext: Provide a query for module initializer contents.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM with a nits. Comment at: clang/include/clang/AST/ASTContext.h:1083 + /// Does the module initializer array contain this decl. + bool moduleInitializerContains(Mo

[PATCH] D120484: More explicit message when failing to find a mandatory cfi ressource file

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:216 +def err_drv_missing_sanitizer_ignorelist : Error< + "missing

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189

[PATCH] D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2ea5b496bcd: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]` (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137

[clang] a2ea5b4 - [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`

Author: Phoebe Wang Date: 2022-06-01T09:45:04+08:00 New Revision: a2ea5b496bcd3762f96c38a09db1d38729fa6325 URL: https://github.com/llvm/llvm-project/commit/a2ea5b496bcd3762f96c38a09db1d38729fa6325 DIFF: https://github.com/llvm/llvm-project/commit/a2ea5b496bcd3762f96c38a09db1d38729fa6325.diff L

[PATCH] D126749: [RISCV][Clang] Support policy functions for Vector Mask Instructions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, kito-cheng, fakepaper56, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D126748: [RISCV][Clang] Support policy functions for Vector Reduction Instructions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, kito-cheng, fakepaper56, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D126746: [RISCV][Clang] Support policy functions for Vector Comparison Instructions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, kito-cheng, fakepaper56, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, kito-cheng, fakepaper56, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D126743: [RISCV][Clang] Add tests for all supported policy functions. (NFC)

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, kito-cheng, fakepaper56, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D126602: [Clang][OpenMP] Replace IgnoreImpCasts with IgnoreImplicitAsWritten in atomic compare

ABataev added a comment. Can you add the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126602/new/ https://reviews.llvm.org/D126602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:242 HasAVX512FP16 = true; HasFloat16 = true; + HasLegalHalfType = true; This can be removed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https:/

[PATCH] D126741: [RISCV][Clang] Refactor RISCVVEmitter. (NFC)

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, kito-cheng, fakepaper56, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D126740: [RISCV][Clang] Refactor and rename rvv intrinsic related stuff. (NFC)

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, kito-cheng, fakepaper56, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D125338: [HLSL] add -D option for dxc mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3e4727907e5: [HLSL] add -D option for dxc mode. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.o

[clang] d3e4727 - [HLSL] add -D option for dxc mode.

Author: Xiang Li Date: 2022-05-31T17:50:36-07:00 New Revision: d3e4727907e533a088fdb42963b6efcd1f26ec88 URL: https://github.com/llvm/llvm-project/commit/d3e4727907e533a088fdb42963b6efcd1f26ec88 DIFF: https://github.com/llvm/llvm-project/commit/d3e4727907e533a088fdb42963b6efcd1f26ec88.diff LOG:

[clang] 79e3d57 - [RISCV][NFC] Rename variables in rvv intrinsics related files.

Author: Zakk Chen Date: 2022-05-31T17:43:01-07:00 New Revision: 79e3d57f52284c7d911724ef6298f765c747c20d URL: https://github.com/llvm/llvm-project/commit/79e3d57f52284c7d911724ef6298f765c747c20d DIFF: https://github.com/llvm/llvm-project/commit/79e3d57f52284c7d911724ef6298f765c747c20d.diff LOG

[PATCH] D126634: [RISCV][NFC] Rename variables in rvv intrinsics related files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG79e3d57f5228: [RISCV][NFC] Rename variables in rvv intrinsics related files. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126634/new/

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. The way I see it, there are two possibilities here: 1. In Sema, we have two rounding modes that correspond to FE_DYNAMIC: llvm::RoundingMode::Dynamic, and llvm::RoundingMode::NearestTiesToEven, plus some boolean to indicate whether the user actually explicitly specifie

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D126602: [Clang][OpenMP] Replace IgnoreImpCasts with IgnoreImplicitAsWritten in atomic compare

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126602/new/ https://reviews.llvm.org/D126602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D126735: [clang-tidy] Silence modernize-redundant-void-arg in the case of vexing parses

george.burgess.iv created this revision. george.burgess.iv added reviewers: LegalizeAdulthood, aaron.ballman. george.burgess.iv added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. george.burgess.iv requested review of this revision. H

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

NoQ added a comment. Oh nice, I think I've heard about such problems, thanks a lot. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:106 while (Ex) { -const BinaryOperator *BO = - dyn_cast(Ex->IgnoreParenCasts()); +Ex = Ex->IgnoreParenCasts();

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae updated this revision to Diff 433227. python3kgae added a comment. Recover after fixed Mac/arm test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.org/D125338 Files: clang/include/clang/Driver/Op

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

sammccall added a comment. Neat, looks like the pre-merge windows buildbot at least is happy! I'll land this tomorrow. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3221 + TestTU TU = TestTU::withCode(T.code()); + TU.OmitPredefinedMacros = false; + auto AST =

[PATCH] D126608: [clangd] Remove a test with a duplicate of FileCacheTests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c1494039491: [clangd] Remove a test with a duplicate of FileCacheTests (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126608/new/ h

[clang-tools-extra] 5c14940 - [clangd] Remove a test with a duplicate of FileCacheTests

Author: Yuki Okushi Date: 2022-06-01T08:15:54+09:00 New Revision: 5c14940394919cbc66cab06103342610af69bc58 URL: https://github.com/llvm/llvm-project/commit/5c14940394919cbc66cab06103342610af69bc58 DIFF: https://github.com/llvm/llvm-project/commit/5c14940394919cbc66cab06103342610af69bc58.diff L

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

jyknight added a comment. So, I've been spending some significant time looking into this. I found that I couldn't really review this change for correctness, because I find it basically impossible to figure out whether the intrinsic calls have actually been added to all the right places in Clang

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. ClangBasic dependency el

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll updated this revision to Diff 433217. gkll added a comment. Fixed formatting of `Argv` array. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126498/new/ https://reviews.llvm.org/D126498 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll updated this revision to Diff 433211. gkll added a comment. Use `uintptr_t` instead of `unsigned long` for the casts, to ensure the pointer always fits into the integer type. For example on Windows x64 that was previously not the case, because there `unsigned long` is only 32-bits wide. Thu

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360 + auto *GA = llvm::GlobalAlias::create("__main_void", F); + GA->setVisibility(F->getVisibility()); +} sunfish wrote: > sbc100 wrote: > > sunfish wrote: > > > Can this

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sunfish added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360 + auto *GA = llvm::GlobalAlias::create("__main_void", F); + GA->setVisibility(F->getVisibility()); +} sbc100 wrote: > sunfish wrote: > > Can this use `GA->setVisibil

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360 + auto *GA = llvm::GlobalAlias::create("__main_void", F); + GA->setVisibility(F->getVisibility()); +} sunfish wrote: > Can this use `GA->setVisibility(GlobalValue::Hi

[PATCH] D126725: [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, alextsao1999. Herald added projects: LLVM, clang-tools-extra. This

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong added a comment. In D126719#3548469 , @thakis wrote: > What does cl do if both `/kernel` and (eg) `/EHsc` is passed (try both > orders)? Same question for `/kernel /GR`. From my experiments, cl doesn't complain and happily compiles the code if

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sunfish added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360 + auto *GA = llvm::GlobalAlias::create("__main_void", F); + GA->setVisibility(F->getVisibility()); +} Can this use `GA->setVisibility(GlobalValue::HiddenVisibility)`

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

sammccall updated this revision to Diff 433201. sammccall added a comment. remove dead variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126723/new/ https://reviews.llvm.org/D126723 Files: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999, ilya-biryukov. Herald added a project: clang-tools-extra

[PATCH] D126719: [clang-cl] Add support for /kernel

thakis added a comment. https://docs.microsoft.com/en-us/cpp/build/reference/kernel-create-kernel-mode-binary?view=msvc-170 says we should err when `/kernel` is used with various flags (e.g. most `/arch:`) flags. Want to add that too? It also says `/kernel` is passed on to the linker. What doe

[PATCH] D126681: [HIP] Fix static lib name on windows

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1788 +for (auto Prefix : {"/libdevice/", "/"}) { + if (IsMSVC) { +AOBFileNames.push_back(Twine(LPath + Prefix + Lib + ".lib").str()); ---

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide chars

johannes requested changes to this revision. johannes added a comment. This revision now requires changes to proceed. I wonder if clang-diff is useful in its current state, I remember there are many edge cases left over. Anyway, I've left some minor comments. I'm not sure how to download a patch

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

steplong updated this revision to Diff 433194. steplong added a comment. - Handle static C/C++ functions and C functions in general Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126559/new/ https://reviews.llvm.org/D126559 Files: clang/lib/Sema/

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 433191. sbc100 added a comment. - revert parts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp:264 - } -} } sunfish wrote: > Why is this code going away? This isn't Emscripten-specific code. Ah.. I was hoping we could delete these codepaths,

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong updated this revision to Diff 433185. steplong added a comment. - Test that exceptions aren't enabled with /kernel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 Files: clang/include/clang/Bas

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae reopened this revision. python3kgae added a comment. This revision is now accepted and ready to land. Reopen to recover the change after fix Mac/arm test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.ll

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13e1a653278b: [HLSL] Enable vector types for hlsl. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 13e1a65 - [HLSL] Enable vector types for hlsl.

Author: Xiang Li Date: 2022-05-31T13:54:17-07:00 New Revision: 13e1a653278ba4a9805f0247c5bc92dad720aab3 URL: https://github.com/llvm/llvm-project/commit/13e1a653278ba4a9805f0247c5bc92dad720aab3 DIFF: https://github.com/llvm/llvm-project/commit/13e1a653278ba4a9805f0247c5bc92dad720aab3.diff LOG:

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae updated this revision to Diff 433179. python3kgae added a comment. Recover after fix Mac/arm test issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052 Files: clang/include/clang/Driver/Opt

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae reopened this revision. python3kgae added a comment. This revision is now accepted and ready to land. Reopen for the Mac/arm test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. MSVC defines _KERNEL_MODE when /kernel is passed. Also, /kernel disables RTTI and C++ exception handling. https:/

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll updated this revision to Diff 433174. gkll added a comment. Changed return type of non-returning function in test code to void. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126498/new/ https://reviews.llvm.org/D126498 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extr

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp:264 - } -} } Why is this code going away? This isn't Emscripten-specific code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 433173. sbc100 added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CodeGenModule.cpp llvm/l

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

sammccall added a comment. Landed as ce5ebf0b9113df8ccaec1bcfd6804fb16cdef69d but I had to revert due to test failures on windows: - https://buildkite.com/llvm-project/premerge-checks/builds/94783 - http://45.33.8.238/win/591

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Adding the debug-info group. I don't really know enough about deduction guides to comment on the implications, but if it fixes the crash it seems to be a strict improvement. Maybe wait anoth

[clang-tools-extra] 218393f - Revert "[clangd] Fix hover crashing on integral or enumeral casts"

Author: Sam McCall Date: 2022-05-31T22:30:20+02:00 New Revision: 218393f44ec903341125b70ce3fbb6dc731a9399 URL: https://github.com/llvm/llvm-project/commit/218393f44ec903341125b70ce3fbb6dc731a9399 DIFF: https://github.com/llvm/llvm-project/commit/218393f44ec903341125b70ce3fbb6dc731a9399.diff LO

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfde240c9c328: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] fde240c - [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

Author: Xiang Li Date: 2022-05-31T13:23:30-07:00 New Revision: fde240c9c328b8a824a064c8ccd91252516e6d41 URL: https://github.com/llvm/llvm-project/commit/fde240c9c328b8a824a064c8ccd91252516e6d41 DIFF: https://github.com/llvm/llvm-project/commit/fde240c9c328b8a824a064c8ccd91252516e6d41.diff LOG:

[clang-tools-extra] ce5ebf0 - [clangd] Fix hover crashing on integral or enumeral casts

Author: Georg Kotheimer Date: 2022-05-31T22:05:23+02:00 New Revision: ce5ebf0b9113df8ccaec1bcfd6804fb16cdef69d URL: https://github.com/llvm/llvm-project/commit/ce5ebf0b9113df8ccaec1bcfd6804fb16cdef69d DIFF: https://github.com/llvm/llvm-project/commit/ce5ebf0b9113df8ccaec1bcfd6804fb16cdef69d.dif

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme marked 8 inline comments as done. mboehme added a comment. I notice that https://reviews.llvm.org/D111548, which this change is based on, has some failing flang tests in the CI. I'm pretty sure these are unrelated and stem from the base revision that I happen to be based off. Before reba

[PATCH] D126717: [pseudo] Add PSEUDO_GEN cmake cache variable to avoid nested CMake invocation

sammccall added a comment. In D126717#3548184 , @mstorsjo wrote: > Looks reasonable to me. The variable name feels a bit un-namespaced though, > but that's what the tool is called currently. Should we rename the tool and > the variable to give it a bit

[PATCH] D126717: [pseudo] Add PSEUDO_GEN cmake cache variable to avoid nested CMake invocation

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. Looks reasonable to me. The variable name feels a bit un-namespaced though, but that's what the tool is called currently. Should we rename the tool and the variable to give it a bit more o

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll added a comment. In D126498#3548168 , @sammccall wrote: > In D126498#3548132 , @gkll wrote: > >> In D126498#3548013 , @sammccall >> wrote: >> >>> Oh wow, my mental m

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

sammccall added a comment. In D126498#3548132 , @gkll wrote: > In D126498#3548013 , @sammccall > wrote: > >> Oh wow, my mental model of these was all wrong. >> >> Thank you! Do you want me to land this for you? >

[PATCH] D126664: Expand definition deprecation warning to include constexpr statements.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a release note about the new diagnostic behavior. Do you need someone to commit on your behalf? If so, what name and email address would you like used for pa

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll added a comment. In D126498#3548013 , @sammccall wrote: > Oh wow, my mental model of these was all wrong. > > Thank you! Do you want me to land this for you? Yeah, that would be great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

aaron.ballman added a comment. In D126559#3547921 , @steplong wrote: > It looks like MSVC also accepts > > // foo.c > static void foo(); > #pragma alloc_text("hello", foo) > void foo() {} > > and > > // foo.cpp > extern "C" { > static void f

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

sammccall added a comment. In D126397#3547438 , @sammccall wrote: > In D126397#3547060 , @thakis wrote: > >> Should pseudo-gen honor LLVM_USE_HOST_TOOLS too? It looks like it's >> basically the same situation. >

[PATCH] D126717: [pseudo] Add PSEUDO_GEN cmake cache variable to avoid nested CMake invocation

sammccall created this revision. sammccall added a reviewer: mstorsjo. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Similar to LLVM_TABLEG

[PATCH] D126642: [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a nit. Comment at: clang/include/clang/AST/Type.h:3809-3811 unsigned NumExceptionType; + +FunctionTypeExtraBitfields() : NumExceptionType(0) {} Repository: rG LLV

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3547494 , @sscalpone wrote: > I'm fine with removing or renaming the existing flang shell script. In D125788#3547656 , @rouson wrote: > On Mon, May 30, 2022 at 2:39 AM An

[clang-tools-extra] 9d991da - [pseudo] Respect LLVM_USE_HOST_TOOLS

Author: Sam McCall Date: 2022-05-31T20:47:57+02:00 New Revision: 9d991da60df492a191b34aa3e75484ddd27e8930 URL: https://github.com/llvm/llvm-project/commit/9d991da60df492a191b34aa3e75484ddd27e8930 DIFF: https://github.com/llvm/llvm-project/commit/9d991da60df492a191b34aa3e75484ddd27e8930.diff LO

  1   2   >