[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

jansvoboda11 added a comment. I finished an initial pass through the code and it looks good for the most parts. I left a couple of suggestions in-line. Did you test this change on some larger body of code? That would make me more confident, since this is a non-trivial change. Might be good to

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:1105 + static const llvm::Regex VerilogToken( + "^(\'|``?|((\r?\n|\r)|[^[:space:]])*)"); + Consider a raw string, for a better reading. Co

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

myhsu added a comment. Just curious: Have you considered using llvm::opt or even llvm::cl infrastructure? What are the pros & cons? Comment at: clang/utils/TableGen/ClangSAConfigsEmitter.cpp:24 + +using SortedRecords = llvm::StringMap; + Co

[PATCH] D124751: Support -E option for HLSL.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield, sscalpone, pow2clk, rnk, bogner, MaskRay, dexonsmith. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a proje

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:839 +void FormatTokenLexer::resizeToken(size_t NewLen) { + resetLexer(SourceMgr.getFileOffset(Lex->getSourceLocation( Can you add some documentation?

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

nridge added a comment. In D124688#3483895 , @sammccall wrote: > Trying this on a few files, this seems like it increases preamble sizes up to > 1% or so Are preamble sizes a good proxy for preamble build times as well? I suspect that may be the metric

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed. Apologies for the slow response here. This generally looks good to me, but I have a couple of suggestions regarding the formatting of the hints and handling type aliases.

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 426335. srishti-pm added a comment. Improving the commit summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files: clang/docs/tools/clang-formatted-files.tx

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

saiislam added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm created this revision. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny.

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:598-599 + auto UnlessNotLHS = unless(hasLHS(NotOp)); + // match !(!a || b) + Finder->addMatcher(unaryOperator(Not, hasUnaryOperand(binaryOperator( +

[PATCH] D124157: [clang][preprocessor] Add more macros to target AVR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42fa5bae7afc: [clang][preprocessor] Add more macros to target AVR (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 42fa5ba - [clang][preprocessor] Add more macros to target AVR

Author: Ben Shi Date: 2022-05-02T04:37:57Z New Revision: 42fa5bae7afcd58f769adfd46d15996eeb0381ad URL: https://github.com/llvm/llvm-project/commit/42fa5bae7afcd58f769adfd46d15996eeb0381ad DIFF: https://github.com/llvm/llvm-project/commit/42fa5bae7afcd58f769adfd46d15996eeb0381ad.diff LOG: [clan

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa132e527f251: [Driver][Ananas] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] a132e52 - [Driver][Ananas] -r: imply -nostdlib like GCC

Author: Brad Smith Date: 2022-05-02T00:28:14-04:00 New Revision: a132e527f25164268e08ebc63b043bbce8a043ed URL: https://github.com/llvm/llvm-project/commit/a132e527f25164268e08ebc63b043bbce8a043ed DIFF: https://github.com/llvm/llvm-project/commit/a132e527f25164268e08ebc63b043bbce8a043ed.diff LO

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

brad updated this revision to Diff 426327. brad added a comment. Updated with feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124729/new/ https://reviews.llvm.org/D124729 Files: clang/lib/Driver/ToolChains/Ananas.cpp clang/test/Driver/

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw added a comment. This revision depends on D124748 , but somehow it doesn't show up when I open the parent revision dialog. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://reviews.llvm.org/

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

MaskRay added inline comments. Comment at: clang/test/Driver/ananas.c:20 +// -r suppresses default -l and crt*.o like -nostdlib. +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o \ +// RUN: --target=x86_64-unknown-ananas -r 2>&1 \ brad wrote: > MaskRay w

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current way of counting whitespace would co

[PATCH] D124157: [clang][preprocessor] Add more macros to target AVR

benshi001 added a reviewer: MaskRay. benshi001 added a comment. Herald added a subscriber: StephenFan. avr-gcc does define this __AVR_TINY_ macro for the tiny device family, we can check that by `avr-gcc -mmcu=avrtiny -E -dM -xc /dev/null -dM | grep tiny -i`. CHANGES SINCE LAST ACTION https:

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

This revision was automatically updated to reflect the committed changes. benshi001 marked an inline comment as done. Closed by commit rGfb7a435492a5: [compiler-rt][builtins] Add several helper functions for AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D123200?

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

brad added inline comments. Comment at: clang/test/Driver/ananas.c:20 +// -r suppresses default -l and crt*.o like -nostdlib. +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o \ +// RUN: --target=x86_64-unknown-ananas -r 2>&1 \ MaskRay wrote: > Delete -n

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:671 +set(avr_SOURCES + avr/mulqi3.S MaskRay wrote: > Keep the `*_SOURCES` in alphabetical order. Move avr to the beginning. Ignore

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:598-599 + auto UnlessNotLHS = unless(hasLHS(NotOp)); + // match !(!a || b) + Finder->addMatcher(unary

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood added a comment. I also noticed that some of the simplifications being performed resulted in `!(x || !y)` coming out of other parts of the simplifier, so it should be the case that running this check on your code should result in no further changes to your code if you run the

[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

owenpan added a comment. Now that we look ahead instead of looking back, it doesn't matter what comes before `*[]` or `[]`. Comment at: clang/unittests/Format/FormatTest.cpp:3342 + "public:\n" + " std::unique_ptr b() { return nullptr; }\n" +

[PATCH] D124741: [Clang] Add integer add reduction builtin

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks > For other reductions, we've tried to share builtins for float/integer > vectors, but the fadd reduction builtins also take a starting value argument. > Technically I could suppor

[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

owenpan updated this revision to Diff 426307. owenpan added a comment. Instead of looking back, look ahead in `tryToParseLambdaIntroducer()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124589/new/ https://reviews.llvm.org/D124589 Files: clang/lib/Format/UnwrappedLineParser.cpp c

[PATCH] D124741: [Clang] Add integer add reduction builtin

RKSimon created this revision. RKSimon added reviewers: fhahn, scanon, aaron.ballman, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. Similar to the existing bitwise reduction builtins, this

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. > @fhahn Remind me - why did you want me to split these? If we're initially > just going for integer support, can't both be done at the same time in this > patch? I think my original thinking was that `__builtin_reduce_mul` isn't defined at the moment https://clang.llvm.

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD updated this revision to Diff 426303. BertalanD added a comment. Removed accidental execute permission from the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124736/new/ https://reviews.llvm.org/D124736 Files: clang/lib/CodeGen/C

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

Meinersbur added a comment. In D124606#3479793 , @ilya-biryukov wrote: > LGTM This and the commit (@MForster ) was too hasty. There should have been time for people discussing D124563 and D97625

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD updated this revision to Diff 426301. BertalanD added a comment. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124736/new/ https://reviews.llvm.org/D124736 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenC

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:586 + + auto Not = hasOperatorName("!"); + auto Or = hasOperatorName("||"); njames93 wrote: > njames93 wrote: > > This whole implementati

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood added a comment. Testing on VTK revealed this change: - this->SliceMapper->SetBackground((this->Background && -!(this->SliceFacesCamera && this->InternalResampleToScreenPixels && - !this->SeparateWindowLevelOperation))); + this->SliceMapper->SetBackground( +

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

MaskRay added inline comments. Comment at: clang/test/Driver/ananas.c:20 +// -r suppresses default -l and crt*.o like -nostdlib. +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o \ +// RUN: --target=x86_64-unknown-ananas -r 2>&1 \ Delete -no-canonical-pr

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

zhmu added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124729/new/ https://reviews.llvm.org/D124729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

This revision was automatically updated to reflect the committed changes. Closed by commit rG955a05a2782e: [clang][dataflow] Optimize flow condition representation (authored by sgatev). Changed prior to commit: https://reviews.llvm.org/D124395?vs=425221&id=426298#toc Repository: rG LLVM Gith

[clang] 955a05a - [clang][dataflow] Optimize flow condition representation

Author: Stanislav Gatev Date: 2022-05-01T16:25:29Z New Revision: 955a05a2782ee19d6f4bce6bf5d1c4a8f591f0f3 URL: https://github.com/llvm/llvm-project/commit/955a05a2782ee19d6f4bce6bf5d1c4a8f591f0f3 DIFF: https://github.com/llvm/llvm-project/commit/955a05a2782ee19d6f4bce6bf5d1c4a8f591f0f3.diff LO

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:586 + + auto Not = hasOperatorName("!"); + auto Or = hasOperatorName("||"); njames93 wrote: > This whole implementation would be alot simpler(and

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:3989 Group; -def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option, NoXarchOption]>, +def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option,FlangOp

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3484189 , @rjmccall wrote: > IIRC, the reason it works it that way is that "warnings which default to an > error" are really "errors which you can explicitly downgrade to a warning". > Maybe those ought to be d

[PATCH] D124683: [analyzer] Fix return of llvm::StringRef to destroyed std::string

This revision was automatically updated to reflect the committed changes. Closed by commit rG57c55165ebe8: [analyzer] Fix return of llvm::StringRef to destroyed std::string (authored by andrewng). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 57c5516 - [analyzer] Fix return of llvm::StringRef to destroyed std::string

Author: Andrew Ng Date: 2022-05-01T12:24:32+01:00 New Revision: 57c55165ebe8283b71ea785d2b0217119f8c5c51 URL: https://github.com/llvm/llvm-project/commit/57c55165ebe8283b71ea785d2b0217119f8c5c51 DIFF: https://github.com/llvm/llvm-project/commit/57c55165ebe8283b71ea785d2b0217119f8c5c51.diff LOG

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng added inline comments. Comment at: clang/lib/Sema/SemaRVVLookup.cpp:91 +struct RVVIntrinsicDef { + std::string Name; + std::string GenericName; khchen wrote: > why do we need to declare Name as std::string here but RVVIntrinsicRecord use > `const ch

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 426285. kito-cheng marked 2 inline comments as done. kito-cheng added a comment. Changes: - Minor tweak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files:

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 426284. kito-cheng marked 4 inline comments as done. kito-cheng added a comment. Changes: - Add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Fil

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:586 + + auto Not = hasOperatorName("!"); + auto Or = hasOperatorName("||"); This whole implementation would be alot simpler(and likely faster) if

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 426281. kito-cheng marked 2 inline comments as done. kito-cheng added a comment. Changes: - Split out refactor part to D124730 . - Add more comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

BertalanD created this revision. Herald added a project: All. BertalanD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we do not know the alignment of the operand, we can't assume it has the preferred alignment. It might be e.g. a point

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG43c146c96d8e: [clang-format] Take out common code for parsing blocks NFC (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D121757?vs=420653&id=426277#toc Repository: rG LLVM Gi

[clang] 43c146c - [clang-format] Take out common code for parsing blocks NFC

Author: sstwcw Date: 2022-05-01T08:58:40Z New Revision: 43c146c96d8e4607266f2c2ef74c17d4170fc248 URL: https://github.com/llvm/llvm-project/commit/43c146c96d8e4607266f2c2ef74c17d4170fc248 DIFF: https://github.com/llvm/llvm-project/commit/43c146c96d8e4607266f2c2ef74c17d4170fc248.diff LOG: [clang

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng updated this revision to Diff 426276. kito-cheng added a comment. Changes: - Extract more utils functions to RISCVVIntrinsicUtils Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124730/new/ https://reviews.llvm.org/D124730 Files: clang

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj abandoned this revision. upsj added a comment. I think we should be able to do this without adding new matchers globally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124373/new/ https://reviews.llvm.org/D124373 _