fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land.
LGTM, thanks > For other reductions, we've tried to share builtins for float/integer > vectors, but the fadd reduction builtins also take a starting value argument. > Technically I could support float by using default values, but we're probably > better off with specific fadd reduction builtins for both arguments. I think them main issue for fadd reductions is that the `fadd` intrinsic can either do unordered or serialized, but not reduction-trees as specified for the builtins in Clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124741/new/ https://reviews.llvm.org/D124741 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
