[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-26 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood updated this revision to Diff 425425. LegalizeAdulthood added a comment. Inline Variable CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124500/new/ https://reviews.llvm.org/D124500 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

2022-04-26 Thread Petr Hosek via Phabricator via cfe-commits
phosek abandoned this revision. phosek added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. No longer needed, this is now the Clang default. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44605/new/ https://reviews.llvm.org/D44605 ___

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-26 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood updated this revision to Diff 425423. LegalizeAdulthood added a comment. - Add banner block comment for new files - Extract Functions to eliminate duplication CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124500/new/ https://reviews.llvm.org/D124500 Files: clang-too

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

2022-04-26 Thread Petr Hosek via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19190cc651ef: [Driver] Support for compressed debug info on Fuchsia (authored by phosek). Herald added a subscriber: MaskRay. Herald added a project:

[clang] 19190cc - [Driver] Support for compressed debug info on Fuchsia

2022-04-26 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2022-04-26T23:46:56-07:00 New Revision: 19190cc651ef153c308d23fb56f064223b144488 URL: https://github.com/llvm/llvm-project/commit/19190cc651ef153c308d23fb56f064223b144488 DIFF: https://github.com/llvm/llvm-project/commit/19190cc651ef153c308d23fb56f064223b144488.diff LO

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

2022-04-26 Thread ChenZheng via Phabricator via cfe-commits
shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringS

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

2022-04-26 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG56058b921bd9: [clangd] Output inlay hints with `clangd --check` (authored by upsj, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344

[clang-tools-extra] 56058b9 - [clangd] Output inlay hints with `clangd --check`

2022-04-26 Thread Nathan Ridge via cfe-commits
Author: Tobias Ribizel Date: 2022-04-27T02:36:09-04:00 New Revision: 56058b921bd9b9e14697fb6108903836f7f9c328 URL: https://github.com/llvm/llvm-project/commit/56058b921bd9b9e14697fb6108903836f7f9c328 DIFF: https://github.com/llvm/llvm-project/commit/56058b921bd9b9e14697fb6108903836f7f9c328.diff

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

2022-04-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Thanks for working on this! Could you add some test cases to [InlayHintTests.cpp] to illustrate the new hint please? As in the other patch, uploading the patch with context would also be helpful for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

2022-04-26 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj added a comment. @nridge Please do, I don't have commit permissions :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 ___ cfe-commits mailing list cfe-com

[PATCH] D124435: [X86] Always extend the integer parameters in callee

2022-04-26 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2988-2992 +.. option:: -mconservative-extend +Always extend the integer parameter both in the callee and caller. + +.. option:: -mno-conservative-extend +Keep the original integer parameter passi

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

2022-04-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Let me know if you'd like me to commit the patch for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 ___ cfe-commits mailing list c

[PATCH] D124149: [NFC] follow up code cleanup after D123837

2022-04-26 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. @iains gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124149/new/ https://reviews.llvm.org/D124149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

2022-04-26 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. I'd be in favor of defaulting to an `ERROR` and providing an option to downgrade to a `WARNING`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124489/new/ https://reviews.llvm.org/D124489 __

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

2022-04-26 Thread Amy Kwan via Phabricator via cfe-commits
amyk marked an inline comment as done. amyk added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) ---

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

2022-04-26 Thread Wang Yihan via Phabricator via cfe-commits
yihanaa added a comment. In D122920#3472379 , @asoffer wrote: > In D122920#3471865 , @yihanaa wrote: > >> In D122920#3471654 , @erichkeane >> wrote: >> >>> @yihanaa : I'd

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

2022-04-26 Thread Amy Kwan via Phabricator via cfe-commits
amyk updated this revision to Diff 425417. amyk added a comment. Address review comments of adding documentation to `clang/docs/ClangCommandLineReference.rst` and adding AIX checks to `clang/test/Driver/ppc-crbits.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D124487: [HLSL] Adjust access specifier behavior

2022-04-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/ParserHLSL/access_specifiers.hlsl:8 +private: + // expected-note@+2 {{declared private here}} + // expected-note@+1 {{declared private here}} May need tests for `protected:` and `public:`, and possibly for `

[PATCH] D123958: [randstruct] Randomize all elements of a record

2022-04-26 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

2022-04-26 Thread Wang Yihan via Phabricator via cfe-commits
yihanaa added a comment. In D122920#3472379 , @asoffer wrote: > In D122920#3471865 , @yihanaa wrote: > >> In D122920#3471654 , @erichkeane >> wrote: >> >>> @yihanaa : I'd

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

2022-04-26 Thread Jez Ng via Phabricator via cfe-commits
int3 added inline comments. Comment at: llvm/lib/CodeGen/MachineModuleInfo.cpp:69 MMI.TM.getMCRegisterInfo(), MMI.TM.getMCSubtargetInfo(), nullptr, - nullptr, false), + &MMI.TM.Options.MCOptions, false), MachineFunctions(std::move(M

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

2022-04-26 Thread Jez Ng via Phabricator via cfe-commits
int3 updated this revision to Diff 425408. int3 marked an inline comment as done. int3 added a comment. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. use MCTargetOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/n

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-26 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:1 +#include "IntegralLiteralExpressionMatcher.h" + ditto Comment at: clang-tools-extra/clang-tidy/modernize/Integ

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-26 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. LegalizeAdulthood requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscri

[PATCH] D124316: [clang-tidy] Modernize-macro-to-enum should skip macros used in other macros

2022-04-26 Thread Richard via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG693246e03f28: [clang-tidy] Modernize-macro-to-enum should skip macros used in other macros (authored by LegalizeAdulthood). Repository: rG LLVM Gi

[clang-tools-extra] 693246e - [clang-tidy] Modernize-macro-to-enum should skip macros used in other macros

2022-04-26 Thread via cfe-commits
Author: Richard Date: 2022-04-26T21:09:13-06:00 New Revision: 693246e03f28eaa72e0959fe6a969cea655b1fdc URL: https://github.com/llvm/llvm-project/commit/693246e03f28eaa72e0959fe6a969cea655b1fdc DIFF: https://github.com/llvm/llvm-project/commit/693246e03f28eaa72e0959fe6a969cea655b1fdc.diff LOG:

[PATCH] D124316: [clang-tidy] Modernize-macro-to-enum should skip macros used in other macros

2022-04-26 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood updated this revision to Diff 425399. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124316/new/ https://reviews.llvm.org/D124316 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp clang

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

2022-04-26 Thread krishna chaitanya sankisa via Phabricator via cfe-commits
skc7 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2435 DetermineNoUndef(ParamType, getTypes(), DL, AI)) { - Attrs.addAttribute(llvm::Attribute::NoUndef); + if(!FuncAttrs.contains(llvm::Attribute::Convergent)) +Attrs.addAttribute(llvm:

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

2022-04-26 Thread krishna chaitanya sankisa via Phabricator via cfe-commits
skc7 updated this revision to Diff 425394. skc7 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124158/new/ https://reviews.llvm.org/D124158 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/PowerPC/ppc64le-varargs-f

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

2022-04-26 Thread krishna chaitanya sankisa via Phabricator via cfe-commits
skc7 updated this revision to Diff 425393. skc7 added a comment. clang-format to CGCall.cpp. Added comment for the change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124158/new/ https://reviews.llvm.org/D124158 Files: clang/lib/CodeGen/CGCall.

[PATCH] D124496: [Clang][Attr] clanf-format update

2022-04-26 Thread krishna chaitanya sankisa via Phabricator via cfe-commits
skc7 created this revision. Herald added a project: All. skc7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124496 Files: clang/lib/CodeGen/CGCall.cpp Index: clang/lib/

[PATCH] D124493: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

2022-04-26 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 425379. hctim added a comment. Wrong base, updating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CGDe

[PATCH] D124493: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

2022-04-26 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added a comment. Sorry for the large patch. Honestly, looks bigger than it is due to 1-line changes in many files + many-line changes in stuff that was pretty much moved around. I didn't see a great way to split this up except for sharding out the GlobalValue changes + IR + bitcode read/w

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

2022-04-26 Thread Moshe via Phabricator via cfe-commits
MosheBerman added a comment. In D123352#3475889 , @NoQ wrote: > I'm worried that even if the warning is correct, the suggested fix is not > necessarily the right solution. > > The very nature of path-sensitive warnings requires multiple events to happen

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

2022-04-26 Thread Dan Liew via Phabricator via cfe-commits
delcypher added a comment. > Making it an ERROR and providing an option to downgrade it to a WARNING seems > reasonable to me. Thoughts? One nice property this would have is it would (eventually) allow us to collect a list of all the places that depend on this old code. It is potentially quite

[PATCH] D124452: [clang-format] Adjust editor cursor position past #include blocks

2022-04-26 Thread Owen Pan via Phabricator via cfe-commits
owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:895 + Style.IncludeBlocks = Style.IBS_Regroup; + std::string Code = "#include \"b\"\n" // Start of line: 0 + "\n"

[PATCH] D124452: [clang-format] Adjust editor cursor position past #include blocks

2022-04-26 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 425376. owenpan added a comment. Updated the test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124452/new/ https://reviews.llvm.org/D124452 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clang/uni

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. Making it an `ERROR` and providing an option to downgrade it to a `WARNING` seems reasonable to me. Thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124489/new/ https://reviews.llvm.org/D124489 __

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

2022-04-26 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. In D124287#3474369 , @jansvoboda11 wrote: > This sounds reasonable to me. What use-cases does `ASTStructuralEquivalence` > fit better than ODR hashes? I think the biggest advantage of `ASTStructuralEquivalence` is that it doesn

[PATCH] D124466: [CUDA][HIP] Fix linkage of __clang_gpu_used_external

2022-04-26 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG57a210e5b705: [CUDA][HIP] Fix linkage of __clang_gpu_used_external (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 57a210e - [CUDA][HIP] Fix linkage of __clang_gpu_used_external

2022-04-26 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2022-04-26T20:43:39-04:00 New Revision: 57a210e5b705f4d176facbd8a15aa3e89ea9e335 URL: https://github.com/llvm/llvm-project/commit/57a210e5b705f4d176facbd8a15aa3e89ea9e335 DIFF: https://github.com/llvm/llvm-project/commit/57a210e5b705f4d176facbd8a15aa3e89ea9e335.dif

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

2022-04-26 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. I don't think many people are gonna notice a warning in the general spew of CMake configuration, tbh. Would it be too disruptive to make this an error instead and have a CMake option you can pass to get rid of the error? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

2022-04-26 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 425354. dgoldman added a comment. Minor formatting fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https://reviews.llvm.org/D124486 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractVaria

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz updated this revision to Diff 425353. beanz added a comment. Making the warning message more specific. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124489/new/ https://reviews.llvm.org/D124489 Files: clang/runtime/CMakeLists.txt Index:

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 425344. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124220/new/ https://reviews.llvm.org/D124220 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D124435: [X86] Always extend the integer parameters in callee

2022-04-26 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2988-2992 +.. option:: -mconservative-extend +Always extend the integer parameter both in the callee and caller. + +.. option:: -mno-conservative-extend +Keep the original integer parameter passi

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz created this revision. beanz added reviewers: delcypher, phosek, compnerd, ldionne, smeenai. Herald added a subscriber: mgorny. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. This patch goes with the RFC posted here: https://discourse.llv

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

2022-04-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I'm worried that even if the warning is correct, the suggested fix is not necessarily the right solution. The very nature of path-sensitive warnings requires multiple events to happen on the path in order for the problem to manifest. Eliminating even one of those critical

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. Posted an RFC: https://discourse.llvm.org/t/rfc-deprecate-and-remove-llvm-build-external-compiler-rt/62058 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124474/new/ https://reviews.llvm.org/D124474 _

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Dan Liew via Phabricator via cfe-commits
delcypher accepted this revision. delcypher added a comment. This revision is now accepted and ready to land. Change LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124474/new/ https://reviews.llvm.org/D124474 _

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Dan Liew via Phabricator via cfe-commits
delcypher added a comment. > I'd definitely prefer moving towards LLVM_ENABLE_RUNTIMES. We already require > LLVM_ENABLE_RUNTIMES for libc++, libc++abi and libunwind and I'm going to > propose doing the same for compiler-rt as well. +1 on this. Compiler-RT's CMake code is extremely and unnecess

[PATCH] D124487: [HLSL] Adjust access specifier behavior

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz created this revision. beanz added reviewers: aaron.ballman, MaskRay, kuhar, rsmith. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. HLSL doesn't supp

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

2022-04-26 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. In D123436#3475002 , @dblaikie wrote: > In D123436#3462567 , @dblaikie > wrote: > >> Perhaps GlobalModuleIndex should create the cursor itself - it's being >> handed the buffer anyway? >

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2527 HelpText<"Use the static host OpenMP runtime while linking.">; +def offload_device_only : Flag<["-"], "offload-device-only">, + HelpText<"Only compile for the offloading device.">; -

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

2022-04-26 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Use the expression's type fo

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2527 HelpText<"Use the static host OpenMP runtime while linking.">; +def offload_device_only : Flag<["-"], "offload-device-only">, + HelpText<"Only compile for the offloading device.">; -

[clang] 35e7b4f - [NFC] Fix argument types in doxygen comment

2022-04-26 Thread Warren Ristow via cfe-commits
Author: Warren Ristow Date: 2022-04-26T16:30:55-07:00 New Revision: 35e7b4f82cfabc28ebc23558917440aece3f489f URL: https://github.com/llvm/llvm-project/commit/35e7b4f82cfabc28ebc23558917440aece3f489f DIFF: https://github.com/llvm/llvm-project/commit/35e7b4f82cfabc28ebc23558917440aece3f489f.diff

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 425336. jhuber6 added a comment. Updating to not use `-f/-fno` versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124220/new/ https://reviews.llvm.org/D124220 Files: clang/include/clang/Driver/Options.t

[PATCH] D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

2022-04-26 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 425334. vsapsai marked an inline comment as done. vsapsai added a comment. Drop unnecessary `cast<>`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124285/new/ https://reviews.llvm.org/D124285 Files: clang/i

[PATCH] D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

2022-04-26 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai marked an inline comment as done. vsapsai added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3300 - Decl *ActOnObjCContainerStartDefinition(Decl *IDecl); + void ActOnObjCContainerStartDefinition(ObjCContainerDecl *IDecl); jansvoboda1

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

2022-04-26 Thread Mitch Phillips via Phabricator via cfe-commits
hctim marked an inline comment as done. hctim added inline comments. Comment at: clang/test/CodeGen/debug-info-variables.c:1 +// RUN: %clang_cc1 %s -debug-info-kind=standalone -S -emit-llvm -o - | FileCheck %s + dblaikie wrote: > Presumably named variables are a

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

2022-04-26 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added a comment. > summary of DWARF: > & how many of these descriptions get added to the debug info? afaict, there is now: 1x .debug_addr entry for each string 1x. debug_info DW_TAG_variable for each string 1x. DW_TAG_array_type + DW_TAG_subrange_type for each unique sizeof(string) i tr

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

2022-04-26 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 425322. python3kgae added a comment. Remove useless brackets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files: clang/include/clang/Basic/DiagnosticDriverK

[PATCH] D124435: [X86] Always extend the integer parameters in callee

2022-04-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:120 bool SRetAfterThis : 1; // isIndirect() bool InReg : 1; // isDirect() || isExtend() || isIndirect() bool CanBeFlattened: 1; // isDirect() Instead of int

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. I pointed out a few (not all) the places where you have unneeded brackets. Also all your new files don't have newlines at the end of them (the C standard specifies that as a requirement although pretty much all compilers just issue a warning). Comment

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

2022-04-26 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 425315. python3kgae added a comment. Fix issues mentioned in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files: clang/include/clang/Basic/Diagnost

[PATCH] D124469: [NFC] Cleanup miscellaneous header items

2022-04-26 Thread Warren Ristow via Phabricator via cfe-commits
wristow added a comment. Thanks for the review @RKSimon ! Comment at: clang/lib/Headers/__wmmintrin_pclmul.h:25 /// \code -/// __m128i _mm_clmulepi64_si128(__m128i __X, __m128i __Y, const int __I); +/// __m128i _mm_clmulepi64_si128(__m128i X, __m128i Y, const int I); /// \end

[PATCH] D124469: [NFC] Cleanup miscellaneous header items

2022-04-26 Thread Warren Ristow via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf08b3493869: [NFC] Cleanup miscellaneous header items (authored by wristow). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] df08b34 - [NFC] Cleanup miscellaneous header items

2022-04-26 Thread Warren Ristow via cfe-commits
Author: Warren Ristow Date: 2022-04-26T14:36:49-07:00 New Revision: df08b3493869540bad5d4b040dae814e078b411d URL: https://github.com/llvm/llvm-project/commit/df08b3493869540bad5d4b040dae814e078b411d DIFF: https://github.com/llvm/llvm-project/commit/df08b3493869540bad5d4b040dae814e078b411d.diff

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

2022-04-26 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1178-1266 + +void AMDGPUAsmPrinter::emitResourceUsageRemarks( +const MachineFunction &MF, const SIProgramInfo &CurrentProgramInfo, +bool isModuleEntryFunction, bool hasMAIInsts) { + if

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added reviewers: compnerd, ldionne, smeenai. beanz added subscribers: smeenai, ldionne, compnerd. beanz added a comment. I don't want to roadblock or say "no we absolutely can't let this in", _but_... Apple Clang and Swift have long been the only reason we've kept this code alive. I didn't

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_device_only : Flag<["-"], "foffload-device-only">, + HelpText<"Only compile for the offloading device.">; +def foffload_host_only : Flag<["-"], "foffload-host-only">, + HelpText

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

2022-04-26 Thread Lang Hames via Phabricator via cfe-commits
lhames added inline comments. Comment at: llvm/tools/llc/llc.cpp:697-700 +auto &Ctx = MMIWP->getMMI().getContext(); +Ctx.setGenDwarfForAssembly(Target->Options.ForceDwarfFrameSection); const_cast(LLVMTM.getObjFileLowering()) +->Initialize(Ctx, *Target); -

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Azharuddin Mohammed via Phabricator via cfe-commits
azharudd added a comment. In D124474#3475550 , @beanz wrote: > In D124474#3475539 , @azharudd > wrote: > >> In this case I'm just trying to make it work with existing build >> configurations where it is being us

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

2022-04-26 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 425303. vsapsai added a comment. Handle in `VisitObjCIvarDecl` only redeclarations in extensions. Interface+interface redeclarations should be handled in VisitObjCInterfaceDecl and implementation+implementation in VisitObjCImplementationDecl. Checked that we

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 425301. jhuber6 added a comment. Adding `-fno` variants and replacing the uses of `--cuda-host-only` with and alias and this flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124220/new/ https://reviews.llvm

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D124474#3475550 , @beanz wrote: > In D124474#3475539 , @azharudd > wrote: > >> In this case I'm just trying to make it work with existing build >> configurations where it is being used

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. In D124474#3475539 , @azharudd wrote: > In this case I'm just trying to make it work with existing build > configurations where it is being used (for example Swift). We should > definitely be moving away from `LLVM_BUILD_EXTERNAL_

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Azharuddin Mohammed via Phabricator via cfe-commits
azharudd added a comment. In D124474#3475432 , @beanz wrote: > I question whether we should be extending this or killing it off... Is there > a reason you're using `LLVM_BUILD_EXTERNAL_COMPILER_RT` instead of > `LLVM_ENABLE_RUNTIMES=compiler-rt`? In th

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_device_only : Flag<["-"], "foffload-device-only">, + HelpText<"Only compile for the offloading device.">; +def foffload_host_only : Flag<["-"], "foffload-host-only">, + Help

[PATCH] D124469: [NFC] Cleanup miscellaneous header items

2022-04-26 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Headers/__wmmintrin_pclmul.h:25 /// \code -/// __m128i _mm_clmulepi64_si128(__m128i __X, __m128i __Y, const int __I); +/// __m128i _mm_clmulepi6

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_device_only : Flag<["-"], "foffload-device-only">, + HelpText<"Only compile for the offloading device.">; +def foffload_host_only : Flag<["-"], "foffload-host-only">, + HelpText

[clang] 72adc46 - [PS5] Add debug option testing for the PS5 target

2022-04-26 Thread Paul Robinson via cfe-commits
Author: Paul Robinson Date: 2022-04-26T13:42:38-07:00 New Revision: 72adc461cca59e3ed1fd2409aa592805572b URL: https://github.com/llvm/llvm-project/commit/72adc461cca59e3ed1fd2409aa592805572b DIFF: https://github.com/llvm/llvm-project/commit/72adc461cca59e3ed1fd2409aa592805572b.diff

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. ping Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_device_only : Flag<["-"], "foffload-device-only">, + HelpText<"Only compile for the offloading device.">; +def foffload_host_only : Flag<["-"], "foffload-host-only">, + Hel

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

2022-04-26 Thread Moshe via Phabricator via cfe-commits
MosheBerman added a comment. In D123352#3474033 , @whisperity wrote: > Regarding FixIts... FixIts are implemented in the "Diagnostic" library, which > is non-specific to neither Clang-Tidy nor Sema whatsoever, they use the same > infrastructure under t

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

2022-04-26 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

2022-04-26 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. In D112921#3473632 , @pcwang-thead wrote: > In D112921#3473022 , @ldionne wrote: > >> (BTW I strongly support this patch, I just think we should do it properly on >> all platforms from t

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. I question whether we should be extending this or killing it off... Is there a reason you're using `LLVM_BUILD_EXTERNAL_COMPILER_RT` instead of `LLVM_ENABLE_RUNTIMES=compiler-rt`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Azharuddin Mohammed via Phabricator via cfe-commits
azharudd created this revision. azharudd added reviewers: yln, delcypher, beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: All. azharudd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building with LLVM_BUILD_

[PATCH] D124452: [clang-format] Adjust editor cursor position past #include blocks

2022-04-26 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:895 + Style.IncludeBlocks = Style.IBS_Regroup; + std::string Code = "#include \"b\"\n" // Start of line: 0 + "\n"

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

2022-04-26 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:194 + /// The validator version for dxil. + std::string DxilValidatorVersion; + Rather than adding this to `CodeGenOptions`, it may make sense to put this in `TargetOptions` in

[PATCH] D119544: Deferred Concept Instantiation Implementation

2022-04-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. OK, 1 issue left (see `FriendFunc`). Comment at: clang/test/SemaTemplate/concepts.cpp:436 + SingleDepthReferencesTopLambda(v); + // TODO: This should error on constraint failure! (Lambda!) + SingleDepthReferencesTopLambda(will_fail); -

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

2022-04-26 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6223-6224 if (IsCuda || IsHIP) { -if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) +if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false) || +

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

2022-04-26 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk added a comment. In D121370#3471183 , @krasimir wrote: > It appears that this regressed include sorting in the following case, where > the contents of `test.h` show the expected include order and the > `clang-format` behavior before this patch: > >

[PATCH] D119544: Deferred Concept Instantiation Implementation

2022-04-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 425275. erichkeane added a comment. Update the concepts-test, remove some extra commented out code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 Files: clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

2022-04-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6223-6224 if (IsCuda || IsHIP) { -if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false)) +if (Args.hasFlag(options::OPT_fgpu_rdc, options::OPT_fno_gpu_rdc, false) || +

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

2022-04-26 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_device_only : Flag<["-"], "foffload-device-only">, + HelpText<"Only compile for the offloading device.">; +def foffload_host_only : Flag<["-"], "foffload-host-only">, + HelpText

[clang] 0a27622 - [NVPTX] Disable DWARF .file directory for PTX

2022-04-26 Thread Andrew Savonichev via cfe-commits
Author: Andrew Savonichev Date: 2022-04-26T21:40:36+03:00 New Revision: 0a27622a1d625f179a17f3a22a547d50b042b76e URL: https://github.com/llvm/llvm-project/commit/0a27622a1d625f179a17f3a22a547d50b042b76e DIFF: https://github.com/llvm/llvm-project/commit/0a27622a1d625f179a17f3a22a547d50b042b76e.d

[PATCH] D121299: [NVPTX] Disable DWARF .file directory for PTX

2022-04-26 Thread Andrew Savonichev via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a27622a1d62: [NVPTX] Disable DWARF .file directory for PTX (autho

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

2022-04-26 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D120272#3475155 , @jhuber6 wrote: > Changing this to simply require that the user manually passes `-fgpu-rdc` in > order to use the new driver. I think t

  1   2   3   >