[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

[krishna chaitanya sankisa via Phabricator via cfe-commits]

skc7 updated this revision to Diff 425393.
skc7 added a comment.

clang-format to CGCall.cpp. Added comment for the change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124158/new/

https://reviews.llvm.org/D124158

Files:
  clang/lib/CodeGen/CGCall.cpp


Index: clang/lib/CodeGen/CGCall.cpp
===================================================================
--- clang/lib/CodeGen/CGCall.cpp
+++ clang/lib/CodeGen/CGCall.cpp
@@ -2432,7 +2432,8 @@
     // Decide whether the argument we're handling could be partially undef
     if (CodeGenOpts.EnableNoundefAttrs &&
         DetermineNoUndef(ParamType, getTypes(), DL, AI)) {
-      if(!FuncAttrs.contains(llvm::Attribute::Convergent))
+      // Skip adding noundef attribute to arguments when function has 
convergent attribute.
+      if (!FuncAttrs.contains(llvm::Attribute::Convergent))
         Attrs.addAttribute(llvm::Attribute::NoUndef);
     }
 



Index: clang/lib/CodeGen/CGCall.cpp
===================================================================
--- clang/lib/CodeGen/CGCall.cpp
+++ clang/lib/CodeGen/CGCall.cpp
@@ -2432,7 +2432,8 @@
     // Decide whether the argument we're handling could be partially undef
     if (CodeGenOpts.EnableNoundefAttrs &&
         DetermineNoUndef(ParamType, getTypes(), DL, AI)) {
-      if(!FuncAttrs.contains(llvm::Attribute::Convergent))
+      // Skip adding noundef attribute to arguments when function has convergent attribute.
+      if (!FuncAttrs.contains(llvm::Attribute::Convergent))
         Attrs.addAttribute(llvm::Attribute::NoUndef);
     }
 

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits