[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall updated this revision to Diff 403149. sammccall marked an inline comment as done. sammccall added a comment. Fix hover revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116387/new/ https://reviews.llvm.org/D116387 Files: clang-tool

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:65 Base.SuppressTemplateArgsInCXXConstructors = true; + Base.CleanUglifiedParameters = true; return Base; hokein wrote: > IIUC, the

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

serge-sans-paille accepted this revision. serge-sans-paille added a comment. No performance regression on my side either (but only minor gains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118169/new/ https://reviews.llvm.org/D118169 ___

[clang] f563bd7 - [NFC] Group PowerPC clang codegen tests into directory

Author: Qiu Chaofan Date: 2022-01-26T15:19:22+08:00 New Revision: f563bd74cb9a4f0d2d3eb49d35536b648361ec53 URL: https://github.com/llvm/llvm-project/commit/f563bd74cb9a4f0d2d3eb49d35536b648361ec53 DIFF: https://github.com/llvm/llvm-project/commit/f563bd74cb9a4f0d2d3eb49d35536b648361ec53.diff L

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

serge-sans-paille added a comment. The change looks fine to me. I've started a set of benchmark to make sure it provides the expected speedup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118169/new/ https://reviews.llvm.org/D118169

[clang-tools-extra] f0726ae - Refactor: Extract Class MessagePrefix (NFC)

Author: Richard Date: 2022-01-25T23:19:33-07:00 New Revision: f0726ae0f9fa3fc5fadec7fdc940cc2f88759001 URL: https://github.com/llvm/llvm-project/commit/f0726ae0f9fa3fc5fadec7fdc940cc2f88759001 DIFF: https://github.com/llvm/llvm-project/commit/f0726ae0f9fa3fc5fadec7fdc940cc2f88759001.diff LOG:

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 403135. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. In D115610#3269265 , @urnathan wrote: > Seems good to me, @iains you've been looking at this? According to the discussion in https://github.com/llvm/llvm-project/issues/51682, it looks like Iains plans to implement something

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu updated this revision to Diff 403130. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp clang/test/CXX/module/module

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117972/new/ https://reviews.llvm.org/D117972 ___

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 added a comment. Yes, https://reviews.llvm.org/D116160 is deprecated and will be abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 ___ cfe-comm

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. In D115867#3270137 , @Quuxplusone wrote: > LGTM now, modulo my suggested edits (and the necessary corresponding edits in > the test case). > I don't think I'm really qualified to acc

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu updated this revision to Diff 403121. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 Files: clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticGroups.td clang/

[PATCH] D118211: Add missing namespace to PPCLinux.cpp

glandium created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. glandium requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a build failure with MSVC introduced in https://reviews.llvm.org/D112906 Repository:

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:72-73 -const Expr *getBoolLiteral(const MatchFinder::MatchResult &Result, - StringRef Id) { +static const Expr *getBoolLiteral(c

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:72-73 -const Expr *getBoolLiteral(const MatchFinder::MatchResult &Result, - StringRef Id) { +static const Expr *getBoolLiteral(c

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood updated this revision to Diff 403118. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117939/new/ https://reviews.llvm.org/D117939 Files: clang-tools-extra/docs/clang-tidy/Contributing.rst Index: clang-to

[PATCH] D117681: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics.

khchen updated this revision to Diff 403117. khchen added a comment. rebase and address Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117681/new/ https://reviews.llvm.org/D117681 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 403116. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

qiucf added a comment. > It is probably not worth the effort since there won't be that many test cases > that test the front end's IR generation for long double, but there should be > a way to set up lit to know the default through its configuration files. Yes, lit doesn't know about it. But li

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

qiucf updated this revision to Diff 403114. qiucf marked 3 inline comments as done. qiucf edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118110/new/ https://reviews.llvm.org/D118110 Files: clang/CMakeLists.txt

[PATCH] D118120: [C++20] [Modules] Only check decls under namespace scope in CheckRedeclarationExported

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c1f7b296ac0: [C++20] [Modules] Only check decls under namespace scope in… (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 5c1f7b2 - [C++20] [Modules] Only check decls under namespace scope in CheckRedeclarationExported

Author: Chuanqi Xu Date: 2022-01-26T10:54:52+08:00 New Revision: 5c1f7b296ac0dddeca02891976e6ab5cfc006719 URL: https://github.com/llvm/llvm-project/commit/5c1f7b296ac0dddeca02891976e6ab5cfc006719 DIFF: https://github.com/llvm/llvm-project/commit/5c1f7b296ac0dddeca02891976e6ab5cfc006719.diff LO

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

rjmccall added a comment. > In addition to the ABI compatibility concern, IMO, GCC's behavior here is > better and more user friendly: > > - C++ classes have methods > - calling a method on a field takes the address of a field I mean, this argument is hardly limited to non-POD types. I suppose

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

pkubaj updated this revision to Diff 403103. pkubaj added a comment. Address review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117972/new/ https://reviews.llvm.org/D117972 Files: clang/lib/Headers/ppc_wrappers/mm_malloc.h Index: clang/lib/

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

nickdesaulniers added a comment. > This patch supersedes the one from https://reviews.llvm.org/D116160. Can that one be abandoned then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199 ___

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

qiucf added a comment. Thanks for the fix! Comment at: clang/lib/Headers/ppc_wrappers/mm_malloc.h:22 #else +#if defined(__linux__) extern "C" int posix_memalign (void **, size_t, size_t) throw (); Actually I just realised we don't need this guard, Clang alrea

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

ChuanqiXu added a comment. Oh, it looks like we couldn't go on since the part of PR1766R1 is not adopted: https://github.com/cplusplus/draft/issues/5237 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117295/new/ https://reviews.llvm.org/D117295 _

[PATCH] D112493: [OpenMP][NFCI] Record the location string as part of the ident_t

jdoerfert abandoned this revision. jdoerfert added a comment. Committed partially as 944aa0421cb7da3aa764b2a108ea25ef8bceb979 , rest is NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D117647: [RISCV] Add passthru operand for RVV nomask load intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9273378b8576: [RISCV] Add the passthru operand for RVV nomask load intrinsics. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D118205: [ASan] Added a unit test for D118184.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69da422bdaa6: [ASan] Added a unit test for D118184. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 69da422 - [ASan] Added a unit test for D118184.

Author: Kirill Stoimenov Date: 2022-01-26T01:20:02Z New Revision: 69da422bdaa684fbd14c95b06f40ac57910642d9 URL: https://github.com/llvm/llvm-project/commit/69da422bdaa684fbd14c95b06f40ac57910642d9 DIFF: https://github.com/llvm/llvm-project/commit/69da422bdaa684fbd14c95b06f40ac57910642d9.diff L

[PATCH] D118205: [ASan] Added a unit test for D118184.

kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118205/new/ https://reviews.llvm.org/D118205 ___

[PATCH] D118205: [ASan] Added a unit test for D118184.

kstoimenov updated this revision to Diff 403083. kstoimenov added a comment. Fixed order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118205/new/ https://reviews.llvm.org/D118205 Files: clang/test/Driver/sanitizer-ld.c Index: clang/test/Driv

[PATCH] D118205: [ASan] Added a unit test for D118184.

kstoimenov created this revision. kstoimenov added a reviewer: kda. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To make sure the the libraries are there for executable and not there for DSOs. Repository: rG LLVM Github Mo

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:428 +const Driver &D, StringRef TargetTriple, const ArgList &Args, +llvm::Triple *UnnormalizedTriple = nullptr, StringRef DarwinArchName = "") { // FIXME: Already done in Compilation *Driver::Build

[PATCH] D118084: [CUDA, NVPTX] Pass byval aggregates directly

tra added a comment. In D118084#3271073 , @jdoerfert wrote: > @lebedev.ri wanted to teach SROA how to deal with dynamic indices before, > IIRC. It seems to be generally useful. Interesting. I'd like to hear more. > This patch can wait till then? Yes.

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. No worries! Thanks for the reply. I use Debian and want it to work well and support the `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on` direction. Currently, `-DLLVM_DEFAULT_TARGET_TRIPLE=aarch64-linux-gnu` (Debian style multiarch triple, so no `-unknown` or `-pc`) does not w

[PATCH] D118084: [CUDA, NVPTX] Pass byval aggregates directly

jdoerfert added a subscriber: lebedev.ri. jdoerfert added a comment. @lebedev.ri wanted to teach SROA how to deal with dynamic indices before, IIRC. It seems to be generally useful. This patch can wait till then? Comment at: clang/lib/CodeGen/TargetInfo.cpp:7193 EIT-

[PATCH] D118084: [CUDA, NVPTX] Pass byval aggregates directly

tra planned changes to this revision. tra added a comment. Getting rid of byval helps getting rid of locals in quite a few places, but runs into a new problem. 😕 Looks like this change does have unexpected side-effects. When we need to dynamically index into a struct passed directly, there's no

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks updated this revision to Diff 403070. aeubanks added a comment. only use PointerIntPair when alignof(Value*) >= 8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262 Files: clang/lib/CodeGen/Addres

[PATCH] D118184: [ASan] Not linking asan_static library for DSO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf730d8ce134: [ASan] Not linking asan_static library for DSO. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] cf730d8 - [ASan] Not linking asan_static library for DSO.

Author: Kirill Stoimenov Date: 2022-01-26T00:13:26Z New Revision: cf730d8ce1341ba593144df2e2bc8411238e04c3 URL: https://github.com/llvm/llvm-project/commit/cf730d8ce1341ba593144df2e2bc8411238e04c3 DIFF: https://github.com/llvm/llvm-project/commit/cf730d8ce1341ba593144df2e2bc8411238e04c3.diff L

[clang] fe30370 - Reland "[AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)"

Author: Dávid Bolvanský Date: 2022-01-26T01:11:06+01:00 New Revision: fe30370b007e7efa1bd1f39a3189b27ae4e5fcbe URL: https://github.com/llvm/llvm-project/commit/fe30370b007e7efa1bd1f39a3189b27ae4e5fcbe DIFF: https://github.com/llvm/llvm-project/commit/fe30370b007e7efa1bd1f39a3189b27ae4e5fcbe.dif

[PATCH] D118184: [ASan] Not linking asan_static library for DSO.

kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. unit test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118184/new/ https://reviews.llvm.org/D118184 ___

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

This revision was automatically updated to reflect the committed changes. Closed by commit rGce94432702bf: [clangd] Add designator inlay hints for initializer lists. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116786/new/

[clang-tools-extra] ce94432 - [clangd] Add designator inlay hints for initializer lists.

Author: Sam McCall Date: 2022-01-26T00:35:29+01:00 New Revision: ce94432702bf42a0b95a2693aa47177f37dd0bb3 URL: https://github.com/llvm/llvm-project/commit/ce94432702bf42a0b95a2693aa47177f37dd0bb3 DIFF: https://github.com/llvm/llvm-project/commit/ce94432702bf42a0b95a2693aa47177f37dd0bb3.diff LO

[PATCH] D118084: [CUDA, NVPTX] Pass byval aggregates directly

jdoerfert added a comment. The RFC discussion concluded this should be fine wrt. the interoperability use cases we want to support. Code change looks good but I have one question. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7183 } -return getNaturalAlignIndirect(Ty,

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a subscriber: hvdijk. phosek added a comment. In D110663#3270509 , @MaskRay wrote: > Ping @phosek I apologize about the belated response, but I wanted to test this change first given the potentially large blast radius. To clarify, when I t

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

njames93 updated this revision to Diff 403050. njames93 added a comment. Simplify check logic to only detect loop inits with 0 and incriment with 1. Functionality can be introduced with later patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 created this revision. Herald added a subscriber: kristof.beyls. tyb0807 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This introduces the new __ARM_FEATURE_MOPS ACLE feature test macro, which signals the availability of the new A

[PATCH] D118198: [OpenMP] Remove call to 'clang-offload-wrapper' binary

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, saiislam. Herald added subscribers: guansong, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch removes t

[PATCH] D118197: [OpenMP] Replace sysmtem call to `llc` with target machine

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, saiislam. Herald added subscribers: mikhail.ramalho, guansong, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Thi

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. hokein requested review of this revision. Herald added a project: clang. This patch introduces a dense implementation of the LR parsing table, which is used by LR parsers. We implement a SLR(1) par

[clang] 493509a - [NFC] DeclCXX: Fix -Wreorder-ctor

Author: Jordan Rupprecht Date: 2022-01-25T14:29:35-08:00 New Revision: 493509a40ad1653feb779861badd3ee59fc4a79c URL: https://github.com/llvm/llvm-project/commit/493509a40ad1653feb779861badd3ee59fc4a79c DIFF: https://github.com/llvm/llvm-project/commit/493509a40ad1653feb779861badd3ee59fc4a79c.di

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

jansvoboda11 added a comment. I don't have any suggestions here except for running the patch through `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117830/new/ https://reviews.llvm.org/D117830 __

[clang] 8ba9c79 - Add support for sycl_special_class attribute.

Author: Zahira Ammarguellat Date: 2022-01-25T14:17:09-08:00 New Revision: 8ba9c794feb30cd969b9776c39873def10c51bff URL: https://github.com/llvm/llvm-project/commit/8ba9c794feb30cd969b9776c39873def10c51bff DIFF: https://github.com/llvm/llvm-project/commit/8ba9c794feb30cd969b9776c39873def10c51bff

[clang] 90f185c - Revert "[AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)"

Author: Dávid Bolvanský Date: 2022-01-25T23:13:46+01:00 New Revision: 90f185c964d05e9f3081bb4acc734b3932db221a URL: https://github.com/llvm/llvm-project/commit/90f185c964d05e9f3081bb4acc734b3932db221a DIFF: https://github.com/llvm/llvm-project/commit/90f185c964d05e9f3081bb4acc734b3932db221a.dif

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 added a comment. In D117965#3270744 , @thakis wrote: > Could this have caused http://45.33.8.238/linux/66347/step_7.txt ? Yeah, possible as inliner removes internal unused functions (small change before commit, missed check-clang). I will rev

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

thakis added a comment. Could this have caused http://45.33.8.238/linux/66347/step_7.txt ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117965/new/ https://reviews.llvm.org/D117965 ___ cfe-commits maili

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:362 +Private custom matchers are a good example of auxiliary support code for your check +that is best tested with a unit t

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGceec4383681c: [AlwaysInliner] Enable call site inlining to make flatten attribute working… (authored by xbolva00). Changed prior to commit: https:

[clang] ceec438 - [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

Author: Dávid Bolvanský Date: 2022-01-25T22:55:30+01:00 New Revision: ceec4383681c42bfd3d06a6913ce7554bea160b0 URL: https://github.com/llvm/llvm-project/commit/ceec4383681c42bfd3d06a6913ce7554bea160b0 DIFF: https://github.com/llvm/llvm-project/commit/ceec4383681c42bfd3d06a6913ce7554bea160b0.dif

[PATCH] D117939: [clang-tidy] Add more documentation about check development

ymandel added a comment. Overall, this looks fantastic! You may want to consider (in a separate patch) mentioning godbolt.org, which is a great UI for interacting with clang-query and the AST. Example configuration: https://godbolt.org/z/v88W8ET19 In D117939#3266234

[PATCH] D118184: [ASan] Not lininking asan_static library for DSO.

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Whithout this change DSOs fail to link because of missing asan_report_(load|store)n functions. Repository: rG LLVM Github Monorepo https://re

[PATCH] D118150: [clang] Fix serialized diagnostics edge-cases

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118150/new/ https://reviews.llvm.org/D118150 _

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

erichkeane accepted this revision. erichkeane added a comment. This looks fine to change, and seems like a slight compile timeimprovement. It seems that the only thing we use this for is .find, .erase, and operator[], all of which don't depend on iterator order, so this should not cause any pro

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. https://llvm-compile-time-tracker.com/compare.php?from=c39d22d1968cf07e54b5816ba76dccef8acaace1&to=1958f5a5fb5be3fb5b6bad5079a2f3485db0b0e9&stat=instructions mostly neutral but a tiny bit of

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added a comment. Can you add a release note to go along with this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D117616 ___ cfe-commits mailing list

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a subscriber: probinson. dblaikie added a comment. @probinson for Sony ABI input Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D117616 ___ cfe-commits

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Transforms/Coroutines/coro-retcon-once-private.ll:6 -; CHECK: define internal { i8*, i32 } @f(i8* %buffer, i32* %array) -; CHECK-NEXT: entry:

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

erichkeane accepted this revision. erichkeane added a comment. Accept again, thanks! Note the purpose of the assert is to make sure that a backend doesn't make a bad decision, and the test for 'max size' is only validating 1 backend (AND has now been changed to >128 I think). CHANGES SINCE LA

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

rnk added a comment. In addition to the ABI compatibility concern, IMO, GCC's behavior here is better and more user friendly: - C++ classes have methods - calling a method on a field takes the address of a field - if the field is in a packed struct, it may be misaligned - misaligned loads and st

[PATCH] D112915: [clang][modules] Track included files per submodule

vsapsai added a comment. Can you please rebase this change after D114095 lands? Overall looks good but I want to take one final look and triggering the pre-merge checks will be useful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

aaron.ballman updated this revision to Diff 403008. aaron.ballman added a comment. Updated based on review feedback. I added an additional assert to test that the value picked by the target meets the requirements from the C standard. (We already had a test case for it in lit, but no reason not t

[PATCH] D118178: [clang][dataflow] Allow clients to disable built-in transfer functions.

ymandel created this revision. ymandel added a reviewer: sgatev. Herald added subscribers: tschuett, steakhal. ymandel requested review of this revision. Herald added a project: clang. These built-in functions build the (sophisticated) model of the code's memory. This model isn't used by all analy

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; dblaikie wrote: > rnk wrote: > > dblaikie wrote: > > > bwyma wrot

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks for working on it! Though I haven't built it locally and it can be useful for pre-merge checks to finish. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

dblaikie added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; rnk wrote: > dblaikie wrote: > > bwyma wrote: > > > dblaikie

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 added inline comments. Comment at: llvm/lib/Transforms/IPO/AlwaysInliner.cpp:95 - // Remember to try and delete this function afterward. This both avoids - // re-walking the rest of the module and avoids dealing with any iterator - // invalidation issues

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 updated this revision to Diff 402997. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117965/new/ https://reviews.llvm.org/D117965 Files: clang/test/CodeGen/flatten.c clang/test/CodeGenCXX/flatten.cpp llvm/lib/Transforms/IPO/AlwaysInliner.cpp llvm/test/Transforms/Coroutine

[PATCH] D117939: [clang-tidy] Add more documentation about check development

aaron.ballman added a comment. Aside from the unit testing bit, I think this is fantastic! (And the unit testing bit may also be fantastic, I just think it needs more explicit discussion with a wider audience.) Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:30

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

erichkeane added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:917 + Builder.defineMacro("__BITINT_MAXWIDTH__", Twine(TI.getMaxBitIntWidth())); + Could you do an assert that TI.getMaxBitIntWidth() is not greater than the LLVM maximum (j

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 added a comment. Thanks, addressed review comments. > we should reconsider the attribute support I agree. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117965/new/ https://reviews.llvm.org/D117965 ___ cfe-commits mailing list cfe-c

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; dblaikie wrote: > bwyma wrote: > > dblaikie wrote: > > > rnk wrot

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 updated this revision to Diff 402994. xbolva00 retitled this revision from "[AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)" to "[AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)". Herald added a subscri

[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rG491c154677bc: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116966/new/ htt

[clang] 491c154 - [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

Author: Aleksandr Platonov Date: 2022-01-25T23:05:00+03:00 New Revision: 491c154677bcf0fba3c91fdaa7897a48ab605327 URL: https://github.com/llvm/llvm-project/commit/491c154677bcf0fba3c91fdaa7897a48ab605327 DIFF: https://github.com/llvm/llvm-project/commit/491c154677bcf0fba3c91fdaa7897a48ab605327.

[PATCH] D118153: [CUDA][HIP] Do not treat host var address as constant in device compilation

yaxunl added a comment. In D118153#3270122 , @tra wrote: > LGTM. > > Do we need to do anything special about `__managed__` vars? Right `__managed__` var is special. Its address is set by runtime, therefore it is not a constant. nvcc does not treat it as

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:497 +// Pack expansion is only allowed in the variadic argument at the end. +const size_t attrNumArgs = attributeNumberOfArguments(*AttrName); +if (ArgExprs.size() + I + 1 < att

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0944c196c58f: [libTooling] Adds more support for constructing object access expressions. (authored by ymandel). Repository: rG LLVM Github Monorep

[clang] 0944c19 - [libTooling] Adds more support for constructing object access expressions.

Author: Yitzhak Mandelbaum Date: 2022-01-25T19:43:36Z New Revision: 0944c196c58f62299540983e2d10cd7bef60691a URL: https://github.com/llvm/llvm-project/commit/0944c196c58f62299540983e2d10cd7bef60691a DIFF: https://github.com/llvm/llvm-project/commit/0944c196c58f62299540983e2d10cd7bef60691a.diff

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel updated this revision to Diff 402984. ymandel added a comment. Herald added a subscriber: JDevlieghere. fix bad previous snapshot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116377/new/ https://reviews.llvm.org/D116377 Files: clang/inc

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ad19a833177: [CUDA,NVPTX] Corrected fragment size for tf32 LD B matrix. (authored by JackAKirk, committed by tra). Repository: rG LLVM Github Mon

[clang] 0ad19a8 - [CUDA, NVPTX] Corrected fragment size for tf32 LD B matrix.

Author: JackAKirk Date: 2022-01-25T11:29:19-08:00 New Revision: 0ad19a833177861be55fefaff725ab89c8695d01 URL: https://github.com/llvm/llvm-project/commit/0ad19a833177861be55fefaff725ab89c8695d01 DIFF: https://github.com/llvm/llvm-project/commit/0ad19a833177861be55fefaff725ab89c8695d01.diff LOG

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a comment. In D117616#3270205 , @tstellar wrote: > So to summarize: this will change the ABI of clang built objects from clang13 > -> clang14 in order to make clang14 compatible with gcc? That's the idea, yes. (only for non-pod members of

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)

aeubanks added a comment. sounds good for the purposes of going back to what we had before, but we should reconsider the attribute support Comment at: llvm/lib/Transforms/IPO/AlwaysInliner.cpp:95 - // Remember to try and delete this function afterward. This both avoids

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added a comment. So to summarize: this will change the ABI of clang built objects from clang13 -> clang14 in order to make clang14 compatible with gcc? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D11

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

yurai007 created this revision. yurai007 added reviewers: nikic, xbolva00, erichkeane, craig.topper, aeubanks, Tyker. Herald added a subscriber: pengfei. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CodeGenModule::DeferredDecls

  1   2   3   >