[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 398857. Ericson2314 added a comment. Fix conflicts, one more thing for openmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.

[PATCH] D116994: [RISCV] Add bfp and bfpw intrinsic in zbf extension

Jimerlife created this revision. Jimerlife added reviewers: craig.topper, benshi001, asb, LevyHsu. Jimerlife added a project: LLVM. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna,

[PATCH] D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50ec1306d060: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence… (authored by mstorsjo). Repository: rG LLVM Github Mo

[clang] 50ec130 - [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

Author: Martin Storsjö Date: 2022-01-11T09:22:00+02:00 New Revision: 50ec1306d060e46e0d53c9f5d8a052e1b0d10d3b URL: https://github.com/llvm/llvm-project/commit/50ec1306d060e46e0d53c9f5d8a052e1b0d10d3b DIFF: https://github.com/llvm/llvm-project/commit/50ec1306d060e46e0d53c9f5d8a052e1b0d10d3b.diff

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 398846. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

carlosgalvezp added a comment. In D116833#3232739 , @efriedma wrote: > I'll just note here that doing this globally is likely to have unexpected > results... consider, for example: > > #include > void f() { long x = M_PI; } > > Currently, the implic

[PATCH] D116736: [Clang] Add __builtin_reduce_or and __builtin_reduce_and

junaire updated this revision to Diff 398838. junaire added a comment. fix the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116736/new/ https://reviews.llvm.org/D116736 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:2142 +if (capture.isConstantOrTrivial()) + continue; + rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > Should this condition be specific to whether it's trivial *to de

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:2142 +if (capture.isConstantOrTrivial()) + continue; + ahatanak wrote: > rjmccall wrote: > > Should this condition be specific to whether it's trivial *to destroy*? > > C++ type

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 398824. achieveartificialintelligence added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Support/RISCVISAIn

[PATCH] D116659: [llvm][clang][vfs] NFC: Extract directory iteration boilerplate into macro

dexonsmith added a comment. I think th eAPI is designed to ensure users don't forget to check the error code. What about a new API/iterator type that wraps the existing one and has a "normal" `operator++`? - Take an error as an out-parameter on construction - Make it an `llvm::Error` which gua

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

jhuber6 updated this revision to Diff 398821. jhuber6 added a comment. Herald added subscribers: ormris, steven_wu. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116975/new/ https://reviews.llvm.org/D116975 Files: clang/lib/Driver/Dri

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:2142 +if (capture.isConstantOrTrivial()) + continue; + rjmccall wrote: > Should this condition be specific to whether it's trivial *to destroy*? C++ > types could be trivial to

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:361 /// Order by 1) all __strong together 2) next, all byfref together 3) next, /// all __weak together. Preserve descending alignment in all situations. "byref"

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

vitalybuka added a comment. >> https://lab.llvm.org/buildbot/#/builders/sanitizer-windows >> https://lab.llvm.org/buildbot/#/builders/clang-x64-windows-msvc Actually these were already on VS2019, version 16.8, so I only updated them both to 16.11. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116987: [clang][utils] Remove StringRef lldb summary provider

kastiglione created this revision. kastiglione added reviewers: akyrtzi, jingham. Herald added subscribers: usaxena95, arphaman. kastiglione requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove the `StringRef` summary provider in favor of

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

ahatanak updated this revision to Diff 398800. ahatanak marked 2 inline comments as done. ahatanak added a comment. Build the map (`Captures`) after building the vector (`SortedCaptures`). Also fix a minor bug where a `BlockLayoutChunk` wasn't being removed after being copied when the end of the

[PATCH] D116792: [AST] lookup in parent DeclContext for transparent DeclContext

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9d63fc1088c: [AST] lookup in parent DeclContext for transparent DeclContext (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116792/ne

[clang] d9d63fc - [AST] lookup in parent DeclContext for transparent DeclContext

Author: Chuanqi Xu Date: 2022-01-11T10:16:26+08:00 New Revision: d9d63fc1088c22129cde9c3d3a84f356c875190e URL: https://github.com/llvm/llvm-project/commit/d9d63fc1088c22129cde9c3d3a84f356c875190e DIFF: https://github.com/llvm/llvm-project/commit/d9d63fc1088c22129cde9c3d3a84f356c875190e.diff LO

[PATCH] D116911: [AST] Don't consider 'ExportDecl' when calculating DeclContext 'Encloses'

This revision was automatically updated to reflect the committed changes. Closed by commit rG86c5b870b2e5: [AST] Don't consider 'ExportDecl' when calculating DeclContext 'Encloses' (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 86c5b87 - [AST] Don't consider 'ExportDecl' when calculating DeclContext 'Encloses'

Author: Chuanqi Xu Date: 2022-01-11T09:54:57+08:00 New Revision: 86c5b870b2e5192a9414204500a53b31524db065 URL: https://github.com/llvm/llvm-project/commit/86c5b870b2e5192a9414204500a53b31524db065 DIFF: https://github.com/llvm/llvm-project/commit/86c5b870b2e5192a9414204500a53b31524db065.diff LO

[PATCH] D111566: [SYCL] Fix function pointer address space

rjmccall added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11496 + .getProgramAddressSpace() + : getTargetAddressSpace(T.getQualifiers()); +} Oh, I'm sorry I missed this. Parsing the data layout string into an `llvm::

[PATCH] D114908: [clang] Don't call inheritDefaultTemplateArguments() on CXXDeductionGuideDecl's template parameters

aeubanks added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3784-3790 + if (auto *TD = dyn_cast(D)) { +// CXXDeductionGuideDecls reference the class template parameters so we need +// to make sure not to call this twice on the same template par

[clang] 140a6b1 - [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

Author: Jennifer Yu Date: 2022-01-10T16:58:56-08:00 New Revision: 140a6b1e5c6857617a83f66680b4829ff2b08d82 URL: https://github.com/llvm/llvm-project/commit/140a6b1e5c6857617a83f66680b4829ff2b08d82 DIFF: https://github.com/llvm/llvm-project/commit/140a6b1e5c6857617a83f66680b4829ff2b08d82.diff L

[PATCH] D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG140a6b1e5c68: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116764/new/ ht

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews updated this revision to Diff 398784. eandrews added a comment. Implement review comments - add a comment + remove unnecessary code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 Files: clang/include/clang/AST/ASTContext.h clang/

[PATCH] D116721: [Tooling] When transferring compile commands between files, always use '--'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4258d68dc737: [Tooling] When transferring compile commands between files, always use '--' (authored by sammccall). Repository: rG LLVM Github Mono

[clang-tools-extra] 4258d68 - [Tooling] When transferring compile commands between files, always use '--'

Author: Sam McCall Date: 2022-01-11T01:41:42+01:00 New Revision: 4258d68dc73789bc7fc491734c9c392809b1b29a URL: https://github.com/llvm/llvm-project/commit/4258d68dc73789bc7fc491734c9c392809b1b29a DIFF: https://github.com/llvm/llvm-project/commit/4258d68dc73789bc7fc491734c9c392809b1b29a.diff LO

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall updated this revision to Diff 398779. sammccall added a comment. Fix printName Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116387/new/ https://reviews.llvm.org/D116387 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clang

[PATCH] D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

This revision was automatically updated to reflect the committed changes. Closed by commit rGd789ea713372: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option… (authored by wolfgangp). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D10

[clang] d789ea7 - [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

Author: Wolfgang Pieb Date: 2022-01-10T16:38:01-08:00 New Revision: d789ea713372d44e50ff52a85a198ac6bbedaef9 URL: https://github.com/llvm/llvm-project/commit/d789ea713372d44e50ff52a85a198ac6bbedaef9 DIFF: https://github.com/llvm/llvm-project/commit/d789ea713372d44e50ff52a85a198ac6bbedaef9.diff

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11494 + const Type *TypePtr = T.getTypePtr(); + return TypePtr->isFunctionType() + ? llvm::DataLayout(getTargetInfo().getDataLayoutString()) rjmccall wrote: > You can just do `

[PATCH] D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

MaskRay accepted this revision. MaskRay added a comment. In D116503#3231138 , @mstorsjo wrote: > In D116503#3223094 , @MaskRay wrote: > >> But make sure to wait a bit to see what others think. > > Do you think it'

[PATCH] D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

sammccall updated this revision to Diff 398775. sammccall added a comment. Never eat malformed decl while code completing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116294/new/ https://reviews.llvm.org/D116294 Files: clang-tools-extra/clangd/

[PATCH] D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

sammccall added inline comments. Comment at: clang/lib/Parse/ParseCXXInlineMethods.cpp:153 + // probably truncated, so don't eat more tokens. + if (!Toks.back().is(tok::code_completion)) +SkipMalformedDecl(); kadircet wrote: > i don't follow the

[PATCH] D116790: C++ -gmodules .pcm files don't have the same DW_AT_language dialect

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb200e584ece: Emit the C++ dialect in -gmodules .pcm files. (authored by aprantl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] eb200e5 - Emit the C++ dialect in -gmodules .pcm files.

Author: Adrian Prantl Date: 2022-01-10T16:13:40-08:00 New Revision: eb200e584ece7ca8c1f8cac59ca5418956ccf1e4 URL: https://github.com/llvm/llvm-project/commit/eb200e584ece7ca8c1f8cac59ca5418956ccf1e4 DIFF: https://github.com/llvm/llvm-project/commit/eb200e584ece7ca8c1f8cac59ca5418956ccf1e4.diff

[PATCH] D116717: [CodeCompletion] Complete designators for fields in anonymous structs/unions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbf234b56a82: [CodeCompletion] Complete designators for fields in anonymous structs/unions (authored by sammccall). Repository: rG LLVM Github Mon

[clang] bbf234b - [CodeCompletion] Complete designators for fields in anonymous structs/unions

Author: Sam McCall Date: 2022-01-11T00:58:49+01:00 New Revision: bbf234b56a82d1b9b7fa58f8b10f16d417500d9b URL: https://github.com/llvm/llvm-project/commit/bbf234b56a82d1b9b7fa58f8b10f16d417500d9b DIFF: https://github.com/llvm/llvm-project/commit/bbf234b56a82d1b9b7fa58f8b10f16d417500d9b.diff LO

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

dblaikie added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; Just came across this code today - it's /probably/ a problem

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9463 + + verifyFormat("void operator delete(void *foo) ATTRIB;"); + verifyFormat("void operator new(void *foo) ATTRIB;"); Please add a test for `operator delete[]`. Repository:

[PATCH] D116978: [clangd] Selection: Prune gtest TEST()s earlier

sammccall updated this revision to Diff 398757. sammccall added a comment. Use the other end too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116978/new/ https://reviews.llvm.org/D116978 Files: clang-tools-extra/clangd/Selection.cpp Index: cl

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood updated this revision to Diff 398756. LegalizeAdulthood added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/clang-tidy

[PATCH] D116978: [clangd] Selection: Prune gtest TEST()s earlier

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When searching for AST nodes

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood updated this revision to Diff 398754. LegalizeAdulthood added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116518/new/ https://reviews.llvm.org/D116518 Files: clang/docs/LibASTMatchersReference.html clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

egorzhdan updated this revision to Diff 398753. egorzhdan added a comment. Fix clang-format warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116412/new/ https://reviews.llvm.org/D116412 Files: clang/include/clang/AST/DeclObjC.h clang/lib/

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c33b0ec976: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang-tools-extra] a2c33b0 - [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

Author: Richard Date: 2022-01-10T15:44:12-07:00 New Revision: a2c33b0ec976c894dc45558d0b50c9c2fe87e1da URL: https://github.com/llvm/llvm-project/commit/a2c33b0ec976c894dc45558d0b50c9c2fe87e1da DIFF: https://github.com/llvm/llvm-project/commit/a2c33b0ec976c894dc45558d0b50c9c2fe87e1da.diff LOG:

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116412/new/ https://reviews.llvm.org/D116412 __

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

jhuber6 updated this revision to Diff 398748. jhuber6 added a comment. Undoing accidental clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116975/new/ https://reviews.llvm.org/D116975 Files: clang/lib/Driver/Driver.cpp clang/lib/Dri

[PATCH] D116840: [HIP] Fix device only linking for -fgpu-rdc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98ab43a1d209: [HIP] Fix device only linking for -fgpu-rdc (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] 98ab43a - [HIP] Fix device only linking for -fgpu-rdc

Author: Yaxun (Sam) Liu Date: 2022-01-10T17:38:02-05:00 New Revision: 98ab43a1d209875ce9cc39420d3e6af57ed0f5b2 URL: https://github.com/llvm/llvm-project/commit/98ab43a1d209875ce9cc39420d3e6af57ed0f5b2 DIFF: https://github.com/llvm/llvm-project/commit/98ab43a1d209875ce9cc39420d3e6af57ed0f5b2.dif

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: guansong, hiraditya, inglorion, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

craig.topper added a comment. In D116935#3232584 , @fhahn wrote: > Rebased and made sure comments are consistent between different folders. > > In D116935#3232227 , @craig.topper > wrote: > >> In D116935#3232203

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

efriedma added a comment. I'll just note here that doing this globally is likely to have unexpected results... consider, for example: #include void f() { long x = M_PI; } Currently, the implicit conversion warning points into math.h. That said, I don't see any problem with the current imp

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext, std::move(DiagUnknownTrai

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:420 + auto FromTy = symRHS->getType(); + auto ToTy = RLocAsInt->getType(this->Context); + symRHS = this->getSymbolManager().getCastSymbol(symRHS, FromTy, ToTy); AS

[PATCH] D111566: [SYCL] Fix function pointer address space

rjmccall added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11494 + const Type *TypePtr = T.getTypePtr(); + return TypePtr->isFunctionType() + ? llvm::DataLayout(getTargetInfo().getDataLayoutString()) You can just do `T->isFunctionType(

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks great with the option flag. Landing this patch will enable more people to test the new mode and produce feedback on whether the constraint solver keeps working well enough in presence of

[PATCH] D116967: [HIP] Fix device malloc/free

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:80 +#if HIP_VERSION_MAJOR > 4 || (HIP_VERSION_MAJOR == 4 && HIP_VERSION_MINOR >= 5) +extern "C" __device__ unsigne

[libunwind] 914fffc - [libunwind][cmake] Create `LIBUNWIND_INSTALL_INCLUDE_DIR` CACHE PATH

Author: John Ericson Date: 2022-01-10T21:31:52Z New Revision: 914fffc7f2492a1e4bc419a80c30fdb3f9440698 URL: https://github.com/llvm/llvm-project/commit/914fffc7f2492a1e4bc419a80c30fdb3f9440698 DIFF: https://github.com/llvm/llvm-project/commit/914fffc7f2492a1e4bc419a80c30fdb3f9440698.diff LOG:

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added a comment. In D111566#3228949 , @rjmccall wrote: > Block pointers are actually data pointers and should stay in the generic > address space if they don't have an address space qualifier. That might > require new logic. Thanks! I kept th

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews updated this revision to Diff 398723. eandrews added a comment. Implemented review comment to move logic into function (`getTargetAddressSpace`) as opposed to call site. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 Files: clang/

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810-4811 + + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build)\n", +

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

rjmccall added a comment. Yes, this LGTM implementation-wise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115440/new/ https://reviews.llvm.org/D115440 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D116967: [HIP] Fix device malloc/free

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. yaxunl requested review of this revision. ROCm 4.5 device library introduced `__ockl_dm_alloc` and `__oclk_dm_dealloc` for supporting device side malloc/free. This patch redefines device malloc/free to use these functions. It a

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:41 + // Reserve space now to prevent reallocation. + Captures.reserve(Block->getNumCaptures()); Does this actually work? It's a hashtable, so I'm worried about the possibility of e.g

[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

ArcsinX created this revision. ArcsinX added reviewers: aaronpuchert, hintonda, NoQ, Szelethus, lebedev.ri. Herald added subscribers: manas, wenlei, steakhal, ASDenysPetrov, usaxena95, dkrupp, donat.nagy, kadircet, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. ArcsinX

[PATCH] D116960: [ADT] Add an in-place version of toHex()

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Mostly LGTM, just a couple of comments on the drive-by changes to `hexdigit()` (I might split that (and the new call in toHex()) into a separate commit, but if you keep them here pleas

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

erichkeane added a comment. In D98895#3232453 , @nickdesaulniers wrote: > Linus Torvalds' thoughts > > on the patches as a result of this change. > >>

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810-4811 + + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

nickdesaulniers added a comment. Linus Torvalds thoughts on the patches as a result of this change. > Those uses of 1E6L were perhaps strange, but they were only used in > constant compile-tim

[PATCH] D112718: Add intrinsics and builtins for PTX atomics with semantic orders

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:1057 + +BUILTIN(__nvvm_atom_xchg_global_i, "iiD*i", "n") +TARGET_BUILTIN(__nvvm_atom_cta_xchg_global_i, "iiD*i", "n", SM_60) t4c1 wrote: > tra wrote: > > t4c1 wrote: > > > tra wrot

[PATCH] D116596: [clang][dataflow] Add transfer functions for assignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7481f6ee591: [clang][dataflow] Add transfer functions for assignment (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] e7481f6 - [clang][dataflow] Add transfer functions for assignment

Author: Stanislav Gatev Date: 2022-01-10T19:35:50Z New Revision: e7481f6ee591678e3a70569c2e87597f148adb3e URL: https://github.com/llvm/llvm-project/commit/e7481f6ee591678e3a70569c2e87597f148adb3e DIFF: https://github.com/llvm/llvm-project/commit/e7481f6ee591678e3a70569c2e87597f148adb3e.diff LO

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5b387988bd4: Revert "[CodeGen] Mark fma as const for Android" (authored by alxu, committed by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116755/

[clang] f5b3879 - Revert "[CodeGen] Mark fma as const for Android"

Author: Alex Xu (Hello71) Date: 2022-01-10T11:31:09-08:00 New Revision: f5b387988bd4885a973f35deaf3881524f526e3f URL: https://github.com/llvm/llvm-project/commit/f5b387988bd4885a973f35deaf3881524f526e3f DIFF: https://github.com/llvm/llvm-project/commit/f5b387988bd4885a973f35deaf3881524f526e3f.d

[PATCH] D116960: [ADT] Add an in-place version of toHex()

hans updated this revision to Diff 398704. hans added a comment. (avoid toStringRef -> arrayRefFromStringRef by reshuffling the toHex overloads) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116960/new/ https://reviews.llvm.org/D116960 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:666-675 + HasHBC |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A || +ArchKind == llvm::AArch64::ArchKind::ARMV9_3A; + + // Check features that are manually disabled by command li

[PATCH] D116960: [ADT] Add an in-place version of toHex()

hans updated this revision to Diff 398699. hans added a comment. Trying to upload the right diff this time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116960/new/ https://reviews.llvm.org/D116960 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/include/llvm/ADT/StringExtras.h llv

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

craig.topper added a comment. In D116935#3232203 , @lebedev.ri wrote: > In D116935#3232126 , @craig.topper > wrote: > >> If I remember correctly, the Or and And folds for 0 and all 1s are there to >> optimize b

[PATCH] D116960: [ADT] Add an in-place version of toHex()

hans created this revision. hans added reviewers: thakis, arlosi, rnk. Herald added subscribers: dexonsmith, hiraditya. hans requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. and use that to simplify MD5's hex string code which was previ

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

tyb0807 updated this revision to Diff 398698. tyb0807 edited the summary of this revision. tyb0807 added a comment. Update patch author in commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 F

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

tyb0807 updated this revision to Diff 398697. tyb0807 added a comment. Update patch author in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

lebedev.ri added a comment. In D116935#3232126 , @craig.topper wrote: > If I remember correctly, the Or and And folds for 0 and all 1s are there to > optimize bitfield codegen for the frontend. Are we losing that optimization > if this patch goes in be

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

futuarmo updated this revision to Diff 398695. futuarmo edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unitte

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

tyb0807 updated this revision to Diff 398693. tyb0807 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64

[PATCH] D116824: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rG988c3f5f9692: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers (authored by logan-5). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] 988c3f5 - [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers

Author: Logan Smith Date: 2022-01-10T10:35:04-08:00 New Revision: 988c3f5f96925e3bcd757043314e345b8f65589f URL: https://github.com/llvm/llvm-project/commit/988c3f5f96925e3bcd757043314e345b8f65589f DIFF: https://github.com/llvm/llvm-project/commit/988c3f5f96925e3bcd757043314e345b8f65589f.diff L

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

ahoppen added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:179 /// directory is suppressed. - std::vector SearchDirs; - /// Whether the DirectoryLookup at the corresponding index in SearchDirs has - /// been successfully used to lookup a file. - std:

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

craig.topper added a comment. If I remember correctly, the Or and And folds for 0 and all 1s are there to optimize bitfield codegen for the frontend. Are we losing that optimization if this patch goes in before switching clang to InstSimplifyFolder? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

hans added a comment. In D116835#3228296 , @arlosi wrote: > I submitted a change last year to hook up the /ZH option, but it was never > completed. https://reviews.llvm.org/D98438 I just put some comments on that. I'm happy to provide review if you thin

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

hans added a comment. Sorry for not seeing this sooner. I think this looks great, just a few comments, and it also needs tests. Comment at: clang/include/clang/Basic/CodeGenOptions.def:303 +/// Set debug info source file hashing algorithm +ENUM_CODEGENOPT(DebugSrcHashAlgorithm

[PATCH] D72940: Add a support for clang tidy to import another configurations files from .clang-tidy

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Herald added a subscriber: carlosgalvezp. Please upload a full context diff so that the changes can be properly viewed. Thanks. Repository: rG LLVM Github M

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

LegalizeAdulthood added a comment. I have run into this line ending problem with python scripts as well. If you follow the advice on the "getting started" pages, then you will have checked out the entire repo with Unix line endings, but when you run python scripts like add_new_check.py for clang-t

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

aaron.ballman added a comment. In D116774#3227280 , @jrtc27 wrote: > The fact that va_list is in the std namespace does leak out into > __builtin_dump_struct, possibly the odd other place, and of course to > external AST consumers. It can also leak out

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/boost/UseRangeBasedForLoopCheck.cpp:68 + ColToken->getLocation()), + (llvm::Twine("for(") + VariableString + " : ").str()); + } ---

Re: [clang] 80e2c58 - [clang] Remove redundant member initialization (NFC)

Hi Martin, I've reverted the patch as 7485e6c7e9c7d484ba1faf2dc53c9b598286455b. Thank you for reporting the problem! Kazu Hirata On Mon, Jan 10, 2022 at 3:35 AM Martin Storsjö wrote: > On Sun, 9 Jan 2022, Kazu Hirata via cfe-commits wrote: > > > > > Author: Kazu Hirata > > Date: 2022-01-09T0

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cf7e61a42c7: [clang][HeaderSearch] Support framework includes in suggestPath... (authored by dgoldman). Changed prior to commit: https://reviews.

[clang] 0cf7e61 - [clang][HeaderSearch] Support framework includes in suggestPath...

Author: David Goldman Date: 2022-01-10T12:25:53-05:00 New Revision: 0cf7e61a42c7a08b0332204f1b60aa9fd1562089 URL: https://github.com/llvm/llvm-project/commit/0cf7e61a42c7a08b0332204f1b60aa9fd1562089 DIFF: https://github.com/llvm/llvm-project/commit/0cf7e61a42c7a08b0332204f1b60aa9fd1562089.diff

  1   2   3   >