[clang] 62b59c5 - [NFC][clang] Fix comments.

Author: Shao-Ce SUN Date: 2022-01-05T14:49:03+08:00 New Revision: 62b59c59a6d9bab0c45808dcb96cf09047b9cba1 URL: https://github.com/llvm/llvm-project/commit/62b59c59a6d9bab0c45808dcb96cf09047b9cba1 DIFF: https://github.com/llvm/llvm-project/commit/62b59c59a6d9bab0c45808dcb96cf09047b9cba1.diff L

[PATCH] D115301: [clangd] Don't index __reserved_names in headers.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/SourceCode.h:334 +/// Returns true if Name is reserved, like _Foo or __Vector_base. +inline bool isReservedName(llvm::StringR

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2384 +if ((CodeGenOpts.EnableNoundefAttrs || + CodeGenOpts.SanitizeMemoryParamRetval) && +ArgNoUndef) vitalybuka wrote: > @eugenis Would be better to force CodeGenOpts.

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added a subscriber: eugenis. vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1675 + PosFlag, NegFlag, + BothFlags<[], "eager param-retval uninitialized use detection in MemorySanitizer">>, +Group; Mayb

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

vitalybuka added a comment. this patch depends on D116633 , but D116633 is useless without this one a better patch order is : 1. llvm 2. clang 3. compiler-rt (but if it's just test which uses clang flag it should be OK merge w

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke added a comment. Thanks for your review! Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:177-178 const auto &CurrentParam = *FunctionDecl->getParamDecl(Index); +if (IsExplicitTemplateSpecialization && Function != FunctionDecl

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/test/Sema/warn-calls-without-prototype.c:39 + return a + b +c; +} + delcypher wrote: > @NoQ Any ideas about this? It seems kind of weird that when merging > `not_a_prototype3` prototype with the K&R style defi

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf updated this revision to Diff 397443. qiucf added a comment. Only emit the flags when any instance of `long double` is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016 Files: clang/lib/CodeGe

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

ChuanqiXu closed this revision. ChuanqiXu added a comment. This should be covered in: https://reviews.llvm.org/D115790 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100282/new/ https://reviews.llvm.org/D100282 _

[clang] c75cedc - [Coroutines] Set presplit attribute in Clang and mlir

Author: Chuanqi Xu Date: 2022-01-05T10:25:02+08:00 New Revision: c75cedc237f9747c5d5fe2a312d5ccc8531e2e70 URL: https://github.com/llvm/llvm-project/commit/c75cedc237f9747c5d5fe2a312d5ccc8531e2e70 DIFF: https://github.com/llvm/llvm-project/commit/c75cedc237f9747c5d5fe2a312d5ccc8531e2e70.diff LO

[PATCH] D116638: [ClangFormat] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

andmis created this revision. andmis added a reviewer: MyDeveloperDay. andmis added a project: clang-format. andmis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this patch, when ColumnWidth: 0, all JS imports of the form `import

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5435-5442 +/// Matches two consecutive statements within a compound statement. +/// +/// Given +/// \code +/// { if (x > 0) ret

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the Sema support f

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked always_inline might not be inlined properly." + >, + InGroup; Quuxplusone wrote: > Chua

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added a comment. Patch https://reviews.llvm.org/D116636 demonstrates the changes needed if the warning was enabled by default: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116635/new/ https://reviews.llvm.org/D116635 __

[PATCH] D116636: [WIP] Enable `-Wstrict-calls-without-prototype` by default

delcypher added a comment. This change depends on https://reviews.llvm.org/D116635. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116636/new/ https://reviews.llvm.org/D116636 ___ cfe-commits mailing list

[PATCH] D116636: [WIP] Enable `-Wstrict-calls-without-prototype` by default

delcypher created this revision. delcypher added reviewers: arphaman, rapidsna, fcloutier, NoQ. delcypher requested review of this revision. Herald added a project: clang. This patch enables the `-Wstrict-calls-without-prototype` warning by default and fixes the existing clang test suite to pass.

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/test/Sema/warn-calls-without-prototype.c:39 + return a + b +c; +} + @NoQ Any ideas about this? It seems kind of weird that when merging `not_a_prototype3` prototype with the K&R style definition of `not_a_pro

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher updated this revision to Diff 397431. delcypher added a comment. Add another test case for function definitions without prototypes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116635/new/ https://reviews.llvm.org/D116635 Files: clang

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher created this revision. delcypher added reviewers: arphaman, rapidsna, fcloutier, NoQ. delcypher requested review of this revision. Herald added a project: clang. The warning is currently disabled by default but can be enabled with `-Wstrict-calls-without-prototype`. Enabling it by defaul

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

kda created this revision. kda added a reviewer: vitalybuka. Herald added subscribers: ormris, hiraditya. kda requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. follow up to https://reviews.llvm.org/D1

[PATCH] D116503: [clang] Add arguments for silencing unused argument warnings for some but not all arguments

MaskRay added a comment. > Add arguments for silencing unused argument warnings for some but not all > arguments More searchable subject may be `Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings` Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116503: [clang] Add arguments for silencing unused argument warnings for some but not all arguments

MaskRay added a comment. I know some folks who dislike aggressive unused command line option diagnostics but also worry about -Qunused-arguments -Wno-unused-command-line-argument affecting the entire command line. start/end looks good to me. Comment at: clang/docs/ClangComman

[clang] d007e66 - [docs] Re-generate ClangCommandLineReference.rst

Author: Fangrui Song Date: 2022-01-04T16:52:24-08:00 New Revision: d007e66cb6f58042e043645fda3463de44eb4756 URL: https://github.com/llvm/llvm-project/commit/d007e66cb6f58042e043645fda3463de44eb4756 DIFF: https://github.com/llvm/llvm-project/commit/d007e66cb6f58042e043645fda3463de44eb4756.diff

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda created this revision. kda added a reviewer: vitalybuka. Herald added subscribers: dexonsmith, dang. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the introduction of this flag, it is no longer necessary to enable noundef an

[clang] 37be748 - Revert "[clang][ObjC] Add fix it for missing methods in impl"

Author: Rumeet Dhindsa Date: 2022-01-04T16:43:54-08:00 New Revision: 37be74885946f18dbeb70343ad659924c61d2549 URL: https://github.com/llvm/llvm-project/commit/37be74885946f18dbeb70343ad659924c61d2549 DIFF: https://github.com/llvm/llvm-project/commit/37be74885946f18dbeb70343ad659924c61d2549.diff

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc99b2c63169d: CUDA/HIP: Allow __int128 on the host side (authored by linjamaki, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] c99b2c6 - CUDA/HIP: Allow __int128 on the host side

Author: Henry Linjamäki Date: 2022-01-04T16:09:26-08:00 New Revision: c99b2c63169d5aa6499143078790cb3eb87dee45 URL: https://github.com/llvm/llvm-project/commit/c99b2c63169d5aa6499143078790cb3eb87dee45 DIFF: https://github.com/llvm/llvm-project/commit/c99b2c63169d5aa6499143078790cb3eb87dee45.dif

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

arphaman added a comment. Thanks! I think your tests don't actually test the added code, can you check if you can parse a mapping like `ios_tvos` in the constructed SDK settings? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116615/new/ https://re

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

arphaman added a comment. I think we would still want to diagnose any mismatches between `class` properties that override a `class` property in the superclass. do you think that would be useful? You can adjust the lookup to take that into account. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116618: [clangd] Use the localSourceRange as the default claimed range for typelocs.

sammccall added a comment. OK, I hacked up this and your other patch into https://reviews.llvm.org/D116630. The TypeLoc part seems a little more principled there, because: - most types are treated the same as any other nodes - the types that are treated differently have a precise reason, and we

[PATCH] D116630: [clangd] Handle declarators more consistently in Selection.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Because declarators n

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

rnk added a comment. > clang actually refuses taking the address of a stdcall function if it has an > incomplete type parameter: I was going to say, I thought I remembered fixing this problem, and I guess that's how I fixed it: with errors. MSVC doesn't add stdcall mangling suffixes to non-ext

[PATCH] D116618: [clangd] Use the localSourceRange as the default claimed range for typelocs.

sammccall added a comment. In D116618#3220744 , @sammccall wrote: > - claim their full range, but in the opposite order (parents before children) To refine this a little more, for declarator type nodes: - first, we should recurse into non-declarator chi

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: pengfei, tpr. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the initial s

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5435-5442 +/// Matches two consecutive statements within a compound statement. +/// +/// Given +/// \code +/// { if (x > 0) return true; return false; } +/// \endcode +/// compoundStm

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

aaron.ballman resigned from this revision. aaron.ballman added a comment. Resigning only because I don't think I have strong enough Python skills to give a quality review. I didn't spot anything that concerned me specific to this patch though. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

rnk added a comment. Nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

david-salinas abandoned this revision. david-salinas added a comment. Abandoning. Will use D115960 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116547/new/ https://reviews.llvm.org/D116547 _

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

LegalizeAdulthood added a comment. I opened a similar issue for converting Qt's foreach to a range for loop . However this check lands, it should be a simple generalization to have it process Qt foreach loops as well, so perhaps a check name li

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker updated this revision to Diff 397394. collinbaker added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115049/new/ https://reviews.llvm.org/D115049 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/Dri

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

LegalizeAdulthood added a comment. If there are no new comments by the end of the week, I'm going to accept this revision and commit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/ https://reviews.llvm.org/D56343

[PATCH] D116618: [clangd] Use the localSourceRange as the default claimed range for typelocs.

sammccall added a comment. This is neat, and I we're getting closer to the principled answer. After staring at this patch for a while, and seeing what arrays, functions, and now parens have in common, I finally understand. The problem is *declarators*. Declarators are inside-out: `((*x)[](double

[PATCH] D116623: [clangd][WIP] Remove the earlySourceRange hack in SelectionTree.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is an attempt to remove the existin

[PATCH] D113146: [Sema] Fix the assertion in Sema::ActOnDependentMemberExpr

ychen added a comment. Richard seems very busy. I just committed this based on Aaron's LGTM. Richard could still review this at any time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113146/new/ https://reviews.llvm.org/D113146 _

[PATCH] D113146: [Sema] Fix the assertion in Sema::ActOnDependentMemberExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe902ffe6d756: [Sema] Fix the assertion in Sema::ActOnDependentMemberExpr (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] e902ffe - [Sema] Fix the assertion in Sema::ActOnDependentMemberExpr

Author: Yuanfang Chen Date: 2022-01-04T13:08:12-08:00 New Revision: e902ffe6d7560f708b76edaa53d75edcb5d49a3f URL: https://github.com/llvm/llvm-project/commit/e902ffe6d7560f708b76edaa53d75edcb5d49a3f DIFF: https://github.com/llvm/llvm-project/commit/e902ffe6d7560f708b76edaa53d75edcb5d49a3f.diff

[PATCH] D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers

aaronpuchert added a comment. In D76038#3219500 , @zahiraam wrote: > This change is generating this crash discussed here: > https://bugs.llvm.org/show_bug.cgi?id=49834 Now migrated to https://github.com/llvm/llvm-project/issues/49178. > @aaronpuchert do

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGdd72ae3dcc68: [clang][ObjC] Add fix it for missing methods in impl (authored by dgoldman). Repository:

[clang] dd72ae3 - [clang][ObjC] Add fix it for missing methods in impl

Author: David Goldman Date: 2022-01-04T15:57:58-05:00 New Revision: dd72ae3dcc6895f95e1203b40aabcb069c76a0ab URL: https://github.com/llvm/llvm-project/commit/dd72ae3dcc6895f95e1203b40aabcb069c76a0ab DIFF: https://github.com/llvm/llvm-project/commit/dd72ae3dcc6895f95e1203b40aabcb069c76a0ab.diff

[PATCH] D116618: [clangd] Use the localSourceRange as the default claimed range for typelocs.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:234 )cpp", - "FunctionProtoTypeLoc", + "PointerTypeLoc", }, these two new behavior changes seem to be more appropriate. Repositor

[PATCH] D116618: [clangd] Use the localSourceRange as the default claimed range for typelocs.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. It also fixes a bug where SelectionTree

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

egorzhdan created this revision. Herald added a subscriber: dexonsmith. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change makes it possible to extract iOS-to-another-platform version mappings from `VersionMap` in the `S

RE: [clang] b8e03be - [PS4][DWARF] Explicitly set default DWARF version to 4

Follow-up to test this explicitly (I thought it was already!) in https://github.com/llvm/llvm-project/commit/fa17c0e27ac5e874e0d0ce3be9146ee3f5a99016 Thanks for catching this! --paulr From: David Blaikie Sent: Monday, December 6, 2021 10:44 PM To: Robinson, Paul ; Paul Robinson Cc: cfe-commits

[clang] fa17c0e - [PS4] Verify the default DWARF version is 4.

Author: Paul Robinson Date: 2022-01-04T11:57:10-08:00 New Revision: fa17c0e27ac5e874e0d0ce3be9146ee3f5a99016 URL: https://github.com/llvm/llvm-project/commit/fa17c0e27ac5e874e0d0ce3be9146ee3f5a99016 DIFF: https://github.com/llvm/llvm-project/commit/fa17c0e27ac5e874e0d0ce3be9146ee3f5a99016.diff

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel updated this revision to Diff 397356. ymandel added a comment. ignore implicit and add deprecations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116377/new/ https://reviews.llvm.org/D116377 Files: clang/include/clang/Tooling/Transformer

[PATCH] D116611: [clang][scandeps] Update Module Cache Path in Test

lenary created this revision. lenary added reviewers: rsmith, Bigcheese. lenary requested review of this revision. Herald added a project: clang. This fixes the test introduced in D114206 so it no longer writes to the current working directory. Repository: r

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary added inline comments. Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6 +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > %t.dir/build/vfs.yaml +// RUN: clang-scan-deps -compilation-database %t.dir/build/compile-commands.json -j 1 -format experimen

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2021 + // fields imported) at that time without multiple AST import passes. + To->setCompleteDefinition(true); // Complete the definition even if error is returned. So `DefinitionComplet

[PATCH] D116592: [clang-format] Missing space after cast in a macro

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1887 + // parentheses, look past it as these might be chained casts. + if (LeftOfParens->is(tok::r_paren) && !LeftOfParens->is(TT_CastRParen)) { if (!LeftOfParens->MatchingPar

[PATCH] D116583: Change the default optimisation level of PTXAS from -O0 to -O3. This makes the optimisation levels of PTXAS and the ptxjitcompiler equal (ptxjitcompiler defaults to -O3).

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:433 } else { -// If no -O was passed, pass -O0 to ptxas -- no opt flag should correspond -// to no optimizations, but ptxas's default is -O3. -CmdArgs.push_back("-O0"); +// If no -O was

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

sammccall added a comment. Alright, the implementation looks good. I think just a question of what to do when firing on @implementation. I'd suggest one of: - generating the interface too, you have almost allthe code - not supporting @implementation yet We can also keep the current behavior if

[PATCH] D116592: [clang-format] Missing space after cast in a macro

owenpan added a comment. LGTM except for the nit. Comment at: clang/lib/Format/TokenAnnotator.cpp:1887 + // parentheses, look past it as these might be chained casts. + if (LeftOfParens->is(tok::r_paren) && !LeftOfParens->is(TT_CastRParen)) { if (!LeftOfParen

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added a comment. The summary for the patch explains what's being added, but there's really no information as to why it's being added. Why do we need these builtins? Comment at: clang/include/clang/AST/Type.h:743 + bool isReferenceable() const; + --

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:2241 +method->print(Out, Policy); +Str.append(" {\n\n}\n\n"); + sammccall wrote: > sammccall wrote: > > nit: mixing string & output stre

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman updated this revision to Diff 397336. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116417/new/ https://reviews.llvm.org/D116417 Files: clang/lib/Sema

[clang] e1e74f6 - -Wmissing-prototypes: Don't warn in named namespaces nested in anonymous namespaces

Author: David Blaikie Date: 2022-01-04T10:08:23-08:00 New Revision: e1e74f6cd6ce41ce8303a5a91f29736808fccc36 URL: https://github.com/llvm/llvm-project/commit/e1e74f6cd6ce41ce8303a5a91f29736808fccc36 DIFF: https://github.com/llvm/llvm-project/commit/e1e74f6cd6ce41ce8303a5a91f29736808fccc36.diff

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c shchenz wrote: > Jake-Egan wrote: > > shchenz wrote: > > > Do we still need this?

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:91 + +struct LocationWithPadding { + SourceLocation Loc; sammccall wrote: > We try not to spend complex

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 397329. dgoldman marked 3 inline comments as done. dgoldman added a comment. Rebase + use new helpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane added a comment. Should be fixed here: 2edc21e8566be8fa9b20e0bb71a83af90ec9aa97 Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.llv

[clang] 2edc21e - Fix altivec regression caused by D115670 in Vec Const Eval

Author: Erich Keane Date: 2022-01-04T09:53:26-08:00 New Revision: 2edc21e8566be8fa9b20e0bb71a83af90ec9aa97 URL: https://github.com/llvm/llvm-project/commit/2edc21e8566be8fa9b20e0bb71a83af90ec9aa97 DIFF: https://github.com/llvm/llvm-project/commit/2edc21e8566be8fa9b20e0bb71a83af90ec9aa97.diff L

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary accepted this revision. lenary added a comment. LGTM! Thanks for your hard work on this! I think you've addressed @pbarrio's comments on this, and I'm not sure when he's back, so wait 48h before landing this, in case there are further comments. CHANGES SINCE LAST ACTION https://review

RE: [clang] 229c95a - [CodeCompletion] Signature help for aggregate initialization.

Yeah, our automation appears to have tripped up on the weird character in the name (which is why I noticed this in the first place). Easy enough to handle manually. Thanks, --paulr From: Sam McCall Sent: Tuesday, January 4, 2022 11:47 AM To: Robinson, Paul Cc: cfe-commits Subject: Re: [clang]

[PATCH] D116596: [clang][dataflow] Add transfer functions for assignment

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:34 +/// storage locations or values. +enum class SkipPast { + /// No indirections should be skipped past. I am just wondering if this is the right level

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 397322. mubashar_ marked 2 inline comments as done. mubashar_ added a comment. Enabled warning whenever +strict-align is present. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 Files: clang/include/cl

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman marked 3 inline comments as not done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:113 +if (MD->getMethodFamily() == OMF_init) { + Loc = effectiveEndLoc(MD, SM).getLocWithOffset(1); +} el

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 397321. dgoldman marked 11 inline comments as done. dgoldman added a comment. Some review fixes, still need to rebase for new changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.l

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/boost/CMakeLists.txt:8 BoostTidyModule.cpp + UseRangeBasedForLoopCheck.cpp UseToStringCheck.cpp I am wondering if this check is better placed in the modernize module? Maybe a

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b09313cd533: [funcattrs] Infer writeonly argument attribute [part 2] (authored by reames). Changed prior to commit: https://reviews.llvm.org/D115

[clang] 0b09313 - [funcattrs] Infer writeonly argument attribute [part 2]

Author: Philip Reames Date: 2022-01-04T09:07:54-08:00 New Revision: 0b09313cd53316eacbdc5e98d4ef00bef2c41d02 URL: https://github.com/llvm/llvm-project/commit/0b09313cd53316eacbdc5e98d4ef00bef2c41d02 DIFF: https://github.com/llvm/llvm-project/commit/0b09313cd53316eacbdc5e98d4ef00bef2c41d02.diff

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

reames added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:728 + } else if (CB.hasFnAttr(Attribute::WriteOnly) || + CB.dataOperandHasImpliedAttr(UseIndex, Attribute::WriteOnly)) { +IsWrite = true; nikic wrote

Re: [clang] 229c95a - [CodeCompletion] Signature help for aggregate initialization.

On Tue, Jan 4, 2022 at 5:39 PM wrote: > This commit appears to add a file "tl" which I suspect wasn't intended? > --paulr > Yes, I removed it in 10bb837feb22ad70dc4acc3d2cdb5be7f45d1c21. (A command-line mistake compounded by a careless git commit --amend -a) The filename also has a nonprintable

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

sammccall added a comment. Thanks, this looks good! Comment at: clang/lib/Sema/SemaDeclObjC.cpp:2237 +// a better place to put it. +std::string Str; +llvm::raw_string_ostream Out(Str); Str -> FixitStr The comment is IMO too verbose, maybe just "//

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille abandoned this revision. serge-sans-paille added a comment. Obsoleted by https://reviews.llvm.org/D116599 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/new/ https://reviews.llvm.org/D115798 ___ cfe-commits mailing lis

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda6b0d0b768e: [clang-format] Add an option to add a space between operator overloading and… (authored by rajatbajpai, committed by curdeius). Chang

[clang] da6b0d0 - [clang-format] Add an option to add a space between operator overloading and opening parentheses

Author: Rajat Bajpai Date: 2022-01-04T17:23:23+01:00 New Revision: da6b0d0b768e3ecb1af2fd9df2d98510f7aff45c URL: https://github.com/llvm/llvm-project/commit/da6b0d0b768e3ecb1af2fd9df2d98510f7aff45c DIFF: https://github.com/llvm/llvm-project/commit/da6b0d0b768e3ecb1af2fd9df2d98510f7aff45c.diff

[PATCH] D116414: [AST] Produce ReturnStmt containing RecoveryExpr when type is wrong

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG71059f26d313: [AST] Produce ReturnStmt containing RecoveryExpr when type is wrong (authored by sammccall)

[clang] 71059f2 - [AST] Produce ReturnStmt containing RecoveryExpr when type is wrong

Author: Sam McCall Date: 2022-01-04T17:07:55+01:00 New Revision: 71059f26d31398d109be057e35bb8c5960d8aaf6 URL: https://github.com/llvm/llvm-project/commit/71059f26d31398d109be057e35bb8c5960d8aaf6 DIFF: https://github.com/llvm/llvm-project/commit/71059f26d31398d109be057e35bb8c5960d8aaf6.diff LO

[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

jpienaar accepted this revision. jpienaar added a comment. This revision is now accepted and ready to land. Looks reasonable as an option/this is another way to make it explicit that param is unused. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unused-parameters.

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane added a comment. Hi! Sorry for the delay, I just got back from my christmas break. I'll take a look later today/this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.llvm.org/D115670

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

nikic added a comment. I'm generally on board with this change. After D116110 , the `AttrBuilder` is only used in situations where we actually expect all the added attributes to be converted to `Attribute`s in any case, so we don't lose anything by storing them

[PATCH] D111457: [clang][test] Add lit helper for windows paths

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: This isn't really a separator, this

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille updated this revision to Diff 397298. serge-sans-paille added a comment. upload correct patch version CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, rnk, dexonsmith. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, ormris, dcaballe, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

yaxunl added a comment. In D116216#3209335 , @pvellien wrote: > @yaxunl It would be very much helpful to know how to write test coverage for > this particular patch? thanks there is a lit test amdgpu-asan.cu. You can add a call of print to that test an

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/boost/UseRangeBasedForLoopCheck.cpp:60 + +auto Loc = MacroNameToken.getLocation(); +auto Diag = Check->diag(Loc, "use range-based for loop instead of %0") Please specify type e

[PATCH] D116415: [Arm] Remove duplicate CPU tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aea5d5951dc: [Arm] Remove duplicate CPU tests (authored by tmatheson). Changed prior to commit: https://reviews.llvm.org/D116415?vs=396681&id=397

[clang] 8aea5d5 - [Arm] Remove duplicate CPU tests

Author: Tomas Matheson Date: 2022-01-04T15:22:10Z New Revision: 8aea5d5951dc7d2130ad671423830a45e215c540 URL: https://github.com/llvm/llvm-project/commit/8aea5d5951dc7d2130ad671423830a45e215c540 DIFF: https://github.com/llvm/llvm-project/commit/8aea5d5951dc7d2130ad671423830a45e215c540.diff LOG

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie updated this revision to Diff 397289. OikawaKirie added a comment. Replace on-demand-parsing with loading AST file for the new test case. Tested on Linux and MacOS(x86). If it can also pass the CI test on Windows, I think we can have another try on landing this patch. Besides, as men

  1   2   >