jpienaar accepted this revision. jpienaar added a comment. This revision is now accepted and ready to land.
Looks reasonable as an option/this is another way to make it explicit that param is unused. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unused-parameters.rst:48 + +.. option:: misc-unused-parameters.CommentOutUnusedParameters + ---------------- Could we flip this? ElideUnusedParameterNames with default value false: eliding drops local information and I'd rather that be explicit in the name. CommentOut is still the default with the current naming, but it feels more optional for some reason to me. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116488/new/ https://reviews.llvm.org/D116488 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
