[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray added inline comments. Comment at: clang/lib/AST/APValue.cpp:637-639 + // Nothing we can do about a sequence that is not null-terminated + if (!Data[--Size].getInt().isZero()) +return false; lichray wrote: > rsmith wrote: > > lichray wrote: > > > rs

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/float128-ld-incompatibility.cpp:13 +long double ld{qf()}; // expected-error {{non-constant-expression cannot be narrowed from type '__float128' to 'long double' in initializer list}} expected-note {{inser

[PATCH] D108901: [Sparc] Create an error when `__builtin_longjmp` is used

This revision was automatically updated to reflect the committed changes. Closed by commit rGeeb4266f8137: [Sparc] Create an error when `__builtin_longjmp` is used (authored by xtkoba, committed by brad). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] eeb4266 - [Sparc] Create an error when `__builtin_longjmp` is used

Author: Tee KOBAYASHI Date: 2021-12-03T23:41:50-05:00 New Revision: eeb4266f8137c232f0f218a727dd12b5d4f52adc URL: https://github.com/llvm/llvm-project/commit/eeb4266f8137c232f0f218a727dd12b5d4f52adc DIFF: https://github.com/llvm/llvm-project/commit/eeb4266f8137c232f0f218a727dd12b5d4f52adc.diff

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray added inline comments. Comment at: clang/lib/AST/APValue.cpp:637-639 + // Nothing we can do about a sequence that is not null-terminated + if (!Data[--Size].getInt().isZero()) +return false; rsmith wrote: > lichray wrote: > > rsmith wrote: > > > We

Re: Maintenance works at llvm lab today at 7PM PST

LLVM lab and build bot are back to normal work. Thanks Galina On Fri, Oct 1, 2021 at 4:50 PM Galina Kistanova wrote: > Hello everyone, > > LLVM lab and build bot will be unavailable for about an hour starting from > 7:00 PM PST today for some maintenance work. > > Thank you for understanding.

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1540 // Diagnose attempts to convert between __ibm128, __float128 and long double - // where such conversions currently can't be handled. + // in arithmetic or comparison. if (unsupporte

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. In D115061#3170908 , @HazardyKnusperkeks wrote: > No I don't think there is a performance penalty. **I** just don't like using > pointers. I'm happ

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

owenpan added a comment. How about naming `I[-1]` as well? And maybe `I[i + 1]` too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 ___ cfe-commits mailing lis

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 391780. ellis added a comment. Add warning when debug info is missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/BackendUtil.cpp comp

Maintenance works at llvm lab today at 6PM PST

Hello everyone, LLVM lab and build bot will be unavailable for about an hour starting from 6:00 PM PST today for maintenance works. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 4 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3464-3483 + * ``RCPS_TwoLines`` (in configuration: ``TwoLines``) +The clause always gets its own line, and the content of the cla

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

MaskRay accepted this revision. MaskRay added a comment. LGTM. Comment at: clang/lib/Driver/ToolChain.cpp:545 +const char *ToolChain::getDefaultLinker() const { + if (StringRef(CLANG_DEFAULT_LINKER).empty()) +return "ld"; `CLANG_DEFAUALT_LINKER[0] == '\0'`

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

rsmith added inline comments. Comment at: clang/lib/AST/APValue.cpp:637-639 + // Nothing we can do about a sequence that is not null-terminated + if (!Data[--Size].getInt().isZero()) +return false; lichray wrote: > rsmith wrote: > > We should drop all trail

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray added inline comments. Comment at: clang/lib/AST/APValue.cpp:628-629 +static bool TryPrintAsStringLiteral(raw_ostream &Out, const ArrayType *ATy, +const APValue *Data, size_t Size) { + if (Size == 0) rsmith wrote: >

[PATCH] D114124: [clang][ARM] only check -mtp=cp15 for non-asm sources

nickdesaulniers updated this revision to Diff 391755. nickdesaulniers added a comment. - try to fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114124/new/ https://reviews.llvm.org/D114124 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D114124: [clang][ARM] only check -mtp=cp15 for non-asm sources

nickdesaulniers updated this revision to Diff 391754. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114124/new/ https://reviews.llvm.org/D114

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

HazardyKnusperkeks added a comment. No I don't think there is a performance penalty. **I** just don't like using pointers. I'm happy to drop this, if the Style says to use pointers. But from what I've seen in clang-format pointers are mostly used when it can be null, but there is a wild mix.

[PATCH] D114124: [clang][ARM] only check -mtp=cp15 for non-asm sources

nickdesaulniers updated this revision to Diff 391752. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114124/new/ https://reviews.llvm.org/D114124 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/li

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1294-1296 + Previous->isOneOf(tok::l_paren, tok::comma, tok::colon, TT_BinaryOperator, +TT_ConditionalExpr) && !Previous->isOneOf(TT_DictLiteral, T

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:961 + DB.finalize(); +} + } kyulee wrote: > I think when `-debug-info-correlate` is used without debug info, we should > fail or emit a warning here instead

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 391744. lichray added a comment. Ensure the ellipses output is never shorter than the normal ones (will look at review comments later) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

salman-javed-nz accepted this revision. salman-javed-nz added a comment. This revision is now accepted and ready to land. LGTM. The use of `mutable` with public inheritence is all over the clang-tools-extra code. See `class SwapIndex : public SymbolIndex`. CHANGES SINCE LAST ACTION https://re

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

rsmith added inline comments. Comment at: clang/lib/AST/APValue.cpp:628-629 +static bool TryPrintAsStringLiteral(raw_ostream &Out, const ArrayType *ATy, +const APValue *Data, size_t Size) { + if (Size == 0) Is there anything

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for non-thumb cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f95bc7dc183: [clang][ARM] relax -mtp=cp15 for non-thumb cases (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 9f95bc7 - [clang][ARM] relax -mtp=cp15 for non-thumb cases

Author: Nick Desaulniers Date: 2021-12-03T14:00:00-08:00 New Revision: 9f95bc7dc18390199553cf2ea3bfcdc6a95717ef URL: https://github.com/llvm/llvm-project/commit/9f95bc7dc18390199553cf2ea3bfcdc6a95717ef DIFF: https://github.com/llvm/llvm-project/commit/9f95bc7dc18390199553cf2ea3bfcdc6a95717ef.di

[PATCH] D113319: [clang-format] Improve require and concept handling

Quuxplusone added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3424 +templates or between template and function delcarations. In case of +after the function delcaration it tries to stick to this. + `s/delca/decla/g` `s/Preceeding/Pr

[PATCH] D115065: [clang-format][NFC] Merge two calls of isOneOf

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. I guess this is matter of taste whether to call `isOneOf` separately for `TokenKind`s and for `TokenType`s (but +1 for removing the repetition). Repository: rG LLVM Github Monorepo CHA

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

Quuxplusone added a comment. FWLIW, I'm strongly in favor of "Pass out-parameters by pointer," for the reason Marek said (and the reason Google, Bloomberg, Facebook, Mongo, etc, do it) — it makes life easier for the reader of the calling code. Especially for e.g. `addNextStateToQueue(Penalty, N

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

curdeius added a comment. Deque, contrary to the vector, doesn't need to move the elements when growing. I'm not sure if that's relevant here though. Have you checked what's on average the maximum size of `Path` on some larger repo? Maybe using `llvm::SmallVector` with some well-thought (data-ba

[PATCH] D115063: [clang-format][NFC] Rename variable so no shadowing happens

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115063/new/ https://reviews.llvm.org/D115063 __

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 391718. lichray added a comment. Add EOL to source file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/lib/AST/APValue.cpp clang/test/SemaTemplate/t

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 391717. lichray added a comment. - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/lib/AST/APValue.cpp clang/test/SemaTemplate/temp_arg_str

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

curdeius added a comment. What do we usually do for output parameters? I'm ok with both refs and pointers. It seems to me to be google-style thingy to pass by pointer. It is indeed clearer at the caller site that the passed variable will be modified. Are you worried about any performance penalty

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115045/new/ https://reviews.llvm.org/D115045 ___

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Don't forget to reformat please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 _

[PATCH] D115066: [clang-format][NFC] Reorder conditions

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115066/new/ https://reviews.llvm.org/D115066 __

[PATCH] D115067: [clang-format][NFC] Use range based for

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Format/TokenAnnotator.cpp:2376 void TokenAnnotator::annotate(AnnotatedLine &Line) { - for (SmallVectorImpl::iterator I = Line.Children.begin

[PATCH] D115068: [clang-format][NFC] Move static variable in scope

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115068/new/ https://reviews.llvm.org/D115068 __

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

curdeius added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1294-1296 + Previous->isOneOf(tok::l_paren, tok::comma, tok::colon, TT_BinaryOperator, +TT_ConditionalExpr) && !Previous->isOneOf(TT_DictLiteral, TT_ObjCMeth

[PATCH] D115070: [clang-format][NFC] Early return when nothing to do

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115070/new/ https://reviews.llvm.org/D115070 __

[PATCH] D115071: [clang-format][NFC] Use range based for for fake l parens

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115071/new/ https://reviews.llvm.org/D115071 __

[PATCH] D115072: [clang-format][NFC] Use member directly

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM if CI is happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115072/new/ https://reviews.llvm.org/D115072 ___

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > Is this valid code? Or did we just wrongly assign

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks added a comment. Still WIP, not marking as changes planned, so that it pops up on your list and you can give me feedback. :) Comment at: clang/lib/Format/Format.cpp:1213 + // This is open for discussions! When will LLVM adapt C++20? + LLVMStyle.RequiresCla

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 391708. HazardyKnusperkeks retitled this revision from "[clang-format] Improve require handling" to "[clang-format] Improve require and concept handling". HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added reviewers: go

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Delayed until D113319 is resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D115072: [clang-format][NFC] Use member directly

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of

[PATCH] D115071: [clang-format][NFC] Use range based for for fake l parens

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115070: [clang-format][NFC] Early return when nothing to do

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not com

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115068: [clang-format][NFC] Move static variable in scope

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Let only t

[PATCH] D115067: [clang-format][NFC] Use range based for

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. That's muc

[PATCH] D115066: [clang-format][NFC] Reorder conditions

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prefer to

[PATCH] D115065: [clang-format][NFC] Merge two calls of isOneOf

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think th

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

thakis added a comment. I patched this in and verified that it fixes the make_top_domain_list_variables issue in https://bugs.chromium.org/p/chromium/issues/detail?id=1273966 and went ahead and landed this. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a14674f276b: CodeGen: Strip exception specifications from function types in CFI type names. (authored by pcc, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D115063: [clang-format][NFC] Rename variable so no shadowing happens

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the loo

[clang] 0a14674 - CodeGen: Strip exception specifications from function types in CFI type names.

Author: Peter Collingbourne Date: 2021-12-03T14:50:52-05:00 New Revision: 0a14674f276b598d23353290635fc62f93e9ab30 URL: https://github.com/llvm/llvm-project/commit/0a14674f276b598d23353290635fc62f93e9ab30 DIFF: https://github.com/llvm/llvm-project/commit/0a14674f276b598d23353290635fc62f93e9ab30

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Give I[1

[libunwind] f178a05 - [libunwind] Fix unwind_leaffunction test

Author: Leonard Chan Date: 2021-12-03T11:21:20-08:00 New Revision: f178a05f220403f2a9d73c7640bfcc7dc2d7be72 URL: https://github.com/llvm/llvm-project/commit/f178a05f220403f2a9d73c7640bfcc7dc2d7be72 DIFF: https://github.com/llvm/llvm-project/commit/f178a05f220403f2a9d73c7640bfcc7dc2d7be72.diff

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts.VScaleMax) return std::pair(LangOpts.VScaleMin, La

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 added a comment. @hokein @aaron.ballman Following up on this, let me know if there are any other action items to address! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113917/new/ https://reviews.llvm.org/D113917 __

[PATCH] D106585: Fix clang debug info irgen of i128 enums

aeubanks added a comment. In D106585#3170019 , @aeubanks wrote: > In D106585#3169898 , @rnk wrote: > >> This usage of isSameValue seems suspicious: >> https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LL

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes marked an inline comment as done. c-rhodes added a comment. In D113294#3170007 , @paulwalker-arm wrote: > I agree, it's the change to VScaleMin that has caused the issue. If the > LangOpts default can remain as 0 and you can still achieve what

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes updated this revision to Diff 391668. c-rhodes added a comment. Revert to previous behaviour where both the min/max Clang flags override SVE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/ https://reviews.llvm.org/D113294 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; HazardyKnusperkeks wrote: > Is this valid code? Or did we just wrongly assign PointerOrReference? I'd say >

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames planned changes to this revision. reames added a comment. Needs reworked over previous patch in stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115021/new/ https://reviews.llvm.org/D115021 __

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

reames planned changes to this revision. reames added a comment. Has the same propagation bug fixed in 7b54de5f , need to rework. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added a comment. @martong > Nice, assiduous work! Many thanks for your time! Your work is not less assiduous! > (LHS, RHS) swaps it doesn't really matter, as the operation is comutative, but, yes, it does matter to depict the particular test case. I'll revise twise LHS-RHS's. >

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; Is this valid code? Or did we just wrongly assign PointerOrReference? I'd say after that there can not

[PATCH] D115032: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

yaxunl accepted this revision. yaxunl added a comment. Ideally, we could let the builtins accept both vec3 and vec4. But I am OK with this for now. I think the overhead may be minimal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115032/new/ http

[PATCH] D115032: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115032/new/ https://reviews.llvm.org/D115032 ___

[PATCH] D106585: Fix clang debug info irgen of i128 enums

aeubanks added a comment. In D106585#3169898 , @rnk wrote: > This usage of isSameValue seems suspicious: > https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LLVMContextImpl.h#L389 > > It seems to allow the possibility that APInts of differing bi

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=48916 Left and Right Alignment inside a loop is misaligne

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm added a comment. I agree, it's the change to VScaleMin that has caused the issue. If the LangOpts default can remain as 0 and you can still achieve what you're after then that would be perfect. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/ https://reviews.l

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts.VScaleMax) return std::pair(LangOpts.VScaleMin, LangOpts

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker updated this revision to Diff 391661. collinbaker added a comment. Fix variable name style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115049/new/ https://reviews.llvm.org/D115049 Files: clang/include/clang/Driver/ToolChain.h cla

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

bader added a comment. In D109818#3169531 , @linjamaki wrote: > The patch is ready to land. @Anastasia, @bader, could you commit this patch > to the LLVM for us? Thanks. Could you rebase on the tip of the main branch, please? I see a couple of conflict

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm requested changes to this revision. paulwalker-arm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker created this revision. Herald added subscribers: abrachet, danielkiss, kristof.beyls. collinbaker requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang searches for runtimes (e.g. libclang_rt*) first in a subdirectory named for

[clang] 7b54de5 - [funcattrs] Fix a bug in recently introduced writeonly argument inference

Author: Philip Reames Date: 2021-12-03T08:57:15-08:00 New Revision: 7b54de5feffedfc08e5a02d6c9e27c54e3b7f119 URL: https://github.com/llvm/llvm-project/commit/7b54de5feffedfc08e5a02d6c9e27c54e3b7f119 DIFF: https://github.com/llvm/llvm-project/commit/7b54de5feffedfc08e5a02d6c9e27c54e3b7f119.diff

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added a comment. This usage of isSameValue seems suspicious: https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LLVMContextImpl.h#L389 It seems to allow the possibility that APInts of differing bitwidth compare equal, but the hash value incorporates the bitwidth, so they may be inse

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added a subscriber: aeubanks. rnk added a comment. Thanks for the reduction, it sounds like there is something wrong with the way DIEnumerator is uniqued in the LLVMContext. I probably don't have time to follow up on this, but maybe @dblaikie and @aeubanks can help out. Repository: rG LL

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll created this revision. simoll added reviewers: kaz7, MaskRay, phosek. simoll requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before, the CLANG_DEFAULT_LINKER cmake option was a global override for the linker that shall be used on all

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 added inline comments. Comment at: llvm/include/llvm/Support/SmallVectorMemoryBuffer.h:54 + /// and invoke the given function right after the move. + SmallVectorMemoryBuffer( + SmallVectorImpl &&SV, I'm not happy with introducing new (hacky) c

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch avoids unnecessarily copying `mmap`-ed memory into

[clang-tools-extra] 1cefe91 - [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

Author: Balázs Kéri Date: 2021-12-03T16:53:08+01:00 New Revision: 1cefe91d40aef043ec949c6ddb053b47b4d5b8e6 URL: https://github.com/llvm/llvm-project/commit/1cefe91d40aef043ec949c6ddb053b47b4d5b8e6 DIFF: https://github.com/llvm/llvm-project/commit/1cefe91d40aef043ec949c6ddb053b47b4d5b8e6.diff L

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cefe91d40ae: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception… (authored by balazske). Repository: rG LLVM Github Mo

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

balazske updated this revision to Diff 391640. balazske marked 2 inline comments as done. balazske added a comment. Applied the text changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114602/new/ https://reviews.llvm.org/D114602 Files: clan

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

rnk added a comment. In D102090#3169439 , @ebrevnov wrote: > While -Bsymbolic-funtions brings nice performance improvements it also > changes symbol resolution order. That means we effectively disabled > preemption for functions and all references from

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6279562dae4: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct. (authored by ABataev). Repository: rG LLVM Github Monor

[clang] f627956 - [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

Author: Alexey Bataev Date: 2021-12-03T07:01:00-08:00 New Revision: f6279562dae456f6c58d5f7484ba4bae5c2071fa URL: https://github.com/llvm/llvm-project/commit/f6279562dae456f6c58d5f7484ba4bae5c2071fa DIFF: https://github.com/llvm/llvm-project/commit/f6279562dae456f6c58d5f7484ba4bae5c2071fa.diff

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. This patch fixes issues for -fgpu-rdc for Windows MSVC toolchain: Fix COFF specific section flags and remove section types in llvm-mc input file for Windows. Escape fatbin path in llvm-mc input

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115015/new/ https://reviews.llvm.org/D115015 ___ c

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 391616. MattDevereau added a comment. run clang format to fix test macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 Files: clang/include/clang/Basic/Built

[PATCH] D106585: Fix clang debug info irgen of i128 enums

glandium added a comment. Reduced testcase: enum FrameIID { nsBox_id, nsIFrame_id, nsHTMLFramesetBlankFrame_id, nsHTMLFramesetBorderFrame_id, }; enum class ClassID : unsigned char { nsBox_id, nsIFrame_id, nsHTMLFramesetBlankFrame_id, nsHTMLFramesetBorderFr

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

steakhal added a comment. L129 and L135 are uncovered by tests. The rest of the lines are covered by tests, according to `lcov`. The checker produced in total 15 reports on these 18 projects: `memcached,tmux,curl,twin,vim,openssl,sqlite,ffmpeg,postgres,tinyxml2,libwebm,xerces,bitcoin,protobuf,qt

  1   2   >