[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

mstorsjo created this revision. mstorsjo added a reviewer: rnk. mstorsjo requested review of this revision. Herald added a project: clang. Clang has custom handling of --no-demangle, where it is removed from the input -Wl and -Xlinker options, and readded specifically by the drivers where it's kno

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114059/new/ https://reviews.llvm.org/D114059 ___

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

FreddyYe updated this revision to Diff 387845. FreddyYe added a comment. convertion -> conversion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114059/new/ https://reviews.llvm.org/D114059 Files: clang/lib/Headers/avx512bf16intrin.h clang/lib

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki added a comment. Hi @Anastasia and @bader, This patch should be ready to land, I think. Could you please push it to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 ___

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:429 +///A 128-bit vector of [4 x bfloat]. +/// \returns A 128-bit vector of [4 x float] come from convertion of __A +static __inline__ __m128 __DEFAULT_FN_ATTRS128 _mm_cvtpbh_ps(__m128bh __

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc created this revision. sheldonneuberger-sc added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet. sheldonneuberger-sc added a reviewer: erichkeane. sheldonneuberger-sc edited the summary of this revision. sheldonneuberger-sc published this revision for review.

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

FreddyYe created this revision. Herald added a subscriber: pengfei. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114059 Files: clang/lib/Headers/avx512vlbf16int

[PATCH] D114051: Illustrate an alternative for tracking includes per submodule.

vsapsai updated this revision to Diff 387834. vsapsai added a comment. Handle `BuildingSubmoduleStack` not storing the top-level module. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114051/new/ https://reviews.llvm.org/D114051 Files: clang/incl

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu updated this revision to Diff 387828. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Use `-Wno-coroutine` instead of `-Wno-deprectated-experimental-coroutine` to keep CI stable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/ https://reviews.

[PATCH] D51650: Implement target_clones multiversioning

erichkeane added a comment. In D51650#3127097 , @aaron.ballman wrote: > In D51650#3126569 , @akuegel wrote: > >> Since it is not clear whether the semantic change was intended, I think it >> makes sense to revert

[PATCH] D112777: [X86][FP16] add alias for f*mul_*ch intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG73c9cf820409: [X86][FP16] add alias for f*mul_*ch intrinsics (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://revie

[clang] 73c9cf8 - [X86][FP16] add alias for f*mul_*ch intrinsics

Author: Freddy Ye Date: 2021-11-17T13:26:11+08:00 New Revision: 73c9cf820409834b134a8c8c8039efe4113845d9 URL: https://github.com/llvm/llvm-project/commit/73c9cf820409834b134a8c8c8039efe4113845d9 DIFF: https://github.com/llvm/llvm-project/commit/73c9cf820409834b134a8c8c8039efe4113845d9.diff LOG

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf updated this revision to Diff 387819. qiucf added a comment. Disallow conversion in compound and conditional CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109751/new/ https://reviews.llvm.org/D109751 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp clan

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf added a comment. In D109751#3131169 , @nemanjai wrote: > Please provide a description for this patch which includes justification for > why we want to allow conversion between the two types. > I am of the impression that allowing the two types to c

[PATCH] D112915: [clang][modules] Track number of includes per submodule

vsapsai added a comment. Didn't go in-depth for serialization/deserialization. When we add tracking `isImport` on per-submodule basis, do you think AST reading/writing would change significantly? Comment at: clang/include/clang/Lex/ExternalPreprocessorSource.h:45 + /// Retur

[PATCH] D114051: Illustrate an alternative for tracking includes per submodule.

vsapsai created this revision. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Aggregated transitive includes are stored in SubmoduleState, includes per submodule for subsequent serialization are

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported. --

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu marked 5 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/co_await-range-for-exp-namespace.cpp:54 for -co_await(auto i : arr) {} +co_await(auto i : arr) {} // expected-warning {{Found deprecated std::experimental}}

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu updated this revision to Diff 387811. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/ https://reviews.llvm.org/D113977 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. Does GCC actually change the formal types of expressions to `float`, or is it doing this "no intermediate casts thing" as some sort of fp_contract-style custom emission of trees of expressions that involve `_Float16`? In any case, doing operation-by-operation emulation

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

NoQ added a comment. Taking advantage of strict aliasing is good as long as it produces strictly smaller analysis space (less paths, more constrained states). I.e., we can use it for eliminating possibilities, but not for discovering possibilities. If we ever prove that strict aliasing is viola

[PATCH] D106756: Added l16/l32 length modifiers for char16_t/char32_t

MarcusJohnson91 updated this revision to Diff 387788. MarcusJohnson91 added a comment. Clang-FormatDiff.py; Still waiting for the UTFConvert patch to land first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106756/new/ https://reviews.llvm.org/D106756 Files: clang/include/clang/AST/

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances

ASDenysPetrov added a comment. In D114006#3135456 , @steakhal wrote: > Sweet! > I think commit titles are not punctuated, even though they start with an > uppercase letter. Thanks! That depends on the mood at the particular moment :) But seriously, it'

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

ASDenysPetrov updated this revision to Diff 387773. ASDenysPetrov added a comment. Fixed failed unittest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114006/new/ https://reviews.llvm.org/D114006 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h clang/

[PATCH] D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0"

srhines accepted this revision. srhines added a comment. Thanks for the expanded (and more specific) tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114036/new/ https://reviews.llvm.org/D114036 ___

[PATCH] D113943: Add `withTag` matcher.

jcking1034 updated this revision to Diff 387769. jcking1034 added a comment. Improve wrapping of PolymorphicMatchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113943/new/ https://reviews.llvm.org/D113943 Files: clang/include/clang/ASTMatcher

[PATCH] D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0"

jamesfarrell created this revision. Herald added a subscriber: danielkiss. jamesfarrell requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114036 Files: clang/test/Sema/attr-a

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

sugak added a comment. ping @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112481/new/ https://reviews.llvm.org/D112481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley added a subscriber: dstenb. mattbeardsley added a comment. @dstenb - wanted to check with you too to make sure that this change to pr37091.cpp seems like it won't interfere with the original intent of the test (https://reviews.llvm.org/D45686 ) The lingering file issue you'd fixed

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley created this revision. mattbeardsley added a reviewer: kbobyrev. Herald added a subscriber: xazax.hun. mattbeardsley requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. The clang-tidy/infrastructure/pr37091.cpp

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj updated this revision to Diff 387759. michaelrj marked an inline comment as done. michaelrj added a comment. update the set type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/D113946 Files: clang-to

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

beccadax added a comment. > My reading of > https://clang.llvm.org/docs/LanguageExtensions.html#specifying-an-attribute-for-multiple-declarations-pragma-clang-attribute > suggests that any() /could/ apply to everything. (`The any rule applies > attributes to all declarations that are matched by

[PATCH] D114031: Full matching for version numbers.

jamesfarrell created this revision. jamesfarrell requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114031 Files: clang/test/Sema/attr-availability-android.c Index: clang/te

[PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

ZarkoCA created this revision. ZarkoCA added reviewers: klimek, akyrtzi, quinnp. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added subscribers: lldb-commits, cfe-commits. Herald added a project: LLDB. Rename function to more inclusive name. Repository: rG

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/X86/pr23258.ll:22 + +declare dso_local void @bar(i32, ...) + nickdesaulniers wrote: > Is there anything one the callee side that we should check? I assume the > callee does some check of `%al`

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

nickdesaulniers added a comment. It might be nice to add an `llvm-link` test that produces an error when this module metadata doesn't match. Basically, it would be nice to error if during LTO we link together two modules that differ in their use of `-mskip-rax-setup` since that has ABI implica

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA created this revision. ZarkoCA added reviewers: aaron.ballman, dcoughlin, quinnp. ZarkoCA added a project: clang. Herald added subscribers: dexonsmith, martong. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Rewording of comments to avoid using `sanity t

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

mcgrathr added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:91 +std::string CPU = getCPUName(D, Args, Triple); +if (CPU.empty() || CPU == "generic" || CPU == "cortex-a53") + CmdArgs.push_back("--fix-cortex-a53-843419"); How do

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3135461 , @hans wrote: > We're seeing a diagnostic change in Chromium which looks funny. For the > following code (span<> is our own class): > > the diagnostic changes from: > > fatal error: no viable conversio

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan. Herald added a subscriber: abrachet. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting cortex-a53, set this linker flag rather than relying on

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Just a comment on the ECX bit, otherwise this patch looks fine to me. Someone with more x86 knowledge may want to take a look though. Thanks for the patch!

[PATCH] D113840: [Driver][Android] Remove unneeded isNoExecStackDefault

pirama edited reviewers, added: srhines; removed: pirama. pirama added a comment. Will defer to Dan's review. I think these changes are safe for the Android platform (where we only use lld). The NDK only supports lld but that does not preclude external users from using other linkers. Reposit

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

hokein added a comment. In D113889#3134857 , @kuhnel wrote: > I just checked with my local clangd and it does not crash on this file... yeah, this file is fine, the crash only occurs if you use an assertion-enabled clangd and the code has an unmatched `

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

sivachandra accepted this revision. sivachandra added a comment. For libc requirements, LGTM. Please wait for @aaron.ballman for stamping the clang-tidy parts. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:39 +// intercepted. +static const char *FU

[PATCH] D114011: Add a clang-transformer tutorial

ymandel created this revision. Herald added a subscriber: arphaman. ymandel updated this revision to Diff 387719. ymandel added a comment. ymandel edited the summary of this revision. ymandel added reviewers: gribozavr2, aaron.ballman. ymandel changed the edit policy from "All Users" to "Only User:

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer updated this revision to Diff 387723. DaanDeMeyer added a comment. Addressed comments by adding two new errors, one for character literals and one for numeric literals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj updated this revision to Diff 387713. michaelrj added a comment. add test for the new lint behavior: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/D113946 Files: clang-tools-extra/clang-tidy/llvmlib

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae27ca9a6783: [PowerPC] PPC backend optimization on conditional trap intrustions (authored by NeHuang). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. We're seeing a diagnostic change in Chromium which looks funny. For the following code (span<> is our own class): int WontCompile() { const std::vector v; span s = make_span(v); } the diagnostic changes from: fatal error: no viable conversion from 'span' to

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c484f11d355: [llvm] Add a SFINAE template parameter to DenseMapInfo (authored by rriddle). Changed prior to commit: https://reviews.llvm.org/D113

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Sweet! I think commit titles are not punctuated, even though they start with an uppercase letter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported. -

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:13 +#include + sivachandra wrote: > Eugene.Zelenko wrote: > > Should be `` and without newline separation form rest of headers. > Looks like this is pr

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj updated this revision to Diff 387703. michaelrj marked 6 inline comments as done. michaelrj added a comment. clean up the code and remove debug statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/

[clang] 4c484f1 - [llvm] Add a SFINAE template parameter to DenseMapInfo

Author: River Riddle Date: 2021-11-16T18:54:14Z New Revision: 4c484f11d355e4293f7b245a9330f0a1e89630ac URL: https://github.com/llvm/llvm-project/commit/4c484f11d355e4293f7b245a9330f0a1e89630ac DIFF: https://github.com/llvm/llvm-project/commit/4c484f11d355e4293f7b245a9330f0a1e89630ac.diff LOG:

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang marked 2 inline comments as not done. avogelsgesang added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerContainsCheck.cpp:105-108 + const auto *PositiveCheck = Result.Nodes.getNodeAs("positive"); + const auto *NegativeCheck = Resu

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 387699. mizvekov retitled this revision from "[clang] WIP: Implement ElaboratedType sugaring for types written bare" to "[clang] Implement ElaboratedType sugaring for types written bare". mizvekov edited the summary of this revision. mizvekov added a comment

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 387698. avogelsgesang marked 11 inline comments as done. avogelsgesang added a comment. Address review comments by @whisperity: - "containment" -> "membership" - "C++ 20" -> "C++20" - double-backticks in rst files - additonal test cases (both positive a

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. Yes, this header does everything Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D112374: [clang] WIP: Implement ElaboratedType sugaring for types written bare

mizvekov created this revision. Herald added subscribers: lxfind, jdoerfert. mizvekov updated this revision to Diff 382454. mizvekov added a comment. Herald added subscribers: carlosgalvezp, arphaman. mizvekov edited the summary of this revision. Herald added a subscriber: kristof.beyls. mizvekov u

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:73 static bool DecodeAArch64Features(const Driver &D, StringRef text, std::vector &Features, llvm::AArch64::ArchKind Ar

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:73 static bool DecodeAArch64Features(const Driver &D, StringRef text, std::vector &Features, llvm::AArch64::ArchKind ArchK

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:73 static bool DecodeAArch64Features(const Driver &D, StringRef text, std::vector &Features, llvm::AArch64::ArchKind Ar

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

beccadax requested changes to this revision. beccadax added a comment. This revision now requires changes to proceed. err_lexing_string’s message is “failure when lexing a string”

[PATCH] D113433: [NFC][clang] Inclusive language: Rename myMaster in testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ed404a4abd3: [NFC][clang] Inclusive language: Rename myMaster in testcase (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 5ed404a - [NFC][clang] Inclusive language: Rename myMaster in testcase

Author: Quinn Pham Date: 2021-11-16T11:46:43-06:00 New Revision: 5ed404a4abd3fc3559ecc9dfc6cee83fcc3796e6 URL: https://github.com/llvm/llvm-project/commit/5ed404a4abd3fc3559ecc9dfc6cee83fcc3796e6 DIFF: https://github.com/llvm/llvm-project/commit/5ed404a4abd3fc3559ecc9dfc6cee83fcc3796e6.diff LO

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

rnk added a comment. In D110257#3134001 , @JonChesterfield wrote: > So you won't articulate or document the new invariant and you think there's a > llvm-dev discussion that says we can't verify the invariant which you won't > reference, but means you w

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 updated this revision to Diff 387668. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - removed debug code - some macro definitions need to be defined for HIP-only compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer updated this revision to Diff 387667. DaanDeMeyer added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://reviews.llvm.org/D114003 Files: clang/lib/Lex/LiteralSupport.cpp Index: clang/lib/Lex

[PATCH] D114006: [analyzer]{NFC} Enable access to CodeGenOptions from analyzer's instances.

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, steakhal, Charusso, Szelethus, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov req

[PATCH] D113433: [NFC][clang] Inclusive language: Rename myMaster in testcase

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113433/new/ https://reviews.llvm.org/D113433 _

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

amyk accepted this revision. amyk added a comment. Thanks for addressing the review comments and answering my question. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 _

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang updated this revision to Diff 387652. NeHuang added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 Files: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp llvm/t

[PATCH] D113993: WIP: [clang] customizable build-id style

kwk updated this revision to Diff 387650. kwk added a comment. enabled DEFAULT_LINKER_BUILD_ID_STYLE in linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113993/new/ https://reviews.llvm.org/D113993 Files: clang/CMakeLists.txt clang/include/

[PATCH] D113942: [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4b28a0fe685: [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] d4b28a0 - [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py

Author: Quinn Pham Date: 2021-11-16T10:11:06-06:00 New Revision: d4b28a0fe6857e0404d07b0989eeced05eaa45e7 URL: https://github.com/llvm/llvm-project/commit/d4b28a0fe6857e0404d07b0989eeced05eaa45e7 DIFF: https://github.com/llvm/llvm-project/commit/d4b28a0fe6857e0404d07b0989eeced05eaa45e7.diff LO

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang marked 7 inline comments as done. NeHuang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1020 +// We can only do the optimization for the "reg + reg" form. +if (!(LiMI1 && (Opcode1 == PPC::LI || Opcode1 == PPC::LI8))) +

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer added a comment. Added some people that were recent reviewers of changes to this file and some clangd folks. I don't have the time to properly test this unfortunately (aside from verifying that it fixes all the clangd crashes I'm having), but putting the patch up anyway in case any

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer created this revision. DaanDeMeyer added reviewers: eduucaldas, beccadax, sammccall, kadircet. DaanDeMeyer added a project: clang. Herald added a subscriber: usaxena95. DaanDeMeyer requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. When using cla

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

Quuxplusone requested changes to this revision. Quuxplusone added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11015-11017 + "Found deprecated std::experimental::%0. Consider to update your libc++ "

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

Mordante accepted this revision. Mordante added a comment. Thanks for working on this and landing the coroutines. LGTM after applying @ldionne's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/ https://reviews.llvm.org/D11397

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

kuhnel added a comment. I just checked with my local clangd and it does not crash on this file... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113889/new/ https://reviews.llvm.org/D113889 ___ cfe-commit

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG75a078455fc7: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h (authored by kuhnel). Changed prior to commit: https://reviews.llvm.org/D113889?vs=387239&id=387634#toc Reposi

[clang-tools-extra] 75a0784 - [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

Author: Christian Kühnel Date: 2021-11-16T15:25:43Z New Revision: 75a078455fc71cddc5e04b709b349125b610e1bb URL: https://github.com/llvm/llvm-project/commit/75a078455fc71cddc5e04b709b349125b610e1bb DIFF: https://github.com/llvm/llvm-project/commit/75a078455fc71cddc5e04b709b349125b610e1bb.diff L

[PATCH] D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c8b8e0154f0: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays (authored by saghir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113306

[clang] 4c8b8e0 - [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays

Author: Ahsan Saghir Date: 2021-11-16T09:14:41-06:00 New Revision: 4c8b8e0154f075e463428acc0640388c40d60097 URL: https://github.com/llvm/llvm-project/commit/4c8b8e0154f075e463428acc0640388c40d60097 DIFF: https://github.com/llvm/llvm-project/commit/4c8b8e0154f075e463428acc0640388c40d60097.diff

[PATCH] D113895: [NFC][clangd] fix llvm-namespace-comment finding

This revision was automatically updated to reflect the committed changes. Closed by commit rG274f12a44c60: [NFC][clangd] fix llvm-namespace-comment finding (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113895/new/ https://revie

[clang-tools-extra] 274f12a - [NFC][clangd] fix llvm-namespace-comment finding

Author: Christian Kühnel Date: 2021-11-16T15:10:32Z New Revision: 274f12a44c606ecd20152f3e63c4f186793d9a8c URL: https://github.com/llvm/llvm-project/commit/274f12a44c606ecd20152f3e63c4f186793d9a8c DIFF: https://github.com/llvm/llvm-project/commit/274f12a44c606ecd20152f3e63c4f186793d9a8c.diff L

[PATCH] D113999: [clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The overload shouldSuppre

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Apologies, I thought I had already accepted this. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113538/new/ https://reviews.llvm.org/D113538 _

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113538/new/ https://reviews.llvm.org/D113538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

JonChesterfield added a comment. If the amdgpu backend doesn't require this then it doesn't matter much if other passes undo it. If it's not an invariant, we don't need the verifier to alert people to passes that break it. Git blame on the new code in clang will lead people here where they may

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 387615. kbobyrev added a comment. Add a small comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.cpp clan

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These are the trigrams for quer

[PATCH] D113993: WIP: [clang] customizable build-id style

kwk updated this revision to Diff 387610. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113993/new/ https://reviews.llvm.org/D113993 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Hurd.cpp I

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM with some suggestions, thanks for adding this notice! Comment at: clang/include/clang/Basic/DiagnosticGroups.td:57-59 +def DeprecatedCorotuine : + DiagGroup<"deprecat

[PATCH] D113993: WIP: [clang] customizable build-id style

kwk updated this revision to Diff 387608. kwk added a comment. Use correct CMake variable type: BOOLEAN -> BOOL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113993/new/ https://reviews.llvm.org/D113993 Files: clang/CMakeLists.txt Index: clang

  1   2   >